1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-06 09:20:43 +01:00
Commit Graph

145 Commits

Author SHA1 Message Date
Robyn MacCallum
31beae1783
[SG-230] “All Items” and “Trash” missing from Organization Vault (#795) 2022-05-09 14:47:28 -04:00
Oscar Hinton
694de6ffdb
[EC-192] Use ts-jest instead of deprecated ts-jest/utils (#792) 2022-05-09 18:25:17 +02:00
Addison Beck
141ade3c38
[feat] End User Vault Refresh (#790)
* Move access logic to org model (#713)

* [feature] Allow for top level groupings to be collapsed (#712)

* [End User Vault Refresh] Refactor route permission checking (#727)

* Update admin access logic

* Centralize route permission handling

* Add permission check for disabled orgs

* [EndUserVaultRefresh] Add base routing guard (#732)

* Add a base class for Angular routing guards

* Update Guard naming convention

* Bump node-forge to 1.2.1 (#722)

* Remove Internet Explorer logic (#723)

* Username generator (#734)

* add support for username generation

* remove unused Router

* pr feedback

* Bump electron and related dependencies (#736)

* PS-91 make isMacAppStore return true/false (#735)

* return false if undefined from isMacAppStore

* PS-91 use strict equality instead of null coalescing

Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>

Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>

* [bug] Fix Safari CSV importer for URL and Notes (#730)

* Fix import path for safari importer (#740)

* Force updates to be silent (#739)

* support for username gen website setting (#738)

* Fix jslibModule forms (#742)

* Add DatePipe provider to JslibModule (#741)

* Feature/move to jest (#744)

* Switch to jest

* Fix jslib-angular package name

* Make angular test project

* Split up tests by jslib project

* Remove obsolete node test script

* Use legacy deps with jest-preset-angular

* Move web tests to common

* Remove build from pipeline

This was only being used because we were not using ts runners.
We are now, so build is unnecessary

* Remove the VerifyMasterPasswordComponent from jslib module (#747)

* Add ellipsis pipe to jslib module (#746)

* add ellipsis pipe to jslib module

* Add ellipsis pipe to exports

* Add ColorPasswordCountPipe to JslibModule (#751)

* Generator cleanup (#753)

* type is null by default

* rename generator component

* remove showWebsiteOption

* shorthand if check

* EC-134 Fix api token refresh (#749)

* Fix apikey token refresh

* Refactor: use class for TokenRequestTwoFactor

* Remove keytar and biometric logic (#706)

* [bug] CL - fix default button display and callout header class (#756)

* [EC-142] Fix error during import of 1pux containing new email field format (#758)

* Add support for complex email field type

* Ensure complex email field type gets imported on identities

* [euvr] Separate Billing Payment/History APIs (#750)

* [euvr] Separate Billing Payment/History APIs

* Updated to new accounts billing API

* Removed getUserBilling as it will become obsolete once merged

* [end user vault refresh] Base Changes For Vault Filters (#737)

* [dependency] Update icons

* Avoid duplicate fullSync api calls (#716)

* Tweak component library slightly (#715)

* Check runtime name vs mangled name (#724)

* Add Chromatic (#719)

* Update SECURITY.md (#725)

* Update SECURITY.md

Add link to our HackerOne program for submitting potential security issues.

* Revise language on SECURITY.md

* Remove error Response type check (#731)

* Remove error Response type check

Minimization is impacting type checking in a non-consistent way.
The previous type check works locally,
but not from build artifacts 🤷. We only set `captchaRequired` on
our errors when we want a resubmit with captcha included, so we're safe
keying off that

* linter

* [JslibModule] Add JslibModule (#733)

* Add ellipsis pipe (#728)

* add ellipsis pipe

* run prettier

* Account for ellipsis length in returned string

* Fix complete words case

* Fix another complete words issue

* fix for if there are not spaces in long value

* extract length check to beginning of method

* condense if statements

* remove log

* [refactor] Add optional folders param to folderService.getAllNested()

This will be used later for use cases where the vault filters service needs to build a list of nested folders that have been filtered by organization

* [feature] Add organization filters

This is an MVP implementation of the changes needed for the vault refresh. This includes collapsable top level groupings, and organization based filters that dynamically adjust folders and collections.

* [refactor] Break down vault filter into several components

These changes rename and rewrite the GroupingsComponent into a VaultFiltersModule. The module follows typical angular patterns for structure and purpose, and contain components for each filter type. The mostly communicate via Input and Output, and depend on a VaultFilterService for sending and recieving data from other parts of the product.

* [bug] Add missing events for folder add/edit

* [refactor] Dont directly change activeFilter in VaultFilterComponent

* [refactor] Move DisplayMode to a dedicated file

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>

* [CL-16 Component Library] Menu Dropdown (#761)

* [bug] Add missing null check in vault filters (#769)

* [bug] Add @Injectable to VaultFilterService (#781)

* [fix] Ran prettier

* [fix] Fix merge issue

I used createUrlTree when merging guards because I knew that was the angular standard, didn't notice that redirect was a helper method from us

* Remove BaseGuard (#791)

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
Co-authored-by: Kyle Spearrin <kspearrin@users.noreply.github.com>
Co-authored-by: Jake Fink <jfink@bitwarden.com>
Co-authored-by: Chad Scharf <3904944+cscharf@users.noreply.github.com>
Co-authored-by: David Frankel <42774874+frankeld@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
Co-authored-by: Vincent Salucci <26154748+vincentsalucci@users.noreply.github.com>
Co-authored-by: Vincent Salucci <vincesalucci21@gmail.com>
2022-05-09 08:09:46 -04:00
Jake Fink
80c834b52a
Stop clearing list on every reload (#784) 2022-05-04 11:10:21 -04:00
Oscar Hinton
c757cc7ab6
Fix linting (#789) 2022-05-02 17:04:53 +02:00
Anthony Garera
7e05089d73
[CP-30] Added creditCardNumber pipe for viewing saved card numbers properly (#590)
Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-05-02 16:52:53 +02:00
Thomas Rittson
2e2849b4de
[PS-74] Fix user authentication state checks (#721)
* Create authService.authStatus, refactor isLocked checks

* Rename authStatus -> getAuthStatus
2022-04-29 21:33:38 +10:00
Thomas Rittson
d7e554653a
[EC-154] [BEEEP] Add token for localesDirectory (#783)
* Add token for localesDirectory

* Add token for SYSTEM_LANGUAGE
2022-04-29 17:28:38 +10:00
Federico Maccaroni
e4687b4cc6
PS-302 Added DeviceId to the 2FA email request and set it when calling the endpoint that's needed to see if it's a 2FA email because of a new device (#782) 2022-04-28 13:18:26 -03:00
Kyle Spearrin
fe65a337c8
Forwarded email alias generation (#772)
* generate forwarded alias with SL and AD

* added forwarded email to type list

* add ApiService dep

* ApiServiceAbstraction

* use proper status codes

* only generate on button press

* reset username to `-`

* reset username when forwarded

* Authorization header for anonaddy

* use proper anonaddy json path

* firefox relay support

* update description for firefox

* log username generation errors
2022-04-27 10:08:46 -04:00
Thomas Rittson
e40e7de808
[EC-159] [BEEEP] Remove factory providers in Angular DI (#775) 2022-04-26 07:28:43 +10:00
Oscar Hinton
f6e3481fe9
[BEEEP] Allow linking to ciphers (#760) 2022-04-20 11:15:58 +02:00
Oscar Hinton
3f56834716
Update jest configs to remove roots (#766) 2022-04-12 16:55:59 +02:00
Thomas Rittson
0f0adc9bd9
Add jsdoc comments for user verification, password reprompt, and appApiAction (#754)
* Rename and add comments to clarify password reprompt classes

* Add comment for appApiAction
2022-04-12 11:48:33 +10:00
Thomas Rittson
e595c0548e
EC-134 Fix api token refresh (#749)
* Fix apikey token refresh

* Refactor: use class for TokenRequestTwoFactor
2022-04-01 11:28:23 +10:00
Kyle Spearrin
4d58200ee9
Generator cleanup (#753)
* type is null by default

* rename generator component

* remove showWebsiteOption

* shorthand if check
2022-03-31 18:26:59 -04:00
Thomas Rittson
e0da3116f1
Add ColorPasswordCountPipe to JslibModule (#751) 2022-04-01 07:32:44 +10:00
Robyn MacCallum
56f5aba11e
Add ellipsis pipe to jslib module (#746)
* add ellipsis pipe to jslib module

* Add ellipsis pipe to exports
2022-03-31 09:57:19 -04:00
Oscar Hinton
47473b7ede
Remove the VerifyMasterPasswordComponent from jslib module (#747) 2022-03-29 10:38:22 +02:00
Matt Gibson
a4fba0e1c5
Feature/move to jest (#744)
* Switch to jest

* Fix jslib-angular package name

* Make angular test project

* Split up tests by jslib project

* Remove obsolete node test script

* Use legacy deps with jest-preset-angular

* Move web tests to common

* Remove build from pipeline

This was only being used because we were not using ts runners.
We are now, so build is unnecessary
2022-03-28 16:00:42 +02:00
Thomas Rittson
13ef7aea7d
Add DatePipe provider to JslibModule (#741) 2022-03-27 22:40:47 +02:00
Oscar Hinton
9d1df26dfa
Fix jslibModule forms (#742) 2022-03-28 06:32:21 +10:00
Kyle Spearrin
fa73c13b8c
support for username gen website setting (#738) 2022-03-25 10:32:01 +01:00
Kyle Spearrin
bfdd3561da
Username generator (#734)
* add support for username generation

* remove unused Router

* pr feedback
2022-03-24 12:19:19 -04:00
Oscar Hinton
5b7b2a03dd
Remove Internet Explorer logic (#723) 2022-03-24 10:42:11 +01:00
Robyn MacCallum
5409525ea2
Add ellipsis pipe (#728)
* add ellipsis pipe

* run prettier

* Account for ellipsis length in returned string

* Fix complete words case

* Fix another complete words issue

* fix for if there are not spaces in long value

* extract length check to beginning of method

* condense if statements

* remove log
2022-03-21 15:46:54 -04:00
Thomas Rittson
9950fb42a1
[JslibModule] Add JslibModule (#733) 2022-03-21 19:32:55 +10:00
Matt Gibson
f88515745c
Remove error Response type check (#731)
* Remove error Response type check

Minimization is impacting type checking in a non-consistent way.
The previous type check works locally,
but not from build artifacts 🤷. We only set `captchaRequired` on
our errors when we want a resubmit with captcha included, so we're safe
keying off that

* linter
2022-03-18 12:24:22 +10:00
Matt Gibson
3ec0f6977a
Check runtime name vs mangled name (#724) 2022-03-14 20:12:31 -05:00
Oscar Hinton
f7375e9064
Add premium and unless-premium directives (#710) 2022-03-08 15:21:49 +01:00
Oscar Hinton
813457c348
Expose logger in lock component (#703) 2022-03-03 17:19:52 +01:00
Vincent Salucci
48a4c27fe7
[Captcha] Failed login attempts (#698)
* [Captcha] Failed login attempts

* Fix logIn.strategy test

* Updated with the stark majority of requested changes

* Fix typo

* Unused import
2022-03-02 19:47:57 -06:00
Thomas Rittson
adfc2f234d
Remove unused SSO Form code (#701)
* Remove unused SAML Artifact Binding properties

* Remove unused validators
2022-03-03 07:52:11 +10:00
Thomas Rittson
e47eb5e74f
Fix linting (#700) 2022-03-01 23:11:12 +01:00
Thomas Rittson
d81eb7ddae
Improve SSO Config validation (#572)
* Extract SsoConfig enums to own file

* Add ChangeStripSpaces directive

* Move custom validators to jslib

* Add a11y-invalid directive

* Add and implement dirtyValidators

* Create ssoConfigView model and factory methods

* Add interface for select options

* Don't build SsoConfigData if null

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-03-02 07:31:00 +10:00
Thomas Rittson
1cbc119ad8
[AuthService refactor] Don't clear state if 2FA is invalid (#690)
* Don't clear state if 2FA is invalid

* Add session timeout to 2FA

* Clear internal authService state if unhandled error
2022-02-23 21:08:43 -06:00
Thomas Rittson
fdaa4f9fa5
Fix linting (#693) 2022-02-23 15:33:34 -06:00
Melanie Kanavakatini
2779cd0966
feat: add hidden char count toggle (#341)
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2022-02-24 07:18:46 +10:00
Addison Beck
78b5f15042
[feature] Implement scope warning for exports (#688)
* [feature] Add a hasOrganizations() service method

* [feature] Add a component to warn users about export scope
2022-02-23 13:56:46 +10:00
Oscar Hinton
60878cd4ed
Add eslint (#610) 2022-02-22 15:39:11 +01:00
Vincent Salucci
6d186bb204
[Icons] Fix sass deprecation warnings (#680)
* [Icons] Cleanup deprecation warnings

* Reverted to calc since math.div is not available in our current version

* Removed * -1 trick
2022-02-18 17:17:58 -06:00
Addison Beck
a6092916d8
[bug] Persistantly store collapsedGroupings (#686)
Collapsed groupings have regressed to not maintaining their state through restarting clients.

The state mangement refactor erroniously began saving this field to memory instead of disk, but there were some other issues that changing this brought on that are also fixed in this commit.

Changes:
1. Save collapsedGroupings persistantly in StateService
2. Adjust the type of collapsedGroupings on the Account model from a Set<string> to a string[]
	* This is the way we were storing this value in previous releases, and saving the entire set object breaks.
3. Adjust the StateService getter/setter for collapsedGroupings to expect a string[]
4. Extract a string[] from the GroupingsComponent groupings that is a Set<string> before saving
2022-02-15 12:54:22 -05:00
Matt Gibson
b0f735814f
Load component on init, then watch (#669) 2022-02-11 03:31:40 -06:00
Addison Beck
c282ef8575
[bug] Fix logout timeout action for inactive accounts (#660)
* [bug] Fix logout timeout action for inactive accounts

* Pass userId in to the logout callback parameter to the vaultTimeoutService. The message handle in desktop already expects this.
* Set lastActive on account login, and null it on account deauthentication. This prevents an issue where newly logged in accounts immediatly time out due to inactivity.

* Add userId to locked callbacks

* Add userId to log out callback
2022-02-09 12:15:20 -05:00
Vincent Salucci
8cb029947b
[Help] Update links to new pattern (#658)
* [Help] Updated urls to current pattern

* Rotate key update
2022-02-08 17:35:29 -06:00
Jake Howard
4252501620
Add lazy loading and decoding to images (#591)
The lazy loading will work in addition to any already being done, rather
than conflicting with it.

Co-authored-by: Daniel James Smith <djsmith@web.de>
2022-02-04 12:38:56 +01:00
Oscar Hinton
9dccd3198f
Fix avatar error when src is undefined (#652) 2022-02-03 19:37:51 +01:00
Addison Beck
067cd1e0e1
[bug] Assign client specific account settings during migration (#653)
* [bug] Assign client specific account settings during migration

* [refactor] Write State type arguements in consistent order

* [style] Ran prettier
2022-02-03 13:32:42 -05:00
Jake Fink
ca5c6a9c32
Master password policy is not checked when accepting invite from an existing account (#597)
* create update-password component

* linting and prettier
2022-02-02 23:31:37 -05:00
Thomas Rittson
aa2bdd00be
[Tech debt] Refactor authService and remove LogInHelper (#588)
* Use different strategy classes for different types of login
* General refactor and cleanup of auth logic
* Create subclasses for different types of login credentials
* Create subclasses for different types of tokenRequests
* Create TwoFactorService, move code out of authService
* refactor base CLI commands to use new interface
2022-02-01 09:51:32 +10:00