1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-25 12:15:18 +01:00
Commit Graph

16731 Commits

Author SHA1 Message Date
✨ Audrey ✨
b2811e07ce
[PM-14198] zero minimums when the character category is disabled (#11906) 2024-11-07 21:23:01 +01:00
Vince Grassia
e95af8269f
Add check for trigger event (#11904) 2024-11-07 15:15:44 -05:00
Vince Grassia
771bfdaccd
Fix quotes (#11902) 2024-11-07 19:42:10 +00:00
Vince Grassia
668ede2dfb
Add event_name check to Deploy Web trigger job (#11901) 2024-11-07 14:38:05 -05:00
Brandon Treston
ef0fd60676
[PM-11409] prevent managed user from leaving organization (#11895)
* add check to prevent managed  user from leaving managing org

* remove unused vaiable

* add null check
2024-11-07 14:09:56 -05:00
Matt Bishop
db40f20160
Check run permissions for build artifact generation secrets usage (#11897) 2024-11-07 13:01:54 -05:00
Nick Krantz
b42741f313
[PM-13839][PM-13840] Admin Console Collections (#11649)
* allow admin console to see all collections when viewing a cipher

- When "manage all" option is selected all collections should be editable

* update cipher form service to use admin endpoints

* when saving a cipher, choose to move to collections first before saving any other edits

- This handles the case where a cipher is moving from unassigned to assigned and needs to have a collection to save any other edits

* set admin flag when the original cipher has zero collections

- handling the case where the user  un-assigns themselves from a cipher

* add check for the users ability to edit items within the collection

* save cipher edit first to handle when the user unassigns themselves from the cipher

* update filter order of collections

* use cipher returned from the collections endpoint rather than re-fetching it

* fix unit tests by adding canEditItems

* re-enable collection control when orgId is present

* fetch the updated cipher from the respective service for editing a cipher
2024-11-07 10:22:35 -06:00
Jonathan Prusik
05a79d58bb
do not do browser extension permission check if the Show autofill suggestions setting is being turned off (#11889) 2024-11-07 10:38:49 -05:00
SmithThe4th
faf7e3d315
[PM-11201][CL-507] Add the ability to sort by Name, Group, and Permission within the collection and item tables (#11453)
* Added sorting to vault, name, permission and group

Added default sorting

* Fixed import

* reverted test on template

* Only add sorting functionality to admin console

* changed code order

* Fixed leftover test for sortingn

* Fixed reference

* sort permissions by ascending order

* Fixed bug where a collection had multiple groups and sorting alphbatically didn't happen correctly all the time

* Fixed bug whne creating a new cipher item

* Introduced fnFactory to create a sort function with direction provided

* Used new sort function to make collections always remain at the top and ciphers below

* extracted logic to always sort collections at the top

Added similar sorting to sortBygroup

* removed org vault check

* remove unused service

* Sort only collections

* Got rid of sortFn factory in favour of passing the direction as an optional parameter

* Removed tenary

* get cipher permissions

* Use all collections to filter collection ids

* Fixed ascending and descending issues

* Added functionality to default sort in descending order

* default sort permissions in descending order

* Refactored setActive to not pass direction as a paramater
2024-11-07 10:10:15 -05:00
Daniel James Smith
872f36752f
[PM-13876] Generator PR review follow up (#11885)
* Remove unused regex

* Remove viewChild reference from markup

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-07 09:03:54 -05:00
Alec Rippberger
f5e6fc8ed5
[PM-5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled (#11811)
* Add server settings model and service.

* Inject ServerSettingsService into the login-secondary-content component.

* Fix merge conflict

* Add server settings to old views

* Remove server settings from desktop/mobile

* Cleanup unused code

* Remove changes to default config

* Conditionally show/hide HR element

* Add tests

* PM-5237 - Move ServerSettingsService to jslib-services.module so it is the same across all clients and to solve NullInjectorErrors on desktop & browser extension

* Remove change to v1 components

* Rename ServerSettingsService to DefaultServerSettingsService

* Remove unnecessary map call

* Remove server interface in favor of using ServerSettings class

* Add back HR element

---------

Co-authored-by: Jared Snider <jsnider@bitwarden.com>
2024-11-06 17:57:07 -05:00
Alec Rippberger
1afb2f7769
Wrap login component email and MP entry states with invisible divs (#11884)
- Allows autofill to fill both email and password
2024-11-06 15:38:17 -06:00
Brandon Treston
2c5221d3aa
Allow deletion for items with no collectionId(s) (#11825) 2024-11-06 14:23:36 -05:00
Alec Rippberger
619651ca55
[PM-13818] Allow user to edit self-hosted url during registration (#11790)
* Trigger self hosted settings dialog on select close

* Simplify triggering self hosted env config dialog

* Always emit selected value

* Update variable naming of lastSelectedValue to userSelectedValue to better reflect purpose

* Add comment for userSelectedValue variable

* Remove userSelectedValue and simply emit a closed event

* Remove passing selectedRegion in closed event
2024-11-06 13:17:59 -06:00
Jordan Aasen
4cc562c228
[PM-12971] - close safari default extension on pop out (#11391)
* fix safari extension opening

* Update apps/browser/src/platform/browser/browser-api.ts

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* remove whitespace

* remove check for id

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2024-11-06 10:53:15 -08:00
Alec Rippberger
5a288b97db
[PM-14454] Add bit-menu-panel and bitmenuitem to environment selector dropdown (#11866)
* Add bit-menu-panel class and bitmenuitem attribute

* Add data-testids instead of class/attributes
2024-11-06 11:23:38 -06:00
Alec Rippberger
a959620a11
[PM-14369] Hide account switcher if on login page and not logged into any accounts (#11827)
* Add hasLoggedInAccount to check if there is a logged in account

* Update Storybook providers

* Revert "Update Storybook providers"

This reverts commit 646506ab95.

* Reapply "Update Storybook providers"

This reverts commit d86744a80b.

* Add story for HasLoggedInAccountExample

* Remove unused imports
2024-11-06 11:08:29 -06:00
✨ Audrey ✨
414bdde232
[PM-13876] replace angular validation with html constraints validation (#11816)
* rough-in passphrase validation failure handling

* trigger valid change from settings

* fix `max` constraint enforcement

* add taps for generator validation monitoring/debugging

* HTML constraints validation rises like a phoenix

* remove min/max boundaries to fix chrome display issue

* bind settings components as view children of options components

* remove defunct `okSettings$`

* extend validationless generator to passwords

* extend validationless generator to catchall emails

* extend validationless generator to forwarder emails

* extend validationless generator to subaddress emails

* extend validationless generator to usernames

* fix observable cycle

* disable generate button when no algorithm is selected

* prevent duplicate algorithm emissions

* add constraints that assign email address defaults
2024-11-06 17:54:29 +01:00
Daniel García
a9595b4d14
[PM-13361] Fix DDG DMG builds (#11878) 2024-11-06 17:46:57 +01:00
Vincent Salucci
dce8c0a61a
fix: refactor enabled state of org name field, refs PM-14533 (#11879) 2024-11-06 10:12:24 -06:00
Nick Krantz
d5139e0511
change totp code to monospace font (#11844) 2024-11-06 09:42:53 -06:00
cyprain-okeke
f33661c31c
[PM-11505]Delete the feature flag PM-5864-dollar-threshold (#11436)
* remove the time threshold flag

* Remove the time threshold flag
2024-11-06 16:05:22 +01:00
Jordan Aasen
b877624ce3
[PM-14462] - Update "Access Intelligence" to "Risk Insights" (#11853)
* rename acess intelligence to risk insights

* keep branch name

* replace all instances of AccessIntelligence. strip raw data + members to just the table

* revert change to feature flag name
2024-11-06 09:47:29 -05:00
renovate[bot]
52c7d21e5f
[deps] Platform: Update Rust crate anyhow to v1.0.93 (#11059)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-06 02:59:35 -05:00
renovate[bot]
350a85674d
[deps] Platform: Update Rust crate napi to v2.16.13 (#11533)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 14:20:41 -05:00
Jared Snider
b5450227da
PM-14424 - LoginComponents should listen for unauthUiRefresh flag changes and forcibly change the UI on browser & desktop to make for a seamless experience without having to refresh. (#11830) 2024-11-05 14:02:51 -05:00
Justin Baur
1e2a51a56b
Reverse Arguments (#11870) 2024-11-05 13:55:31 -05:00
renovate[bot]
12cf870e34
[deps] Platform: Update Rust crate zbus to v4.4.0 (#10581)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 13:13:52 -05:00
renovate[bot]
8ccece38e3
[deps] Platform: Update Rust crate thiserror to v1.0.68 (#10562)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 12:48:47 -05:00
Todd Martin
eb95d437a8
[PM-13804] Add new Is-Prerelease header to requests (#11605)
* Added new Is-Beta header

* Updated beta to prerelease
2024-11-05 12:01:29 -05:00
Vince Grassia
9d2c57d3d9
BRE-344 - Add Repository Management workflow (#11855) 2024-11-05 11:48:03 -05:00
Nick Krantz
adcd5bd307
hide ownership view when viewing a cipher in the admin console (#11852) 2024-11-05 10:09:16 -06:00
Thomas Avery
e206fc1819
[PM-14478] Add libs/key-management to jest.config (#11854) 2024-11-05 10:03:43 -06:00
renovate[bot]
b800193d80
[deps]: Lock file maintenance (#11542)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 15:58:33 +01:00
Bernd Schoolmann
48bd438824
Add context logs for native messaging (#11690)
* Add logging to decryption routines

* Fix case of uknown encryption type

* Add decryption context to log where failures occur

* Update log message

* Fix linting

* Add more context logs

* Add context logs for native messaging

* Update apps/desktop/native-messaging-test-runner/src/native-message.service.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Update apps/desktop/src/services/native-message-handler.service.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Rename channel key to desktop ipc channel key

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
2024-11-05 15:38:23 +01:00
Daniel James Smith
8bee0ada2f
Move ownership of electron-dependencies to platform (#11862)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-05 14:23:20 +01:00
Andreas Coroiu
77309d89f9
chore: remove post-install type hack (#11860) 2024-11-05 13:23:38 +01:00
Oscar Hinton
e3e675383f
Fix locale test after typescript upgrade (#11859)
The TypeScript update broke locale tests, to fix this we need to define moduleResolution manually as mentioned in the TS changelog.
2024-11-05 11:40:47 +01:00
Oscar Hinton
af6a2f5553
[PM-13375] Gulp: Remove beta builds (#11482)
Part of the browser build script refactor effort. bitwarden.atlassian.net/browse/PM-6683

The beta logic adds a fair bit of complexity and is currently unused. Let’s remove it and we can look into re-add it after migrating to our new build system.
2024-11-05 10:54:38 +01:00
Andreas Coroiu
586edafc79
chore: bump SDK to 0.2.0.main-3 (#11849) 2024-11-05 10:34:17 +01:00
Justin Baur
0d06c499f3
Remove Heartbeat Code (#11585) 2024-11-04 17:54:12 -05:00
Justin Baur
f41365ce48
[PM-13673] Require UserId In CompareHash Method (#11568)
* Require UserId In CompareHash Method

* Throw on null-ish 'masterKey'

* Update Test
2024-11-04 15:11:59 -05:00
Justin Baur
008e928d0a
[PM-10744] Remove Last Uses of getBgService (#10947)
* Remove Last Uses of `getBgService`

* Fix Merge Issue

* Fix Merge
2024-11-04 15:10:36 -05:00
renovate[bot]
fc9c10340b
[deps] Tools: Update utf-8-validate to v6.0.5 (#11848)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-04 21:08:36 +01:00
Jordan Aasen
c36fbcf8b7
[PM-14268] - Access intelligence - add tabbing and events (#11831)
* comment code

* small fixes

* undo change to flags
2024-11-04 10:45:34 -08:00
Jordan Aasen
527f48f78f
check if member has subscription access before showing subscription modal (#11794) 2024-11-04 10:45:13 -08:00
Oscar Hinton
cd79457349
[PM-4347] Upgrade angular to 17 (#11031)
Upgrade angular to 17
2024-11-04 11:51:43 -05:00
renovate[bot]
c96b4f4cb2
[deps] Autofill: Update tldts to v6.1.58 (#11847)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-04 11:42:34 -05:00
Rui Tomé
d804a78bfb
[PM-11406] Account Management: Prevent a verified user from deleting their account (#11505)
* Update AccountService to include a method for setting the managedByOrganizationId

* Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization

* Add missing method to FakeAccountService

* Remove the setAccountManagedByOrganizationId method from the AccountService abstract class.

* Refactor AccountComponent to use OrganizationService to check for managing organization

* Rename managesActiveUser to userIsManagedByOrganization

* Hide the change email section if the user is managed by an organization

* Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models

* Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property

* Refactor account component to conditionally show delete account button based on user's organization management status

* Add showDeleteAccount$ observable to AccountComponent
2024-11-04 16:37:24 +00:00
Rui Tomé
d669d2003f
[PM-10323] Add delete option to managed members (#11655)
* Add managedByOrganization property to OrganizationUserUserDetailsResponse and OrganizationUserView

* Add managedByOrganization property to OrganizationUserDetailsResponse and OrganizationUserAdminView

* Add deleteOrganizationUser method to OrganizationUserApiService

* Add copy strings for organization user delete dialog

* Add copy string for organization user deleted toast

* Add delete organization user dialog component

* Add the option to delete managed organization users from the members list

* Refactor delete user confirmation dialog in MembersComponent to use DialogService

* Delete DeleteOrganizationUserDialogComponent

* Refactor delete button in member dialog component to change the icon and tooltip text to 'Remove'

* Add delete button to members dialog if the user is managed by the organization
2024-11-04 16:19:30 +00:00