1
0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-02 03:41:09 +01:00
Commit Graph

395 Commits

Author SHA1 Message Date
Jacob Fink
57d270b08b
pass key to encrypt service 2023-06-26 16:45:14 -04:00
Jacob Fink
3e11a9b092
migrate master key if found 2023-06-26 16:42:34 -04:00
Jacob Fink
3f496f8fb0
move biometric check to electron crypto service 2023-06-26 15:27:44 -04:00
Jacob Fink
71ebb17a56
change isPinLockSet to union type 2023-06-26 13:41:37 -04:00
Jacob Fink
817b491fb6
require key in validateUserKey 2023-06-26 10:08:38 -04:00
Jacob Fink
d14240fb92
use encrypt service in crypto service 2023-06-26 09:38:35 -04:00
Jacob Fink
64ca08ef8a
use encrypt service in crypto service 2023-06-26 09:35:32 -04:00
Jacob Fink
3adfffeabd
jsdoc deprecate account properties 2023-06-23 16:22:33 -04:00
Jacob Fink
c942bc08ca
Merge branch 'tde-key-model-migration' into feature/PM-1049-TDE-flow-3-login-decryption-options 2023-06-23 13:54:15 -04:00
Jacob Fink
a4b329b413
Merge branch 'master' into tde-key-model-migration 2023-06-23 13:05:13 -04:00
André Bispo
c31504cab4
[PM-1593] send password as null if it is not in state (#5634) 2023-06-23 17:21:48 +01:00
Jacob Fink
6349410ec2
rename 'user symmetric key' with 'user key' 2023-06-23 10:59:54 -04:00
Jacob Fink
e4bfa62e70
add tests to crypto service 2023-06-23 09:55:19 -04:00
Jacob Fink
91f6943709
use user sym key for account changing unlock verification 2023-06-22 11:29:28 -04:00
Andreas Coroiu
44bfca0da1
Merge branch 'master' into feature/PM-1049-TDE-flow-3-login-decryption-options 2023-06-22 08:24:35 +02:00
Jacob Fink
a1e61feec3
Revert "share disk cache between contexts on browser"
This reverts commit 56a590c491.
2023-06-21 10:39:26 -04:00
Jacob Fink
56a590c491
share disk cache between contexts on browser 2023-06-21 09:31:04 -04:00
André Bispo
4124f7bdc8
[PM-2676] Fix web set environment urls after state init (#5632)
* [PM-2676] Fix web set env urls after state init.

* [PM-2676] Add note to remove workaround
2023-06-20 20:44:46 +01:00
Jared Snider
d7e29a0d22
Merge remote-tracking branch 'origin/master' into feature/PM-1049-TDE-flow-3-login-decryption-options 2023-06-20 15:25:44 -04:00
Jacob Fink
d16f76524c
fix cli crypto service calls 2023-06-20 11:49:54 -04:00
Jacob Fink
690e9ffc4a
cleanup old TODOs, add missing crypto service parameters 2023-06-20 11:22:32 -04:00
Jacob Fink
8f225bf541
use master key for device approvals still 2023-06-20 11:18:12 -04:00
Jacob Fink
a8f1e7858d
fix tests imports 2023-06-20 10:06:02 -04:00
Jacob Fink
ef8db575a9
remove cryptoMasterKeyB64 from account 2023-06-20 10:01:30 -04:00
Jacob Fink
87bf80a461
add new types to tests 2023-06-20 09:15:15 -04:00
Jacob Fink
a24c49adae
fix linter 2023-06-19 16:34:25 -04:00
Jacob Fink
abd2adb0b6
remove state no longer needed and add JSDOC 2023-06-19 14:36:25 -04:00
Jacob Fink
3e5e45f147
check for ephemeral pin before process reload 2023-06-19 09:49:26 -04:00
Jacob Fink
7f0749ca5c
share disk cache to fix syncing issues between contexts 2023-06-19 09:49:26 -04:00
Jacob Fink
b9de7535ca
improve error strings in crypto service 2023-06-19 09:49:25 -04:00
Jacob Fink
61ba9692bc
migrate native messaging for biometrics to use new key model
- support backwards compatibility
- update safari web extension to send user key
- add error handling
2023-06-19 09:49:24 -04:00
Jacob Fink
9c6739f40a
update account model with new keys serialization 2023-06-19 09:49:24 -04:00
Jacob Fink
7110e3cda6
fix EncString serialization issues & various fixes
Co-authored-by: Matt Gibson <MGibson1@users.noreply.github.com>
2023-06-19 09:49:24 -04:00
Jacob Fink
8353d67e1f
add org key type and new method to build a data enc key for orgs 2023-06-19 09:49:23 -04:00
Jacob Fink
2789fdc393
move crypto service jsdoc to abstraction 2023-06-19 09:49:22 -04:00
Jacob Fink
92d714ae29
remove clearEncKey from crypto service 2023-06-19 09:46:43 -04:00
Jacob Fink
42db4eb0ac
remove old EncKey methods from crypto service 2023-06-19 09:46:43 -04:00
Jacob Fink
d79f2e24be
update device-crypto service with new crypto service 2023-06-19 09:46:42 -04:00
Jacob Fink
3b7f57fd20
update change password components with new crypto service 2023-06-19 09:46:42 -04:00
Jacob Fink
2aa303d17e
fix crypto calls for key connector and vault timeout settings 2023-06-19 09:46:41 -04:00
Jacob Fink
9a12cb099a
migrate biometrics key
- migrate only on retrieval
2023-06-19 09:46:41 -04:00
Jacob Fink
56c750d375
finish migrate auto key if needed
- migrate whenever retrieved from storage
- add back the user symmetric key toggle
2023-06-19 09:46:41 -04:00
Jacob Fink
7963d3c996
clean up the old pin keys in more flows
- in the case that the app is updated while logged in and the user changes their pin, this will clear the old pin keys
2023-06-19 09:46:40 -04:00
Jacob Fink
62c43794e9
remove additional keys in state service clean 2023-06-19 09:46:40 -04:00
Jacob Fink
c2893bd0a8
migrate auto key
- add helper to internal crypto service method to migrate
2023-06-19 09:46:40 -04:00
Jacob Fink
9ce3b4976b
set user symmetric key on lock component
- add missed key suffix types to crypto service methods
2023-06-19 09:46:39 -04:00
Jacob Fink
6fc7c406a4
update pin key when the user symmetric key is set
- always set the protected pin so we can recreate pin key from user symmetric key
- stop using EncryptionPair in account
- use EncString for both pin key storage
- update migration from old strategy on lock component
2023-06-19 09:46:39 -04:00
Jacob Fink
7837202180
migrate pin to use user's symmetric key instead of master key
- set up new state
- migrate on lock component
- use new crypto service methods
2023-06-19 09:46:39 -04:00
Jacob Fink
91ac281da0
migrate login strategies to new key model
- decrypt and set user symmetric key if Master Key is available
- rename keys where applicable
- update unit tests
2023-06-19 09:46:06 -04:00
Jacob Fink
82bc7662a1
update collection service to use new crypto service 2023-06-19 09:42:54 -04:00
Jacob Fink
46abba2135
update vault timeout service with new crypto service 2023-06-19 09:42:54 -04:00
Jacob Fink
ffc23bfcdb
update password generation service to use new crypto service 2023-06-19 09:42:54 -04:00
Jacob Fink
7a037724d5
update cipher service to use new crypto service 2023-06-19 09:42:54 -04:00
Jacob Fink
7d8c4a430a
update folder service to use new crypto service methods 2023-06-19 09:42:53 -04:00
Jacob Fink
3452e39b9d
update send service to use new crypto service methods 2023-06-19 09:42:53 -04:00
Jacob Fink
076ab184fd
update sync service to use new crypto service methods 2023-06-19 09:42:53 -04:00
Jacob Fink
f466c91469
update auth service to use new crypto service 2023-06-19 09:42:52 -04:00
Jacob Fink
4772166e83
separate the user key in memory from user keys in storage 2023-06-19 09:42:51 -04:00
Jacob Fink
f0438e5dd2
add setUserSymKeyMasterKey so we can set the encrypted user sym key from server 2023-06-19 09:42:51 -04:00
Jacob Fink
c7feae6238
add type to parameter of setUserKey in abstraction of crypto service 2023-06-19 09:42:50 -04:00
Jacob Fink
820c71d1a1
update makeKeyPair on crypto service to be generic 2023-06-19 09:42:50 -04:00
Jacob Fink
6dc454e5e7
add decryption with MasterKey method to crypto service 2023-06-19 09:42:02 -04:00
Jacob Fink
acd3ef2204
remove provided key from getKeyForUserEncryption 2023-06-19 09:42:01 -04:00
Jacob Fink
4ce2a17ea4
Begin refactor of crypto service to support new key structure 2023-06-19 09:42:01 -04:00
Jacob Fink
bc4b3f3d74
add storage for master key encrypted user symmetric key 2023-06-19 09:35:51 -04:00
Jacob Fink
702dfb7eaf
add new storage to replace MasterKey with UserSymKey 2023-06-19 09:35:50 -04:00
Rui Tomé
d3d17f1496
[AC-1144] Warn admins when removing or revoking users without master password (#5494)
* [AC-1144] Added new messages for warning removing/revoking user without master password

* [AC-1144] Added property 'hasMasterPassword' to OrganizationUserUserDetailsResponse and OrganizationUserView

* [AC-1144] Added user's name to 'No master password' warning

* [AC-1144] Added property 'hasMasterPassword' to ProviderUserResponse

* [AC-1144] Added alert to bulk "remove/revoke users" action when a selected user has no master password

* [AC-1144] Moved 'noMasterPasswordConfirmationDialog' method to BasePeopleComponent

* [AC-1144] Removed await from noMasterPasswordConfirmationDialog

* [AC-1144] Changed ApiService.getProviderUser to output ProviderUserUserDetailsResponse

* [AC-1144] Added warning on removing a provider user without master password

* [AC-1144] Added "No Master password" warning to provider users

* [AC-1144] Added "no master password" warning when removing/revoking user in modal view

* [AC-1144] Reverted changes made to ProviderUsers

* [AC-1144] Converted showNoMasterPasswordWarning() into a property

* [AC-1144] Fixed issue when opening invite member modal
2023-06-16 16:38:55 +01:00
André Bispo
1052f00b87
[PM-2475][PM-2536] Clicking "US" in region selector sets base URL (#5604) 2023-06-16 14:09:16 +01:00
Vincent Salucci
5cd51374d7
[AC-1416] Expose Organization Fingerprint (#5557)
* refactor: change getFingerprint param to fingerprintMaterial, refs PM-1522

* feat: generate and show fingerprint for organization (WIP), refs AC-1416

* feat: update legacy params subscription to best practice (WIP), refs AC-1461

* refactor: update to use reactive forms, refs AC-1416

* refactor: remove boostrap specific classes and update to component library paradigms, refs AC-1416

* refactor: remove boostrap specific classes and update to component library paradigms, refs AC-1416

* refactor: create shared fingerprint component to redude boilerplate for settings fingerprint views, refs AC-1416

* refactor: use grid to emulate col-6 and remove unnecessary theme extensions, refs AC-1416

* refactor: remove negative margin and clean up extra divs, refs AC-1416

* [AC-1431] Add missing UserVerificationModule import (#5555)

* [PM-2238] Add nord and solarize themes (#5491)

* Fix simple configurable dialog stories (#5560)

* chore(deps): update bitwarden/gh-actions digest to 72594be (#5523)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor: remove extra div leftover from card-body class, refs AC-1416

* refactor: use bitTypography for headers, refs AC-1416

* fix: update crypto service abstraction path, refs AC-1416

* refactor: remove try/catch on handler, remove bootstrap class, update api chaining in observable, refs AC-1416

* fix: replace faulty combineLatest logic, refs AC-1416

* refactor: simplify observable logic again, refs AC-1416

---------

Co-authored-by: Shane Melton <smelton@bitwarden.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-15 21:03:48 -05:00
Daniel Chateau
9ed59c6fa9
Update request headers sent to AnonAddy API. (#5565) 2023-06-14 22:59:29 +02:00
Robyn MacCallum
2b65b3f0f7
[AC-1383] Move collections to Vault (#5424)
* Move CollectionDialog to Vault

* Fix CollectionDialogModule imports

* Move CollectionAdminService and View to Vault

* Move CollectionService to Vault

* Split GroupService into internal and public facing classes

* Move collection models to vault

* lint spacing fix

* Move collection spec file

* Fix spec import

* Update apps/web/src/app/core/core.module.ts

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>

* Remove CoreOrganizationModule from CollectionDialogModule

---------

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
2023-06-14 08:38:24 -04:00
Andreas Coroiu
37010a6414
[PM-2642] Fix feature flags not working properly when urls load from storage (#5598)
* fix: feature flags not working properly

Due to race conditions the api url is not set during the first fetch och server config. This causes the config to be fetched from `api.bitwarden.com`. The config is then supposed to be re-fetched when the api url is set by the environment service, but due to a missing line this is not done when the urls are set from storage.

* feat: change to `Observable<void>`
2023-06-14 14:10:39 +02:00
Daniel James Smith
3b708d9311
Remove try-catch to display proper api-errors (#5570) 2023-06-14 11:28:32 +02:00
Daniel James Smith
72a5ba455c
[PM-2367] [BEEEP]: Extract password strength from password-generation-service (#5502)
* Extract passwordStrength from passwordGenerationService

Extract passwordStrength from password-generation.service.ts
Create new password-strength.service.ts
Create new password-strength.service.abstraction.ts
Register new password-strength service
Fix usages in libs

* Fix usage in web

* Fix usage in desktop

* Fix usage in CLI

* Fix usage in browser

Move password-generation-factory to tools

* Fix tests

* Change dependency in jslib-services.module
2023-06-13 23:22:25 +02:00
Jared Snider
b6c2c83936
Merge branch 'master' into feature/PM-1049-TDE-flow-3-login-decryption-options 2023-06-13 16:13:53 -04:00
Thomas Rittson
22caae116c
Restrict angular imports (#5597)
* Refactor restricted imports eslint rule, add angular deps

* Move FormValidationErrorsService into libs/angular

* Remove angular decorators from configService

* Remove angular decorator from anonymousHubService
2023-06-13 10:03:32 +10:00
Thales Augusto
c70d67bad3
[PM-1823] Defining the card brand according to its number (#5204)
* Defining the card brand according to its number

* Moving cardBrandByPatterns function to Card View

* Getting Card brand via cardBrandByPatterns function

* Changing cardBrandByPatterns method to static. See:
The reason being that someone wanting to use this outside of the onCardNumberChange would need to know to set the cc-number on the view-model before calling cardBrandByPatterns

* Defining the card brand according to its number on Desktop

* Defining the card brand according to its number on Web
2023-06-09 20:44:33 +02:00
Daniel James Smith
ab260a3653
Fix broken import of misc/utils (#5586) 2023-06-09 11:12:20 +02:00
titanism
d18b45a87e
[PM-1060] Added new forwarder (Forward Email <https://forwardemail.net>) (#4809)
* Added new forwarder (Forward Email <https://forwardemail.net>)

* fix: fixed Basic authorization header

* fix: fixed returned email value

* feat: added verbose message for end-users (e.g. "Not Found" vs. "Domain does not exist on your account." (automatically localized with i18n for user)

* fix: fixed Buffer.from to Utils.fromBufferToB64

* fix: fixed fromBufferToB64 to fromUtf8ToB64

* Remove try-catch to properly display api errors

---------

Co-authored-by: Daniel James Smith <djsmith@web.de>
2023-06-09 09:55:12 +02:00
Jared Snider
aaf771bbdb
PM-1049 - IdTokenResponse - only userDecryptionOptions if they exist on the response from the server; I saw a few instances where it did not. Wasn't able to replicate consistently, but I put this check here to be safe. 2023-06-08 17:36:56 -04:00
Jared Snider
afb5ed3392
PM-1049 - AcctDecryptionOptions now persist across page refreshes of the login-initiated page to act similarly to refreshes on the lock screen. Accomplished via persisting AcctDecryptionOptions in local storage -- still cleared on logout. 2023-06-08 17:27:56 -04:00
Jared Snider
da69fe8742
Merge remote-tracking branch 'origin/master' into feature/PM-1049-TDE-flow-3-login-decryption-options + merge conflict resolutions 2023-06-08 11:05:17 -04:00
Jared Snider
806bd8d039
Tech-Debt - [PM-2283] - Update ConfigApiService getServerConfig call to send access token if it exists (#5464)
* PM-2283 - Update config api service get server config call to send authed when we have an access token so that LaunchDarkly on the server can properly acquire user context.

* PM-2283- Replace token service with Auth service per PR feedback

* PM-2283 - Refactor config api service get authed status based on PR feedback.

* PM-2283 - Fix import issues due to platform folder creation and file moves
2023-06-07 17:47:30 -04:00
Jared Snider
da395f7209
PM-1049 - Create domain models vs using response models as response models have a response property w/ the full response nested underneath which we don't need to persist for the user decryption options stored on the account. 2023-06-07 11:24:08 -04:00
Jared Snider
bf07fdb001
PM-1049 - StateService - replace User with Acct for decryption options 2023-06-07 10:14:37 -04:00
Jared Snider
07bbe96f86
PM-1049 - State Service - setup setters / getters for UserDecryptionOptions off the account 2023-06-07 10:09:38 -04:00
Jared Snider
763a0d6963
PM-1049 - Update all User Decryption Options response and state models in light of the back end changes from a list to an object. Web building now with decryption options stored on state under the account successfully. Must now build out state service methods for retrieving / setting account decryption options for use elsewhere. 2023-06-06 18:19:02 -04:00
Matt Gibson
78248db590
Platform/pm 19/platform team file moves (#5460)
* Rename service-factory folder

* Move cryptographic service factories

* Move crypto models

* Move crypto services

* Move domain base class

* Platform code owners

* Move desktop log services

* Move log files

* Establish component library ownership

* Move background listeners

* Move background background

* Move localization to Platform

* Move browser alarms to Platform

* Move browser state to Platform

* Move CLI state to Platform

* Move Desktop native concerns to Platform

* Move flag and misc to Platform

* Lint fixes

* Move electron state to platform

* Move web state to Platform

* Move lib state to Platform

* Fix broken tests

* Rename interface to idiomatic TS

* `npm run prettier` 🤖

* Resolve review feedback

* Set platform as owners of web core and shared

* Expand moved services

* Fix test types

---------

Co-authored-by: Hinton <hinton@users.noreply.github.com>
2023-06-06 15:34:53 -05:00
Jared Snider
a739422f86
PM-1049 - WIP of building out needed response and regular models for saving new UserDecryptionOptions on the Account in state. 2023-06-01 19:21:33 -04:00
Jared Snider
ebeeb5cbb7
PM-1049 - Move newly created getDevices() method out of api.service into proper place in new devices-api.service. 2023-05-25 15:26:16 -04:00
Jared Snider
e43da8044b
Merge remote-tracking branch 'origin/master' into feature/PM-1049-TDE-flow-3-login-decryption-options + merge conflict resolutions 2023-05-25 14:26:42 -04:00
Jared Snider
0fcfe883b5
Feature/[PM-1378] - Trusted Device Encryption - Establish trust logic for all clients (#5339)
* PM1378 - (1) Create state service methods for securely storing a device symmetric key while following existing pattern of DuckDuckGoKey generation (2) Create makeDeviceKey method on crypto service which leverages the new state service methods for storing the device key.

* PM-1378 - Document CSPRNG types w/ comments explaining what they are and when they should be used.

* PM-1378 - TODO to add tests for makeDeviceKey method

* PM-1378 - Create Devices API service for creating and updating device encrypted master keys + move models according to latest code standards ( I think)

* PM-1378 - TODO clean up - DeviceResponse properly moved next to device api service abstraction per ADR 0013

* PM-1378 - CryptoService makeDeviceKey test written

* PM-1378 - Tweak crypto service makeDeviceKey test to leverage a describe for the function to better group related code.

* PM-1378 - Move known devices call out of API service and into new devices-api.service and update all references. All clients building.

* PM-1378 - Comment clean up

* PM-1378 - Refactor out master key naming as that is a reserved specific key generated from the MP key derivation process + use same property on request object as back end.

* PM-1378 - Missed a use of master key

* PM-1378 - More abstraction updates to remove master key.

* PM-1378 - Convert crypto service makeDeviceKey into getDeviceKey method to consolidate service logic based on PR feedback

* PM-1378- Updating makeDeviceKey --> getDeviceKey tests to match updated code

* PM-1378 - Current work on updating establish trusted device logic in light of new encryption mechanisms (introduction of a device asymmetric key pair in order to allow for key rotation while maintaining trusted devices)

* PM-1378 - (1) CryptoService.TrustDevice() naming refactors (2) Lots of test additions and tweaks for trustDevice()

* PM-1378 - Updated TrustedDeviceKeysRequest names to be consistent across the client side board.

* PM-1378 - Move trusted device crypto service methods out of crypto service into new DeviceCryptoService for better single responsibility design

* PM-1378 - (1) Add getDeviceByIdentifier endpoint to devices api as will need it later (2) Update TrustedDeviceKeysRequest and DeviceResponse models to match latest server side generic encrypted key names

* PM-1378 - PR feedback fix - use JSDOC comments and move from abstraction to implementation

* PM-1378 - Per PR feedback, makeDeviceKey should be private - updated tests with workaround.

* PM-1378- Per PR feedback, refactored deviceKey to use partialKey dict so we can associate userId with specific device keys.

* PM-1378 - Replace deviceId with deviceIdentifier per PR feedback

* PM-1378 - Remove unnecessary createTrustedDeviceKey methods

* PM-1378 - Update device crypto service to leverage updateTrustedDeviceKeys + update tests

* PM-1378 - Update trustDevice logic - (1) Use getEncKey to get user symmetric key as it's the correct method and (2) Attempt to retrieve the userSymKey earlier on and short circuit if it is not found.

* PM-1378 - Replace deviceId with deviceIdentifier because they are not the same thing

* PM-1378 - Per PR feedback, (1) on web/browser extension, store device key in local storage under account.keys existing structure (2) on desktop, store deviceKey in secure storage. (3) Exempt account.keys.deviceKey from being cleared on account reset

* PM-1378 - Desktop testing revealed that I forgot to add userId existence and options reconciliation checks back

* PM-1378 - Per discussion with Jake, create DeviceKey custom type which is really just an opaque<SymmetricCryptoKey> so we can more easily differentiate between key types.

* PM-1378 - Update symmetric-crypto-key.ts opaque DeviceKey to properly setup Opaque type.

* PM-1378 - Fix wrong return type for getDeviceKey on DeviceCryptoServiceAbstraction per PR feedback
2023-05-25 14:17:19 -04:00
André Bispo
b9d3b0aff7
[PM-2398] Fix firefox extension environments bug (#5514) 2023-05-25 18:32:26 +01:00
André Bispo
1a9a328d39
[PM-2347] Refresh configs when environment urls change (#5507)
* [PM-2347] Re fetch feature flags when environment urls change and update UI.
2023-05-25 14:38:23 +01:00
Oscar Hinton
62591a8bc8
[PM-2328] Fix jest deprecations (#5483) 2023-05-22 20:19:16 +02:00
André Bispo
b9fe78796a
[PM-1019] Environment selection clients (#5480)
* [PM-169][PM-142][PM-191] Add Environments to Web and Desktop (#5294)

* [PM-1351] Add property to server-config.response. Change config to be able to fetch without being authed.

* [PM-1351] fetch every hour.

* [PM-1351] fetch on vault sync.

* [PM-1351] browser desktop fetch configs on sync complete.

* [PM-1351] Add methods to retrieve feature flags

* [PM-1351] Add enum to use as key to get values feature flag values

* [PM-1351] Remove debug code

* [PM-1351] Get flags when unauthed. Add enums as params. Hourly always fetch.

* [PM-1351] add check for authed user using auth service

* [PM-169] Web: add drop down to select environment

* [PM-169] Fix pop up menu margins. Add DisplayEuEnvironmentFlag.

* [PM-169] Change menu name.

* [PM-169] Add environment selector ts and html. Add declaration and import on login.module

* [PM-169] Add environment selector to desktop.

* [PM-169] Ignore lint error.

* [PM-169] add takeUntil to subscribes

* [PM-191] PR Fixes, code format

* [PM-168] Add Environments to extension login/registration (#5434)
2023-05-19 17:35:42 +01:00
renovate[bot]
9e32f8d574
chore(deps): update dependency rimraf to v5 (#5468)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
2023-05-19 14:23:44 +02:00
Jared Snider
c8794a3b01
Merge remote-tracking branch 'origin/master' into feature/PM-1049-TDE-flow-3-login-decryption-options 2023-05-17 19:01:45 -04:00
Oscar Hinton
3da7fc7cb3
Deprecated broadcaster (#5461) 2023-05-17 12:27:27 +02:00
Matt Gibson
c58b0c0753
Return error code when any tsc typecheck fails (#5459)
* Return error code when any tsc typecheck fails

* Try with bash

`sh ./scripts/test-types.s` resulted in errors missing `[[`,
which is a bash builtin. It's possible the ubuntu runner is using
some other shell.

* Fix spec type errors

* Switch to node for Windows compatibility
2023-05-16 09:20:40 -05:00