1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-11 10:10:25 +01:00
Commit Graph

1217 Commits

Author SHA1 Message Date
Shane Melton
6179397ba9
[PM-9503] Add paperclip icon for items with attachments (#10329) 2024-08-07 10:59:01 -07:00
Cesar Gonzalez
f51d1ba101
[PM-8841] Passkeys script injection breaks loading of specific websites that are expecting an empty DOM on init (#10424)
* [PM-8841] Passkeys script injection breaks loading of specific websites that are expecting an empty DOM on init

* [PM-8841] Implementing feature flag to allow for dynamic registration of the delayed page-script-append mv2 script
2024-08-07 10:41:30 -05:00
Jordan Aasen
af14c3fe6d
[PM-9854] - Send Search Component (#10278)
* send list items container

* update send list items container

* finalize send list container

* remove unecessary file

* undo change to config

* prefer use of takeUntilDestroyed

* add send items service

* and send list filters and service

* undo changes to jest config

* add specs for send list filters

* Revert "Merge branch 'PM-9853' into PM-9852"

This reverts commit 9f65ded13f, reversing
changes made to 63f95600e8.

* add send items service

* Revert "Revert "Merge branch 'PM-9853' into PM-9852""

This reverts commit 81e9860c25.

* finish send search

* fix formControlName

* add specs

* finalize send search

* layout and copy fixes

* cleanup

* Remove unneeded empty file

* Remove the erroneous addition of send-list-filters to vault-export tsconfig

* update tests

* hide send list filters for non-premium users

* fix and add specss

* Fix small typo

* Re-add missing tests

* Remove unused NgZone

* Rename selector for send-search

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-08-07 14:34:03 +02:00
rr-bw
b2a995462f
[PM-9605] Extension AnonLayout wrapper component (#10338)
* setup extension component

* setup extension service

* update icon based on theme, adjust padding, service injection

* override service

* add stories

* add current-account component

* add ConfigService to storybook

* use null checks for boolean data - otherwise false values are ignored

* update translations

* remove router implementation test

* remove imports in main.background.ts

* add showLogo to template

* update icon usage

* fix app-current-account storybook style issue
2024-08-06 16:02:47 -07:00
Todd Martin
e4ed4a3858
Add consistent and contextual logging around decryption failure (#10404)
* Added more context to logging messages around decryption failure

* Added missing period.
2024-08-06 18:23:38 -04:00
Bernd Schoolmann
7cd6fcf265
[PM-2192] Improve userkey verification on biometric unlock (#10326)
* Improve biometric unlock userkey verification

* Add early return

* Pass activeuserid to cryptoservice functions
2024-08-06 15:35:04 -04:00
Justin Baur
dcb21c2685
Move lastSync State (#10272) 2024-08-06 15:01:42 -04:00
Jonathan Prusik
887b98988a
improve typing for fido2 message type values (#10420) 2024-08-06 14:56:59 -04:00
Bernd Schoolmann
2ce8500391
[PM-990] Unix biometrics unlock via Polkit (#4586)
* Update unix biometrics for desktop biometrics rework

* Implement polkit policy setup

* Enable browser integration on Linux

* Remove polkit policy file

* Undo change to messages.json

* Fix biometrics setup, implement missing functions

* Implement osSupportsBiometrics

* Fix polkit settings message

* Remove unwraps in biometrics unix rust module

* Force password reprompt on start on linux with biometrics

* Merge branch 'main' into feature/unix-biometrics

* Allow browser extension to be unlocked on Linux via Polkit

* Implement availability check

* Cleanup

* Add auto-setup, manual setup, setup detection and change localized prompts

* Implement missing methods

* Add i18n to polkit message

* Implement missing method

* Small cleanup

* Update polkit consent message

* Fix unlock and print errors on failed biometrics

* Add dependencies to core crate

* Fix reference and update polkit policy

* Remove async-trait

* Add tsdoc

* Add comment about auto setup

* Delete unused init

* Update help link

* Remove additional settings for polkit

* Add availability-check to passwords implementation on linux

* Add availability test

* Add availability check to libsecret

* Expose availability check in napi crate

* Update d.ts

* Update osSupportsBiometric check to detect libsecret presence

* Improve secret service detection

* Add client half to Linux biometrics

* Fix windows build

* Remove unencrypted key handling for biometric key

* Move rng to rust, align linux bio implementation with windows

* Consolidate elevated commands into one

* Disable snap support in linux biometrics

---------

Co-authored-by: DigitallyRefined <129616584+DigitallyRefined@users.noreply.github.com>
2024-08-06 11:04:17 -04:00
Cesar Gonzalez
320e4f18ce
[PM-10654] Fixing broken jest tests (#10415) 2024-08-06 09:15:45 -05:00
Cesar Gonzalez
b0c938ea7e
[PM-10654] Inline menu not working in MS Edge (#10414) 2024-08-06 08:32:16 -05:00
Nick Krantz
aaf8b3e2b1
[PM-9921] Add Popout to Add/Edit/View components (#10382)
* add popout component to add/edit component

* add popout component to view cipher components

* fix formatting
2024-08-05 13:18:16 -05:00
Cesar Gonzalez
cecfbaeaad
[PM-10552] Values input between separate iframes are not populated when adding a cipher from the inline menu (#10401)
* [PM-10554] Inline menu glitches on single form fields that are wrapped within inline menu

* [PM-10554] Adding jest tests to validate expected behavior

* [PM-10554] Adding jest tests to validate expected behavior

* [PM-10552] Vaules input between separate iframes are not populated in add-edit cipher popout

* [PM-10552] Working through issues found when attempting to add ciphers within iframes that trigger a blur event

* [PM-10552] Working through issues found when attempting to add ciphers within iframes that trigger a blur event

* [PM-10552] Fixing broken jest tests due to implementation changes

* [PM-10552] Implementing jest tests to validate behavior within OverlayBackground
2024-08-05 12:03:17 -05:00
Cesar Gonzalez
fdcf1c7ea2
[PM-10554] Inline menu glitches on single form fields that are wrapped within an iframe (#10384)
* [PM-10554] Inline menu glitches on single form fields that are wrapped within inline menu

* [PM-10554] Adding jest tests to validate expected behavior

* [PM-10554] Adding jest tests to validate expected behavior
2024-08-05 11:32:29 -05:00
Jonathan Prusik
7e3358d4ee
move fido2 popup components from vault to autofill (#10381) 2024-08-05 12:20:13 -04:00
Cesar Gonzalez
157f3a5d39
[PM-10598] Revert autocomplete="off" removal when qualifying the inline menu for identity fields (#10402) 2024-08-05 10:11:54 -05:00
Cesar Gonzalez
032c013dd7
[PM-10550] Card inline menu not displayed on popup payment form (#10380)
* [PM-10550] Card inline menu not displayed on popup payment form

* [PM-10550] Removing requirement for autocomplete to be "off" for identity fields when matching inline menu presentation
2024-08-02 15:30:23 -04:00
Cesar Gonzalez
76351ce750
[PM-10420] Autofill focus jumps around after autofilling identity (#10361)
* [PM-10420] Autofill focus jumps around after autofilling identity ciphers

* [PM-10420] Autofill focus jumps around after autofilling identity ciphers

* [PM-10420] Autofill focus jumps around after autofilling identity ciphers

* [PM-10420] Incorporating the feature flag within jest to test the validity of both implementations

* [PM-10420] Refactoring how we compile the combined list of keywords

* [PM-10420] Adding JSDocs to the implemented methods
2024-08-02 14:14:23 -05:00
Oscar Hinton
c50a9063bc
[PM-2340] Enable use-lifecycle-interface (#5488)
Enables one of the recommended rules of @angular-eslint. Since this rule was fairly trivial to fix and has no QA effects it seemed reasonable to migrate all code.
2024-08-02 13:59:38 -04:00
SmithThe4th
0b6d9928a3
missing focus on the learn more button (#10365) 2024-08-02 12:07:11 -04:00
Bernd Schoolmann
cc45655b86
Revert "[PM-6296] Fix biometrics error prompt when biometrics are temporarily…" (#10373)
This reverts commit 1184c504d1.
2024-08-02 07:46:54 -04:00
Bernd Schoolmann
1184c504d1
[PM-6296] Fix biometrics error prompt when biometrics are temporarily unavailable in browser extension (#9851)
* Add availability check to biometrics

* Move isbiometricunlockavailable logic to parent component

* Fix availability detection on desktop

* FIx response parsing on browser

* Suppress pending biometric message while checking for availability

* Refactor biometrics functions out of platformutilsservice

* Remove unused constructor

* Remove unused abstract function definitions

* Rename abstract services

* Add documentation

* Rename service abstraction, add comments

* Add comments

* Refactor browser biometrics into background/foreground and remove callbacks

* Remove unused logs

* Remove unused logs
2024-08-02 12:31:11 +02:00
Bernd Schoolmann
a9ba7d8d25
Deduplicate background storage service in browser mv2 (#10241) 2024-08-02 12:03:54 +02:00
github-actions[bot]
ce86fc0232
Autosync the updated translations (#10369)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-08-02 06:43:32 +00:00
Bernd Schoolmann
c6229abd12
[PM-5963] Fix tde offboarding vault corruption (#9480)
* Fix tde offboarding

* Add tde offboarding password request

* Add event for tde offboarding

* Update libs/auth/src/common/models/domain/user-decryption-options.ts

Co-authored-by: Jake Fink <jfink@bitwarden.com>

* Update libs/common/src/services/api.service.ts

Co-authored-by: Jake Fink <jfink@bitwarden.com>

* Make tde offboarding take priority

* Update tde offboarding message

* Fix unit tests

* Fix unit tests

* Fix typo

* Fix unit tests

---------

Co-authored-by: Jake Fink <jfink@bitwarden.com>
2024-08-01 19:48:09 -04:00
Nick Krantz
82d6b26b18
[PM-9839] Extension - Safari - Disable Account Switching (#10364)
* only show account switching when enableAccountSwitching is true

* update the title of the account switcher component

* only show "Lock All" when more than one account is present

* implement account switching restrictions on non-extension refresh page
2024-08-01 16:11:52 -05:00
Alec Rippberger
a90df15dc0
[PM-8794] Update "auto-fill" to "autofill" (#10156)
* Update i18n message strings from "auto-fill" to "autofill".

* Update tests, warnings and stories "auto-fill" to "autofill".

* Remove unnecessary new line removal.
2024-08-01 12:39:52 -05:00
Shane Melton
0d76835cd8
[PM-9190] Edit Login - Autofill Options (#10274)
* [PM-8524] Update appA11yTitle to keep attributes in sync after first render

* [PM-8524] Introduce UriOptionComponent

* [PM-9190] Introduce AutofillOptionsComponent

* [PM-9190] Add AutofillOptions to LoginDetailsSection

* [PM-9190] Add autofill options component unit tests

* [PM-9190] Add UriOptionComponent unit tests

* [PM-9190] Add missing translations

* [PM-9190] Add autofill on page load field

* [PM-9190] Ensure updatedCipherView is completely separate from originalCipherView

* [CL-348] Do not override items if there are no OptionComponents available

* [PM-9190] Mock AutoFillOptions component in Login Details tests

* [PM-9190] Cleanup storybook and missing web translations

* [PM-9190] Ensure storybook decryptCipher returns a separate object
2024-08-01 08:35:04 -07:00
Jonathan Prusik
0738495dee
[PM-10134] Add text to default URI match detection select (#10346)
* add text to default URI match detection select

* add separate entry for recommended option variant
2024-08-01 10:22:39 -04:00
Cesar Gonzalez
77d6ac88e7
[PM-10416] Address field is used to populate state field when adding identity cipher from inline menu (#10348) 2024-08-01 08:18:20 -05:00
Cesar Gonzalez
86acca3bec
[PM-10079] Add keyboard shortcut to autofill identity and credit cards (#10254)
* [BEEEP] Autofill Identity and Card Ciphers From Keyboard Shortcut

* [PM-10079] Add keyboard shortcut to autofill identity and credit card ciphers

* [PM-10079] Fixing jest tests

* [PM-10079] Added an enum for the autofill commands, and adjusted how we filter out cipher types before sorting them by last used when calling for ID and card ciphers

* [PM-10079] Updating copywriting for the autofill settings revolving around keyboard shortcuts

* [PM-10079] Setting a method within CipherService as private
2024-07-31 12:52:04 -05:00
Cesar Gonzalez
85c8ff04a1
[PM-10138] Inline menu not properly validating as the top-most element within mutation observer (#10292)
* [PM-10138] Inline menu not properly validating as the top-most element within mutation observer

* [PM-10138] Identity inline menu appearing for invalid field types

* [PM-10138] Identity inline menu appearing for invalid field types

* [PM-10138] Fixing an issue present with references to card and identity ciphers

* [PM-10138] Fixing issues with initialization of the inline menu

* [PM-10138] Fixing issues with initialization of the inline menu

* [PM-10138] Removing inclusion of file protocol when injecting scripts
2024-07-31 12:51:41 -05:00
Jonathan Prusik
ea362a9ed9
section headers should use heading 6 styling (#10345) 2024-07-31 12:35:47 -04:00
Jonathan Prusik
c9f4cffc75
remove margin from last field in each card of autofill settings (#10344) 2024-07-31 12:35:17 -04:00
Cesar Gonzalez
0c84f44806
[PM-10124] Browser refresh update for autofill settings component returning invalid data type (#10289) 2024-07-31 09:59:14 -05:00
Jared Snider
d915bd8c86
Auth/PM-10069 - Unauthenticated UI Extension Refresh Swap Utility (#10327)
* PM-3515 - Lock component - remove isUnlocked check on lock comp load b/c lock guard should cover all cases with its existing logic for all clients.

* PM-9685 - Add new feature flag

* PM-10069 - ExtensionRefreshRouteUtils - Add unauthExtensionRefreshSwap helper

* Restore lock component
2024-07-30 14:41:10 -04:00
Nick Krantz
84ee01caee
[PM-7103] Identity View (#10240)
* make headings of v2 view component lowercase

* initial add of view identity sections

* adding identification fields

* add contact information section

* add copy ability to all identity fields

* add visibility toggle for passport and ssn

* add testids for all identity fields

* add test-ids to visibility toggles

* refactor visibility methods to be called in `ngOnInit` rather than on each render

* replace `disabled` with `readonly`
2024-07-30 10:55:09 -05:00
SmithThe4th
81212deaad
[PM-7306] Onboarding users to new UI (#10267)
* Added translation keys

* created simple dialog

(cherry picked from commit c12257cf51ca5e0d773a160afb6860a8f5df66b7)

* added announcement svg

(cherry picked from commit 635103120b500103b93dc1a8cbefc34dd396445b)

* removed announcement svg, moved svg to component, refactored component

(cherry picked from commit 50db6aa40fd90d92afeeb60e919f98f268bd69b5)

* renamed state definition

(cherry picked from commit 4c3618c46ee5ffab7050fbc9f6d779ee59c0c26b)

* created vault ui onboarding service

(cherry picked from commit 19ba3c42656d4f891ba3635da06f3ff7656b6028)

* added vault ui dialog to vault component

(cherry picked from commit 56527c8e5eda7df2f222ceebdeba168e2f1ae278)

* moved updating the state to vault component

* updated the link and fixed minor issues

* moved onboarding logic from component to service and fixed review comments
2024-07-30 11:45:26 -04:00
Shane Melton
973aba1bf4
[PM-8379] Fix Vault Popup Items service loading (#10324)
* [PM-8379] Avoid fetching decrypted ciphers if no sync has completed

* [PM-8379] Do not emit ciphers loading when applying filters
2024-07-30 08:14:17 -07:00
Alec Rippberger
3b54bbd168
[PM-7902] Create V2 Note Component View (#10150)
* Rename <additional-information> component to <additional-options>

The Figma designs show and update to the Additional Information section. The heading changed to "Additional options". It probably makes sense to update the component name to match.

* Make view note header "note" lowercase.

* Add new translation messages for view header.

* Revert "Add new translation messages for view header."

This reverts commit 4e8877fe71.

* Make cipher headers lowercase via toLowerCase function

* Remove unused import.

* run npm ci && npm run prettier

* add back missing import
2024-07-29 16:24:35 -05:00
Alec Rippberger
6b8f60792e
Count and display invalid fields in toast. (#10249) 2024-07-29 15:33:29 -05:00
Jason Ng
3b668deaac
[PM-9631] MP reprompt view items (#10291)
* MP reprompt check will run before viewing item
2024-07-29 16:08:35 -04:00
Jared Snider
ea72552599
Auth/PM-7077 - Browser Extension - UI Refresh - Account Switcher Component (#10268)
* PM-7077 - (1) Convert app-header to standalone (2) Convert account-switcher to standalone (3) Start wiring up extension refresh feature flag and fixing deps.

* PM-7077 WIP

* PM-7077 - Mostly get account switcher and account component converted to CL components.

* PM-7077 - Apply semibold classes to section headers to match storybook

* PM-7077 - AccountSwitcher - (1) Fix margin per design call (2) Add missing lockAll call

* PM-7077 - Remove test code.
2024-07-29 12:57:54 -04:00
Shane Melton
ad01a529e8
[PM-9959] [PM-9962] Browser Refresh - Passkey Fixes (#10299)
* [PM-9959] Expose Fido2SessionData interface

* [PM-9959] Ensure cipherType is passed during passkey creation

* [PM-9959] Add beforeSubmit hook to cipherForm

* [PM-9959] Add support for Fido2 credential creation in add-edit-v2

* [PM-9959] Ensure cipherType defaults to CipherType.Login if none is available

* [PM-9959] Add support for name and username to be passed in as query params for initial form values

* [PM-9962] Hide remove passkey button when cipher has "except passwords" permissions
2024-07-29 08:13:56 -07:00
Shane Melton
00f6920a86
[PM-8379] Implement loading state in vault v2 (#10302) 2024-07-29 08:10:12 -07:00
Justin Baur
c91f9146da
[PM-9978] Add State Logging Options (#10251)
* Add `DebugOptions` to Definitions

* Respect Debug Options

* Configure DI
2024-07-29 13:21:21 +00:00
github-actions[bot]
73429a2150
Autosync the updated translations (#10312)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-29 12:28:50 +00:00
Nick Krantz
7594ebead2
[PM-9953][PM-9963] Collections Reprompt and Org assignment (#10194)
* prompt for master password for assigning-collections

* only pass collections that are within the cipher's org

* remove type=button on anchor element
2024-07-26 12:46:06 -05:00
github-actions[bot]
f96a66ebd9
Autosync the updated translations (#10280)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-26 13:48:01 +00:00
Bernd Schoolmann
ad26f0890a
[PM-4348] Migrate AuthGuards to functions (#9595)
* Migrate auth guards

* Fix remaining auth guard migration

* Fix unauth guard usage

* Add unit tests for auth guard and unauth guard

* Remove unused angular DI code

* Move auth related logic out fo sm guard

* Add tests

* Add more tests for unauth guard

* Fix incorrect merge
2024-07-25 17:00:29 -04:00