1
0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-11 00:31:45 +01:00
Commit Graph

2196 Commits

Author SHA1 Message Date
Jared Snider
65d080a6e7
PM-8113 - TwoFactorAuthComp - Integrate latest ssoLoginService changes 2025-02-04 16:41:44 -05:00
Jared Snider
2fd7224487
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-comps-ui-refresh + merge conflict resolutions 2025-02-04 16:39:07 -05:00
Nick Krantz
aa024b419c
[PM-12571][PM-13807] Add/Edit Folder Dialog (#12487)
* move `add-edit-folder` component to `angular/vault/components` so it can be consumed by other platforms

* add edit/add folder copy to web app copy

* add extension refresh folder dialog to individual vault

* adding folder delete message to the web

* add deletion result for add/edit folder dialog

* allow editing folder from web

* fix strict types for changed files

* update tests

* remove border class so hover state shows

* revert changes to new-item-dropdown-v2

* migrate `AddEditFolderDialogComponent` to `libs/vault` package

* add Created enum type

* add static open method for folder dialog

* add fullName to `FolderFilter` type

* save the full name of a folder before splitting it into parts

* use the full name of the folder filter when available

* use a shallow copy to edit the folder's full name

---------

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2025-02-04 15:13:13 -06:00
Jordan Aasen
a9f24b6d24
[PM-15938] - Restrict viewing hidden input based on permission (#13016)
* allow string or boolean disabled prop in input directive

* fix tests

* add test

* disable custom fields in partial edit

* disable custom fields in partial edit

* manually disable inputs

* revert changes to directive

* revert other changes

* remove unnecessary check for partial-edit
2025-02-04 12:59:25 -08:00
Jason Ng
327aed9763
[PM-11162] Assign To Collections Permission Update (#11367)
Only users with Manage/Edit permissions will be allowed to Assign To Collections. If the user has Can Edit Except Password the collections dropdown will be disabled.
---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Co-authored-by: kejaeger <138028972+kejaeger@users.noreply.github.com>
2025-02-04 15:44:59 -05:00
Alex Morask
f9efbf0a6a
Update feature flag name (#13243) 2025-02-04 15:14:54 -05:00
Jared Snider
fa8f9df07e
PM-8113 - TwoFactorAuth - Save off 2FA providers map so we can only show the select another 2FA method if the user actually has more than 1 configured 2FA method. 2025-02-04 13:56:02 -05:00
Jared Snider
adf448ce76
PM-8113 - Add required to inputs 2025-02-04 13:37:09 -05:00
Patrick-Pimentel-Bitwarden
0523ce0b40
refactor(active-user-state-refactor): [PM-12040] Remove ActiveUserStatus For SSO Login Component (#13149)
* refactor(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - First pass of work to update the state. In the middle of testing.

* fix(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Fix for jslib-services.module.ts

* fix(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Fix main.background.ts

* test(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Added simple tests

* fix(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Tiny touchups.

* fix(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Few fixes to resolve comments.

* fix(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Changed place where userId is loaded.

* test(active-user-state-refactor): [PM-12040] Remove ActiveUserState from SSO Service - Fixed test.
2025-02-04 13:31:36 -05:00
Daniel James Smith
2c367444ff
Group tools-owned feature flags (#13239)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-02-04 17:18:24 +00:00
Jared Snider
56535adaaf
PM-8113 - TwoFactorAuthComp - (1) remove unused deps (2) get tests passing 2025-02-04 11:25:14 -05:00
Jared Snider
5f30790437
Merge branch 'main' into auth/pm-8113/2fa-comps-ui-refresh 2025-02-04 09:37:26 -05:00
Alex Morask
cf7a174d11
[PM-15179] Implement add-existing-organization-dialog.component (#13010)
* Implement add-existing-organization-dialog.component

* Add missing button type

* Thomas' feedback

* Import order issue
2025-02-04 09:02:12 -05:00
Jared Snider
7ab9225af1
PM-8113 - TwoFactorAuthComp - Add loginSuccessHandlerService 2025-02-03 17:43:47 -05:00
SmithThe4th
101cd940e9
[PM-14417] Create admin TaskService (#12891)
* [PM-14416] Add initial SecurityTask models and enums

* [PM-14416] Add support for PATCH request method and 204 No Content response

* [PM-14416] Add initial task service abstraction

* [PM-14416] Add SecurityTask state/key definitions

* [PM-14416] Add DefaultTaskService implementation

* [PM-14416] Add DefaultTaskService tests

* [PM-14416] Add better null checking to new models

* [PM-14416] Improve null value filtering for task service

* initial commit, added absract file and implementation file

* Added abstract method and implemented bulk create method

* Implemented get all api

* created spec file

* Fixed references

* Added exports

* Added tests

* fixed suggestions

* fixed test

---------

Co-authored-by: Shane Melton <smelton@bitwarden.com>
2025-02-03 16:20:48 -05:00
Vicki League
3c01abcdfd
[CL-569] Fix ngClass error on item content (#13235) 2025-02-03 20:43:27 +00:00
Oscar Hinton
e5ffc162b8
[CL-553] Migrate CL to Control Flow syntax (#12390) 2025-02-03 20:11:59 +01:00
Alec Rippberger
ec16efabf2
refactor(styles): [PM-17181] remove Bootstrap styles from UserVerificationFormInputComponent
Replace Bootstrap classes with Tailwind CSS equivalents to maintain consistent styling:
- Replace form-control with Tailwind input classes
- Replace btn and btn-outline-secondary with Tailwind button classes
- Replace d-block with tw-block
- Replace spacing and utility classes with tw- prefixed equivalents
- Replace box-content-row with Tailwind layout classes

[PM-17181]
2025-02-03 10:15:32 -06:00
Andreas Coroiu
d7c46bb3a5
[PM-16231] Improved SDK referencing (#12475)
* feat: implement Rc

* feat: use Rc in sdk service

* docs: add an example to `take()`

* fix: clarify function doc

* Add custom eslint rule package with enforced `using` rule (#13009)

* feat: add custom eslint rule

* feat: check for `UsingRequired` instead of hardcoding `Rc`

* chore: move package to libs

* wip: add tests. Tests work when run from same folder but not from root

* fix: add dependencies to renovate

* fix: add empty ts file to avoid typechecking throwing errors

* fix: tests not running from root

* chore: remove unecessary config

* fix: linting

* docs: add readme

* chore: add platform ownership

* chore: clean up comment

* Add support for flat config to "Improved sdk referencing" (#13054)

* WIP flat config for eslint

* Add rxjs

* Configure vscode to use flat config

* Fix some new linting errors

* Remove directory overrides of .eslintrc

* Remove explicit dependencies on typescript-eslint/ and @angular-eslint/

* Add missing rules

* Add rxjs recommended rules

* Add storybook and enabled rxjs-angular rule

* Add buildNoRestrictedImports helper

* Ignore platform import restrictions

* Remove unused ignores

* feat: migrate rules over to .mjs and flat config

* feat: implement support for .mjs tests

* chore: remove old package approach

* chore: update package-lock

* fix: add empty TS file to stop errors

* chore: clean up comments

---------

Co-authored-by: Hinton <hinton@users.noreply.github.com>

* fix: update CODEOWNERS to match folder name

* fix: renovate.json after merge

* fix: package.json, pin versions, sort order

* fix: update package-lock.json

---------

Co-authored-by: Hinton <hinton@users.noreply.github.com>
2025-02-03 15:09:25 +01:00
Jared Snider
a5ca2f956e
PM-8113 - 2FA Auth Comp - for form validated 2FA methods, add enter support. 2025-02-02 14:44:58 -05:00
Jared Snider
118aea38f4
PM-8113 - Refactor all 2FA flows to use either reactive forms or programmatic submission so we get the benefit of onSubmit form validation like we have elsewhere. 2025-02-02 14:28:59 -05:00
Jared Snider
386315aa90
PM-8113 - TwoFactorAuthYubikey - Clean up design per figma 2025-01-31 16:31:37 -05:00
Jared Snider
762d1c16a2
PM-8113 - TwoFactorAuthAuthenticator - Remove text per figma 2025-01-31 16:26:25 -05:00
Jared Snider
22890e1024
PM-8113 - Two Factor Options - Implement wrapping 2025-01-31 16:09:07 -05:00
Jared Snider
59050558df
Merge remote-tracking branch 'origin/main' into auth/pm-8113/2fa-comps-ui-refresh + oss routing module merge conflict resolution 2025-01-31 15:57:08 -05:00
Vicki League
ca53ecccd0
[CL-569] Optionally allow item content to wrap (#13178) 2025-01-31 13:42:41 -05:00
Vincent Salucci
22edfd4283
fix: move feature flag to correct grouping, update casing, update callers, refs PM-17763 (#13184) 2025-01-31 12:18:17 -06:00
Alec Rippberger
8e70d5b923
feat(auth): [PM-3953] generalize copy for login with device flows
Updates UI text and translations for the login with device feature to be more consistent and clear across desktop, browser and web clients. Changes include:

- Updated titles and content for login via auth request components
- Revised translations for device approval modal
- Updated notification titles and alert messages
- Simplified device management URL handling
- Added missing translations across platforms

Resolves PM-3953
2025-01-31 11:54:41 -06:00
Daniel James Smith
6ae30f5059
Remove dependency on importer/core from libs/angular (#13137)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-01-31 14:04:35 +01:00
Jared Snider
177fa3fc14
PM-8113 - TwoFactorAuthComp - per figma, put webauthn after checkbox. 2025-01-30 20:35:38 -05:00
Jared Snider
33ab7e6358
PM-8113 - Webauthn Iframe - update translation per figma 2025-01-30 20:31:10 -05:00
Jared Snider
afad4e08cf
PM-8113 - TwoFactorAuthWebAuthn - Add loading state for iframe until webauthn ready 2025-01-30 20:13:03 -05:00
Will Martin
f17cb61183
[UIF] fix toast title type (#13098) 2025-01-30 16:20:41 -05:00
Jimmy Vo
7a1121dff4
[pm-17763] Add limitItemDeletion property to UI. (#13162) 2025-01-30 15:30:34 -05:00
Shane Melton
a404729c9e
[PM-17745] Catch network errors in new device notification guard (#13161)
* [PM-17745] Wrap new device guard applicability check in try/catch to prevent crashes from network errors

* [PM-17745] Fix broken test
2025-01-30 12:18:22 -08:00
Jared Snider
4cce1d788d
PM-8113 - TwoFactorOptions - (1) Sort providers like setup screen (2) Add responsive scaling 2025-01-30 12:27:17 -05:00
Jimmy Vo
cbba1a686c
[pm-17363] Add LimitItemDeletion property to models (#13087) 2025-01-30 11:09:04 -05:00
Oscar Hinton
f8bdd66fbb
[PM-17629] Split up KM lib to km and km-ui (#13093) 2025-01-30 11:20:17 +01:00
Jared Snider
306b08ea09
PM-8113 - 2FA Options Comp rewritten to match figma 2025-01-29 18:58:49 -05:00
Jared Snider
dfacaff005
PM-8113 - TwoFactorOptionsComponent - remove icon disable logic and unused imports 2025-01-29 17:45:38 -05:00
Jared Snider
01314f1aa1
PM-8113 - TwoFactorOptionsComponent - deprecate recovery code functionality 2025-01-29 17:44:46 -05:00
Jared Snider
e2e5a92ef0
PM-8113 - Adjust translations based on meeting with Design 2025-01-29 17:06:48 -05:00
Jordan Aasen
4b45029d23
[PM-17688] - generator dialog - add missing button label i18n keys. fix logic for disabling button (#13140)
* add missing button label i18n keys. fix logic for displaying button label

* Update comment

Co-authored-by:  Audrey  <ajensen@bitwarden.com>

---------

Co-authored-by:  Audrey  <ajensen@bitwarden.com>
2025-01-29 14:06:03 -08:00
Shane Melton
99ecf821dd
[PM-17713] Only use cachedCipherView if the cache was initialized from a cipher (#13133) 2025-01-29 13:40:03 -08:00
Daniel James Smith
ef38a96faf
[PM-16485] Remove legacy generator from change password component (#13132)
* Remove deprecated and unused PasswordGenerationService

* Remove unused state-service

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-01-29 14:40:48 -05:00
Jared Snider
e368f1afa3
PM-8113 - Mark old two-factor-options component as v1. 2025-01-29 13:28:06 -05:00
Shane Melton
db2b405421
Fix noop notification service registration (#13131)
* Re-order the constructor dependencies to match between Noop and Default notification service

* Fix test file

* One more missed constructor
2025-01-29 12:58:01 -05:00
Jared Snider
7d8686122b
PM-8113 - TwoFactorAuthComp - remove icon from launch duo button per figma 2025-01-29 11:35:26 -05:00
Jared Snider
d579acb3aa
PM-8113 - (1) Add Yubico logo icon (2) Rename Yubikey icon to security key icon 2025-01-29 11:26:31 -05:00
Jared Snider
5a36c8b298
PM-8113 - 2FA Auth Comp - Duo icon works 2025-01-29 11:11:46 -05:00