1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-06 09:20:43 +01:00
Commit Graph

12124 Commits

Author SHA1 Message Date
Rui Tomé
3a298bd989
[EC-377] Transition Policy service into providing observables (#3259)
* Added abstractions for PolicyApiService and PolicyService

* Added implementations for PolicyApiService and PolicyService

* Updated all references to new PolicyApiService and PolicyService

* Deleted old PolicyService abstraction and implementation

* Fixed CLI import path for policy.service

* Fixed main.background.ts policyApiService dependency for policyService

* Ran prettier

* Updated policy-api.service with the correct imports

* [EC-377] Removed methods from StateService that read policies

* [EC-377] Updated policy service getAll method to use observable collection

* [EC-377] Added first unit tests for policy service

* [EC-377] Added more unit tests for Policy Service

* [EC-376] Sorted methods order in PolicyApiService

* [EC-376] Removed unused clearCache method from PolicyService

* [EC-376] Added upsert method to PolicyService

* [EC-376] PolicyApiService putPolicy method now upserts data to PolicyService

* [EC-377] Removed tests for deleted clearCache method

* [EC-377] Added unit test for PolicyService.upsert

* [EC-377] Updated references to state service observables

* [EC-377] Removed getAll method from PolicyService and refactored components to use observable collection

* [EC-377] Updated components to use concatMap instead of async subscribe

* [EC-377] Removed getPolicyForOrganization from policyApiService

* [EC-377] Updated policyAppliesToUser to return observable collection

* [EC-377] Changed policyService.policyAppliesToUser to return observable

* [EC-377] Fixed browser settings.component.ts getting vault timeout

* Updated people.component.ts to get ResetPassword policy through a subscription

* [EC-377] Changed passwordGenerationService.getOptions to return observable

* [EC-377] Fixed CLI generate.command.ts getting enforcePasswordGeneratorPoliciesOnOptions

* [EC-377] Fixed eslint errors on rxjs

* [EC-377] Reverted changes on passwordGeneration.service and vaultTimeout.service

* [EC-377] Removed eslint disable on web/vault/add-edit-component

* [EC-377] Changed AccountData.policies to TemporaryDataEncryption

* [EC-377] Updated import.component to be reactive to policyAppliesToUser$

* [EC-377] Updated importBlockedByPolicy$

* [EC-377] Fixed missing rename

* [EC-377] Updated policyService.masterPasswordPolicyOptions to return observable

* [EC-377] Fixed vaultTimeout imports from merge

* [EC-377] Reverted call to passwordGenerationService.getOptions

* [EC-377] Reverted call to enforcePasswordGeneratorPoliciesOnOptions

* [EC-377] Removed unneeded ngOnDestroy

* Apply suggestions from code review

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* [EC-377] Fixed login.component.ts and register.component.ts

* [EC-377] Updated PolicyService to update vaultTimeout

* [EC-377] Updated PolicyService dependencies

* [EC-377] Renamed policyAppliesToUser to policyAppliesToActiveUser

* [EC-377] VaultTimeoutSettings service now gets the vault timeout directly instead of using observables

* [EC-377] Fixed unit tests by removing unneeded vaultTimeoutSettingsService

* [EC-377] Set getDecryptedPolicies and setDecryptedPolicies as deprecated

* [EC-377] Set PolicyService.getAll as deprecated and updated to use prototype.hasOwnProperty

* [EC-565] Reverted unintended change to vaultTimeoutSettings that was causing a bug to not display the correct vault timeout

* [EC-377] Removed unneeded destroy$ from preferences.component.ts

* [EC-377] Fixed policy.service.ts import of OrganizationService

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com>
2022-10-11 13:08:48 +01:00
Andreas Coroiu
ea12ee2b10
[EC-558] chore: cleanup unused code (#3740) 2022-10-11 10:50:46 +02:00
Thomas Rittson
be040080db
Mark modalService.openViewRef as deprecated (#3697) 2022-10-11 06:57:45 +10:00
Opeyemi
333bc27972
Update download artifact action (#3735) 2022-10-10 20:35:44 +01:00
Robyn MacCallum
fe1a895e6b
[SG-720] Trim c null characters getting padded at end of messages (#3724)
* Trim everything at the end of decrypted payload before parsing

* Clarify comment

* Use char code check for nulls

* Extract trim code to function

* make char codes constants
2022-10-10 13:07:12 -04:00
Oscar Hinton
f6b2b75ad8
Forbid substitute (#3734) 2022-10-10 17:19:01 +02:00
Andreas Coroiu
bb4f063fe7
[EC-558] Reflecting async progress on buttons and forms (#3548)
* [EC-556] feat: convert button into component

* [EC-556] feat: implement loading state

* [EC-556] feat: remove loading from submit button

* [EC-556] fix: add missing import

* [EC-556] fix: disabling button using regular attribute

* [EC-556] feat: implement bitFormButton

* [EC-556] feat: use bitFormButton in submit button

* [EC-556] fix: missing import

* [EC-558] chore: rename file to match class name

* [EC-558] feat: allow skipping bitButton on form buttons

* [EC-558]: only show spinner on submit button

* [EC-558] feat: add new bit async directive

* [EC-558] feat: add functionToObservable util

* [EC-558] feat: implement bitAction directive

* [EC-558] refactor: simplify bitSubmit using functionToObservable

* [EC-558] feat: connect bit action with form button

* [EC-558] feat: execute function immediately to allow for form validation

* [EC-558] feat: disable form on loading

* [EC-558] chore: remove duplicate types

* [EC-558] feat: move validation service to common

* [EC-558] feat: add error handling using validation service

* [EC-558] feat: add support for icon button

* [EC-558] fix: icon button hover border styles

* [EC-558] chore: refactor icon button story to show all styles

* [EC-558] fix: better align loading spinner to middle

* [EC-558] fix: simplify try catch

* [EC-558] chore: reorganize async actions

* [EC-558] chore: rename stories

* [EC-558] docs: add documentation

* [EC-558] feat: decouple buttons and form buttons

* [EC-558] chore: rename button like abstraction

* [EC-558] chore: remove null check

* [EC-558] docs: add jsdocs to directives

* [EC-558] fix: switch abs imports to relative

* [EC-558] chore: add async actions module to web shared module

* [EC-558] chore: remove unecessary null check

* [EC-558] chore: apply suggestions from code review

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* [EC-558] fix: whitespaces

* [EC-558] feat: dont disable form by default

* [EC-558] fix: bug where form could be submit during a previous submit

* [EC-558] feat: remove ability to disable form

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2022-10-10 16:04:29 +02:00
Oscar Hinton
96c99058c4
[CL-42] Add code color (#3662) 2022-10-07 18:24:49 +02:00
Gbubemi Smith
c0e872e576
added 2fa enabled (#3711) 2022-10-07 16:05:20 +01:00
cd-bitwarden
8676d194d0
fixes (#3708) 2022-10-06 12:31:31 -04:00
Vince Grassia
f2159d71ea
Add staged rollout desktop workflow (#3702) 2022-10-06 09:54:37 -04:00
Thomas Rittson
7c3255d9fa
Add organization-options menu to single org (#3678) 2022-10-05 07:41:35 +10:00
Daniel James Smith
43d586ff99
[PS-1514] Do not subscribe to activeAccount-observable and execute load asynchronously (#3608)
* Fix async subscribe

* Revert "[PS-1066] Browser and Desktop - SSO User does not see Update Master Password screen after Owner does a Admin Password Reset (#3207)"

This reverts commit 0eda418591.
2022-10-04 20:43:51 +02:00
Oscar Hinton
b153ed6d01
[SM-265] Add eslint rule forbidding get().value (#3671) 2022-10-04 15:40:00 +02:00
Alexey Zilber
9ca877a7be
Cloudops 165 (#3661)
* Upload artifacts to R2 after we do S3.

* Added beta check line to R2 upload
2022-10-04 21:38:48 +08:00
Thomas Rittson
162db0b600
[EC-582] Add domain object serialization (#3623) 2022-10-04 06:50:43 +10:00
Patrick H. Lauke
cb7b8313a4
[PS-1198] Desktop / Browser: Accessibility - make TOTP countdown announce for assistive technology users (#2660)
* Make totp countdown `aria-hidden`, add copy of countdown as `sr-only` inside totp button, only make it conditionally "exist" on parent focus

* Make exact same changes to desktop totp

* Tweak copy button accessible name approach

instead of `aria-label`, which overrides the content of the button and, because JAWS has trouble announcing the live region in the desktop app, results in JAWS not announcing ANY countdown at all, this at least announces the current countdown number when the button receives focus in JAWS

* Add `aria-atomic="true"`

avoid JAWS/Firefox only announcing the specific digit that updates, rather than the number as a whole

* Update, run prettier, lint

* Remove orphaned jslibs

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2022-10-03 16:53:44 +02:00
Opeyemi
39399b5cf8
fix: typo in auto issues responses (#3670) 2022-10-03 15:49:15 +01:00
Michał Chęciński
67a93337f3
Add renovate config (#3341)
* Add renovate config

* Run linter
2022-09-30 17:00:33 +02:00
github-actions[bot]
24c6f5d313
Bumped desktop version to 2022.9.2 (#3541)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-09-30 08:00:00 -07:00
Michał Chęciński
de641d42e6
Fix build web workflow (#3664) 2022-09-30 16:17:18 +02:00
github-actions[bot]
9ad9645ebe
Autosync the updated translations (#3656)
Co-authored-by: github-actions <>
2022-09-30 03:07:52 +02:00
github-actions[bot]
ecde1f075a
Autosync the updated translations (#3655)
Co-authored-by: github-actions <>
2022-09-30 03:05:53 +02:00
github-actions[bot]
7700d31544
Autosync the updated translations (#3654)
Co-authored-by: github-actions <>
2022-09-30 02:55:51 +02:00
Addison Beck
65989e3c38
Rename anonymousHub route to anonymous-hub (#3650) 2022-09-29 14:10:35 -04:00
Oscar Hinton
1fbfb89cc3
Ensure avatar component is stable (#3640) 2022-09-29 18:57:35 +02:00
Oscar Hinton
a0e89af120
[SM-255] Forbid absolute imports in libs (#3624) 2022-09-29 16:38:50 +02:00
Oscar Hinton
5915ef7ed9
[SM-247] Fix csp rules not working for local dev (#3588) 2022-09-29 15:24:04 +02:00
Oscar Hinton
c7f85504c5
[SM-254] Rename web vault imports from src to web-vault (#3626) 2022-09-29 14:56:52 +02:00
Michał Chęciński
b91e2919b6
Add EE specific web container image (#3604)
* Add build command for ee

* Add config for ee

* Add build workflow for ee

* Change build pipeline for web ee

* Fix name of workflow in trigger

* Build ee image in web build workflow

* Fix name on matrix

* FIx name of the artifact

* Comment out zip extract

* Add zip extract

* All listing dir before unzip

* Add pwd

* Comment out unzipping

* Fix

* Add matrix instead of two stages

* Remove build web ee workflow

* Fix name
2022-09-29 12:21:47 +02:00
Thomas Rittson
24a7abbba7
Fix alignment for long filter names (#3635) 2022-09-29 08:55:51 +10:00
Justin Baur
188ee5df4f
Add Types for Opera API (#3631)
* Add global types

* Update to self

* Remove main.backgroun changes

* Remove one more change
2022-09-28 18:06:10 -04:00
Thomas Rittson
7ca4ec00ee
Minor workspace tweaks (#3636)
* Add storybook-static to .gitignore

* Set auto-imports to be project relative
2022-09-29 08:01:49 +10:00
Gbubemi Smith
9c40ac4e14
updated submit button to use the block directive and add loader (#3644) 2022-09-28 18:23:48 +01:00
Shane Melton
870ced2235
Make content padding optional on Dialog components to support tab group content (#3634) 2022-09-28 09:05:35 -07:00
Michał Chęciński
c243f3594e
Fix web qa deployment (#3632)
* Comment unzip downloaded artifact

* Replace gihub ref with master

* Add debug commands

* Change CP command

* Add another debug code

* Fix

* Another fix

* Remove debug steps

* Remove master const branch after testing
2022-09-27 16:19:55 -07:00
Justin Baur
c6dccc354c
[PS-1092] Organization Service Observables (#3462)
* Update imports

* Implement observables in a few places

* Add tests

* Get all clients working

* Use _destroy

* Address PR feedback

* Address PR feedback

* Address feedback
2022-09-27 16:25:19 -04:00
Gbubemi Smith
2c68518f87
corrected typos (#3633) 2022-09-27 19:10:19 +01:00
Todd Martin
cb746824e8
Added CSP rule for DDG email fowarder API (#3630)
Co-authored-by: Todd Martin <>
2022-09-27 13:44:13 -04:00
Colton Hurst
d168d5ee9b
Fix last seen & spacing issue (#3567)
* Fix last seen & spacing issue

* Address PR comments, moving try catch to config service
2022-09-27 11:09:48 -04:00
Oscar Hinton
701d795000
Fix storybook (#3625) 2022-09-27 14:42:15 +02:00
Andreas Coroiu
cd7c9bfd9f
[EC-556] refactor cl button (#3537)
* [EC-556] feat: convert button into component

* [EC-556] feat: implement loading state

* [EC-556] feat: remove loading from submit button

* [EC-556] fix: add missing import

* [EC-556] fix: disabling button using regular attribute

* [EC-556] fix: missing loading input in story templates

* [EC-556] feat: remove and replace submit button

* Fix packaging on Build Web workflow (#3613)

(cherry picked from commit 67c447d54c)

* [EC-556] fix: replaced buttons should be primary

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2022-09-27 11:25:53 +02:00
Andreas Coroiu
b5de573497
fix: icon button style incompats (#3611) 2022-09-27 11:22:31 +02:00
Thomas Rittson
5ffa3ccd20
Prevent banned imports into libs/common (#3599)
Also fix typescript-eslint/parser config and fix linting errors
2022-09-27 11:17:43 +10:00
Gbubemi Smith
22a878792e
[SG-168] Passwordless login web MVP (#3424)
* passwordless login page redesign

* passwordless login page redesign

* restyled login form to use tailwind

* restyled login form to use tailwind

* moved texts on login device template to locales

* made reactive form changes for clients

* added request model

* made more changes

* added implmentation to auth request api

* fixed refrencing issue

* renamed model property

* Added resend notification functionality

* Added new file

* login with device first draft

* login with device first draft

* login with device first draft

* login with device first draft

* connection to anonymous hub

* connection to anonymous hub

* refactored confirm login response

* removed comment

* cleaned up login

* changed uptyped form builder

* changed uptyped form builder

* [SG-168] Update login strategy with passwordless login credentials.

* [SG-168] Removed logs. Changed inputs for passwordless logic strategy. Removed tokenRequestPasswordless it is using the same as password.

* code cleanup

* code cleanup

* removed login with device from self hosted

* fixed PR comments

* added module for login

* fixed post request bug

* added feature flag

* added feature flag

* added feature flag

Co-authored-by: André Bispo <abispo@bitwarden.com>
2022-09-26 23:26:10 +01:00
Shane Melton
debaef2941
[EC 456] Component Library Content Switching Tabs (#3452)
* [EC-456] Rename bitTabItem -> bitTab

* [EC-456] Use templateRefs or text for tab label content

* [EC-456] Add bit-tab-nav-bar component

* [EC-456] Finish content tab switching and nav tabs

* [EC-456] Undo accidental eslintrc.json change

* [EC-456] Fix directive/component selector naming convention

* [EC-456] Cleanup unnecessary InjectionTokens and simplify template label property

* [EC-456] Cleanup one more unnecessary InjectionToken

* [EC-456] Cleanup tab styles to better match Figma. Add internal tab header component for styling header background according to Figma.

* [EC-456] Add sub-folders for nav, content, and shared tab components/directives

* [EC-456] Code/style cleanup

* [EC-456] Remove underscore from protected members

* [EC-456] Cleanup tab stories and forgotten any type.

* [EC-456] Fix dark theme story tab content text color

* [EC-456] Add missing padding to tab header

* [EC-456] Add tab content padding to align with tab headers

* [EC-456] Move bottom tab border to header to span entire content area

* [EC-456] Force text-main tab label color

* [EC-456] Undo text-main change
2022-09-26 22:41:51 +01:00
github-actions[bot]
e8936eb4c6
Autosync the updated translations (#3618)
Co-authored-by: github-actions <>
2022-09-26 21:25:49 +02:00
github-actions[bot]
34178f6efd
Autosync the updated translations (#3619)
Co-authored-by: github-actions <>
2022-09-26 21:22:21 +02:00
github-actions[bot]
a50d1004fa
Autosync the updated translations (#3617)
Co-authored-by: github-actions <>
2022-09-26 21:19:40 +02:00
Vince Grassia
81f3fd0aa9
Add Selfhost job to Build Web check for failures job (#3614) 2022-09-26 10:16:53 -04:00