1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-30 17:47:44 +01:00
Commit Graph

3777 Commits

Author SHA1 Message Date
Nick Krantz
e87cc5896b
delete ciphers as an admin when they're unassigned (#11930) 2024-11-11 12:46:51 -06:00
aj-bw
4963b28b82
PM-14810/ssh-not-all-caps-on-web-vault-item-type (#11957) 2024-11-11 11:35:59 -05:00
Alec Rippberger
f0901b0b98
Redirect to signup page if email verification flag is enabled (#11910) 2024-11-11 16:16:58 +00:00
cyprain-okeke
f593269133
[PM-8161] Payment optional trial MVP (#10872)
* Initial comment

* Add changes for the create org with payment method

* Add the secrets manager trail flow

* Add the banners

* Add changes for the Disabled Org

* Add banner to payment method page

* Refactoring changes

* Resolve the bug on tha payment method

* Resolve lint error

* Resolve Pr comments

* resolve the lint issue

* Resolve the lint wrong file issue

* Rename object properly

* Resolve pr comments from sm team

* Resolve the pr comments from sm team

* Fix the failing test

* Resolve some issue with vault

* Resolve the comments from sm team

* Resolve some pr comments from vault team

* Resolve pr comments from auth team

* Exported ValidOrgParams enum

* Removed unnecessary interpolation

* Corrected bit-banner id for trial

* Resolve pr comments from auth team

* Resolve pr comments from auth team

* Removed unnecessary method

* Made OrganizationCreateRequest a subtype of OrganizationNoPaymentMethodCreateRequest

* Resolve review changes from sm

* Resolve review changes from dm

* Resolve the pr comments from billing

* move the free-trial to core

* Move free-trial change to right file

* Revert changes on the free trial  page

* Resolve the comment on protected trial page

* Resolve the comment on protected trial page

* Revert the next async change

* resolve pr comment fro vault team

* resolve the default message comments

* remove unused method

* resolve email sending issue

* Fix the pop issue on payment method

* Fix some console errors

* Fix the pop refresh page

* move the trial services to billing folder

* resolve pr comments

* Resolve the import issues

* Move the observable up

* Resolve blank payment method for trialing org

* Changes to  disable icon is removed onsubmit

* Remove unused references

* add a missing a period at the end of it

* resolve the reload issue

* Resolve the disable icon issue

* Fix the admin access bug

* Resolve the lint issue

* Fix the message incorrect format

* Formatting fixed

* Resolve the access issue of other users role
2024-11-11 17:05:37 +01:00
renovate[bot]
19e786f820
[deps] Platform: Update Rust crate tokio-util to v0.7.12 (#11946)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 14:14:06 +01:00
Daniel García
597296cdb8
Fix electron-log test (#11955) 2024-11-11 12:51:13 +01:00
renovate[bot]
25f00513c0
[deps] Platform: Update Rust crate libc to v0.2.162 (#11731)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-11 12:39:34 +01:00
Rui Tomé
19046aa033
[PM-10326] Hide 'remove' option for organization managed members (#11874)
* Hide 'remove' option for organization managed members

* Refactor member component to conditionally show remove and delete buttons based on account deprovisioning feature flag

* Refactor member dialog component to conditionally show remove and delete buttons based on account deprovisioning feature flag

* Refactor member dialog and members components to simplify conditional rendering of remove and delete buttons based on account deprovisioning feature flag
2024-11-11 10:51:13 +00:00
Jonas Hendrickx
2bbe4d2cba
[PM-13470] Allow creating clients for multi-org providers (#11890) 2024-11-11 07:57:09 +01:00
Shane Melton
e91741b146
[PM-13892] Update item more options component to react to changes to the cipher input (#11914) 2024-11-08 11:43:33 -05:00
github-actions[bot]
0a9dbe17e3
Autosync the updated translations (#11917)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-08 11:25:03 +00:00
Rui Tomé
1f0c1f1b44
[PM-10318] Add organization user deletion and leaving events to EventService (#11554) 2024-11-08 11:23:24 +00:00
Bernd Schoolmann
081fe83d83
PM-10393 SSH keys (#10825)
* [PM-10395] Add new item type ssh key (#10360)

* Implement ssh-key cipher type

* Fix linting

* Fix edit and view components for ssh-keys on desktop

* Fix tests

* Remove ssh key type references

* Remove add ssh key option

* Fix typo

* Add tests

* [PM-10399] Add ssh key import export for bitwarden json (#10529)

* Add ssh key import export for bitwarden json

* Remove key type from ssh key export

* [PM-10406] Add privatekey publickey and fingerprint to both add-edit and view co… (#11046)

* Add privatekey publickey and fingerprint to both add-edit and view components

* Remove wrong a11y title

* Fix testid

* [PM-10098] SSH Agent & SSH Key creation for Bitwarden Desktop (#10293)

* Add ssh agent, generator & import

* Move ssh agent code to bitwarden-russh crate

* Remove generator component

* Cleanup

* Cleanup

* Remove left over sshGenerator reference

* Cleanup

* Add documentation to sshkeyimportstatus

* Fix outdated variable name

* Update apps/desktop/src/platform/preload.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Rename renderersshagent

* Rename MainSshAgentService

* Improve clarity of 'id' variables being used

* Improve clarity of 'id' variables being used

* Update apps/desktop/src/vault/app/vault/add-edit.component.html

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Fix outdated cipher/messageid names

* Rename SSH to Ssh

* Make agent syncing more reactive

* Move constants to top of class

* Make sshkey cipher filtering clearer

* Add stricter equality check on ssh key unlock

* Fix build and messages

* Fix incorrect featureflag name

* Replace anonymous async function with switchmap pipe

* Fix build

* Update apps/desktop/desktop_native/napi/src/lib.rs

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Revert incorrectly renamed 'Ssh' usages to SSH

* Run cargo fmt

* Clean up ssh agent sock path logic

* Cleanup and split to platform specific files

* Small cleanup

* Pull out generator and importer into core

* Rename renderersshagentservice to sshagentservice

* Rename cipheruuid to cipher_id

* Drop ssh dependencies from napi crate

* Clean up windows build

* Small cleanup

* Small cleanup

* Cleanup

* Add rxjs pipeline for agent services

* [PM-12555] Pkcs8 sshkey import & general ssh key import tests (#11048)

* Add pkcs8 import and tests

* Add key type unsupported error

* Remove unsupported formats

* Remove code for unsupported formats

* Fix encrypted pkcs8 import

* Add ed25519 pkcs8 unencrypted test file

* SSH agent rxjs tweaks (#11148)

* feat: rewrite sshagent.signrequest as purely observable

* feat: fail the request when unlock times out

* chore: clean up, add some clarifying comments

* chore: remove unused dependency

* fix: result `undefined` crashing in NAPI -> Rust

* Allow concurrent SSH requests in rust

* Remove unwraps

* Cleanup and add init service init call

* Fix windows

* Fix timeout behavior on locked vault

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Fix libc dependency being duplicated

* fix SSH casing (#11840)

* Move ssh agent behind feature flag (#11841)

* Move ssh agent behind feature flag

* Add separate flag for ssh agent

* [PM-14215] fix unsupported key type error message (#11788)

* Fix error message for import of unsupported ssh keys

* Use triple equals in add-edit component for ssh keys

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: aj-bw <81774843+aj-bw@users.noreply.github.com>
2024-11-08 11:01:31 +01:00
renovate[bot]
2c914def29
[deps] Platform: Update macOS/iOS bindings (#11793)
* [deps] Platform: Update macOS/iOS bindings

* fix: update security-framework to support core-foundation 0.10.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2024-11-08 10:02:31 +01:00
Jordan Aasen
d69642e7a0
[PM-14468] - add feature flag for critical apps (#11871)
* rename acess intelligence to risk insights

* keep branch name

* replace all instances of AccessIntelligence. strip raw data + members to just the table

* revert change to feature flag name

* add feature flag for critical apps

* change flag name

* Update libs/common/src/enums/feature-flag.enum.ts

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-11-07 16:39:15 -08:00
github-actions[bot]
b4428160ca
Autosync the updated translations (#11916)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-08 00:32:02 +00:00
github-actions[bot]
d40c1bad73
Autosync the updated translations (#11915)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-08 00:30:18 +00:00
Daniel James Smith
ec92f82501
Fix wrong import of SendFormModule (#11893)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-11-07 15:28:40 -05:00
Brandon Treston
ef0fd60676
[PM-11409] prevent managed user from leaving organization (#11895)
* add check to prevent managed  user from leaving managing org

* remove unused vaiable

* add null check
2024-11-07 14:09:56 -05:00
Nick Krantz
b42741f313
[PM-13839][PM-13840] Admin Console Collections (#11649)
* allow admin console to see all collections when viewing a cipher

- When "manage all" option is selected all collections should be editable

* update cipher form service to use admin endpoints

* when saving a cipher, choose to move to collections first before saving any other edits

- This handles the case where a cipher is moving from unassigned to assigned and needs to have a collection to save any other edits

* set admin flag when the original cipher has zero collections

- handling the case where the user  un-assigns themselves from a cipher

* add check for the users ability to edit items within the collection

* save cipher edit first to handle when the user unassigns themselves from the cipher

* update filter order of collections

* use cipher returned from the collections endpoint rather than re-fetching it

* fix unit tests by adding canEditItems

* re-enable collection control when orgId is present

* fetch the updated cipher from the respective service for editing a cipher
2024-11-07 10:22:35 -06:00
Jonathan Prusik
05a79d58bb
do not do browser extension permission check if the Show autofill suggestions setting is being turned off (#11889) 2024-11-07 10:38:49 -05:00
SmithThe4th
faf7e3d315
[PM-11201][CL-507] Add the ability to sort by Name, Group, and Permission within the collection and item tables (#11453)
* Added sorting to vault, name, permission and group

Added default sorting

* Fixed import

* reverted test on template

* Only add sorting functionality to admin console

* changed code order

* Fixed leftover test for sortingn

* Fixed reference

* sort permissions by ascending order

* Fixed bug where a collection had multiple groups and sorting alphbatically didn't happen correctly all the time

* Fixed bug whne creating a new cipher item

* Introduced fnFactory to create a sort function with direction provided

* Used new sort function to make collections always remain at the top and ciphers below

* extracted logic to always sort collections at the top

Added similar sorting to sortBygroup

* removed org vault check

* remove unused service

* Sort only collections

* Got rid of sortFn factory in favour of passing the direction as an optional parameter

* Removed tenary

* get cipher permissions

* Use all collections to filter collection ids

* Fixed ascending and descending issues

* Added functionality to default sort in descending order

* default sort permissions in descending order

* Refactored setActive to not pass direction as a paramater
2024-11-07 10:10:15 -05:00
Jordan Aasen
4cc562c228
[PM-12971] - close safari default extension on pop out (#11391)
* fix safari extension opening

* Update apps/browser/src/platform/browser/browser-api.ts

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>

* remove whitespace

* remove check for id

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2024-11-06 10:53:15 -08:00
Alec Rippberger
a959620a11
[PM-14369] Hide account switcher if on login page and not logged into any accounts (#11827)
* Add hasLoggedInAccount to check if there is a logged in account

* Update Storybook providers

* Revert "Update Storybook providers"

This reverts commit 646506ab95.

* Reapply "Update Storybook providers"

This reverts commit d86744a80b.

* Add story for HasLoggedInAccountExample

* Remove unused imports
2024-11-06 11:08:29 -06:00
Daniel García
a9595b4d14
[PM-13361] Fix DDG DMG builds (#11878) 2024-11-06 17:46:57 +01:00
Vincent Salucci
dce8c0a61a
fix: refactor enabled state of org name field, refs PM-14533 (#11879) 2024-11-06 10:12:24 -06:00
cyprain-okeke
f33661c31c
[PM-11505]Delete the feature flag PM-5864-dollar-threshold (#11436)
* remove the time threshold flag

* Remove the time threshold flag
2024-11-06 16:05:22 +01:00
Jordan Aasen
b877624ce3
[PM-14462] - Update "Access Intelligence" to "Risk Insights" (#11853)
* rename acess intelligence to risk insights

* keep branch name

* replace all instances of AccessIntelligence. strip raw data + members to just the table

* revert change to feature flag name
2024-11-06 09:47:29 -05:00
renovate[bot]
52c7d21e5f
[deps] Platform: Update Rust crate anyhow to v1.0.93 (#11059)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-06 02:59:35 -05:00
renovate[bot]
350a85674d
[deps] Platform: Update Rust crate napi to v2.16.13 (#11533)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 14:20:41 -05:00
Jared Snider
b5450227da
PM-14424 - LoginComponents should listen for unauthUiRefresh flag changes and forcibly change the UI on browser & desktop to make for a seamless experience without having to refresh. (#11830) 2024-11-05 14:02:51 -05:00
renovate[bot]
12cf870e34
[deps] Platform: Update Rust crate zbus to v4.4.0 (#10581)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 13:13:52 -05:00
renovate[bot]
8ccece38e3
[deps] Platform: Update Rust crate thiserror to v1.0.68 (#10562)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 12:48:47 -05:00
Nick Krantz
adcd5bd307
hide ownership view when viewing a cipher in the admin console (#11852) 2024-11-05 10:09:16 -06:00
renovate[bot]
b800193d80
[deps]: Lock file maintenance (#11542)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-05 15:58:33 +01:00
Bernd Schoolmann
48bd438824
Add context logs for native messaging (#11690)
* Add logging to decryption routines

* Fix case of uknown encryption type

* Add decryption context to log where failures occur

* Update log message

* Fix linting

* Add more context logs

* Add context logs for native messaging

* Update apps/desktop/native-messaging-test-runner/src/native-message.service.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Update apps/desktop/src/services/native-message-handler.service.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

* Rename channel key to desktop ipc channel key

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
2024-11-05 15:38:23 +01:00
Oscar Hinton
af6a2f5553
[PM-13375] Gulp: Remove beta builds (#11482)
Part of the browser build script refactor effort. bitwarden.atlassian.net/browse/PM-6683

The beta logic adds a fair bit of complexity and is currently unused. Let’s remove it and we can look into re-add it after migrating to our new build system.
2024-11-05 10:54:38 +01:00
Justin Baur
0d06c499f3
Remove Heartbeat Code (#11585) 2024-11-04 17:54:12 -05:00
Justin Baur
008e928d0a
[PM-10744] Remove Last Uses of getBgService (#10947)
* Remove Last Uses of `getBgService`

* Fix Merge Issue

* Fix Merge
2024-11-04 15:10:36 -05:00
Jordan Aasen
c36fbcf8b7
[PM-14268] - Access intelligence - add tabbing and events (#11831)
* comment code

* small fixes

* undo change to flags
2024-11-04 10:45:34 -08:00
Jordan Aasen
527f48f78f
check if member has subscription access before showing subscription modal (#11794) 2024-11-04 10:45:13 -08:00
Oscar Hinton
cd79457349
[PM-4347] Upgrade angular to 17 (#11031)
Upgrade angular to 17
2024-11-04 11:51:43 -05:00
renovate[bot]
c96b4f4cb2
[deps] Autofill: Update tldts to v6.1.58 (#11847)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-04 11:42:34 -05:00
Rui Tomé
d804a78bfb
[PM-11406] Account Management: Prevent a verified user from deleting their account (#11505)
* Update AccountService to include a method for setting the managedByOrganizationId

* Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization

* Add missing method to FakeAccountService

* Remove the setAccountManagedByOrganizationId method from the AccountService abstract class.

* Refactor AccountComponent to use OrganizationService to check for managing organization

* Rename managesActiveUser to userIsManagedByOrganization

* Hide the change email section if the user is managed by an organization

* Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models

* Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property

* Refactor account component to conditionally show delete account button based on user's organization management status

* Add showDeleteAccount$ observable to AccountComponent
2024-11-04 16:37:24 +00:00
Rui Tomé
d669d2003f
[PM-10323] Add delete option to managed members (#11655)
* Add managedByOrganization property to OrganizationUserUserDetailsResponse and OrganizationUserView

* Add managedByOrganization property to OrganizationUserDetailsResponse and OrganizationUserAdminView

* Add deleteOrganizationUser method to OrganizationUserApiService

* Add copy strings for organization user delete dialog

* Add copy string for organization user deleted toast

* Add delete organization user dialog component

* Add the option to delete managed organization users from the members list

* Refactor delete user confirmation dialog in MembersComponent to use DialogService

* Delete DeleteOrganizationUserDialogComponent

* Refactor delete button in member dialog component to change the icon and tooltip text to 'Remove'

* Add delete button to members dialog if the user is managed by the organization
2024-11-04 16:19:30 +00:00
bw-ghapp[bot]
2d0460eb15
Bumped client version(s) (#11850)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-04 15:43:54 +00:00
Brandon Treston
62545aa25a
Revert "[PM-13645] Fix invite counter to check remaining number of seats in p…" (#11843)
This reverts commit 2a956744bd.
2024-11-04 09:46:11 -05:00
Daniel Riera
f43bf48215
[PM-11777] fix: TOTP not copied when autofilling passkey (#11814)
* PM-11777 fix: TOTP not copied when autofilling passkey

- Added totpService to overlay background constructor
- Edited spec to account for totpsService
- Edited fillInlineMenuCipher to copy totp to clipboard if present

* add optional chaining
2024-11-04 08:40:00 -06:00
Daniel García
2e6ed4a4fc
[PM-14270] Use rust to access windows registry (#11413) 2024-11-04 14:50:05 +01:00
renovate[bot]
f6755da15b
[deps] Platform: Update Rust crate tokio to v1.41.0 (#10848)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-04 14:10:54 +01:00
renovate[bot]
80d36f4135
[deps] Platform: Update argon2 to v0.41.1 (#11065)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-04 14:09:51 +01:00
github-actions[bot]
6ca8e7df71
Autosync the updated translations (#11838)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-04 09:38:50 +00:00
github-actions[bot]
1a88e51008
Autosync the updated translations (#11836)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-04 09:34:53 +00:00
github-actions[bot]
c13cc56be3
Autosync the updated translations (#11837)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-11-04 09:34:37 +00:00
Brandon Treston
94cefa1f93
[pm-11407] fix UI story for danger zone component (#11828)
* Fix story for danger zone component

* fix linting

* Fix UI Story for Danger Zone component
2024-11-01 17:02:18 -04:00
Nick Krantz
f416c3ed49
[PM-13449] Owner assignment/visibility in AC (#11588)
* Revert "remove logic for personal ownership, not needed in AC"

This reverts commit f04fef59f4.

* allow for ownership to be controlled from the admin console when cloning a cipher
2024-11-01 14:15:36 -05:00
Daniel Riera
b0a73cfe45
fix:Add accountHolderName to the field names and values constants associated with the cardholder field. This update should help mitigate issues where the Amazon credit card pop-up is not auto-filling the cardholder name field. (#11780) 2024-11-01 14:05:53 -05:00
Jordan Aasen
2539a1d45a
[PM-14266] - access intelligence - application table (#11801)
* add application table

* add critical applications tab

* add button. update copy
2024-11-01 11:48:07 -07:00
Brandon Treston
bb79fdbdb3
[PM-11407] Fix story for danger zone component (#11817)
* Fix story for danger zone component

* fix linting
2024-11-01 10:43:55 -07:00
Cesar Gonzalez
a4c6731021
[PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements (#11803)
* [PM-14054] Fixing scroll-based repositioning of inline menu when inline menu is focused

* [PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements

* [PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements

* [PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements
2024-11-01 11:17:54 -05:00
Cesar Gonzalez
227e9c4c22
[PM-14349] Collection of page details on websites with ShadowDOM elements might not capture form elements (#11809) 2024-11-01 11:17:36 -05:00
Todd Martin
a049b553a6
Update decryptUserKeyWithMasterKey to requireUserId (#11560)
* Updated decryptUserKeyWithMasterKey to requireUserId

* Removed unintended extra character.

* Added dependency to LogService.

* Fixed unlock command.
2024-11-01 11:21:18 -04:00
Daniel García
5eae599b81
[BEEEP][PM-14388] Better dev experience on desktop-browser IPC (#11822) 2024-11-01 14:13:02 +01:00
Jared Snider
c07bf26898
PM-14361 - In PM-8111, the loginWithPasskey web translation was changed to be logInWithPasskey but the usages were not updated. This updates the usages to point to the new translation key. (#11815) 2024-10-31 17:10:09 -04:00
Jonathan Prusik
eba1212e1c
[PM-14351] Migrate away from theme enum (#11812)
* update extension autofill concerns to use theme object and type over enum

* mark ThemeType enum as deprecated

* update theming service concerns to use theme object and type over enum
2024-10-31 16:46:25 -04:00
Jordan Aasen
eb67b73a09
fix send-created tests (#11813) 2024-10-31 12:40:52 -07:00
github-actions[bot]
c809f97470
Autosync the updated translations (#11807)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-31 18:51:33 +00:00
Daniel García
f771bd7dc8
[PM-13361] Fix DDG backwards compat (#11804) 2024-10-31 18:03:24 +01:00
github-actions[bot]
2b6406c1a1
Autosync the updated translations (#11808)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-31 16:52:17 +00:00
github-actions[bot]
af401af778
Autosync the updated translations (#11806)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-31 16:49:13 +00:00
Jordan Aasen
eb510570da
fix header in billing sync dialog (#11777) 2024-10-31 09:34:59 -07:00
Jordan Aasen
6d8b1314a5
add error summary to organization plans (#11778) 2024-10-31 09:34:40 -07:00
Jordan Aasen
e00f22879c
[PM-13947] - guard against call to undefined onSubmit (#11795)
* guard against call to undefined function

* revert input optional
2024-10-31 09:34:26 -07:00
bw-ghapp[bot]
97cd0d492c
Bumped client version(s) (#11805)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-31 16:34:03 +00:00
Alex Morask
36b18c3e59
[PM-14275] Resolve reseller & CB MSP organization owner experience for subscription page (#11797)
* Fixed issue with Resellers and CB MSP Org Owners on subscription page

* Hide billing sync from Families
2024-10-31 11:05:05 -04:00
Oscar Hinton
5e157c5bca
[PM-14180] Provide more debugging details in wasm-debug (#11771)
Improve error logging to include some additional information about the error.
2024-10-31 10:07:55 +01:00
Jared Snider
4de7cb8012
BEEEP - Auth AccountService Improvements (#11779)
* BEEEP Adjacent - AccountService misc improvements - (1) prefer null over undefined and (2) add new Account type

* LockCompV2 - Fix activeAccount type per PR feedback

* AccountService - update getUserId per PR feedback.
2024-10-30 17:54:39 -04:00
Florian Lang
690e175b1d
fix: totp autofill fill single digits if one field per digit exist (#11630) 2024-10-30 15:09:33 -04:00
Jordan Aasen
18f7d64a6d
[PM-14038] - priority applications UI (#11723)
* priority applications UI

* add security icon
2024-10-30 14:25:06 -04:00
Vijay Oommen
ab3d760dfd
[PM-13454] Get hostname for login uri (#11646)
* add uri to raw data

* add  uri

* PM-13454 modify the hostnames to friendly names

* PM-13454 removed commented code

* add password health service

* add spec. fix logic in password reuse

* PM-13454 added member count and group by uris

* PM-13454 removed moved files

* PM-13454 fixed linting errors and failed unit tests

* PM-13454 grouping member count

* PM-13454 added unit test for totalGroupedMembersMap

* PM-13454 removed the grouping - show a flatmap

---------

Co-authored-by: jaasen-livefront <jaasen@livefront.com>
2024-10-30 14:11:45 -04:00
Brandon Treston
82d4fe4d66
[PM-11407] add upated copy to managed accounts (#11768)
* add upated copy to managed accounts

* Add link URL

* Update link

* change copy in danger zone component

* Refactor to look at content projection children
2024-10-30 13:42:22 -04:00
renovate[bot]
e1863e6c5c
[deps] Platform: Update Rust crate futures to v0.3.31 (#11531)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-30 10:41:24 +01:00
Cesar Gonzalez
896d19551a
[PM-14054] Fixing scroll-based repositioning of inline menu when inline menu is focused (#11770) 2024-10-29 16:55:40 -05:00
Bernd Schoolmann
d50e8bbf4c
Add linux .desktop file (#11774) 2024-10-29 19:46:09 +01:00
Victoria League
b391c291df
[CL-475] Use buttons instead of anchors for popup tab navigation (#11643) 2024-10-29 11:10:29 -04:00
Brandon Treston
e39ab59fa8
convert timeout values to strings (#11760) 2024-10-29 10:08:33 -04:00
bw-ghapp[bot]
c8862174d5
Bumped client version(s) (#11767)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-29 13:40:55 +00:00
Cesar Gonzalez
11f18c478e
[PM-14054] Fix scroll based re positioning when inline menu settings change occurs (#11765) 2024-10-28 17:05:10 -05:00
Cesar Gonzalez
3fe84b041a
[PM-14054] Fix scroll based re-positioning of the inline menu within iframes after setting is changed to on button click (#11763) 2024-10-28 16:43:06 -05:00
Alec Rippberger
9da80a6cba
[PM-8115] Desktop, Extension UI Refresh: Self-hosted Setup Dialog (#11597)
* Reimplement RegistrationSelfHostedEnvConfigDialogComponent

* Update EnvironmentSelectorComponent text based on feature flag.

* Initialize RegistrationSelfHostedEnvConfigDialog with existing values if self hosted

* Cleanup debug

* Add comment

* Remove changes to home and login components

* Remove changes to desktop login component

* Remove changes to browser home component

* Simplify accessing string.

* Add environment selector service.

* Cleanup unused imports in environment-selector

* Launch new env selector dialog from desktop

* Fix lint errors

* Address PR feedback: move dialog component, remove EnvironmentSelectorService, remove unused translation string

* Remove changes to AnonLayout

* PM-8115 - Export Re-usable component from Libs/auth for clean import elsewhere in clients.

* Remove unused accessingString variable

* Add success toast

---------

Co-authored-by: Jared Snider <jsnider@bitwarden.com>
2024-10-28 16:12:57 -05:00
Daniel James Smith
95e8e0c9bf
Remove duplicate entries from web messages.json (#11761)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-28 21:55:35 +01:00
✨ Audrey ✨
9a83509183
add boundary help text to credential settings (#11757) 2024-10-28 15:55:16 -04:00
renovate[bot]
2a47b9b06a
[deps] Platform: Update Rust crate tokio-util to v0.7.12 (#11534)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-28 13:55:24 -04:00
Rui Tomé
203a7b0c01
[PM-11405] Account Management: Prevent a verified user from changing their email address (#11486)
* Update AccountService to include a method for setting the managedByOrganizationId

* Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization

* Add missing method to FakeAccountService

* Remove the setAccountManagedByOrganizationId method from the AccountService abstract class.

* Refactor AccountComponent to use OrganizationService to check for managing organization

* Rename managesActiveUser to userIsManagedByOrganization

* Hide the change email section if the user is managed by an organization

* Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models

* Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property

* Refactor account component initialization logic

* Remove opening modal that was added by mistake
2024-10-28 16:12:16 +00:00
Jared McCannon
53f13f4ea5
[PM-10314] Update Warnings for Verifying Domains and Single Org Policy Auto Enable (#11688)
* Updated description and warning for single org policy.

* Added check for verified domains in disabling single org.
2024-10-28 11:00:39 -05:00
Brandon Treston
f86bc9bf28
[PM-13651] migrate verify recover delete provider component (#11586)
* Refactor VerifyRevocerDeleteProvider component to use component library

* Remove components form loose-components.module

* Refactor submit function definition into expression

* Move module out of oss, implement AnonLayoutComponentWrapper route

* Add type to button

* Remove try/catch with error logging

* remove logger service, remove formPromise field
2024-10-28 11:58:16 -04:00
Brandon Treston
2a956744bd
[PM-13645] Fix invite counter to check remaining number of seats in plan (#11577)
* Fix invite counter to check remaining number of seats in plan

* Remove redundant async pipe subscriptions
2024-10-28 11:24:14 -04:00
renovate[bot]
db6c6a84cc
[deps] Platform: Update @types/node to v20.17.1 (#11733)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-28 11:13:54 -04:00
renovate[bot]
dd653b5269
[deps] Autofill: Update tldts to v6.1.56 (#11728)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-28 11:13:21 -04:00
renovate[bot]
f4dfd042bb
[deps]: Update uuid to v11 (#11737)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-28 11:12:43 -04:00
watsondm
3f3f5cb7f0
SRE-1060 Add usdev to additional regions config (#11612) 2024-10-28 10:43:26 -04:00
github-actions[bot]
9d2848d0f1
Autosync the updated translations (#11746)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-28 09:38:50 +00:00
github-actions[bot]
a5d91410a9
Autosync the updated translations (#11745)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-28 09:34:44 +00:00
github-actions[bot]
d9d75c5329
Autosync the updated translations (#11744)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-28 09:25:27 +00:00
Bernd Schoolmann
e83dca529b
[PM-12607] Move key rotation to km ownership (#11709)
* Move key rotation to km ownership

* Fix build

* Move userkey rotation data provider abstraction to km ownership

* Move userkey rotation data provider abstraction to km ownership

* Fix linting

* Fix CODEOWNERS for key-management web

* Remove incorrect export

* Fix import error
2024-10-26 13:47:40 +02:00
Cesar Gonzalez
5f0755d74d
[PM-14045] Scrolling content outside of iframe bounds breaks inline menu position (#11716)
* [PM-14045] Scrolling content outside of iframe bounds breaks inline menu position

* [PM-14045] Scrolling content outside of iframe bounds breaks inline menu position

* [PM-14045] Fixing jest test

* [PM-14045] Adjusting how we determine if the inline menu should reposition on scroll
2024-10-25 16:17:36 -05:00
Jordan Aasen
ad7fa71e76
[PM-13931] - UI - All applications report table (#11678)
* add remaining components to access intelligence page

* Revert "add remaining components to access intelligence page"

This reverts commit cb8e826656.

* add remaining access intelligence table components
2024-10-25 13:04:36 -07:00
Jordan Aasen
4188894468
[PM-13979] - add remaining components to access intelligence page (#11677)
* add remaining components to access intelligence page

* small css adjustments
2024-10-25 13:04:22 -07:00
Alec Rippberger
2fb6a9e1ee
[PM-13150] Remove uses of row-main Bootstrap class in Account Security Settings (#11650)
* Remove uses of row-main Bootstrap class in Account Security Settings component

* Remove class from new component

* Remove extra div

* Remove extra markup
2024-10-25 13:58:02 -05:00
cd-bitwarden
8b64f0de9c
[PM-1992] in ac add current collection actions in menu and deprecate collections component (#11364)
* Removing feature flag

* Removing flag from feature-flag.enum.ts

* suggested changes

* prettier

* fixing merge conflict issue

* Removing unused code

* suggested change from Gbubemi

* Adding back merge conflict code

* fixing prettier styling

* Deprecating collections component, removing unused code now that we dont use collections component in AC

* Removing all Collections component logic from loos-components module and removing the files themselves as they are no longer needed.
2024-10-25 14:19:56 -04:00
Brandon Treston
85194fd1b5
[PM-12600] prevent verified user from deleting their account (#11665) 2024-10-25 12:46:02 -04:00
Daniel James Smith
ab98bef28f
Add warning dialog when clearing generator history (#11711)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-25 11:44:12 -04:00
Daniel James Smith
3b82a82416
[PM-13658] Update copy of password history to generator history (#11710)
* Update copy from password history to generator history

* Update copy on empty state

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-25 11:04:39 -04:00
Bernd Schoolmann
122c3c7809
Add context to logs for decryption failures (#11684)
* Add logging to decryption routines

* Fix case of uknown encryption type

* Add decryption context to log where failures occur

* Update log message

* Fix linting

* Add more context logs

* Add more fine grained logging

* Update log message

* Fix tests
2024-10-25 15:22:30 +02:00
github-actions[bot]
619618e6f3
Autosync the updated translations (#11702)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-25 11:32:16 +00:00
github-actions[bot]
599f9ea549
Autosync the updated translations (#11708)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-25 10:47:50 +00:00
github-actions[bot]
1a33cee562
Autosync the updated translations (#11703)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-25 10:46:52 +00:00
github-actions[bot]
ed2415f4bd
Autosync the updated translations (#11704)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-25 09:45:13 +00:00
Julien Mailleret
e1dce75f56
Allow cli snap to access home and removable-media (#5577)
This commit is adding back the home interface to the cli snap package. This is needed to allow saving Bitwarden attachments and exports to the disk.

Also, add removable-media permission to allow saving Bitwarden attachments and exports to USB disks and equivalents.

The home interface was previously present but has been removed as part of https://github.com/bitwarden/clients/pull/3596.

This commit should fix https://github.com/bitwarden/clients/issues/3923

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2024-10-25 10:39:09 +02:00
Thomas Rittson
55cd435279
[PM-13790] Remove RefactorOrganizationUserApi feature flag (#11662) 2024-10-25 10:16:59 +10:00
Jared Snider
877d379f86
Auth/PM-8111 - LoginComponent Refactor Bug - Fix Extension SSO (#11699)
* PM-8111 - LoginComponent Refactor - I broke the browser SSO flow - fixing it as clientId doesn't persist unless it is in state qParam.

* PM-8111 - Fix DefaultLoginComponentService tests
2024-10-24 19:02:10 -04:00
Jared Snider
1fb1be56b3
Auth/PM-12613 - Registration with Email Verification - Provider Invite Flow (#11635)
* PM-12613 - AcceptProviderComp - Add support for new registration with email verification flow.

* PM-12613 - AcceptProviderComp - Reduce required params for finish registration to minimum

* PM-12613 - RegistrationFinish - Add passthrough logic for provider invite token

* PM-12613 - Update DefaultRegistrationFinishService finishRegistration tests to assert that all web only inputs are undefined on the outgoing request model

* PM-12613 - DefaultRegistrationFinishService - finishRegistration - Add missed mapping of optional properties into buildRegisterRequest

* PM-12613 - WebRegistrationFinishService - Add tests for additional token flows.
2024-10-24 17:21:06 -04:00
Shane Melton
a0fe4f4ca6
[PM-13892] Browser Refresh - Organization item clone permission fix (#11660)
* [PM-13892] Introduce canClone$ method on CipherAuthorizationService

* [PM-13892] Use new canClone$ method for the 3dot menu in browser extension

* [PM-13892] Add todo for vault-items.component.ts
2024-10-24 14:12:04 -07:00
Shane Melton
81d7f319f6
[PM-13896] Avoid sorting when a search term is applied (#11661) 2024-10-24 14:11:48 -07:00
cd-bitwarden
bacb7cd7a0
removing the Share component (#11373) 2024-10-24 16:03:41 -04:00
rr-bw
df8f234b9e
[PM-8111] Browser Refresh: LoginComponent (#10856)
* setup new LoginComponent files in libs/auth

* update pageTitle

* handle loading email settings

* setup web-login.service.ts

* implement web onInit

* fill out webOnInit

* refactor getOrgPolicies call

* update import

* add validateEmail logic

* handle registerRoute

* add showPasswordless flag

* handle captcha

* handle startAuthRequestLogin()

* add handleMigrateEncryptionKey to default and web service

* handle submit routing (web)

* fix typo

* incorporate loginEmailService changes

* minor updates to comments for clarity

* create a defaultOnInit()

* update defaultOnInit()

* handle master password input focus

* handle post-login routing on Browser/Desktop

* handle browser/desktop syncService

* handle browser ngOnInit

* handle browser routing and basic browser template

* setup desktop router

* add template for desktop first UI state: email entry

* rename 'response' to 'authResult'

* refactor handleMigrateEncryptionKey()

* refactor captcha methods and add return types

* refactor submit logic

* refactor submit logic further to use if statements with returns instead of if...else if...else

* remove toast error on invalid form for Browser/Desktop

* refactor to handleAuthResult() method

* refactor webOnInit

* add comment to revisit ngOnInit logic

* refactor handlCaptchaRequired()

* create a LoginSecondaryContentComponent for AnonLayout use

* minor formatting for consistency

* add clarifying comment to handleAuthResult()

* minor refactor to use destructuring

* setup desktopOnInit()

* add continue() method

* handle desktop ngOnDestroy()

* add clarifying comment regarding secondary content

* fill out desktop template and submit()

* add descriptive comment to top of HTML file

* refactor to use a uiState enum for UI states

* handle oss-routing swap

* handle registerRoute$ in secondary content

* web template modifications

* change email validation to only run on submit (or when clicking continue button)

* add dynamic anon-layout wrapper data

* remove static element ref

* desktop HTML template updates

* remove 'showPassword' property b/c now handled by bitPasswordInputToggle

* Extension: setup EmailEntry state UI

* Extension: setup MasterPasswordEntry state UI

* ensure full sync happens on all clients before navigation

* update icon stroke color

* change old components to V1

* remove 'V2' from new component

* update captcha iframe on all clients

* add browser redirect from /home to /login with FF on

* add todo comment regarding browser template

* add launchSsoBrowser to extension template

* move extension launchSsoBrowserWindow() to extension service

* cleanup & comments

* add launchSsoBrowserWindow() to default service

* setup launchSsoBrowserWindow() for Desktop

* refactor to use toastService

* remove unnecessary service injection

* rename LoginService to LoginComponentService to avoid confusion with the LoginStrategyService

* add jsdocs to LoginComponentService

* rename loginService prop to loginComponentService

* Add vault icon to anon layout.

* Prevent email address validation on blur.

* Fix comment typo.

* Prefill email field when "create account" is clicked.

* Use factory function to provide LoginEmailService.

* Add test for RegisterFormComponent.

* Remove back button todo.

* Consolidate clearing loginEmailService values and routing

* Remove unnecessary navigation.

* Fix client navigation after login.

* Consolidate login templates.

* Break up LoginComponent into client-specific services.

* Rename login.component to login-v1.component

* Rename login.component to login-v1.component

* Revert "Rename login.component to login-v1.component"

This reverts commit 9a277d6ca5.

* Revert "Rename login.component to login-v1.component"

This reverts commit 588a7af906.

* Rename login.component to login-v1.component except browser.

* Comment out debug code.

* Remove debug code.

* Rename login.component to login-v1.component for browser.

* Add login-with-passkey route to desktop.

* Set feature flag to false.

* Fix linting errors.

* Populate email on registration start form.

* Implement email population on all clients add add safeProviders.

* Remove comment re. passing email to registration.

* Add unauthUiRefreshRedirect utility function.

* Add transparent border.

* Merge main and add satisfies RouteDataProperties

* PM-8111 - Extension - AppRoutingModule - Home route now redirects conditionally based on unauthenticated ui refresh feature flag.

* PM-8111 - New Login Comp + Login Comp Svc - (1) Refactor naming and returns of getShowPasswordlessFlag to isLoginViaAuthRequestSupported (2) Replace showPasswordless with better composed variable names.

* PM-8111 - TODO cleanup

* PM-8111 - (1) Cleanup DefaultLoginComponentService (2) Sso Connector now checks client id property instead of reading it from state

* PM-8111 - Two TODO cleanups

* Remove specific client services.

* Add isLoginWithPasskeySupported function to reduce client type checking in template.

* Add styles missing from Browser to Create Account link.

* Confirmed inline form errors working and removing todo comments.

* Convert refactoring todo-rr-bw to standard todos.

* Add login component services tests.

* Cleanup formatting and remove unused provider.

* Add comment to explain call to setLoginEmail.

* Rearrange imports to fix lint error.

* Adjust styles for password hint link.

* Address PR feedback: use strict comparison.

* Ensure Login with Passkey button is shown by setting clientType.

* Update "continue" button from "submit" to "button" type.

* Ensure Passkey login available for web and desktop.

* Validate email on enter keypress.

* Use click event to trigger goToHint.

* Restructure handAuthResult to ensure we redirect to vault.

* Add await to saveEmailSettings function.

* Directly set clientType in individual login component services.

* Get clientType via service.

* Add back button.

* Remove hardcoded colors from Vault Icon

* Removing register component changes.

* Removing register component changes.

* Ensure isLoginWithPasskeySupported is only returns true for web client.

* Remove Web/Desktop comment from html template

* Update Storybook with initialLoginEmail

* Fix translation error

* Add test for unauthUiRefreshRedirect.

* Rename goAfterLogIn to evaluatePassword and borrow logic from lock component.

* Add DefaultLoginComponent tests.

* Integrate changes to translations.

* Simplify ngOnInit: remove webOnInit and move getLoginWithDevice to defaultOnInit

I couldn't find any usages of qParams.org or qParams.sponsorshipToken on QA (signing up for family membership, creating organization, manually modifying query params), so I think these are safe to remove.

* Fix translations.

* Clean up and flush out register form tests.

* Update variable name.

* Remove unused enforcedPasswordPolicyOptions property.

* Run prettier.

* Add back safeProviders for LoginEmailService

* Remove duplicate import.

* Update v1 web login title.

* Adjust overlay position of EnvironmentSelectorComponent for new layout.

Since the switcher is located at the bottom of the screen we need to position it up above the trigger button so that it is not cut off.

* Add new wave icon

* Only send email in query parameters if set.

* Remove test/debug code.

* Replace loggedEmail with this.emailFormControl.value.

* Move getLoginWithDevice call to loadEmailSettings.

* Replace loggedEmail with this.emailFormControl.value.

* Add todo comment re. inline errors.

* Remove unused setPreviousUrl function.

* Remove height / width from vault icon svg.

* Use continue method unanimously

* WIP remove validated email&  display extension back button

* Simplify getting query params

* Rework ExtensionAnonLayoutWrapperDataService to use BehaviorSubject

* Simplify validateEmail method

* Hide back button on init

* Revert "Hide back button on init"

This reverts commit e8de5e2bfc.

* Revert "Simplify validateEmail method"

This reverts commit c9141a1cb5.

* Revert "Rework ExtensionAnonLayoutWrapperDataService to use BehaviorSubject"

This reverts commit 8889ed3d3c.

* simplify validateEmail method

* Add primary / accent colors to wave icon

* Remove debug code

* PM-8111 - Tweak ShowBackButton to work

* PM-8111 - LoginCompService - finish removal of setPreviousUrl from implementations.

* PM-8111 - (1) Remove overriden default logo in anon layout (2) Update routing modules to have proper default login logo (3) LoginComp - update toggleLoginUiState to include logic to swap the icon back and forth as user navigates.

* PM-8111 - LoginComp - on UI state change from MP entry to email entry, remove subtitle (this isn't supported yet, but it will be)

* PM-8111 - LoginComp - Simplify toggleLoginUiState

* PM-8111 - LoginComponent - Add known device logic into UI state change handler

* PM-8111 - LoginComp - (1) Refactor name of getLoginWithDevice to be more accurate as getKnownDevice (2) Refactor calls to getKnownDevice to only occur if loginViaAuthRequestSupported

* PM-8111 - LoginComp - add getKnownDevice docs

* PM-8111 - LoginComponent - tweak docs

* PM-8111 - LoginComp - Continue() - remove toast as the validation on submit logic currently shows validation errors - toast is extra and not needed.

* Add isLoginViaAuthRequestSupported for DesktopLoginComponentService

* Remove validating email on init

* PM-8111 - ExtensionLoginComponentService - add tests for showBackButton

* PM-8111 - style tweaks

* PM-8111 - Extension - Refactor Overlay position to include extension default const to avoid repetition.

* PM-8111 - Desktop AppRouting Module - remove login with passkey route as it isn't supported on desktop.

* PM-8111 - Desktop - add default overlay position const

* PM-8111 - DesktopLoginCompSvc - tests were not actually testing super method calls + finish testing launchSsoBrowserWindow

* PM-8111 - Desktop Main.ts - remove dev test code

* PM-8111 - WebLoginCompSvcTests - add success test cases for getOrgPolicies

* PM-8111 - Remove duplicate translation keys

* PM-8111 - DefaultLoginComponentSvcTests - add missing test

* PM-8111 - DefaultLoginComponentServiceTests - add describes

* PM-8111 - LoginSecondaryContentComponent  - Add missing bitLink

* Update to test both browser and desktop

* Remove registration form test

* Remove aliasing CryptoFunctionService and PlatformUtilsService as abstractions

* Remove aliasing PlatformUtilsService and CryptoFunctionService as abstractions

---------

Co-authored-by: Alec Rippberger <alec@livefront.com>
Co-authored-by: Jared Snider <jsnider@bitwarden.com>
Co-authored-by: Alec Rippberger <127791530+alec-livefront@users.noreply.github.com>
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
2024-10-24 15:53:34 -04:00
✨ Audrey ✨
0254550b07
increase minimum number of words on passphrases to 6 (#11675) 2024-10-24 15:16:10 -04:00
bw-ghapp[bot]
c44476788f
Bumped client version(s) (#11696)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-24 18:41:17 +00:00
Cesar Gonzalez
da1e508c25
[PM-8833] Implement on page autofill menu for password generation (#11114) 2024-10-24 13:20:00 -05:00
Bernd Schoolmann
9264e6775c
Add logging for userkey / device trust rotation (#11682)
* Add logging for userkey rotation

* Fix tests
2024-10-24 19:54:39 +02:00
Shane Melton
a9d9130f01
[PM-13907] [PM-13849] Browser Refresh - Improve launch login UX (#11680)
* [PM-13907] Move canLaunch logic to CipherView

* [PM-13907] Add external link icon to vault list items

* [PM-13907] Remove launch option from more options dropdown

* [PM-13849] Add double click to launch support
2024-10-24 10:51:38 -07:00
Bernd Schoolmann
b486fcc689
[Pm-13097] Rename cryptoservice to keyservice and move it to km ownership (#11358)
* Rename cryptoservice to keyservice

* Rename cryptoservice to keyservice

* Move key service to key management ownership

* Remove accidentally added file

* Fix cli build

* Fix browser build

* Run prettier

* Fix builds

* Fix cli build

* Fix tests

* Fix incorrect renames

* Rename webauthn-login-crypto-service

* Fix build errors due to merge conflicts

* Fix linting
2024-10-24 19:41:30 +02:00
Alex Morask
554171b688
Only show client org CB experience when provider status is Billable (#11693) 2024-10-24 12:18:03 -04:00
Jason Ng
2e9177d268
[PM-13854] update autofill label in browser (#11687) 2024-10-24 12:13:01 -04:00
Todd Martin
ed4071c7d4
Revert [PM-11312] Add "prevent screenshot" setting (#11685)
This reverts commit 1b7bb014d2.
2024-10-24 12:06:08 -04:00
Nick Krantz
44e182e32e
[PM-13187] Hide "Assign To Collections" when the user has no orgs (#11668)
* web - hide assign to collections button when the user has no organizations

* browser - hide assign to collections button when the user has no organizations

* hide assign to collections in the bulk edit menu when the user doesn't belong to an organization
2024-10-24 10:30:46 -05:00
Rui Tomé
548abfe906
[PM-12758] Add managed status to OrganizationUserDetailsResponse, OrganizationUserUserDetailsResponse, OrganizationUserView and OrganizationUserAdminView (#11640)
* Add managedByOrganization property to OrganizationUserUserDetailsResponse and OrganizationUserView

* Add managedByOrganization property to OrganizationUserDetailsResponse and OrganizationUserAdminView

* Move response mapping from UserAdminService to method in OrganizationUserAdminView
2024-10-24 15:39:41 +01:00
Jonathan Prusik
15c301d39f
Do not redirect after saving changes to excluded domains (#11676) 2024-10-24 10:15:24 -04:00
Cesar Gonzalez
9b471e6633
[PM-13715] Launching a website from the extension does not trigger an update to reference the correct autofill value (#11587)
* [PM-13715] Launching page from cipher does not set correct autofill action

* [PM-13715] Fix autofill not triggering for correct cipher after page has been launched from browser extension
2024-10-24 08:22:43 -05:00
SamFrank234
7c79487f04
[PM-7565] fix filter icon alignment (#8790)
update styles so that folders and subfolders are correctly aligned in vault filters on web and desktop
2024-10-23 14:21:56 -04:00
Jordan Aasen
7b8aac229c
[PM-13456] - Password health service (#11658)
* add password health service

* add spec. fix logic in password reuse

* move service to bitwarden_license

* revert change to tsconfig

* fix spec

* fix import
2024-10-23 13:30:25 -04:00
Bernd Schoolmann
74dabb97bf
Move process reload ownership to key-management (#10853) 2024-10-23 19:05:24 +02:00
✨ Audrey ✨
eff9a423da
[PM-8280] email forwarders (#11563)
* forwarder lookup and generation support
* localize algorithm names and descriptions in the credential generator service
* add encryption support to UserStateSubject
* move generic rx utilities to common
* move icon button labels to generator configurations
2024-10-23 18:11:42 +02:00
cd-bitwarden
e67577cc39
Updating chipSelect to be the new styling (#11593) 2024-10-23 11:40:11 -04:00
cd-bitwarden
79d7d506df
[PM-12996] Updating UI Spacing for bit section header (#11609)
* Adding space to the section header

* Updating spacing to the left of the bit section header
2024-10-23 11:39:57 -04:00
Nick Krantz
c4fcd53ad2
[PM-13776] Generator Icon Button labels (#11623)
* update aria labels for generate and copy buttons within the generator components

- Using the `appA11yTitle` across all icon buttons
- Updated all labels to be targeted towards the credential type rather than just "password"

* add copy/generate passphrase translations to desktop

* add fixme comments for translations

* remove reference to JIRA ticket
2024-10-23 10:23:51 -05:00
Jordan Aasen
dfa7509c8e
account for potential null config in SendFilePopoutDialogContainerComponent (#11372) 2024-10-23 17:20:34 +02:00
Oscar Hinton
173a5e2574
[PM-13277] Gulp: Remove unnecessary filtering (#11456)
Part of the browser build script refactor effort. bitwarden.atlassian.net/browse/PM-6683

We seem to have some very old filters related to fonts and safari build files. These predates our modern usage of webpack for bundling only used assets.

I've run diff -qr on Chrome, Firefox and Safari builds and the only difference is that we now include a bwi-font.svg resource. bwi-font.svg is referenced in our css files and "should" be included.
2024-10-22 18:53:30 +02:00
Jason Ng
023abe2969
[PM-11199] added permission labels to ciphers in AC (#11210)
* added permission labels to ciphers in AC
2024-10-22 10:07:22 -04:00
SmithThe4th
4a30782939
[PM-12281] [PM-12301] [PM-12306] [PM-12334] Move delete item permission to Can Manage (#11289)
* Added inputs to the view and edit component to disable or remove the delete button when a user does not have manage rights

* Refactored editByCipherId to receive cipherview object

* Fixed issue where adding an item on the individual vault throws a null reference

* Fixed issue where adding an item on the AC vault throws a null reference

* Allow delete in unassigned collection

* created reusable service to check if a user has delete permission on an item

* Registered service

* Used authorizationservice on the browser and desktop

Only display the delete button when a user has delete permission

* Added comments to the service

* Passed active collectionId to add edit component

renamed constructor parameter

* restored input property used by the web

* Fixed dependency issue

* Fixed dependency issue

* Fixed dependency issue

* Modified service to cater for org vault

* Updated to include new dependency

* Updated components to use the observable

* Added check on the cli to know if user has rights to delete an item

* Renamed abstraction and renamed implementation to include Default

Fixed permission issues

* Fixed test to reflect changes in implementation

* Modified base classes to use new naming

Passed new parameters for the canDeleteCipher

* Modified base classes to use new naming

Made changes from base class

* Desktop changes

Updated reference naming

* cli changes

Updated reference naming

Passed new parameters for the canDeleteCipher$

* Updated references

* browser changes

Updated reference naming

Passed new parameters for the canDeleteCipher$

* Modified cipher form dialog to take in active collection id

used canDeleteCipher$ on the vault item dialog to disable the delete button when user does not have the required permissions

* Fix number of arguments issue

* Added active collection id

* Updated canDeleteCipher$ arguments

* Updated to pass the cipher object

* Fixed up refrences and comments

* Updated dependency

* updated check to canEditUnassignedCiphers

* Fixed unit tests

* Removed activeCollectionId from cipher form

* Fixed issue where bulk delete option shows for can edit users

* Fix null reference when checking if a cipher belongs to the unassigned collection

* Fixed bug where allowedCollection passed is undefined

* Modified cipher by adding a isAdminConsoleAction argument to tell when a reuqest comes from the admin console

* Passed isAdminConsoleAction as true when request is from the admin console
2024-10-22 09:15:15 -04:00
Alex Morask
470ddf79ab
[PM-12425] Remove FF: AC-2828_provider-portal-members-page (#11241)
* Remove FF: AC-2828_provider-portal-members-page

* Thomas' feedback: Fix provider layout
2024-10-22 08:46:45 -04:00
Jared Snider
c16d1e0e74
AnonLayoutWrapperComponents - Add reset support for null values (#11651) 2024-10-21 18:52:07 -04:00
bw-ghapp[bot]
79cdf3bf50
Bumped client version(s) (#11648)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-21 20:53:30 +00:00
Jordan Aasen
c89d8a00a1
fix voiceover on send created screen (#11628) 2024-10-21 20:50:50 +02:00
Nick Krantz
116d2166c3
remove slideIn animation as it doesn't support the "show animations" setting (#11591) 2024-10-21 13:05:15 -05:00
Jordan Aasen
4b9fbfc832
[PM-13769] - fix routing for send created page (#11629)
* fix routing for send created page

* fix test

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-10-21 19:45:07 +02:00
Alex Morask
77c50860a9
[PM-12290] Show self-host options for CB MSP managed orgs (#11465)
* (No Logic) organization-subscription-cloud.component.ts cleanup

* Show only selfhost options for org owners and provider admins for managed orgs

* Fix messages.json issue
2024-10-21 13:30:25 -04:00
Jonas Hendrickx
ca3e9fc1bc
[PM-12527] [Defect] Remove unnecessary "General Information" Header in Organizat… (#11198) 2024-10-21 17:56:50 +02:00
Daniel James Smith
d298ac6edf
[PM-13189] Send copy updates (#11619)
* Add more descriptive header text

* Update hint under optional password field

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-21 10:10:57 -04:00
Jonathan Prusik
c9de05de95
[PM-13675] Adjust browser autofill override instructions conditions and placement in the settings view (#11559)
* adjust browser autofill override instructions conditions and placement in the settings view

* adjust placement of override instructions in the refresh component for Firefox
2024-10-21 09:50:59 -04:00
Jonathan Prusik
6335dd6cd7
update search state to show contextual no results view messages (#11570) 2024-10-21 09:47:01 -04:00
github-actions[bot]
cbb6cf42aa
Autosync the updated translations (#11637)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-21 13:32:27 +00:00
github-actions[bot]
6ebdb01429
Autosync the updated translations (#11638)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-21 13:31:28 +00:00
github-actions[bot]
09c4b35073
Autosync the updated translations (#11636)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-21 13:25:48 +00:00
Jordan Aasen
8254757375
[PM-13453] - Health report raw data with member count component (#11573)
* add raw data + members table

* remove commented code
2024-10-18 16:28:42 -07:00
Nick Krantz
80a4fba787
Allow for the web generation dialog to disable the margin of the tools generation components (#11565) 2024-10-18 15:57:34 -05:00
Nick Krantz
97bf459424
[PM-13251] Password History (#11618)
* add password history view component in vault lib

* integrate PasswordHistoryView into individual vault

* add password history v2 to browser extension

* update color of password history link

* add check for `cipherId` before rendering password history
2024-10-18 14:57:08 -05:00
Jordan Aasen
0e23f5e0cd
fix expiration date (#11625) 2024-10-18 20:06:23 +02:00
Mark Youssef
4768f7c0fa
[Marketing] Update testimonial in free registration page (#11603)
* Update testimonial in free registration page

* Fix wired logo alt text

Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>

---------

Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>
2024-10-18 10:25:33 -07:00
Andreas Coroiu
c787ecd22c
[PM-11764] Implement account switching and sdk initialization (#11472)
* feat: update sdk service abstraction with documentation and new `userClient$` function

* feat: add uninitialized user client with cache

* feat: initialize user crypto

* feat: initialize org keys

* fix: org crypto not initializing properly

* feat: avoid creating clients unnecessarily

* chore: remove dev print/subscription

* fix: clean up cache

* chore: update sdk version

* feat: implement clean-up logic (#11504)

* chore: bump sdk version to fix build issues

* chore: bump sdk version to fix build issues

* fix: missing constructor parameters

* refactor: simplify free() and delete() calls

* refactor: use a named function for client creation

* fix: client never freeing after refactor

* fix: broken impl and race condition in tests
2024-10-18 16:15:10 +02:00
Brandon Treston
cdd5bd4387
Remove appApiAction directive, remove Promise (#11557) 2024-10-18 09:40:58 -04:00
github-actions[bot]
fcf52638c9
Autosync the updated translations (#11617)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-18 07:37:55 +00:00
github-actions[bot]
df26b6b568
Autosync the updated translations (#11615)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-18 07:23:30 +00:00
github-actions[bot]
c438fbf36a
Autosync the updated translations (#11616)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-18 07:15:13 +00:00
bw-ghapp[bot]
5cd9063b7b
Bumped client version(s) (#11610)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-17 20:02:52 +00:00
cd-bitwarden
c7bee5c55d
PM-11205 updating empty state description to match figma (#11414) 2024-10-17 19:07:18 +00:00
Vince Grassia
1d10f34864
Remove 'network' from Snap plugs (#11606) 2024-10-17 13:46:58 -04:00
bw-ghapp[bot]
e53bd45fda
Bumped client version(s) (#11604)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-17 17:17:44 +00:00
Rui Tomé
97e195cd7b
[PM-11404] Account Management: Prevent a verified user from purging their vault (#11411)
* Update AccountService to include a method for setting the managedByOrganizationId

* Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization

* Add missing method to FakeAccountService

* Remove the setAccountManagedByOrganizationId method from the AccountService abstract class.

* Refactor AccountComponent to use OrganizationService to check for managing organization

* Rename managesActiveUser to userIsManagedByOrganization

* Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models

* Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property
2024-10-17 16:06:33 +01:00
Bernd Schoolmann
e8f0135d50
[PM-12806] Enforce 5000 iteration minimum for prelogin (#11332)
* Enforce 5000 iteration minimum for prelogin

* Fix tests

* Add more extensive tests

* Add loginstrategy prelogin downgrade test
2024-10-17 09:58:07 -04:00
Addison Beck
073ee4739b
Split Organization.LimitCollectionCreationDeletion into two separate business rules (#11223)
* Declare feature flag

* Introduce new model properties

* Reference feature toggle in template

* Fix bugs caught during manual testing
2024-10-17 06:34:34 -04:00
Jared Snider
4b67cd24b4
Auth/PM-8112 - UI refresh - Registration Components (#11353)
* PM-8112 - Update classes of existing registration icons

* PM-8112 - Add new icons

* PM-8112 - Export icons from libs/auth

* PM-8112 - RegistrationStart - Add new user icon as page icon

* PM-8112 - Replace RegistrationCheckEmailIcon with new icon so it displays properly

* PM-8112 - RegistrationFinish - Add new icon across clients

* PM-8112 - Registration start comp - update page icon and page title on state change to match figma

* PM-8112 - RegistrationFinish - adding most of framework for changing page title & subtitle when an org invite is in state.

* PM-8112 - Add joinOrganizationName to all clients translations

* PM-8112 - RegistrationFinish - Remove default page title & subtitle and let onInit logic figure out what to set based on flows.

* PM-8112 - RegistrationStart - Fix setAnonLayoutWrapperData calls

* PM-8112 - RegistrationFinish - simplify qParams init logic to make handling loading and page title and subtitle setting easier.

* PM-8112 - Registration Link expired - move icon to page icon out of main content

* PM-8112 - RegistrationFinish - Refactor init logic further into distinct flows.

* PM-8112 - Fix icons

* PM-8112 - Extension AppRoutingModule - move sign up start & finish routes under extension anon layout

* PM-8112 - Fix storybook

* PM-8112 - Clean up unused prop

* PM-8112 - RegistrationLockAltIcon tweaks

* PM-8112 - Update icons to have proper styling

* PM-8112 - RegistrationUserAddIcon - remove unnecessary svg class

* PM-8112 - Fix icons
2024-10-16 18:28:27 -04:00
renovate[bot]
e256bde1de
[deps] Vault: Update koa to v2.15.3 (#10567)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2024-10-16 22:35:45 +02:00
renovate[bot]
84d592a080
[deps] Vault: Update @koa/router to v13 (#10602)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2024-10-16 22:34:59 +02:00
Cesar Gonzalez
80d0f7e385
[PM-13768] Create account fields are no longer showing the inline menu when identities are turned off (#11592) 2024-10-16 15:26:16 -05:00
Todd Martin
0f525fa9bc
[PM-11778] Removed super syntax and replaced with this (#11511) 2024-10-16 16:05:11 -04:00
Brandon Treston
a72f3a201f
[PM-11613] Refactor personal-ownership.component to use reactive form (#11440)
* Refactor personal-ownership.component to use reactive form

* Refactor personal-ownership policy component to use base component form control
2024-10-16 15:17:23 -04:00
Shane Melton
80789465cb
Fix vault item collection storybook (#11582) 2024-10-16 10:34:27 -07:00
renovate[bot]
742a8a33dd [deps] Autofill: Update tldts to v6.1.52 (#11579)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-16 13:12:12 -04:00
Jordan Aasen
d70d2cb995
[PM-13452] - add password health raw data component (#11519)
* add raw data component

* fix tests

* simplify logic. fix tests

* revert change to default config service

* remove cipher report dep. fix tests.

* revert changes to mock data and specs

* remove mock data

* use orgId param

* fix test
2024-10-16 09:21:54 -07:00
Jared Snider
34e2d3dad2
PM-13318 - Fix missed page titles which didn't get converted to the new translation interface (#11572) 2024-10-15 22:34:44 -04:00
Thomas Rittson
178a418850
Conditionally disable client-side policy validation (#11550) 2024-10-16 08:46:03 +10:00
Nick Krantz
70d83feb38
add custom field copy to web (#11567) 2024-10-15 14:22:10 -05:00
Merissa Weinstein
1eaa80de26
Revert "Bumped client version(s) (#11564)" (#11566)
This reverts commit c459253beb.
2024-10-15 18:38:13 +00:00
bw-ghapp[bot]
c459253beb
Bumped client version(s) (#11564)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-15 18:27:30 +00:00
Cesar Gonzalez
32d12b3d6a
[PM-7980] Inline autofill menu is not shown inside dialog html tag (#11474)
* [PM-7980] Fix inline menu not showing inside dialog html tag

* [PM-7980] Fix inline menu not showing inside dialog html tag

* [PM-7980] Fixing an issue where a dialog element could potentially not represent itself in the #top-layer
2024-10-15 11:34:14 -05:00
Oscar Hinton
55ee33206f
Fix log service not binding this (#11551) 2024-10-15 12:21:08 -04:00
Jonathan Prusik
1c2cb4440b
[PM-12345] Add cipher type settings for inline autofill menu (#11260)
* add inline menu identity and card visibility settings state to autofill settings service

* add inline menu identity and card visibility settings to autofill settings view component

* add inline menu identity and card visibility settings to legacy autofill settings view component

* do not show inline menu card and identity visibility settings if inline-menu-positioning-improvements feature flag is off

* show card and identity inline menus based on their visibility settings

* do not show identities in account creation username/email fields if user setting disallows it

* reload local tab settings for inline menu visibility when an inline visibility setting value changes

* take out tabSendMessageData call for inline menu visibility sub-settings

---------

Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
2024-10-15 11:07:52 -04:00
Jordan Aasen
7afc99da1e
add missing import (#11549) 2024-10-15 11:20:11 +02:00
Shane Melton
a884fcf664
[PM-11203] Hide collection/item checkboxes in Admin Console (#10970)
* [PM-11203] Hide collection/item checkboxes in AC when a user does not have manage/edit permissions for the collection/item

* [PM-11203] Remove restrict-provider-access flag

* [PM-11203] Adjust the editableItems array to use existing canEdit and canDelete helpers to determine eligibility
2024-10-14 10:02:32 -07:00
renovate[bot]
0377775408
[deps] Platform: Update @types/node to v20.16.11 (#11530)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-14 10:48:19 -04:00
renovate[bot]
0bcd22460c
[deps] Autofill: Update tldts to v6.1.51 (#11529)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-14 10:46:48 -04:00
renovate[bot]
8d507c04a0
[deps] Platform: Update Rust crate log to 0.4.22 (#11532)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-14 12:08:42 +02:00
Jordan Aasen
fa41f29fc4
[CL-425] - add tools card component (#11375)
* add tools card component

* rename to tools-card

* whitelist readme

* fix tw classes in card component

* add RTL support.

* add documentation. revert changes to settings

* Revert vscode settings

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-11 23:00:45 +02:00
Jared Snider
7297d0fccd
Auth/PM-13318 - AnonLayoutWrapperData Refactor to add full Translation support (#11513)
* PM-13318 - AnonLayoutWrapperData refactor to support all possible string scenarios (untranslated string, translated string, and translated string with placeholders)

* PM-13318 - Fix accidental check in

* PM-13318 - Revert the correct change.

* PM-13318 - Fix test failures
2024-10-11 16:02:47 -04:00
Daniel James Smith
784dd3c9a0
Remove right angle icon from about bitwarden button (#11503)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-11 15:58:30 -04:00
Justin Baur
346329c23c
Run npm run electron (#11514) 2024-10-11 14:10:20 -04:00
renovate[bot]
1b25716358
[deps] Platform: Update Rust crate libc to v0.2.159 (#10844)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-11 17:52:21 +02:00
renovate[bot]
f69e943e72
[deps] Platform: Update napi (#10564)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-11 17:24:07 +02:00
github-actions[bot]
5d1538bb8a
Autosync the updated translations (#11497)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-11 08:25:54 +00:00
github-actions[bot]
b523ff7b36
Autosync the updated translations (#11495)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-11 08:14:41 +00:00
github-actions[bot]
7c86474fc0
Autosync the updated translations (#11496)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-11 08:02:52 +00:00
Shane Melton
9d163550fd
[PM-6991] Improve reactivity of cipherViews$ observable in cipher service (#11141)
* [PM-6991] Remove self reference to cipherViews$

* [PM-6991] Update cipherViews$ observable to be reactive to encrypted ciphers and localData

* [PM-6991] Use the cipherViews$ observable in the Web vault

* [PM-6991] Update the vault filter service to use cipherViews$ observable

* [PM-6991] Add deprecation notice to getAllDecrypted

* [PM-6991] Ensure cipherViews$ emits an empty array whenever the decrypted cipher cache is cleared

* [PM-6991] Fix cipher service test

* [PM-6991] Use shareReplay instead of share

* [PM-6991] Remove ciphersExpectingUpdate and replace with a null filter instead for cipherViews$

* [PM-6991] Skip refreshing on null cipherViews$ to avoid flashing an empty vault after modifying ciphers
2024-10-10 14:54:23 -07:00
Cesar Gonzalez
c221efd09a
[PM-13312] Task scheduler loses event callback reference when popout opens (#11492)
* [PM-13312] Task scheduler loses event callback reference when popout opens

* [PM-13312] Task scheduler loses event callback reference when popout opens
2024-10-10 15:53:33 -05:00
Daniel James Smith
14d71e7408
Add numeric score to the result row, as bitSortable does not support sorting by an object/object-ket (#11483)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-10 20:29:34 +02:00
Daniel James Smith
16f36a1008
[PM-13170] Enable use of new generators on web (#11405)
* Create web-specifc credential-generator component

* Add missing entries in en/messages.json

* Import and use conditional routing for new credential generator component

* Add comment about temporary using password-generator component

* Update comment to include FIXME which is more easily searchable

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-10 09:42:46 -04:00
Cesar Gonzalez
877dfeae7e
[PM-13184] Filter out specific-nodes within TreeWalker query (#11415) 2024-10-09 18:14:39 -05:00
Jared McCannon
1ca03e7815
[PM-12357] - Using new Verified SSO Domain call for SSO (#11446)
* Added new SSO verified domain call and added calling of it behind feature flag.
2024-10-09 14:30:39 -05:00
Addison Beck
35ff7d49b3
Migrate ResetPasswordComponent off of bootstrap (#11390)
* Migrate `ResetPasswordComponent` off of bootstrap

* Remove redundant `[appApiAction]` directive usage

* Replace `app-callout` with `bit-callout`

* Remove `formPromise` from compononent. It is unused.

* Implement new password strength component
2024-10-09 12:30:08 -04:00
Jordan Aasen
7fc987d806
[PM-13156] - Access intelligence page (#11420)
* WIP - access intelligence page

* finish access intelligence page

* finish access intelligence page

* use tab label directive

* remove extension swap change

* only show when feature flag enabled

* Move files under tools ownership

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-09 16:19:38 +01:00
Cesar Gonzalez
36c965c453
[PM-9876] Safari Passkeys Prompt is Not Triggered (#11471) 2024-10-09 08:45:28 -05:00
Jordan Aasen
4ce6df3040
[PM-11926] - fix send created page text (#11467)
* fix send created page

* remove unused i18n key

* remove superfluous spec

* fix failing tests
2024-10-09 13:28:39 +02:00
Nick Krantz
c6169432bb
account for adding a new cipher in the admin console (#11469)
- When adding a new cipher, the `editCipher` method is called but without a given cipher
2024-10-08 16:41:28 -05:00
Cesar Gonzalez
a5c1a5a42f
[PM-12548] Fido2 scripts should not load when user is logged out (#11444)
* [PM-12548] Fido2 scripts should not load when user is logged out

* [PM-12548] Fido2 scripts should not load when user is logged out
2024-10-08 16:02:49 -05:00
Cesar Gonzalez
fdfbe66513
[PM-13284] Implement method to ensure that we can handle logic when switching the notification improvements feature flag (#11468) 2024-10-08 15:47:20 -05:00
Cesar Gonzalez
ce871672d2
[PM-13284] Reworked notification bar does not display for certain websites (#11462)
* [PM-13284] Notification bar does not display for certain websites

* [PM-13284] Notification bar does not display for certain websites

* [PM-13284] Notification bar does not display for certain websites
2024-10-08 14:03:58 -05:00
Conner Turnbull
49b26db27e
Split invoice history table into two tables for paid and open (#11459) 2024-10-08 14:55:59 -04:00
Jonathan Prusik
0c2d2ada34
fix fido2 component copy translations (#11460) 2024-10-08 14:51:41 -04:00
Daniel James Smith
005937cb4a
Replace usage of tools-password-generator with tools-credential-generator (#11464)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-08 14:28:05 -04:00
renovate[bot]
6412cfaf80
[deps]: Lock file maintenance (#11442)
* [deps]: Lock file maintenance

* Add `@types/minimatch` back to overrides

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
2024-10-08 14:13:27 -04:00
✨ Audrey ✨
dc1f014ad8
[PM-8282] credential generator (#11398)
* credential generator browser ui
* switch browser generate screen to extension refresh flag
* consolidate generator components into module
* add `@bitwarden/generator-components` readme
* normalize generator component rx subscriptions
2024-10-08 14:08:34 -04:00
bw-ghapp[bot]
c22c478714
Bumped client version(s) (#11461)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-08 17:19:58 +00:00
Oscar Hinton
844d2298e9
[PM-13271] Remove unused ci:coverage from gulpfile (#11455)
Remove the gulp coverage report since we now use jest, and coverage is handled through the root coverage report which is done in a different script.
2024-10-08 16:33:27 +02:00
Thomas Rittson
7c72795d1c
[PM-12747] Move CollectionService and models to AC Team (#11278) 2024-10-08 10:14:39 -04:00
Shane Melton
a83646be33
[PM-13253] Ensure the bulk menu is enabled when showBulkEditCollectionAccess is true (#11448) 2024-10-08 09:50:22 -04:00
Cesar Gonzalez
b6ea6075b3
[PM-13188] Update auto-submit to act on uri hash instead of query param (#11416) 2024-10-08 05:40:11 -05:00
Shane Melton
bf042ef7fa
Revert "[PM-11201] Add the ability to sort by Name, Group, and Permission wit…" (#11445)
This reverts commit 37faccb7e9.
2024-10-07 11:45:15 -07:00
Oscar Hinton
7e4d735532
[PM-11290] Fix safari not starting with sdk (#11438)
We ran into some inconsistencies between how manifest v2 and v3 are handled in browsers. To resolve this we have a different flow for manifest v2 which dynamically imports, while v3 uses the sync importScripts.
2024-10-07 18:00:07 +02:00
Nick Krantz
a6db7e3086
[PM-10426] Admin Console - Edit Modal (#11249)
* add `hideFolderSelection` for admin console ciphers

* hide folder form field when configuration has `hideFolderSelection` set to true

* add `addCipherV2` method in the admin console vault

* add browser refresh logic for add/edit form

* add admin console implementation of `AdminConsoleCipherFormConfigService`

* only allow edit dialog in admin console

* remove duplicate check

* refactor comments

* initial integration of combined dialog

* integrate add cipher with admin console vault

* account for special admin console collection permissions

* add `edit` variable to AC ciphers when the user has permissions

* Move comment to JSDoc

* pass full cipher to view component

* validate edit access when opening view form

* partial-edit not applicable for admin console

* refactor hideIndividualFields to be more generic and hide favorite button

* pass entire cipher into edit logic to match view logic

* add null check for cipher when attempting to view

* remove logic for personal ownership, not needed in AC
2024-10-07 10:59:23 -05:00
bw-ghapp[bot]
c98b4553f2
Bumped client version(s) (#11439)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-10-07 15:06:39 +00:00
Shane Melton
68f4c2e879
[PM-12389] Vault Item Dialog Fixes (#11374)
* [PM-12389] Hide delete button when there is no cipher to delete

* [PM-12389] Ensure decrypted collections and folders are available before building cipher form config

* [PM-12389] Hide the delete button when cloning ciphers
2024-10-07 07:23:00 -07:00
Oscar Hinton
9ea9c3a932
[PM-11290] Enable SDK (#11378)
Follow up PR to #10974, flips the compile time flags to enabled and includes some debug logic to detect if users encounter issues with the WASM bundle in preparation for active consumption of the SDK.
2024-10-07 13:56:02 +02:00
Oscar Hinton
c88c5bf1ef
[PM-11766] Introduce SDK client (#10974)
Integrate the SDK into our other clients.
2024-10-07 13:20:50 +02:00
SmithThe4th
37faccb7e9
[PM-11201] Add the ability to sort by Name, Group, and Permission within the collection and item tables (#11370)
* Added sorting to vault, name, permission and group

Added default sorting

* Fixed import

* reverted test on template

* Only add sorting functionality to admin console

* changed code order
2024-10-07 11:10:48 +02:00
Daniel García
e1d46045e0
Fix IPC proxy selection in prod when using ELECTRON_IS_DEV (#11412) 2024-10-07 10:38:41 +02:00
Shane Melton
bdf91e24c6
[PM-13177] Fix Unassigned cipher collection assignment in AC (#11419)
* [PM-13177] Add saveCollectionsWithServerAdmin to CipherService

* [PM-13177] Introduce isSingleCipherAdmin flag to AssignCollections component
2024-10-04 12:11:03 -07:00
Jared Snider
87cb45c520
Auth/PM-13114 - WebEnvService Refactor + Unit Tests to support QA Env Selector (#11397)
* PM-13114 - WebEnvSvc - use hostname vs domain check for init and setEnv (tests TODO)

* PM-13114 - WebEnvSvc + URLs webpack config - use expected string variable on process.env.URLS to ensure tests can properly mock the WebEnvSvc

* PM-13114 - WebEnvSvc - setEnvironment - fix issue with returning currentRegion urls instead of currentEnv urls.

* PM-13114 - WebEnvSvc - setEnv - refactor names to improve clarity.

* PM-13114 - WebEnvSvc spec file - Test all prod scenarios

* PM-13144 - Work with Justin to move process.env.Urls access into injection token and remove webpack string type conversion.

* PM-13114 - WIP on getting additionalRegionConfigs injected via injection token to default env service.

* PM-13114 - Update all background inits to pass process.env.ADDITIONAL_REGIONS as unknown as RegionConfig[] to env service.

* PM-13114 - WebEnvSvc - adjust order of constructor deps

* PM-13114 - WebEnvSvc - add WebRegionConfig to extend RegionConfig type and be accurate for what the WebEnvSvc uses.

* PM-13114 - WebEnvSvc Tests - US QA tested

* PM-13114 - WebEnvSvc tests - refactor QA naming to make it more clear.

* PM-13114 - WebEnvSvc - test QA EU

* PM-13114 - WebEnvSvc - remove promise resolve per PR feedback.
2024-10-04 14:57:40 -04:00
Daniel James Smith
935ae9d238
[PM-13172] Create desktop-specifc full credential-generator component (#11407)
* Create desktop-specifc full credential-generator component

* Add missing entries in en/messages.json

* Import and use conditional routing for new credential generator component

app.component: The original if, didn't make any sense as it meant that it would behave differently on the Send page vs Vault, which it doesn't, in addition to a duplicate message receiver was added in vault.component which I also removed.

Old generator for cipher add/edit is still in place and will be replaced by the vault team

* Update comment to include FIXME which is more easily searchable

* Add fixme comment for future extension

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-10-04 12:53:14 -04:00
Nick Krantz
d7d7426431
pass the filtered cipher type when creating a new cipher (#11395) 2024-10-04 08:47:03 -05:00
Nick Krantz
02993f7018
[PM-10439] Vault generator components (#11350)
* add password/username generator strings to web app

* remove JSLibServicesModule from generator dependencies

* integrate username and password generators into browser extension

* integrate username and password generators into web app

* move Jslib order back

* remove margin from within the generator components

* add alternative background to web generator dialog

* remove unneeded margin from username generator

* remove disable margin from div

* Revert "remove unneeded margin from username generator"

This reverts commit ae3067e3f2.

* remove CSS to alter internal margins of the generator components
2024-10-04 08:39:29 -05:00