* Revert "remove logic for personal ownership, not needed in AC"
This reverts commit f04fef59f4.
* allow for ownership to be controlled from the admin console when cloning a cipher
* [PM-14054] Fixing scroll-based repositioning of inline menu when inline menu is focused
* [PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements
* [PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements
* [PM-14054] Fixing scroll-based repositioning of the inline menu on ShadowDOM elements
* update extension autofill concerns to use theme object and type over enum
* mark ThemeType enum as deprecated
* update theming service concerns to use theme object and type over enum
* add uri to raw data
* add uri
* PM-13454 modify the hostnames to friendly names
* PM-13454 removed commented code
* add password health service
* add spec. fix logic in password reuse
* PM-13454 added member count and group by uris
* PM-13454 removed moved files
* PM-13454 fixed linting errors and failed unit tests
* PM-13454 grouping member count
* PM-13454 added unit test for totalGroupedMembersMap
* PM-13454 removed the grouping - show a flatmap
---------
Co-authored-by: jaasen-livefront <jaasen@livefront.com>
* add upated copy to managed accounts
* Add link URL
* Update link
* change copy in danger zone component
* Refactor to look at content projection children
* Update AccountService to include a method for setting the managedByOrganizationId
* Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization
* Add missing method to FakeAccountService
* Remove the setAccountManagedByOrganizationId method from the AccountService abstract class.
* Refactor AccountComponent to use OrganizationService to check for managing organization
* Rename managesActiveUser to userIsManagedByOrganization
* Hide the change email section if the user is managed by an organization
* Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models
* Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property
* Refactor account component initialization logic
* Remove opening modal that was added by mistake
* Refactor VerifyRevocerDeleteProvider component to use component library
* Remove components form loose-components.module
* Refactor submit function definition into expression
* Move module out of oss, implement AnonLayoutComponentWrapper route
* Add type to button
* Remove try/catch with error logging
* remove logger service, remove formPromise field
* Move key rotation to km ownership
* Fix build
* Move userkey rotation data provider abstraction to km ownership
* Move userkey rotation data provider abstraction to km ownership
* Fix linting
* Fix CODEOWNERS for key-management web
* Remove incorrect export
* Fix import error
* [PM-14045] Scrolling content outside of iframe bounds breaks inline menu position
* [PM-14045] Scrolling content outside of iframe bounds breaks inline menu position
* [PM-14045] Fixing jest test
* [PM-14045] Adjusting how we determine if the inline menu should reposition on scroll
* Remove uses of row-main Bootstrap class in Account Security Settings component
* Remove class from new component
* Remove extra div
* Remove extra markup
* Removing feature flag
* Removing flag from feature-flag.enum.ts
* suggested changes
* prettier
* fixing merge conflict issue
* Removing unused code
* suggested change from Gbubemi
* Adding back merge conflict code
* fixing prettier styling
* Deprecating collections component, removing unused code now that we dont use collections component in AC
* Removing all Collections component logic from loos-components module and removing the files themselves as they are no longer needed.
* Update copy from password history to generator history
* Update copy on empty state
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is adding back the home interface to the cli snap package. This is needed to allow saving Bitwarden attachments and exports to the disk.
Also, add removable-media permission to allow saving Bitwarden attachments and exports to USB disks and equivalents.
The home interface was previously present but has been removed as part of https://github.com/bitwarden/clients/pull/3596.
This commit should fix https://github.com/bitwarden/clients/issues/3923
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
* PM-8111 - LoginComponent Refactor - I broke the browser SSO flow - fixing it as clientId doesn't persist unless it is in state qParam.
* PM-8111 - Fix DefaultLoginComponentService tests
* PM-12613 - AcceptProviderComp - Add support for new registration with email verification flow.
* PM-12613 - AcceptProviderComp - Reduce required params for finish registration to minimum
* PM-12613 - RegistrationFinish - Add passthrough logic for provider invite token
* PM-12613 - Update DefaultRegistrationFinishService finishRegistration tests to assert that all web only inputs are undefined on the outgoing request model
* PM-12613 - DefaultRegistrationFinishService - finishRegistration - Add missed mapping of optional properties into buildRegisterRequest
* PM-12613 - WebRegistrationFinishService - Add tests for additional token flows.
* [PM-13892] Introduce canClone$ method on CipherAuthorizationService
* [PM-13892] Use new canClone$ method for the 3dot menu in browser extension
* [PM-13892] Add todo for vault-items.component.ts
* setup new LoginComponent files in libs/auth
* update pageTitle
* handle loading email settings
* setup web-login.service.ts
* implement web onInit
* fill out webOnInit
* refactor getOrgPolicies call
* update import
* add validateEmail logic
* handle registerRoute
* add showPasswordless flag
* handle captcha
* handle startAuthRequestLogin()
* add handleMigrateEncryptionKey to default and web service
* handle submit routing (web)
* fix typo
* incorporate loginEmailService changes
* minor updates to comments for clarity
* create a defaultOnInit()
* update defaultOnInit()
* handle master password input focus
* handle post-login routing on Browser/Desktop
* handle browser/desktop syncService
* handle browser ngOnInit
* handle browser routing and basic browser template
* setup desktop router
* add template for desktop first UI state: email entry
* rename 'response' to 'authResult'
* refactor handleMigrateEncryptionKey()
* refactor captcha methods and add return types
* refactor submit logic
* refactor submit logic further to use if statements with returns instead of if...else if...else
* remove toast error on invalid form for Browser/Desktop
* refactor to handleAuthResult() method
* refactor webOnInit
* add comment to revisit ngOnInit logic
* refactor handlCaptchaRequired()
* create a LoginSecondaryContentComponent for AnonLayout use
* minor formatting for consistency
* add clarifying comment to handleAuthResult()
* minor refactor to use destructuring
* setup desktopOnInit()
* add continue() method
* handle desktop ngOnDestroy()
* add clarifying comment regarding secondary content
* fill out desktop template and submit()
* add descriptive comment to top of HTML file
* refactor to use a uiState enum for UI states
* handle oss-routing swap
* handle registerRoute$ in secondary content
* web template modifications
* change email validation to only run on submit (or when clicking continue button)
* add dynamic anon-layout wrapper data
* remove static element ref
* desktop HTML template updates
* remove 'showPassword' property b/c now handled by bitPasswordInputToggle
* Extension: setup EmailEntry state UI
* Extension: setup MasterPasswordEntry state UI
* ensure full sync happens on all clients before navigation
* update icon stroke color
* change old components to V1
* remove 'V2' from new component
* update captcha iframe on all clients
* add browser redirect from /home to /login with FF on
* add todo comment regarding browser template
* add launchSsoBrowser to extension template
* move extension launchSsoBrowserWindow() to extension service
* cleanup & comments
* add launchSsoBrowserWindow() to default service
* setup launchSsoBrowserWindow() for Desktop
* refactor to use toastService
* remove unnecessary service injection
* rename LoginService to LoginComponentService to avoid confusion with the LoginStrategyService
* add jsdocs to LoginComponentService
* rename loginService prop to loginComponentService
* Add vault icon to anon layout.
* Prevent email address validation on blur.
* Fix comment typo.
* Prefill email field when "create account" is clicked.
* Use factory function to provide LoginEmailService.
* Add test for RegisterFormComponent.
* Remove back button todo.
* Consolidate clearing loginEmailService values and routing
* Remove unnecessary navigation.
* Fix client navigation after login.
* Consolidate login templates.
* Break up LoginComponent into client-specific services.
* Rename login.component to login-v1.component
* Rename login.component to login-v1.component
* Revert "Rename login.component to login-v1.component"
This reverts commit 9a277d6ca5.
* Revert "Rename login.component to login-v1.component"
This reverts commit 588a7af906.
* Rename login.component to login-v1.component except browser.
* Comment out debug code.
* Remove debug code.
* Rename login.component to login-v1.component for browser.
* Add login-with-passkey route to desktop.
* Set feature flag to false.
* Fix linting errors.
* Populate email on registration start form.
* Implement email population on all clients add add safeProviders.
* Remove comment re. passing email to registration.
* Add unauthUiRefreshRedirect utility function.
* Add transparent border.
* Merge main and add satisfies RouteDataProperties
* PM-8111 - Extension - AppRoutingModule - Home route now redirects conditionally based on unauthenticated ui refresh feature flag.
* PM-8111 - New Login Comp + Login Comp Svc - (1) Refactor naming and returns of getShowPasswordlessFlag to isLoginViaAuthRequestSupported (2) Replace showPasswordless with better composed variable names.
* PM-8111 - TODO cleanup
* PM-8111 - (1) Cleanup DefaultLoginComponentService (2) Sso Connector now checks client id property instead of reading it from state
* PM-8111 - Two TODO cleanups
* Remove specific client services.
* Add isLoginWithPasskeySupported function to reduce client type checking in template.
* Add styles missing from Browser to Create Account link.
* Confirmed inline form errors working and removing todo comments.
* Convert refactoring todo-rr-bw to standard todos.
* Add login component services tests.
* Cleanup formatting and remove unused provider.
* Add comment to explain call to setLoginEmail.
* Rearrange imports to fix lint error.
* Adjust styles for password hint link.
* Address PR feedback: use strict comparison.
* Ensure Login with Passkey button is shown by setting clientType.
* Update "continue" button from "submit" to "button" type.
* Ensure Passkey login available for web and desktop.
* Validate email on enter keypress.
* Use click event to trigger goToHint.
* Restructure handAuthResult to ensure we redirect to vault.
* Add await to saveEmailSettings function.
* Directly set clientType in individual login component services.
* Get clientType via service.
* Add back button.
* Remove hardcoded colors from Vault Icon
* Removing register component changes.
* Removing register component changes.
* Ensure isLoginWithPasskeySupported is only returns true for web client.
* Remove Web/Desktop comment from html template
* Update Storybook with initialLoginEmail
* Fix translation error
* Add test for unauthUiRefreshRedirect.
* Rename goAfterLogIn to evaluatePassword and borrow logic from lock component.
* Add DefaultLoginComponent tests.
* Integrate changes to translations.
* Simplify ngOnInit: remove webOnInit and move getLoginWithDevice to defaultOnInit
I couldn't find any usages of qParams.org or qParams.sponsorshipToken on QA (signing up for family membership, creating organization, manually modifying query params), so I think these are safe to remove.
* Fix translations.
* Clean up and flush out register form tests.
* Update variable name.
* Remove unused enforcedPasswordPolicyOptions property.
* Run prettier.
* Add back safeProviders for LoginEmailService
* Remove duplicate import.
* Update v1 web login title.
* Adjust overlay position of EnvironmentSelectorComponent for new layout.
Since the switcher is located at the bottom of the screen we need to position it up above the trigger button so that it is not cut off.
* Add new wave icon
* Only send email in query parameters if set.
* Remove test/debug code.
* Replace loggedEmail with this.emailFormControl.value.
* Move getLoginWithDevice call to loadEmailSettings.
* Replace loggedEmail with this.emailFormControl.value.
* Add todo comment re. inline errors.
* Remove unused setPreviousUrl function.
* Remove height / width from vault icon svg.
* Use continue method unanimously
* WIP remove validated email& display extension back button
* Simplify getting query params
* Rework ExtensionAnonLayoutWrapperDataService to use BehaviorSubject
* Simplify validateEmail method
* Hide back button on init
* Revert "Hide back button on init"
This reverts commit e8de5e2bfc.
* Revert "Simplify validateEmail method"
This reverts commit c9141a1cb5.
* Revert "Rework ExtensionAnonLayoutWrapperDataService to use BehaviorSubject"
This reverts commit 8889ed3d3c.
* simplify validateEmail method
* Add primary / accent colors to wave icon
* Remove debug code
* PM-8111 - Tweak ShowBackButton to work
* PM-8111 - LoginCompService - finish removal of setPreviousUrl from implementations.
* PM-8111 - (1) Remove overriden default logo in anon layout (2) Update routing modules to have proper default login logo (3) LoginComp - update toggleLoginUiState to include logic to swap the icon back and forth as user navigates.
* PM-8111 - LoginComp - on UI state change from MP entry to email entry, remove subtitle (this isn't supported yet, but it will be)
* PM-8111 - LoginComp - Simplify toggleLoginUiState
* PM-8111 - LoginComponent - Add known device logic into UI state change handler
* PM-8111 - LoginComp - (1) Refactor name of getLoginWithDevice to be more accurate as getKnownDevice (2) Refactor calls to getKnownDevice to only occur if loginViaAuthRequestSupported
* PM-8111 - LoginComp - add getKnownDevice docs
* PM-8111 - LoginComponent - tweak docs
* PM-8111 - LoginComp - Continue() - remove toast as the validation on submit logic currently shows validation errors - toast is extra and not needed.
* Add isLoginViaAuthRequestSupported for DesktopLoginComponentService
* Remove validating email on init
* PM-8111 - ExtensionLoginComponentService - add tests for showBackButton
* PM-8111 - style tweaks
* PM-8111 - Extension - Refactor Overlay position to include extension default const to avoid repetition.
* PM-8111 - Desktop AppRouting Module - remove login with passkey route as it isn't supported on desktop.
* PM-8111 - Desktop - add default overlay position const
* PM-8111 - DesktopLoginCompSvc - tests were not actually testing super method calls + finish testing launchSsoBrowserWindow
* PM-8111 - Desktop Main.ts - remove dev test code
* PM-8111 - WebLoginCompSvcTests - add success test cases for getOrgPolicies
* PM-8111 - Remove duplicate translation keys
* PM-8111 - DefaultLoginComponentSvcTests - add missing test
* PM-8111 - DefaultLoginComponentServiceTests - add describes
* PM-8111 - LoginSecondaryContentComponent - Add missing bitLink
* Update to test both browser and desktop
* Remove registration form test
* Remove aliasing CryptoFunctionService and PlatformUtilsService as abstractions
* Remove aliasing PlatformUtilsService and CryptoFunctionService as abstractions
---------
Co-authored-by: Alec Rippberger <alec@livefront.com>
Co-authored-by: Jared Snider <jsnider@bitwarden.com>
Co-authored-by: Alec Rippberger <127791530+alec-livefront@users.noreply.github.com>
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
* [PM-13907] Move canLaunch logic to CipherView
* [PM-13907] Add external link icon to vault list items
* [PM-13907] Remove launch option from more options dropdown
* [PM-13849] Add double click to launch support
* web - hide assign to collections button when the user has no organizations
* browser - hide assign to collections button when the user has no organizations
* hide assign to collections in the bulk edit menu when the user doesn't belong to an organization
* Add managedByOrganization property to OrganizationUserUserDetailsResponse and OrganizationUserView
* Add managedByOrganization property to OrganizationUserDetailsResponse and OrganizationUserAdminView
* Move response mapping from UserAdminService to method in OrganizationUserAdminView
* [PM-13715] Launching page from cipher does not set correct autofill action
* [PM-13715] Fix autofill not triggering for correct cipher after page has been launched from browser extension
* add password health service
* add spec. fix logic in password reuse
* move service to bitwarden_license
* revert change to tsconfig
* fix spec
* fix import
* forwarder lookup and generation support
* localize algorithm names and descriptions in the credential generator service
* add encryption support to UserStateSubject
* move generic rx utilities to common
* move icon button labels to generator configurations
* update aria labels for generate and copy buttons within the generator components
- Using the `appA11yTitle` across all icon buttons
- Updated all labels to be targeted towards the credential type rather than just "password"
* add copy/generate passphrase translations to desktop
* add fixme comments for translations
* remove reference to JIRA ticket
Part of the browser build script refactor effort. bitwarden.atlassian.net/browse/PM-6683
We seem to have some very old filters related to fonts and safari build files. These predates our modern usage of webpack for bundling only used assets.
I've run diff -qr on Chrome, Firefox and Safari builds and the only difference is that we now include a bwi-font.svg resource. bwi-font.svg is referenced in our css files and "should" be included.
* Added inputs to the view and edit component to disable or remove the delete button when a user does not have manage rights
* Refactored editByCipherId to receive cipherview object
* Fixed issue where adding an item on the individual vault throws a null reference
* Fixed issue where adding an item on the AC vault throws a null reference
* Allow delete in unassigned collection
* created reusable service to check if a user has delete permission on an item
* Registered service
* Used authorizationservice on the browser and desktop
Only display the delete button when a user has delete permission
* Added comments to the service
* Passed active collectionId to add edit component
renamed constructor parameter
* restored input property used by the web
* Fixed dependency issue
* Fixed dependency issue
* Fixed dependency issue
* Modified service to cater for org vault
* Updated to include new dependency
* Updated components to use the observable
* Added check on the cli to know if user has rights to delete an item
* Renamed abstraction and renamed implementation to include Default
Fixed permission issues
* Fixed test to reflect changes in implementation
* Modified base classes to use new naming
Passed new parameters for the canDeleteCipher
* Modified base classes to use new naming
Made changes from base class
* Desktop changes
Updated reference naming
* cli changes
Updated reference naming
Passed new parameters for the canDeleteCipher$
* Updated references
* browser changes
Updated reference naming
Passed new parameters for the canDeleteCipher$
* Modified cipher form dialog to take in active collection id
used canDeleteCipher$ on the vault item dialog to disable the delete button when user does not have the required permissions
* Fix number of arguments issue
* Added active collection id
* Updated canDeleteCipher$ arguments
* Updated to pass the cipher object
* Fixed up refrences and comments
* Updated dependency
* updated check to canEditUnassignedCiphers
* Fixed unit tests
* Removed activeCollectionId from cipher form
* Fixed issue where bulk delete option shows for can edit users
* Fix null reference when checking if a cipher belongs to the unassigned collection
* Fixed bug where allowedCollection passed is undefined
* Modified cipher by adding a isAdminConsoleAction argument to tell when a reuqest comes from the admin console
* Passed isAdminConsoleAction as true when request is from the admin console
* (No Logic) organization-subscription-cloud.component.ts cleanup
* Show only selfhost options for org owners and provider admins for managed orgs
* Fix messages.json issue
* Add more descriptive header text
* Update hint under optional password field
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* adjust browser autofill override instructions conditions and placement in the settings view
* adjust placement of override instructions in the refresh component for Firefox
* add password history view component in vault lib
* integrate PasswordHistoryView into individual vault
* add password history v2 to browser extension
* update color of password history link
* add check for `cipherId` before rendering password history
* Update testimonial in free registration page
* Fix wired logo alt text
Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>
---------
Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>
* feat: update sdk service abstraction with documentation and new `userClient$` function
* feat: add uninitialized user client with cache
* feat: initialize user crypto
* feat: initialize org keys
* fix: org crypto not initializing properly
* feat: avoid creating clients unnecessarily
* chore: remove dev print/subscription
* fix: clean up cache
* chore: update sdk version
* feat: implement clean-up logic (#11504)
* chore: bump sdk version to fix build issues
* chore: bump sdk version to fix build issues
* fix: missing constructor parameters
* refactor: simplify free() and delete() calls
* refactor: use a named function for client creation
* fix: client never freeing after refactor
* fix: broken impl and race condition in tests
* Update AccountService to include a method for setting the managedByOrganizationId
* Update AccountComponent to conditionally show the purgeVault button based on a feature flag and if the user is managed by an organization
* Add missing method to FakeAccountService
* Remove the setAccountManagedByOrganizationId method from the AccountService abstract class.
* Refactor AccountComponent to use OrganizationService to check for managing organization
* Rename managesActiveUser to userIsManagedByOrganization
* Refactor userIsManagedByOrganization property to be non-nullable in organization data and response models
* Refactor organization.data.spec.ts to include non-nullable userIsManagedByOrganization property
* PM-8112 - Update classes of existing registration icons
* PM-8112 - Add new icons
* PM-8112 - Export icons from libs/auth
* PM-8112 - RegistrationStart - Add new user icon as page icon
* PM-8112 - Replace RegistrationCheckEmailIcon with new icon so it displays properly
* PM-8112 - RegistrationFinish - Add new icon across clients
* PM-8112 - Registration start comp - update page icon and page title on state change to match figma
* PM-8112 - RegistrationFinish - adding most of framework for changing page title & subtitle when an org invite is in state.
* PM-8112 - Add joinOrganizationName to all clients translations
* PM-8112 - RegistrationFinish - Remove default page title & subtitle and let onInit logic figure out what to set based on flows.
* PM-8112 - RegistrationStart - Fix setAnonLayoutWrapperData calls
* PM-8112 - RegistrationFinish - simplify qParams init logic to make handling loading and page title and subtitle setting easier.
* PM-8112 - Registration Link expired - move icon to page icon out of main content
* PM-8112 - RegistrationFinish - Refactor init logic further into distinct flows.
* PM-8112 - Fix icons
* PM-8112 - Extension AppRoutingModule - move sign up start & finish routes under extension anon layout
* PM-8112 - Fix storybook
* PM-8112 - Clean up unused prop
* PM-8112 - RegistrationLockAltIcon tweaks
* PM-8112 - Update icons to have proper styling
* PM-8112 - RegistrationUserAddIcon - remove unnecessary svg class
* PM-8112 - Fix icons
* add raw data component
* fix tests
* simplify logic. fix tests
* revert change to default config service
* remove cipher report dep. fix tests.
* revert changes to mock data and specs
* remove mock data
* use orgId param
* fix test
* [PM-7980] Fix inline menu not showing inside dialog html tag
* [PM-7980] Fix inline menu not showing inside dialog html tag
* [PM-7980] Fixing an issue where a dialog element could potentially not represent itself in the #top-layer
* add inline menu identity and card visibility settings state to autofill settings service
* add inline menu identity and card visibility settings to autofill settings view component
* add inline menu identity and card visibility settings to legacy autofill settings view component
* do not show inline menu card and identity visibility settings if inline-menu-positioning-improvements feature flag is off
* show card and identity inline menus based on their visibility settings
* do not show identities in account creation username/email fields if user setting disallows it
* reload local tab settings for inline menu visibility when an inline visibility setting value changes
* take out tabSendMessageData call for inline menu visibility sub-settings
---------
Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
* [PM-11203] Hide collection/item checkboxes in AC when a user does not have manage/edit permissions for the collection/item
* [PM-11203] Remove restrict-provider-access flag
* [PM-11203] Adjust the editableItems array to use existing canEdit and canDelete helpers to determine eligibility
