1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-09-23 03:22:50 +02:00
Commit Graph

3004 Commits

Author SHA1 Message Date
Jared Snider
924d0b7dfe
Move extension refresh swap function to libs so other clients can use it (#10640)
* Move extension refresh swap function to libs so other clients can use it

* Update extensionRefreshSwap docs
2024-08-20 17:24:49 -04:00
SmithThe4th
dedd7f1b5c
[PM-10607] Require userId for getKeyForCipherKeyDecryption (#10509)
* updated cipher service to stop using the deprecated getUserKeyWithLegacySupport and use the version that requires a user id

* Added account service mock

* fixed cipher test

* Fixed test

* removed async from encryptCipher

* updated encryptSharedCipher to pass userId to the encrypt function

* Pass userId to getUserKeyWithLegacySupport on encryptSharedCipher

* pass in userid when setting masterKeyEncryptedUserKey

* Added activer usedId to new web refresh function
2024-08-20 11:00:48 -05:00
Victoria League
ed719f835a
[CL-389] Add end slot to non-text bit label content (#10457) 2024-08-20 11:55:11 -04:00
Daniel James Smith
e5227c045d
Remove duplicate message-keys (#10633)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-08-20 16:30:45 +02:00
Nick Krantz
8f07c78cc5
[PM-9455] Back Navigation in extension (#10496)
* refactor open-attachments component to push attachments route before opening the popout

* use popupRouterCache for navigating the user back

* use the PopupRouterCache for navigating the user after an attachment
2024-08-20 09:30:11 -05:00
Will Martin
59aa7ebc57
[PM-10940] misc popout history cache bug fixes (#10619) 2024-08-20 09:41:55 -04:00
Alec Rippberger
3a31eb2f10
PM-9665: implement view item view (#10416)
* Add initial view cipher dialog.

* Add working view cipher modal dialog markup.

* Cleanup dialog markup and allow edit from dialog.

* Cleanup unused imports.

* Begin adding org-vault view-cipher functionality.

* Refactor to remove loose-components usage and use DialogService.

* Add edit and delete button functionality.

* Add delete functionality.

* Remove addition to loose components.

* Remove unused modal-dialog artifacts.

* Ensure dialog closes and URL updates properly on edit or close.

* Disable edit/delete buttons instead of hiding them.

* Add simple tests for view.component.ts.

* Adjust import order.

* Remove now unnecessary ng-template.

* Decrypt cipher to cipher view.

* Add cleanup function and additional delete test.

* Remove boolean return from delete promise.

* Remove fake timers.

* Remove unnecessary TestBed.inject calls.

* Add code comments.

* Hide new view cipher dialog behind feature flag.

* Keep "else if" statement intact.

* Simplify getting cipherTypeString.

* Add comments to vault.component.ts files.

* Change button type to "danger"

Update apps/web/src/app/vault/individual-vault/view.component.html

Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>

* Add a11y title to delete button.

* Simplify OrganizationService testing.

* Update comment to better reflect function.

* Use large dialog to better match designs.

* Add aria-haspopup to cipher row button.

* Add deleteCipher to messages.json.

* Remove extra argument from canEditAllCiphers.

* Use 'delete' instead of 'delete cipher' for a11y title.

* Remove 'bitFormButton' from non-form buttons.

* Rework view cipher view delete functionality.

* Add translations for cipher types.

* Remove unecesarry test.

* Add additional test coverage to ensure dialogs close.

* Add back delete functionality in view.component.ts.

* Update "secure note" to "note".

---------

Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
2024-08-19 14:32:17 -07:00
Vince Grassia
d62bdd6e6c
Set BROWSER environment variable (#10622) 2024-08-19 15:33:54 -04:00
Nick Krantz
deab1d1340
[PM-10730] Override FireFox extension styles for text alignment (#10528)
* override firefox extension styles for text alignment

* remove CSS override

* turn off browser specific sidebar styles

- which solves the text-alignment issue in FF
2024-08-19 13:10:36 -05:00
SmithThe4th
97938464e5
get feature flag when needed (#10616) 2024-08-19 11:39:46 -04:00
renovate[bot]
0af09c543c
[deps]: Update uuid to v10 (#10608)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-19 11:34:33 -04:00
renovate[bot]
50a118f88e
[deps] Platform: Update @types/node to v20.16.1 (#10578)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-19 11:17:46 -04:00
renovate[bot]
0272179665
[deps]: Update ts-node to v10.9.2 (#10569)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-19 11:04:55 -04:00
renovate[bot]
c562b75453
[deps] Autofill: Update tldts to v6.1.40 (#10557)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-19 11:00:42 -04:00
renovate[bot]
beaa86dd1b
[deps]: Pin dependencies (#9558)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-19 14:37:27 +02:00
Bernd Schoolmann
5527ffb89c
Move linux memory isolations behind env variable (#10525) 2024-08-19 14:11:26 +02:00
github-actions[bot]
e3d9804b5f
Autosync the updated translations (#10536)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-08-19 10:40:07 +00:00
github-actions[bot]
2d0d8d4b9e
Autosync the updated translations (#10538)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-08-19 10:37:46 +00:00
Jordan Aasen
ef281099b8
migrate report-layout component (#10545) 2024-08-19 12:30:46 +02:00
renovate[bot]
a3d2bb60d1
[deps] [PM-10962] Tools: Update electron to v31.4.0 (#10534)
* [deps] Tools: Update electron to v31.4.0

* Bump version in electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-08-19 12:25:23 +02:00
Andreas Coroiu
71413a7b3b
[PM-6125] Handle kp.alg is string (#10285)
* fix: handle cases when `kp.alg` is `string` in `createCredential` for `Fido2`

* feat: simplify and move fix to mappers

* fix null filter

---------

Co-authored-by: Alessio Cosenza <cosenzaalessio17@gmail.com>
Co-authored-by: Merissa Weinstein <merissa.k.weinstein@gmail.com>
Co-authored-by: Todd Martin <tmartin@bitwarden.com>
2024-08-19 10:17:15 +02:00
Sara Safavi
3e37daf236
add 'desktop' to snapcraft plugs (#5057)
Co-authored-by: Sara Safavi <sara@planet.com>
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2024-08-16 17:07:46 +02:00
Oscar Hinton
4d088f3856
Fix desktop broken on main (#10540) 2024-08-16 09:40:00 -04:00
github-actions[bot]
026467151f
Autosync the updated translations (#10537)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-08-16 09:06:36 +00:00
Oscar Hinton
604e22334a
[BEEEP] [PM-10132] Upgrade storybook to v8 (#10288)
Upgrade storybook to version v8 which is a major upgrade. Storybook provides an
upgrade wizard which did most of the work.

- Ran npx storybook upgrade.
- Manually updated `remark-gfm` since the newer mdx requires v 4.
- Migrated all old stories still using `Story` to `StoryObj`.
2024-08-16 09:28:29 +02:00
Jordan Aasen
92f87dad9a
[PM-4962] remove all bootstrap classes from reports. add missing header column (#10524)
* remove all bootstrap classes from reports. add missing header column

* finish migrating table components to component library

* update reports based on PR feedback
2024-08-15 17:16:38 -07:00
Cesar Gonzalez
d78ff49817
[PM-10949] Identity inline menu showing in unexpected fields (#10533) 2024-08-15 15:58:10 -05:00
Bernd Schoolmann
325d3382d7
[PM-10852] Prevent process reload from logging out active user (#10526) 2024-08-15 13:34:08 -04:00
Jordan Aasen
a72ec8ab89
[PM-8228] - Create new Premium Component (#10514)
* add new premium component

* finish new premium component

* revert change to config service

* hide copy changes behind feature flag

* revert keys back to original

* remove stateService and translation key

* add missing translation key

* add missing key
2024-08-15 10:31:04 -07:00
Jordan Aasen
199ac3de45
[PM-10045] - SendCreated page (#10331)
* WIP - send created component

* WIP - send created page

* finalize send created component and specs

* add extra padding

* undo browser extension refresh

* fix tests

* fix error
2024-08-15 07:59:00 -07:00
Cesar Gonzalez
8fbdd8d22e
[PM-10667] Implement manifest v3 POC for remaining browsers (#10419)
* [PM-10667] Implement manifest v3 on Firefox and Safari

* [PM-10667] Fixing issues with CORS present in sandboxed iframe on Firefox

* [PM-10667] Updating gulp build process to ensure dist files are created correctly

* [PM-10667] Adding build processes to the Github workflow

* [PM-10667] Removing faulty Safari mv3 build workflow

* [PM-10667] Fixing jest tests

* [PM-10667] Reworking logic within inline menu

* Update apps/browser/webpack.config.js

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2024-08-15 09:54:18 -05:00
Cesar Gonzalez
0b24789449
[PM-10897] Fixing invalid url reference when creating login ciphers from inline menu (#10527)
* [PM-10897] Fixing invalid url reference when creating login ciphers from inline menu

* [PM-10897] Ensuring that a subframe that contains a full set of data for a login cipher is treated as authoritative
2024-08-15 08:45:55 -05:00
Jordan Aasen
6fd184728f
add missing header to exposed passwords report (#10516) 2024-08-14 12:53:30 -07:00
Jared Snider
c5ae908fde
PM-10069 - Refactor unauthExtensionRefreshSwap to be available in non-extension clients and rename. (#10518) 2024-08-14 15:15:23 -04:00
Cesar Gonzalez
910ae7d799
[PM-10796] Fix inline menu cipher list scroll behavior (#10500)
* [PM-10796] Fix inline menu setting of scroll class when showing new item button with a list of ciphers

* [PM-10796] Fix inline menu setting of scroll class when showing new item button with a list of ciphers
2024-08-14 11:03:38 -05:00
Cesar Gonzalez
5fad072554
[PM-10155] Fixing broken jest tests for auto-submit content script (#10512) 2024-08-14 10:39:23 -05:00
Kyle Spearrin
5547b953ad
[AC-2928] Create automatic app login policy (#10295)
* Create automatic app login policy

* update copy

* update copy

* [PM-10155] Automatic Login After Autofill (#10297)

---------

Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
2024-08-14 09:38:33 -05:00
Shane Melton
8274ea783c
[PM-10757] Pass current tab uri in new item dropdown (#10505) 2024-08-13 15:59:27 -07:00
Nick Krantz
a6176aaf2c
[PM-10799] Login UI Width (#10506)
* reset `maxWidth` attribute during page change

* set default value for `maxWidth` if null or undefined is passed

* implement `maxWidth` for extension implementation of Anon Layout
2024-08-13 14:18:04 -05:00
Shane Melton
1b22320dc5
[AC-1041] My Vault filter on first login fix (#10301)
* [AC-1041] Ensure organizationTree$ updates whenever the policy observables emit

* [AC-1041] Ensure enforcePersonalOwnership updates whenever the policy observable emits

* [AC-1041] Do not attempt to pre-select null filter values or read-only collections
2024-08-13 10:32:02 -07:00
Shane Melton
fe9d44af6d
[PM-10721] Autofill section styles fixes (#10454)
* [PM-10721] Remove autofill section title hyphen

* [PM-10721] Use h6 styling for header

* [PM-10721] Fix spacing for match detection select
2024-08-13 10:16:53 -07:00
Shane Melton
f017edb088
[PM-10651] Use bitLink instead of icon button and add a11y title (#10483) 2024-08-13 10:15:14 -07:00
Vince Grassia
2acd201752
BRE-243 - Fix credentials used for Desktop upload to App Store (#10503) 2024-08-13 17:14:15 +01:00
Shane Melton
7ad42ae18b
[PM-9190] Browser Refresh - Autofill section fixes (#10488)
* [PM-10751] Add count to website URI label

* [PM-10752] Hide autofill on page load field when the setting is disabled

* [PM-10790] Fix bottom margin
2024-08-13 08:58:16 -07:00
Vincent Salucci
471dd3bd7b
[PM-10294] Remove FC v1 from Clients (#10422)
* chore: remove fc v1 from org.canEditAnyCollection and update callers, refs PM-10294

* chore: remove fc v1 from collectionView.canEdit and update callers, refs PM-10294

* chore: remove fc v1 from organization.canEditAllCiphers and update callers, refs PM-10294

* chore: remove fc v1 from canDeleteAnyCollection, collection views, update callers, refs PM-10294

* chore: remove fc v1 from canEditUser/GroupAccess, refs PM-10294

* chore: remove fc v1 from canViewCollectionInfo, refs PM-10294

* chore: remove fc v1 from account component, refs PM-10294

* fix: remove fc v1 from collections component, refs PM-10294

* fix: update vault-items component, refs PM-10294

* fix: remove fc v1 from collection-dialog and collections components, refs PM-10294

* chore: remove ConfigService from group-add-edit and account components, refs PM-10294

* chore: change canEditAnyCollection to getter and update callers, refs PM-10294

* chore: change canEditUnmanagedCollections to getter and update callers, refs PM-10294

* chore: change canDeleteAnyCollection to getter and update callers, refs PM-10294

* chore: remove deprecated observable and update comments with v1, refs PM-10294

* chore: remove ununsed ConfigService from collection-dialog component, refs PM-10294

* chore: remove final fc v1 ref for vault-collection-row, refs PM-10294
2024-08-13 10:45:41 -05:00
Jared Snider
43da67ee51
Fix nativeMessaging background by replacing removed state service usage with account service for user id retrieval (#10501) 2024-08-13 11:12:59 -04:00
Nick Krantz
5ce5f836e2
Fix failing test on main (#10499)
* mock popuproutercache to fix failing test

* add `OnInit` implementation to fix linting

* Revert "add `OnInit` implementation to fix linting"

This reverts commit 50adcacba3.
2024-08-13 09:12:48 -05:00
Bernd Schoolmann
127811166b
Revert "[PM-8316] Fix account switcher on logged out account on startup (#10342)" (#10498)
This reverts commit 2665afffdd.
2024-08-13 15:43:56 +02:00
Nick Krantz
baf919a4e3
[PM-10700] Navigate to View after cipher creation (#10484)
* refactor params subscription variable names

* refactor param subscription to return a tuple

- this is going to be helpful when multiple params are involved

* navigate the user back to the vault when a new cipher is created

* add unit tests for view-v2 component

* prefer replaceUrl to avoid having to pass a query param

* Fix grammar of mocking comment
2024-08-13 07:51:43 -05:00
Todd Martin
7b508b1ad7
[PM-8933] Require userId on setUserKey (#9675)
* Updated all sets of user key to pass in userId

* Added userId on auth request login.

* Fixed tests.

* Fixed tests to pass in UserId

* Added parameter to tests.

* Addressed PR feedback.

* Merged main
2024-08-13 08:07:36 -04:00