1
0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-13 13:49:37 +01:00
Commit Graph

2189 Commits

Author SHA1 Message Date
Jordan Aasen
985942ac05
collapse collections initially (#13646) 2025-03-10 11:07:04 -07:00
Bernd Schoolmann
01f6fd7ee3
[PM-16227] Move import to sdk and enable it in browser/web (#12479)
* Move import to sdk and enable it in browser/web

* Add uncomitted files

* Update package lock

* Fix prettier formatting

* Fix build

* Rewrite import logic

* Update ssh import logic for cipher form component

* Fix build on browser

* Break early in retry logic

* Fix build

* Fix build

* Fix build errors

* Update paste icons and throw error on wrong import

* Fix tests

* Fix build for cli

* Undo change to jest config

* Undo change to feature flag enum

* Remove unneeded lifetime

* Fix browser build

* Refactor control flow

* Fix i18n key and improve import behavior

* Remove for loop limit

* Clean up tests

* Remove unused code

* Update libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>

* Move import logic to service and add tests

* Fix linting

* Remove erroneous includes

* Attempt to fix storybook

* Fix storybook, explicitly implement ssh-import-prompt service abstraction

* Fix eslint

* Update libs/importer/src/importers/bitwarden/bitwarden-json-importer.ts

Co-authored-by:  Audrey  <ajensen@bitwarden.com>

* Fix services module

* Remove ssh import sdk init code

* Add tests for errors

* Fix import

* Fix import

* Fix pkcs8 encrypted key not parsing

* Fix import button showing on web

---------

Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
Co-authored-by:  Audrey  <ajensen@bitwarden.com>
2025-03-10 18:41:47 +01:00
Nick Krantz
85a5aea897
[PM-18859] Mobile Viewports - Extension Prompt (#13703)
* remove min-width on body element for extension prompt page

* reset meta viewport content for extension prompt page

* set max width of svg to avoid any overflow on mobile devices

* use inline display to avoid icon  overflow on mobile devices

* use max width on the icon to fix overflow rather than editing the anon layout
2025-03-10 10:33:56 -05:00
Oscar Hinton
a569dd9ad6
[PM-15892] [PM-12250]Remove nord and remnants from solarizedark (#13449)
* Remove nord and remnants from solarizedark

* Update window reload color

* Remove extension-refresh feature flag from clients (#13450)

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>

* Remove usage of nord and solarized themes within DarkImageDirective

---------

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-10 15:33:55 +01:00
Thomas Rittson
ef72f513b1
eslint: report unused disable directives (#13463)
Remove any unused disable directives and FIXMEs in our code
2025-03-10 09:33:08 -04:00
Todd Martin
895b36a3d8
[PM-18945] Add CLI as valid SSO client (#13723)
* Added CLI as valid SSO client.

* Updated SsoClientType
2025-03-07 18:30:28 -05:00
Ike
c739a884b4
[PM-15015] Adding Request Country Name to auth requests approval dialog (#13718)
* feat(pm-15015) : 
  - Adding `requestCountryName` to auth requests dialogs, and response models. 
  - Updated i18n messages.json in Web, Browser, and Desktop to include "Location" translation.
2025-03-07 18:03:13 -05:00
Vijay Oommen
f1b69ad65d
[PM-16690] Bitwarden CSV Import - collections not created (#13636) 2025-03-07 16:58:43 -06:00
Jared Snider
264ceaa82a
fix(NewDeviceVerification): [Auth/PM-18641] Show translated invalid code error on enter keypress (#13740) 2025-03-07 12:56:21 -05:00
Merissa Weinstein
d4c74287fc
[CL-281] Override tailwind text-3xl style (#13710)
* override tailwind text-3xl style

* convert px to rem
2025-03-07 10:02:17 -06:00
✨ Audrey ✨
dcf15b496b
[PM-17590] fix chrome translation bug by escaping $ (#13103)
replaces translation with hard-coded text for cross-platform compatibility
2025-03-06 20:13:04 +00:00
Jared Snider
5588e1a1a1
fix(auth): Auth/pm 18836 - UI Refresh - Chrome extension - WebAuthn 2FA revert inline iframe for chromium (#13709)
* PM-18836 - (1) Extension Two Factor Webauthn - revert supporting inline webauthn 2fa as it doesn't work outside of local still (2) Extension 2FA Webauthn comp - add log of webauthn errors to help diagnose future issues

* PM-18836 - Extension - Services module - ExtensionTwoFactorAuthWebAuthnComponentService - remove unused dep
2025-03-06 11:49:49 -08:00
SmithThe4th
e327816bc4
[PM-11941] Migrate TOTP Generator to use SDK (#12987)
* Refactored totp service to use sdk

Fixed strict typescript issues

* Fixed dependency issues

* Returned object that contains code and period, removed get interval function

* removed dependencies

* Updated to use refactored totp service

* removed sdk service undefined check

* removed undefined as an input from the getCode function

* Made getcode$ an observable

* refactored to use getcodee$

* Filter out emmissions

* updated sdk version

* Fixed readability nit

* log error on overlay if totp response does not return a code

* fix(totpGeneration): [PM-11941] Totp countdown not working on clients

* Used optional chaining if totpresponse returns null or undefined
2025-03-06 14:01:07 -05:00
Jason Ng
f65daf7284
[PM-12045] search service activeuserstate (#13035)
* removing activeuserstate from search service
2025-03-06 12:26:24 -05:00
✨ Audrey ✨
9761588a2a
[PM-16790] introduce extension service (#13590) 2025-03-06 11:32:42 -05:00
cyprain-okeke
96fa9e2ea7
Resolve the Tailwind CSS class error (#13700) 2025-03-06 14:47:03 +01:00
Jonas Hendrickx
ed83b6a445
[PM-18163] Remove feature flag 'AC-1795_updated-subscription-status-section' (#13456) 2025-03-06 13:19:08 +01:00
Shane Melton
a7643ebab0
[PM-18650] [PM-18640] Fix change login password service defects (#13596)
* [PM-18650] Ensure http url is returned if well-known cannot be confirmed

* [PM-18650] Modify getChangePasswordUrl logic to check each cipher URL until a valid well-known url is found
2025-03-05 11:49:54 -08:00
Daniel James Smith
f95ce4e442
[PM-18913] Remove unneeded margin from send search component (#13698)
* Remove unneeded margin

* Made send-search.component ts-strict compliant

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-05 10:04:46 -05:00
Brandon Treston
6037c583eb
remove feature flag (#13677) 2025-03-04 14:53:02 -05:00
Daniel James Smith
2b29bf8c23
Move SendAddEditDialog from web to bitwarden/send-ui (#13679)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-03-04 13:24:00 -05:00
Jason Ng
f7642aa0c6
[PM-14423] item view security task (#13485)
* show pending change password tasks for ciphers in extension
2025-03-04 12:18:40 -05:00
Jordan Aasen
13213585b2
[PM-17820] - Browser/Web - update button and label state in username generator (#13189)
* add event handling for username generator

* fix specs. change function name to not be of an event type

* update specs

* rename function

* revert name change

* fix spec

* bubble algorithmSelected up to generator components. add disabled button tests

* add typeSelected event

* revert addition of onType.

* apply same logic in onAlgorithmSelected to web and desktop
2025-03-03 11:44:34 -08:00
✨ Audrey ✨
e10b5af9d3
[PM-16791] introduce generator profile provider (#13588) 2025-03-03 12:43:34 -05:00
Jared Snider
92f027af5e
fix(LoginComp + LoginStrategies): [Auth/PM-18654] Refreshed UI - Desktop TDE JIT provisioned user creation errors with missing org SSO id (#13619)
* PM-18654 - State Service & Login Strategy Refactor - move env seeding into login strategy so that new accounts always load w/ the correct environment

* PM-18654 - SSO Comp - just use user id from auth result

* PM-18654 - Config Service - (1) don't allow cascading calls to the renewConfig by using a private promise (2) Replace shareReplay with share configured with manual timer

* PM-18654 - LoginComponents - detail issue and possible fix

* PM-18654 - DesktopLoginV1Comp - use correct destroy hook

* PM-18654 - LoginComp - clean up no longer correct comment

* PM-18654 - New Device Verification Component - Remove unused PasswordLoginStrategy dependency

* PM-18654 - Browser Home Component - fix qParam logic

* PM-18654 - DefaultConfigService - revert changes as they aren't necessary to fix the bug.

* PM-18654 - DefaultConfigService - remove commented code

* PM-18654 - LoginStrategy - add comment

* PM-18654 - Fix login strat tests
2025-03-03 12:09:35 -05:00
Shane Melton
5b215cf193
[PM-18707] Fix desktop live sync (#13624)
* [PM-18707] Remove redundant cipherService subscription

* [PM-18707] Add artificial tick delay to cipherService to allow for ElectronStore storage service to fully save before continuing
2025-03-03 08:33:48 -08:00
Oscar Hinton
325fdc3f3a
[PM-18659] Remove console logs from importers unit tests (#13583)
* Remove console logs from importers unit tests

* Add fixme
2025-03-03 15:59:50 +00:00
Oscar Hinton
a7a5a2771e
Remove runOnlyPendingTimers (#13581) 2025-03-03 16:51:08 +01:00
Matt Gibson
40f7a0d73f
Parse web push payload JSON (#13594) 2025-02-28 17:53:43 +00:00
Bernd Schoolmann
7ba8dd98e6
Validate parameters in encrypt service tests (#13630) 2025-02-28 17:15:06 +01:00
Jake Fink
43f5423e78
[PM-12606] Move Vault Timeout and Vault Timeout Settings to KM (#13405)
* move vault timeout and vault timeout settings to km

* move browser vault timeout service to km

* fix cli import

* fix imports

* fix some relative imports

* use relative imports within common

* fix imports

* fix new imports

* Fix new imports

* fix spec imports
2025-02-28 09:55:03 -05:00
Bernd Schoolmann
0ee2e0bf93
[PM-18697] Increase test coverage for encrypt service and symmetric crypto key (#13628)
* Increase coverage for EncryptService and SymmetricCryptoKey

* Re-add missing test
2025-02-28 14:20:31 +01:00
Todd Martin
319a4dd1cc
Remove checks of device verification flags on client (#13604) 2025-02-27 13:17:47 -05:00
Jared Snider
e6aaa65563
fix(New-UI-Login-SSO): [Auth/PM-18693] LoginComp - fix form validation not showing up on SSO click (#13601) 2025-02-27 10:53:24 -05:00
Todd Martin
ec488e4f84
[PM-18664] Prevent display of Auth Request notification on triggering device (#13597)
* Send device identifier in header.

* Added null to apiUrl property for strict typing.

* Added null to apiUrl for strict typing.
2025-02-27 10:00:52 -05:00
Todd Martin
182ff6481d
Remove early return from redirect initialization. (#13585) 2025-02-26 21:49:48 -05:00
Shane Melton
b9ebf0704a
[PM-14426] At-risk password Getting Started Carousel (#13383)
* [PM-14426] Add hideIcon input to simple dialog component

* [PM-14426] Introduce dark-image-source.directive.ts

* [PM-14426] Tweaks to the Vault Carousel component
- Create a Carousel NgModule so that the carousel component and carousel slide component are exported
- Update barrel files
- Adjust min height calculation logic to wait for ;hidden slides to finish rendering before calculating height

* [PM-14426] Introduce at risk password getting started carousel component and images

* [PM-14426] Refactor at-risk-password-page.service.ts to use the same state definition for banner and carousel dismissal

* [PM-14426] Open the getting started carousel on page load

* [PM-14426] Add tests

* [PM-14426] Use booleanAttribute

* [PM-14426] Fix failing type checking
2025-02-26 13:24:35 -08:00
Patrick-Pimentel-Bitwarden
d999d91f19
fix(sso-routing): [Auth/PM-13458] Fixes for routing flow on TDE login (#13479)
* fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login - Fixed routing flow and added comments.

* fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login - Undid the old sso component flow because we determined it's not worth fixing.

* fix(sso-routing): [PM-13458] Fixes for routing flow on TDE login - Removed flow entirely.
2025-02-26 14:54:06 -05:00
rr-bw
359007ab8d
fix(auth): [PM-18639] Resend Admin Auth Request After Previous Denial (#13574) 2025-02-26 11:44:41 -08:00
Andreas Coroiu
ce5a5e3649
Improve SDK direct function usage (#13353)
* feat: initalize WASM/SDK directly after load

* fix: default sdk service trying to set log level

* feat: wait for sdk to load in sdk service

* fix: add required disposable polyfills

* feat: update sdk version

* feat: replace rc-specific workaround with global polyfill

* fix: sdk service tests
2025-02-26 09:08:42 +01:00
Jared Snider
44d50a70c2
Auth/PM-5712 - Extension & Desktop Account Switcher - Fix incorrect env showing when adding new accounts (#13362)
* PM-5712 - Refactor env service to require user id instead of having global and active user state fallbacks per working session with Justin.

* PM-5712 - AccountSwitcherService tests - fix tests and add env assertions.
2025-02-25 17:58:26 -05:00
Oscar Hinton
cec117459b
[PM-18599] Forbid unknown property and element in tests (#13556)
Fail tests when relying on unknownProperties or unknownElements. Existing instances are whitelist and have tickets created and assigned to the relevant teams.
2025-02-25 14:02:19 -08:00
Danielle Flinn
e6e6058f9e
CL-261: update popover styles and fix stories (#13547)
* updated popover styles and fix stories

* fixed alignment of icon button title and added long title story
2025-02-25 13:55:21 -08:00
cyprain-okeke
2bb86631f3
[PM-13127]Breadcrumb event logs (#13386)
* Changes for the dummy event

* Add the request UI changes

* refactoring the code

* swapping out the datasources

* Put the changes behind a feature flag

* Rename the Feature flag to lowercase

* Rename the feature flag to epic

* Changes to resolve the pr comments

* Merge the two tables

* commit changes

* Remove unused code

* Add the suggested of content projection

* Resolve the failing ui issues

* remove unused code

* Resolve the repeated code
2025-02-25 20:49:50 +00:00
cd-bitwarden
a5fe0857ee
Fix for the issue where folders do not log when you have two accounts and you lock both then login to the second account (#13273) 2025-02-25 15:15:35 -05:00
Vicki League
6d1914f43d
[CL-485] Add small delay for async action loading state (#12835) 2025-02-25 09:56:01 -05:00
Jared Snider
e06a482d6e
fix(NewDeviceVerification): [Auth/PM-18580] Fix loading state on submit (#13545) 2025-02-24 17:27:15 -05:00
Jordan Aasen
8552578fbb
[PM-12720] - sort organizations in vault item owner select (#13419)
* sort owner select options and filters by name

* don't sort filters

* fix tests

* fix tests

* set organizations in ngOninit

* move assignment up

* Revert change to add-edit.component.ts. Move assignment up.

* fix tests
2025-02-24 13:53:02 -08:00
Jared Snider
c8b3e4c6dc
feat(LoginViaAuthRequestComponent): [Auth/PM-18506] fix missing spaces (#13543) 2025-02-24 15:51:56 -05:00
Alec Rippberger
cbbd53803b
feat(web): [PM-15063] add banner for pending device auth requests
Adds a banner in the web vault to notify users when they have pending device authentication requests. The banner links to the device management screen. Also implements real-time updates to the device management table when new auth requests are received.

JIRA: PM-15063
2025-02-24 11:44:32 -06:00