1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-11 14:48:46 +01:00
Commit Graph

16841 Commits

Author SHA1 Message Date
Matt Gibson
9c1e2ebd67
Typescript-strict-plugin (#12235)
* Use typescript-strict-plugin to iteratively turn on strict

* Add strict testing to pipeline

Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files.

* turn on strict for scripts directory

* Use plugin for all tsconfigs in monorepo

vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes.

* remove plugin from configs that extend one that already has it

* Update workspace settings to honor strict plugin

* Apply strict-plugin to native message test runner

* Update vscode workspace to use root tsc version

* `./node_modules/.bin/update-strict-comments` 🤖

This is a one-time operation. All future files should adhere to strict type checking.

* Add fixme to `ts-strict-ignore` comments

* `update-strict-comments` 🤖

repeated for new merge files
2024-12-09 20:58:50 +01:00
Victoria League
0906c503e1
[CL-522] Reduce font size for checkbox and radio labels (#12251) 2024-12-09 14:10:14 -05:00
Mr. Beedell, Roke Julian Lockhart
f7b81231bc
Remove [CLI]() from README.md. (#12189)
Per https://github.com/bitwarden/clients/issues/12188#issue-2706366498.

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-12-09 16:41:13 +00:00
renovate[bot]
b344722601
[deps] Platform: Update @types/node to v22.10.1 (#12305)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-09 10:22:22 -05:00
renovate[bot]
30e3002b78
[deps] Autofill: Update prettier to v3.4.2 (#12303)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-09 10:21:49 -05:00
renovate[bot]
d24f092d35
[deps] Autofill: Update tldts to v6.1.66 (#12293)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-09 10:18:50 -05:00
Nick Krantz
b5ce2167eb
update styles of the password history to use bitLink & button (#12246) 2024-12-09 09:04:16 -06:00
renovate[bot]
8c446b4720
[deps] Platform: Update Rust crate anyhow to v1.0.94 (#12296)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2024-12-09 15:42:42 +01:00
Bernd Schoolmann
e8976556d8
Fix missing title for ssh key dialog (#12317) 2024-12-09 09:40:58 -05:00
renovate[bot]
ba4d7ea799
[deps] Platform: Update electron-log to v5.2.4 (#12300)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2024-12-09 11:57:58 +01:00
Bernd Schoolmann
3bfe5e4a65
[PM-13099] Enable browserintegration on dmg builds on adding an env variable (#11359)
* Enable browserintegration on dmg builds on adding an env variable

* Fix crash

* Cleanup
2024-12-09 11:09:57 +01:00
renovate[bot]
d5af932cef
[deps] AC: Update style-loader to v4 (#10589)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-06 23:17:47 -06:00
renovate[bot]
1654ff9b7a
[deps] AC: Update sass-loader to v16.0.4 (#11309)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-06 19:56:05 -06:00
renovate[bot]
c6eb78d7fc
[deps] AC: Update postcss to v8.4.49 (#11938)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-06 19:42:56 -06:00
renovate[bot]
a05162b373
[deps] AC: Update mini-css-extract-plugin to v2.9.2 (#11937)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-06 19:09:05 -06:00
cyprain-okeke
019a4d16c4
Resolve the Unauthorized issue on secrets manager (#12278) 2024-12-06 23:23:18 +01:00
Alec Rippberger
69800d01ab
revert: [PR-13659] remove 2FA timeout logging and fix attempts
This reverts two previous commits:
- PM-13659 - 2FA Timeout Log All the things (#12275)
- Auth/PM-13659 - 2FA Timeout - Attempted Fix (#12263)
2024-12-06 13:42:32 -06:00
Jordan Aasen
d295825ff1
[CL-511] - add variant to links within banners (#12090)
* add variant to links within banners

* add fix prop
2024-12-06 11:29:35 -08:00
rr-bw
597e385561
update height of iframe on web (#12265) 2024-12-06 10:48:58 -08:00
Jared Snider
9fcc4f0543
PM-13659 - 2FA Timeout Log All the things (#12275) 2024-12-06 12:43:17 -05:00
Opeyemi
7e2456224d
[BRE-470] - Update Renovate Conf for BRE team (#12274) 2024-12-06 11:52:31 -05:00
Andreas Coroiu
f16bfa4cd2
[PM-9035] desktop build logic to provide credentials to os on sync (#10181)
* feat: scaffold desktop_objc

* feat: rename fido2 to autofill

* feat: scaffold electron autofill

* feat: auto call hello world on init

* feat: scaffold call to basic objc function

* feat: simple log that checks if autofill is enabled

* feat: adding some availability guards

* feat: scaffold services and allow calls from inspector

* feat: create custom type for returning strings across rust/objc boundary

* chore: clean up comments

* feat: enable ARC

* feat: add util function `c_string_to_nsstring`

* chore: refactor and rename to `run_command`

* feat: add try-catch around command execution

* feat: properly implement command calling

Add static typing. Add proper error handling.

* feat: add autoreleasepool to avoid memory leaks

* chore: change objc names to camelCase

* fix: error returning

* feat: extract some helper functions into utils class

* feat: scaffold status command

* feat: implement status command

* feat: implement password credential mapping

* wip: implement sync command

This crashes because we are not properly handling the fact that `saveCredentialIdentities` uses callbacks, resulting in a race condition where we try to access a variable (result) that has already gotten dealloc'd.

* feat: first version of callback

* feat: make run_command async

* feat: functioning callback returns

* chore: refactor to make objc code easier to read and use

* feat: refactor everything to use new callback return method

* feat: re-implement status command with callback

* fix: warning about CommandContext not being FFI-safe

* feat: implement sync command using callbacks

* feat: implement manual password credential sync

* feat: add auto syncing

* docs: add todo

* feat: add support for passkeys

* chore: move desktop autofill service to init service

* feat: auto-add all .m files to builder

* fix: native build on unix and windows

* fix: unused compiler warnings

* fix: napi type exports

* feat: add corresponding dist command

* feat: comment signing profile until we fix signing

* fix: build breaking on non-macOS platforms

* chore: cargo lock update

* chore: revert accidental version change

* feat: put sync behind feature flag

* chore: put files in autofill folder

* fix: obj-c code not recompiling on changes

* feat: add `namespace` to commands

* fix: linting complaining about flag

* feat: add autofill as owner of their objc code

* chore: make autofill owner of run_command in core crate

* fix: re-add napi annotation

* fix: remove dev bypass
2024-12-06 16:31:30 +01:00
cyprain-okeke
f95cc7b82c
Resolve the Unauthorized issue (#12262) 2024-12-06 15:17:48 +01:00
Jared Snider
8d68a2dd58
Auth/PM-13659 - 2FA Timeout - Attempted Fix (#12263)
fix(auth): attempt to resolve 2FA session timeout issue
2024-12-05 20:22:13 -05:00
Vijay Oommen
d6e1fe70ca
PM-15091 Remove client side featureflag.AccessIntelligence and use DB feature flag (#12247)
* PM-15091 remove featureflag.AccessIntelligence

* removed unwanted lines of code

* fixed merge conflict
2024-12-05 17:24:51 +00:00
Brandon Treston
c11f429ddb
[PM-12273] Admin Console Integration Page (#11883)
* Integration page initial implementation

* replace placeholder integrations

* fix linting and tests

* fix locales

* update locale

* Change logos, add link to SCIM page

* refactor to standalone components, add integration filtering pipe

* refactor modules and imports. Remove hyperlink text from integration card template

* refactor i18n usage to be more generic

* Add storybooks

* fix tests

* minify svgs, include spec files in TS config, fix stories

* Update apps/web/src/locales/en/messages.json

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>

* fix imports, add static dir for stories

* Add darkmode svgs for integrations

* hide nav link for non enterprise orgs

* add router guard

* change rxjs selector

* Remove tailwind class causing style issues

---------

Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
2024-12-05 10:09:40 -05:00
Daniel James Smith
6dc68b174b
Prompt user to popout the extension when creating a file send with Chrome on MacOS (#12257)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-05 09:48:03 -05:00
Robyn MacCallum
f8ba01d3fa
Remove SM team from CODEOWNERS (#12258) 2024-12-05 09:46:56 -05:00
Bernd Schoolmann
816bf70dc0
Disable ssh agent for organization items (#12240) 2024-12-05 11:53:30 +01:00
Shane Melton
773aba4fef
[PM-15559] Fix hide passwords in AC for users that have view, except password (#12252)
* [PM-15559] Update admin dialog flows to first try the local state before using the API when not required

* [PM-15559] Clear initial values after creating a new cipher so that they do not override the newly created cipher for subsequent edits
2024-12-04 15:30:15 -08:00
rr-bw
cee13556af
fix(ui): [PM-13147] Change logout a link to button so that it displays correctly (#12232)
On `/update-temp-password`, on the light theme the "Logout" link was not showing in the upper-left corner because the text color for an `a` link is our primary blue color, which blended in with the headers background color. This PR changes the logout `a` link to a `button` so that it inherits the header text color. It should be a button anyway since it's calling a function and not simply routing.
2024-12-04 14:56:59 -08:00
Conner Turnbull
0bc63517bd
If user can't view subscription, don't show upgrade modal (#12248) 2024-12-04 12:25:15 -05:00
SmithThe4th
45db17627e
[PM-15535] User with Edit* permission can permanently delete item from more actions menu on extension (#12234)
* Added conditional to check if a cipher can be delete by user

* Added change detection on push

* Added directive to check if user can delete a cipher

* Added directive to check if user can delete a cipher

* Replaced check with directive

* removed takeUntilDestroyed
2024-12-04 11:57:03 -05:00
Bernd Schoolmann
7e934bc6d3
Fix biometrics not being enabled in browser (#12237) 2024-12-04 17:04:14 +01:00
Bernd Schoolmann
811b97cef5
[PM-15541] Hide ssh key filter behind feature flag (#12239)
* Hide ssh key filter behind feature flag

* Hide ssh keys in web client by featureflag

* Fix build
2024-12-04 17:04:08 +01:00
Bernd Schoolmann
80a898bd8c
[PM-14252] Switch to oo7 and drop libsecret (#11900)
* Switch to oo7 and drop libsecret

* Fix tests

* Fix windows

* Fix windows

* Fix windows

* Fix windows

* Add migration

* Update apps/desktop/desktop_native/core/src/password/unix.rs

Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>

* Remove libsecret in ci

* Move allow async to trait level

* Fix comment

* Pin oo7 dependency

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2024-12-04 17:03:34 +01:00
Daniel James Smith
98702d9f50
Fix the new send dropdown showing premium when it should not (#12242)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-04 09:59:06 -05:00
Jonas Hendrickx
b25dc6300c
Revert "[PM-13999] Show estimated tax for taxable countries (#12145)" (#12244)
This reverts commit 1dce7f5ba0.
2024-12-04 14:40:57 +00:00
Bernd Schoolmann
864e6759fd
Switch to rustcrypto argon2 on desktop (#11753)
* Switch to rustcrypto argon2 on desktop

* Make argon2 use zeroize

* Remove argon2 native modules from electron-builder config

* Clean rust implementation of argon2

* Update cargo.lock

* Update apps/desktop/desktop_native/napi/src/lib.rs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Add tests

* Clean up test

* Remove argon2 external from webpack main

* Fix build

* Fix argon2 module causing a startup crash

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2024-12-04 11:54:55 +00:00
Jonas Hendrickx
1dce7f5ba0
[PM-13999] Show estimated tax for taxable countries (#12145) 2024-12-04 11:45:44 +01:00
Thomas Rittson
853db233d9
Remove AddPolicyDefinitions feature flag (#12172) 2024-12-04 11:50:39 +10:00
Shane Melton
a6c905cc1a
[PM-15533] Remove isNotClone parameter from updateWithServer method (#12233) 2024-12-03 15:43:09 -08:00
Jonathan Prusik
f8c4b8afe8
do not regenerate passwords on every overlay ciphers update (#12226) 2024-12-03 16:08:15 -05:00
Alec Rippberger
c073e91f17
feat(auth): [PM-13659] implement 2FA timeout handling across clients
Add timeout state management for two-factor authentication flows in web, desktop,
and browser extension clients. Includes:

- New timeout screen component with 5-minute session limit
- Updated UI elements and styling
- Comprehensive test coverage

Refs: PM-13659
2024-12-03 13:55:40 -06:00
Shane Melton
2e53a645c9
[PM-15520] Move organizationPaymentStatus$ out of page setup flow and tweak it to avoid hanging when user is not an owner (#12224) 2024-12-03 11:25:02 -08:00
Brandon Treston
694f2c7da2
add policy component form validation to policy edit component (#12150) 2024-12-03 12:55:42 -05:00
Shane Melton
60e52dd2f2
[PM-14965] Fix password reprompt for context menu actions (#12213)
* [PM-14965] Add return value for copy-cipher-field.service

* [PM-14965] Cleanup loadAction handling in updated browser view item page

* [PM-14965] Fix unit tests

* [PM-14965] Clear copy mock
2024-12-03 09:37:44 -08:00
Andreas Coroiu
9188a31b4a
fix: group zbus dependencies (#12165) 2024-12-03 16:04:51 +00:00
Brandon Treston
8a459b3427
[PM-14551] Update copy for revoke dialog (#12089)
* update copy for revoke dialog

* Update bulk restore copy

* update copy in dialog

* remove unused copy

* Check run earlier during setup (#11958)

(cherry picked from commit 80c71c191b)

* Check run earlier during setup (#11958)

(cherry picked from commit 80c71c191b)

* add copy

* update button copy

* add feature flag logic

* restore copy, fix build error

* fix copy

* remove unused copy

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-12-03 09:58:32 -05:00
Daniel James Smith
352d6b9a4d
Remove unused stateService dependency (#12167)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-03 09:50:32 -05:00