1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-26 12:25:20 +01:00
Commit Graph

166 Commits

Author SHA1 Message Date
Thomas Rittson
adfc2f234d
Remove unused SSO Form code (#701)
* Remove unused SAML Artifact Binding properties

* Remove unused validators
2022-03-03 07:52:11 +10:00
Robyn MacCallum
8f5f694a1e
Roll back organizationId and collectionId's if ciphers fail to be moved (#699) 2022-03-02 08:11:34 -05:00
Thomas Rittson
e47eb5e74f
Fix linting (#700) 2022-03-01 23:11:12 +01:00
Thomas Rittson
c1a37eab13
Fix storage keys in v1 migration (#696) 2022-03-02 07:44:14 +10:00
Thomas Rittson
d81eb7ddae
Improve SSO Config validation (#572)
* Extract SsoConfig enums to own file

* Add ChangeStripSpaces directive

* Move custom validators to jslib

* Add a11y-invalid directive

* Add and implement dirtyValidators

* Create ssoConfigView model and factory methods

* Add interface for select options

* Don't build SsoConfigData if null

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-03-02 07:31:00 +10:00
Thomas Rittson
d919346517
Fix autoFillOnPageLoadDefault default value (#697) 2022-03-01 13:13:19 +10:00
Daniel James Smith
a69135ce06
Add missing localeNames (#695) 2022-02-25 18:54:27 +01:00
Addison Beck
65219f5705
[bug] Store collapsedGroupings in accountSettings (#694) 2022-02-25 13:03:13 +01:00
Thomas Rittson
1cbc119ad8
[AuthService refactor] Don't clear state if 2FA is invalid (#690)
* Don't clear state if 2FA is invalid

* Add session timeout to 2FA

* Clear internal authService state if unhandled error
2022-02-23 21:08:43 -06:00
Melanie Kanavakatini
2779cd0966
feat: add hidden char count toggle (#341)
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2022-02-24 07:18:46 +10:00
Addison Beck
78b5f15042
[feature] Implement scope warning for exports (#688)
* [feature] Add a hasOrganizations() service method

* [feature] Add a component to warn users about export scope
2022-02-23 13:56:46 +10:00
Matt Gibson
1fb3d54014
Feature/password protected export (#689)
* Simplify password protected file format

* no items to import is not an error

* Await inner importer

* Add export format type

* Error if import file is password protected

* Update tests

* Test password protected with normat json importer

* Simplify imports

* Ignore code coverage directory

* Expand importer options  without changing display options

* Import password require import error handling

* Use interface

* Fix curlies

* linter fixes

* Add null of empty util

* Lint fixes

* run prettier

* Move import options to separate enum file

* Fix imports
2022-02-23 13:02:07 +10:00
Oscar Hinton
60878cd4ed
Add eslint (#610) 2022-02-22 15:39:11 +01:00
Kyle Spearrin
fc0638a7d9
fix infite recursion on getEncKey (#687) 2022-02-17 11:36:00 -05:00
Addison Beck
a6092916d8
[bug] Persistantly store collapsedGroupings (#686)
Collapsed groupings have regressed to not maintaining their state through restarting clients.

The state mangement refactor erroniously began saving this field to memory instead of disk, but there were some other issues that changing this brought on that are also fixed in this commit.

Changes:
1. Save collapsedGroupings persistantly in StateService
2. Adjust the type of collapsedGroupings on the Account model from a Set<string> to a string[]
	* This is the way we were storing this value in previous releases, and saving the entire set object breaks.
3. Adjust the StateService getter/setter for collapsedGroupings to expect a string[]
4. Extract a string[] from the GroupingsComponent groupings that is a Set<string> before saving
2022-02-15 12:54:22 -05:00
Oscar Hinton
b65a2da18a
Clears the key after locking (#684) 2022-02-15 15:51:22 +01:00
Robyn MacCallum
5de59c32ab
Save localData to local storage instead of in memory (#683) 2022-02-14 16:32:55 -05:00
Addison Beck
240fc154ab
[bug] Allow for toggling the account cache (#674)
* [bug] Allow for toggling the account cache

* Add missing conditional

* Ran prettier
2022-02-14 11:47:01 -05:00
Thomas Rittson
609baece05
Clear stale everBeenUnlocked value from onDisk storage (#682)
* Add StateVersion.Four to remove old everBeenUnlocked key

* Save new state properly

* Add unit tests

* Fix linting
2022-02-14 08:16:07 -05:00
Addison Beck
bcbb52e6ec
Clear active user if state has no users (#677)
* Clear active user if state has no users

* use the correct userId

* run prettier

* add null check
2022-02-11 15:11:31 -05:00
Addison Beck
3a1b5bf9a0
Use getAccount when scaffolding + pass in the correct userId (#676) 2022-02-11 12:45:48 -05:00
Addison Beck
cdc6cbaeb3
Run addAccount storage scaffolding calls through saveAccount (#675) 2022-02-11 11:12:18 -05:00
Addison Beck
e3b29a40d3
[bug] Also check for a never lock timeout when determining where to pull tokens (#673) 2022-02-11 09:38:00 -05:00
Daniel James Smith
eaf387435f
Clean up the cached account (#672)
* Clean up the cached account

* PR feedback: Avoid duplicate code
2022-02-11 14:06:40 +01:00
Oscar Hinton
fd0410ca4b
Resolve hasKeyStored returning true when no biometric key is stored (#671)
* Resolve hasKeyStored returning true when no biometric key is stored

* Change to use a switch statement which avoids having to fetch the key.

* Use triple equals

* Run prettier
2022-02-11 13:17:51 +01:00
Kyle Spearrin
cda649fa21
Cache state service account blob from disk reads (#668)
* store account state in mem cache

* use const
2022-02-11 00:20:50 -05:00
Addison Beck
b7d9a532cb
[bug] Store everBeenUnlocked in memory (#667) 2022-02-10 23:46:42 -05:00
Thomas Rittson
5fad7c666f
Add StateVersion.Three to fix premium migration (#666)
* Add StateVersion.Three to fix premium migration
2022-02-11 13:40:13 +10:00
Justin Baur
52f77c0277
Fix new device login (#664)
* Store appId in localStorage

* Save to local as well
2022-02-10 21:22:18 -05:00
Robyn MacCallum
99f70bea8d
Individually await saving of orgs and providers (#663) 2022-02-10 18:03:55 -05:00
Robyn MacCallum
47399bb583
Move providers to profile and save to disk (#662)
* Move providers to profile and save to disk

* Move providers back to AccountData
2022-02-10 13:55:36 -05:00
Addison Beck
b7bb16c18a
[bug] Toggle tokens appropriatly based on timeout action (#661) 2022-02-09 23:01:43 +01:00
Addison Beck
c282ef8575
[bug] Fix logout timeout action for inactive accounts (#660)
* [bug] Fix logout timeout action for inactive accounts

* Pass userId in to the logout callback parameter to the vaultTimeoutService. The message handle in desktop already expects this.
* Set lastActive on account login, and null it on account deauthentication. This prevents an issue where newly logged in accounts immediatly time out due to inactivity.

* Add userId to locked callbacks

* Add userId to log out callback
2022-02-09 12:15:20 -05:00
Oscar Hinton
8130fce404
Add headers for client type and client version (#651) 2022-02-08 11:18:10 +01:00
Addison Beck
6c08b40847
[bug] Make activity a top level storage key (#656)
* [bug] Make activity a top level storage key

* [bug] use correct index for migration

* [bug] use correct index for migration part 2
2022-02-07 11:36:53 -05:00
Addison Beck
0760b53296
[bug] Default the state version check function to 1 (#657) 2022-02-07 11:08:07 -05:00
Matt Gibson
7afb748791
Feature/password protected export (#612)
* Add password protected export

* Run prettier

* Test password protected export service

* Create type for known import type strings

* Test import service changes

* Test bitwarden password importer

* Run prettier

* Remove unnecessary class properties

* Run prettier

* Tslint fixes

* Add KdfType to password protected export

* Linter fixes

* run prettier
2022-02-07 09:33:10 -06:00
Thomas Rittson
9caea70ea2
[authService refactor] Fix browser by not using instanceof (#647)
* use authenticationType enum instead of instanceof
2022-02-07 07:33:19 +10:00
Matt Gibson
380a7c7ee5
Use Identity server routes (#649)
* Use Identity server routes

We've moved `prelogin` and `register` endpoints to the Indentity project
Reflecting that change here

* Only update path for dev environment
2022-02-04 08:22:19 -06:00
Thomas Rittson
ec9559520b
Fix bug where no passwords recorded in history (#650) 2022-02-04 07:59:55 +10:00
Daniel James Smith
f6ba252139
Temporarily remove keeper json import for the Feb release (#654) 2022-02-03 22:24:22 +01:00
Addison Beck
067cd1e0e1
[bug] Assign client specific account settings during migration (#653)
* [bug] Assign client specific account settings during migration

* [refactor] Write State type arguements in consistent order

* [style] Ran prettier
2022-02-03 13:32:42 -05:00
Thomas Rittson
aa2bdd00be
[Tech debt] Refactor authService and remove LogInHelper (#588)
* Use different strategy classes for different types of login
* General refactor and cleanup of auth logic
* Create subclasses for different types of login credentials
* Create subclasses for different types of tokenRequests
* Create TwoFactorService, move code out of authService
* refactor base CLI commands to use new interface
2022-02-01 09:51:32 +10:00
Addison Beck
92a65b7b36
[bug] Allow for GlobalState to be extended and modified in clients (#646)
Some clients have unique global setting defaults (and unique global settings)
For example: the web vault defaults to light theme, but most clients with theme support default to system theme.

The current way we handle GlobalState is buried in jslib and not easily extendible in clients.

To fix this, we need to treat GlobalState as a generic in the StateService and StateMigration service and allow for its extension in those methods and anywhere GlobalState is inited.
2022-01-31 14:33:31 -05:00
Addison Beck
e372bf242b
[cleanup] Adjust type to match abstraction (#643) 2022-01-28 08:18:39 -05:00
Addison Beck
6c61f53d8b
[bug] Always save environmentUrls passed to setUrls (#641)
* [bug] Always save environmentUrls passed to setUrls

* [bug] Remove parameter from abstraction as well

* [bug] Correct type in abstraction
2022-01-28 08:15:02 -05:00
Addison Beck
ca5b057b43
[refactor] Use ThemeType enum instead of string (#642) 2022-01-28 11:28:36 +01:00
Addison Beck
83305313f9
[bug] Properly define stored window state (#638) 2022-01-27 10:44:09 -05:00
Daniel James Smith
5353cf03b5
BEEEP: Add importer for Keeper in json format (#608)
* Add testdata, create types for keeperjson import

* Create keeperjson importer and tests

* Register, Create instance of keeperjson importer

* Move keeperCsvImporter to keeperImporters folder

* Fixed import of BaseImporter

* Removed unnecessary check for key

* Move instantiation of importer into beforeEach

* Fixed the second import with a wrong path

* Adjust types based on new test export

* Add test case for empty notes and custom fields

* Implement logic for failed test case

* Removed test expectation
2022-01-26 23:04:55 +01:00
Oscar Hinton
e1d4c4c903
Expose getKeyFromStorage with userId (#633) 2022-01-25 15:45:02 +01:00