1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-22 16:29:09 +01:00
Commit Graph

16936 Commits

Author SHA1 Message Date
Daniel Riera
6383048197
PM-5550 Implement on-page autofil for single line TOTP (#12058)
* PM-5550 initial commit -Initial render
-Edit tests
-Clean up styling
-New method to validate totpfields

* add refresh overlay

* localize and clean up

* - Clean up code
- Remove unnecessary data from buildtotpelement
- Add feature flag
- Add aria labels to buildtotpelement
- Add tests and update relevant snapshots

* Add and translate aria labels

* add aria labels

* implement feature flag

* address totp tests

* clean up totpfield function

* fix styling and tests, update snapshots

* Update apps/browser/src/_locales/en/messages.json

Formatting suggestion

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* Update apps/browser/src/_locales/en/messages.json

Formatting suggestion

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>

* remove group tag

* update snapshots

* adress feedback

---------

Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
2024-12-13 12:37:16 -05:00
✨ Audrey ✨
649590ad62
Revert "Autosync the updated translations (#12386)" (#12393)
This reverts commit 107ea04c81.
2024-12-13 16:32:51 +00:00
Rui Tomé
614a4b75cd
[PM-15154] Add missing message for claimed domain (#12353) 2024-12-13 14:44:41 +00:00
Brandon Treston
67e3858206
fix width for organizationName column (#12385) 2024-12-13 09:43:43 -05:00
bw-ghapp[bot]
107ea04c81
Autosync the updated translations (#12386)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-12-13 15:27:54 +01:00
Thomas Rittson
19c5c8722a
[PM-14247] vNextCollectionService fixes (#12362)
* Fix interface to not take observables

* Filter out null orgKeys during transitional state
2024-12-13 14:05:40 +10:00
Daniel James Smith
6933b3a211
Removed unused ctor param for SendApiService (#12330)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-12 20:05:21 -08:00
rr-bw
8ec75613dc
fix(passkeys): [PM-13932] Fix passkey flow incorrect routing (#12363)
This PR fixes a bug in the LockComponent refresh that affected the setup/save and use passkey flows. The user was wrongly directly to the /vault after unlock instead of to /fido2 (the passkey screen).

Feature Flag: ExtensionRefresh ON
2024-12-12 13:10:54 -08:00
bw-ghapp[bot]
2da3043697
Autosync the updated translations (#12379)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-12-12 18:08:23 +00:00
Tomi Belan
7a5f3b2dd4
Fix reporting of server-side errors in "bw sync". (#6855)
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2024-12-12 13:01:03 -05:00
Daniel James Smith
46e2e0233b
Fix duplicate key in en/messages.json (#12375)
This needs to be done, because Firefox compares the keys case-insensitive when a release is uploaded to the store.

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-12 18:27:16 +01:00
Todd Martin
7c8b9db58f
Revert workflow changes (#12376)
* Revert "fix: target workflows not triggering on pull_request_target (#12370)"

This reverts commit 645d36f465.

* Revert "[PM-15126] Tighten scope of our client build pipelines to remove reliance on secrets (#12243)"

This reverts commit f8c33ea04b.
2024-12-12 12:22:55 -05:00
bw-ghapp[bot]
3ce89f9945
Autosync the updated translations (#12373)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-12-12 18:07:38 +01:00
Alec Rippberger
0df7b53bb4
feat(sso): [PM-8114] implement SSO component UI refresh
Consolidates existing SSO components into a single unified component in
libs/auth, matching the new design system. This implementation:

- Creates a new shared SsoComponent with extracted business logic
- Adds feature flag support for unauth-ui-refresh
- Updates page styling including new icons and typography
- Preserves web client claimed domain logic
- Maintains backwards compatibility with legacy views

PM-8114

---------

Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
Co-authored-by: Jared Snider <jsnider@bitwarden.com>
2024-12-12 10:28:30 -06:00
cyprain-okeke
bfa9cf3623
[PM-15545][Defect] Update trial initiation UI for new flow via trial/send-verification-email endpoint (#12256)
* Add the on trial payment option on new UI

* Rename variables correctly

* Resolve the isTrialPaymentOptional and use observable

* use firstValueFrom and remove subscribe

* Resolve the selected plantype

* Changes for free Org
2024-12-12 17:17:24 +01:00
Tom
30c151f44a
[PM-13455] Risk insights aggregation in a new service. (#12071)
* Risk insights aggregation in a new service. Initial PR.

* Ignoring all non-login items and refactoring into a method

* Cleaning up the documentation a little

* logic for generating the report summary

* application summary to list at risk applications not passwords

* Adding more documentation and moving types to it's own file

* Awaiting the raw data report and adding the start of the test file

* Adding more test cases

* Removing unnecessary file

* Test cases update

* Fixing memeber details test to have new member

* Fixing password health tests

* Moving to observables

* removing commented code

* commented code

* Switching from ternary to if/else

* nullable types

* one more nullable type

* Adding the fixme for strict types

* moving the fixme

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-12 09:55:43 -05:00
Github Actions
1b6b5d3110 Bumped Desktop client to 2024.12.1 2024-12-12 13:54:02 +00:00
Icelk
617469127a
ssh agent: fix first start when no .bitwarden-ssh-agent.sock exists (#12356)
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2024-12-12 13:45:37 +01:00
Andreas Coroiu
645d36f465
fix: target workflows not triggering on pull_request_target (#12370) 2024-12-12 12:42:44 +00:00
Alex Morask
5c345c9ee4
[PM-15094] Update remove sponsorship modal content (#12319)
* Update remove sponsorship modal content

* PM-15915
2024-12-12 07:07:50 -05:00
Andreas Coroiu
f8c33ea04b
[PM-15126] Tighten scope of our client build pipelines to remove reliance on secrets (#12243)
* feat: create copy of desktop build for PR target

* chore: add temporary file to trigger ci

* fix: remove check-run from regular desktop build

* feat: change browser build to not use pr target

* fix: skip build-safari if secret is not available

* feat: skip safari build if secrets are not available

* feat: let windows desktop build without secrets

* fix: has_secrets not being output correctly

* feat: let macos desktop build without secrets

* feat: don't build browser as part of desktop

* feat: change CLI to pull_request

* feat: let web build without secrets

* feat: tweak lint to run on PR and not just push

* feat: add PR target workflows

* fix: remove wip files

* fix: lint on hotfix-rc branches

* feat: add new workflows to CODEOWNERS
2024-12-12 11:50:21 +01:00
renovate[bot]
cecf1f2506
[deps] Platform: Update electron to v33 - abandoned (#11580)
* [deps] Platform: Update electron to v33

* fix: remove event from minimize

* chore: update electron version in `electron-builder.json`

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2024-12-12 10:26:05 +01:00
Brandon Treston
8dd904f4b7
fix ts strict errors (#12355) 2024-12-12 10:08:14 +10:00
cd-bitwarden
859f87aabe
[PM-14345] Drag and Drop in Browser - fix for strict nulls (#12337)
* enabling drag and drop for cipher fields

* adding drag and drop to totp and fido

* removing code changes to wrong file

* undoing uneeded change

* Changes suggested by Shane

* fixes

* fixes

* moving export to the correct spot

* handle strict nulls

* fix for dataTransfer potentially being null

* removing uneeded @input tag

* undoing changes

* fix

---------

Co-authored-by: --global <>
2024-12-11 10:30:36 -05:00
Bernd Schoolmann
92a620dd9c
[BEEEP/PM-10534] Add snap biometric support (#12187)
* Add snap biometric support

* Fix linting

* Remove unused message

* Disable snap browser integration again
2024-12-11 16:10:06 +01:00
Brandon Treston
b2ee27c02f
[PM-12443] Remove paging logic from base clients component and subclasses (#12250)
* remove ngx-infinite-scroll in provider clients components.

* cleanup, fix redirect

* cleanup

* remove function call during interpolation

* remove this in template

* add router guard, cleanup

* cleanup

* fix row height for virtual scroller
2024-12-11 09:53:52 -05:00
Rui Tomé
b502e2bc25
[PM-15154] Domain verification copy update (#12217)
* refactor: update domain verification terminology to claimed domains

* feat: add description for claimed domains in domain verification

* Add informational link to claimed domains description in domain verification component

* Update domain verification references to claimed domains in organization layout and SSO component

* Add validation message for invalid domain name format in domain verification

* Add domain claim messages and descriptions to localization files

* Update domain verification navigation text based on feature flag

* Update domain verification dialog to support account deprovisioning feature flag

* Update domain verification component to support account deprovisioning feature flag

* Refactor domain verification dialog to use synchronous feature flag for account deprovisioning

* Refactor domain verification routing to resolve title based on account deprovisioning feature flag

* Update SSO component to conditionally display domain verification link based on account deprovisioning feature flag

* Update event service to conditionally display domain verification messages based on account deprovisioning feature flag

* Update domain verification warning message

* Refactor domain verification navigation text handling based on account deprovisioning feature flag

* Refactor domain verification dialog to use observable for account deprovisioning feature flag

* Refactor domain verification component to use observable for account deprovisioning feature flag
2024-12-11 14:47:49 +00:00
Andreas Coroiu
d4fcb5852a
fix: text-drag directive ts-strict error (#12346) 2024-12-11 12:20:32 +00:00
Bernd Schoolmann
e8d8a816dd
[PM-14988] Use peercred / GetNamedPipeClientProcessId to gather info about process connecting to ssh agent (#12065)
* Fix double prompt when unlocking by ssh request

* Add peercred for unix

* Enable apple-app-store feature

* Add generic parameter

* Update

* Add procinfo for windows

* Show connecting app in ui

* Use struct instead of tuple

* Use atomics instead of mutex

* Fix windows build

* Use is_running function

* Cleanup named pipe listener

* Cleanups

* Cargo fmt

* Replace "" with none

* Rebuild index.d.ts

* Fix is running check
2024-12-11 12:53:00 +01:00
Jonas Hendrickx
7abdc7a423
[PM-15139] [Defect] Upgrade dialog - Percentage discount not aligned with the Annually/Monthly toggle (#12314) 2024-12-11 10:34:25 +01:00
cyprain-okeke
84dfa3ab05
prevent access to freefamilies page (#12335) 2024-12-10 21:52:54 +01:00
cd-bitwarden
83dc66dd56
[PM-14345] Enabling drag and drop for cipher fields (#12067)
* enabling drag and drop for cipher fields

* adding drag and drop to totp and fido

* removing code changes to wrong file

* undoing uneeded change

* Changes suggested by Shane

* fixes

* fixes

* moving export to the correct spot

---------

Co-authored-by: --global <>
2024-12-10 12:55:02 -05:00
Jordan Aasen
4003d30b46
[PM-15180] - update copy for free trial banner (#12151)
* update copy for free trial banner

* add v2 translation keys

* remove old keys. don't use V2 in new key name

* re-add removed keys

* fix copy and examples

* fix i18n key
2024-12-10 09:43:13 -08:00
✨ Audrey ✨
b2af12ab24
[PM-15872] fix username generation character limit (#12329) 2024-12-10 11:08:01 -05:00
Addison Beck
7a26b041cc
chore(codeowners): assign a bunch of workflows to Platform (#12328)
* chore(codeowners): assign a bunch of workflows to Platform

* fix: remove unnecassary lines
2024-12-10 11:00:42 -05:00
renovate[bot]
c2fb224789
[deps] Design System: Update chromatic to v11.20.0 (#12304)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-10 10:58:46 -05:00
renovate[bot]
94410b13b6
[deps] Design System: Update tailwindcss to v3.4.16 (#12295)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-10 10:01:12 -05:00
renovate[bot]
afc7b5d22d
[deps] Design System: Update storybook monorepo to v8.4.7 (#12294)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-10 09:59:06 -05:00
Daniel James Smith
065725df7a
[PM-686] [CLI] Add proxy support for file downloads (#7345)
* Add proxy support for file downloads

Instead of using node's native fetch we extend ApiService with NodeApiService to add support for proxies using `node-fetch`

* Add comments to the DownloadCommand

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-10 09:36:53 -05:00
Daniel James Smith
99008267e6
Add support for using a proxy when running bw update (#7347)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-10 09:36:14 -05:00
renovate[bot]
2fd2d2759d
[deps] Platform: Update webpack to v5.97.1 (#12308)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2024-12-10 14:16:41 +01:00
Daniel James Smith
161a358c49
[PM-5214] [CLI] Add proxy support for file uploads (#7342)
* Add proxy support for file uploads

Instead of using node's native fetch we extend ApiService with NodeApiService to add support for proxies using `node-fetch`

* Fix constructors for FileUploadService in browser

* Fix dependency on ApiService within jslib-services.module

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-12-10 13:17:00 +01:00
Addison Beck
b046c4965d
fix(safari): add a bespoke implementation for reloadExtension (#12326) 2024-12-10 06:28:42 -05:00
renovate[bot]
02c65fd1b8
[deps] BRE: Update sonarsource/sonarcloud-github-action action to v4 (#12311)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-09 16:51:27 -05:00
Victoria League
4daba832a2
[CL-351] Prevent tw-group styling conflicts by namespacing (#12261) 2024-12-09 15:13:42 -05:00
Matt Gibson
9c1e2ebd67
Typescript-strict-plugin (#12235)
* Use typescript-strict-plugin to iteratively turn on strict

* Add strict testing to pipeline

Can be executed locally through either `npm run test:types` for full type checking including spec files, or `npx tsc-strict` for only tsconfig.json included files.

* turn on strict for scripts directory

* Use plugin for all tsconfigs in monorepo

vscode is capable of executing tsc with plugins, but uses the most relevant tsconfig to do so. If the plugin is not a part of that config, it is skipped and developers get no feedback of strict compile time issues. These updates remedy that at the cost of slightly more complex removal of the plugin when the time comes.

* remove plugin from configs that extend one that already has it

* Update workspace settings to honor strict plugin

* Apply strict-plugin to native message test runner

* Update vscode workspace to use root tsc version

* `./node_modules/.bin/update-strict-comments` 🤖

This is a one-time operation. All future files should adhere to strict type checking.

* Add fixme to `ts-strict-ignore` comments

* `update-strict-comments` 🤖

repeated for new merge files
2024-12-09 20:58:50 +01:00
Victoria League
0906c503e1
[CL-522] Reduce font size for checkbox and radio labels (#12251) 2024-12-09 14:10:14 -05:00
Mr. Beedell, Roke Julian Lockhart
f7b81231bc
Remove [CLI]() from README.md. (#12189)
Per https://github.com/bitwarden/clients/issues/12188#issue-2706366498.

Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-12-09 16:41:13 +00:00
renovate[bot]
b344722601
[deps] Platform: Update @types/node to v22.10.1 (#12305)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-09 10:22:22 -05:00
renovate[bot]
30e3002b78
[deps] Autofill: Update prettier to v3.4.2 (#12303)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-12-09 10:21:49 -05:00