1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-14 10:26:19 +01:00
Commit Graph

15455 Commits

Author SHA1 Message Date
Shane Melton
eceec4b908
[PM-8526] Set secureNote type when creating a new note (#10107) 2024-07-12 14:30:39 -07:00
Jason Ng
b7e102dd6d
PM-9632 added MP reprompt check to edit button in view-v2 (#10104) 2024-07-12 16:19:22 -04:00
Vincent Salucci
81a3dce774
[AC-2520] State migration/removal of Unassigned Items Banner state definition (#10080)
* chore: create migration to remove banner dismissed data, refs AC-2520

* chore: remove unassigned items banner state definition, refs AC-2520

* fix: key like definition name updated to match original scope, refs AC-2520
2024-07-12 12:20:16 -05:00
SmithThe4th
7588e06d2b
fix blank titles on menu options button (#10099) 2024-07-12 12:16:54 -04:00
Vincent Salucci
bce6e77514
[AC-2520] Remove Unassigned Items Banner (#10042)
* chore: remove UnassignedItemsBanner feature flag, refs AC-2520

* chore: remove unassignedItemsBanner from web-header component, refs AC-2520

* chore: delete unassigned items banner service/api/spec, refs AC-2520

* chore: remove unassigned items banner messages (web), refs AC-2520

* chore: remove unassigned items banner messages (browser), refs AC-2520

* chore: remove unassigned items banner code from current tab (browser), refs AC-2520

* chore: remove state definition for unassigned items banner, refs AC-2520

* chore: revert state-definition removal, refs AC-2520
2024-07-12 11:06:02 -05:00
Bernd Schoolmann
486176a648
Add foregroundvaulttimeout service and remove getbgservice call for vaulttimeout service (#10071) 2024-07-12 14:32:01 +02:00
Bernd Schoolmann
91dc9f49a5
[PM-6188] Remove get bg service calls (#10050)
* Remove ssologinservice getbgservice call

* Remove deviceservice getbgservice call

* Remove keyconnectorservice getbgservice call

* Remove userverificationservice getbgservice call

* Remove vaulttimeoutsettingservice getbgservice call

* Remove devicetrustservice getbgservice call
2024-07-12 14:31:41 +02:00
github-actions[bot]
8e0e6fdaff
Autosync the updated translations (#10088)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-12 11:07:34 +00:00
github-actions[bot]
e79e4445da
Autosync the updated translations (#10092)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-12 11:04:05 +00:00
github-actions[bot]
7f6969c844
Autosync the updated translations (#10086)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-12 10:17:03 +00:00
github-actions[bot]
36aacb6687
Autosync the updated translations (#10087)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2024-07-12 09:29:21 +00:00
Jared Snider
fef188c221
PM-9688 - Registration with Email Verification - RegistrationFinishComponent - fix button text to say create account instead of set password (#10084) 2024-07-11 20:03:37 -04:00
Jason Ng
7243d62b19
[PM-9627] item details v2 defects (#10082)
* Pull proper item name in item details. add Typography Module to reusable view sections
2024-07-11 18:48:47 -04:00
Jason Ng
d7fa592521
[PM-9646] Identity v2 Edit Defects (#10076)
* add necessary module to identity. update toggle btn with testing attr
2024-07-11 18:47:54 -04:00
Nick Krantz
66f432d6e0
add fallback for navigating the user back when the browser is in a popout (#10024) 2024-07-11 17:32:53 -05:00
Shane Melton
9dda29fb9c
[PM-7896] Cipher Form - Additional Options section (#9928)
* [PM-7896] Adjust cipher form container to expose config and original cipher view for children

* [PM-7896] Add initial additional options section

* [PM-7896] Add tests

* [PM-7896] Add TODO comments for Custom Fields

* [PM-7896] Hide password reprompt checkbox when unavailable

* [PM-7896] Fix storybook
2024-07-11 15:01:24 -07:00
SmithThe4th
050f8f4bdc
[PM-7624] [PM-7625] Bulk management actions on individual vault (#9507)
* fixed issue with clearing search index state

* clear user index before account is totally cleaned up

* added logout clear on option

* removed redundant clear index from logout

* added feature flag

* added new menu drop down and put behind feature flag

* added permanentlyDeleteSelected to the menu

* added permanentlyDeleteSelected to the menu

* wired up logic to show to hide menu drop down items

* modified the bulk collection assignment to work with end user vault

* wired up delete and move to folder

* merged bulk management actions header into old leveraging the feature flag

* added ability to move personal items to an organization and set active collection when user is on a collection

* made collection required by default

* handled organization cipher share when personal items and org items are selected

* moved logic to determine warning text to component class

* moved logic to determine warning text to component class

* Improved hide or show logic for menu

* added bullet point to bulk assignment dialog content

* changed description for move to folder

* Fixed issue were all collections are retrived instead of only can manage, and added logic to get collections associated with a cipher

* added inline assign to collections

* added logic to disable three dot to template

* Updated logic to retreive shared collection ids between ciphers

* Added logic to make attachment view only, show or hide

* Only show menu options when there are options available

* Comments cleanup

* update cipher row to disable menu instead of hide

* Put add to folder behind feature flag

* ensured old menu behaviour is shown when feature flag is turned off

* refactored code base on code review suggestions

* fixed bug with available collections

* Made assign to collections resuable

made pluralize a pipe instead

* Utilized the resuable assign to collections component on the web

* changed description message for collection assignment

* fixed bug with ExpressionChangedAfterItHasBeenCheckedError

* Added changedetectorref markForCheck

* removed redundant startwith as seed value has been added

* made code review suggestions

* fixed bug where assign to collections shows up in trash filter

* removed bitInput

* refactored based on code review comments

* added reference ticket

* [PM-9341] Cannot assign to collections when filtering by My Vault (#9862)

* Add checks for org id myvault

* made myvault id a constant

* show bulk move is set by individual vault and it is needed so assign to collections does not show up in trash filter (#9876)

* Fixed issue where selectedOrgId is null (#9879)

* Fix bug introduced with assigning items to a collection (#9897)

* [PM-9601] [PM-9602] When collection management setting is turned on view only collections and assign to collections menu option show up (#10047)

* Only show collections with edit access on individual vault

* remove unused arguments
2024-07-11 17:39:49 -04:00
Thomas Rittson
a723038b44
Remove OrganizationUserType.Manager (#10060) 2024-07-12 06:14:08 +10:00
Jake Fink
9c66b5bf9f
[PM-4917, PM-8707, PM-9119] Persist login email memory through 2fa on browser (#9811)
* persist email memory through 2fa on browser

* fix tests

* fix desktop
2024-07-11 14:51:06 -04:00
aj-bw
4f3760beae
PM-1935/vault-locked-message-fix (#10078) 2024-07-11 14:39:29 -04:00
cyprain-okeke
cc206d4c3f
[AC-1102]Automatic Sync is visible for self hosted Families Orgs (#9565)
* Add the changes to remove automasync for family org

* Remove changes to the form field file

* Rename productType to productTierType

* Add Upload license and License file

* Hide the License and upload License label

* Resolve the issue of Validation required for family org
2024-07-11 18:05:17 +01:00
Oscar Hinton
39eed02904
[PM-8517] Create web specific layout (#9209)
We currently duplicate some logic between our layouts. In an effort to streamline our experience I'm exploring if we can create a web specific layout that handles some of this.
2024-07-11 12:20:56 -04:00
Alex Morask
9a58b3b774
[AC-2853] [AC-2854] [AC-2861] Consolidated Billing UI Bugs (#10055)
* Fixed Used column on clients page

* Prevent MSP from scaling client below the number of its members

* Prevent MSP from selecting negative seats when creating client
2024-07-11 12:18:09 -04:00
aj-rosado
ea76760782
[AC-2508][AC-2511] member access report view and export logic (#10011)
* Added new report card and FeatureFlag for MemberAccessReport

* Add new "isEnterpriseOrgGuard"

* Add member access icon

* Show upgrade organization dialog for enterprise on member access report click

* verify member access featureflag on enterprise org guard

* add comment with TODO information for follow up task

* Initial member access report component

* Improved readability, removed path to wrong component and refactored buildReports to use the productType

* finished MemberAccessReport layout and added temporary service to provide mock data

* Moved member-access-report files to bitwarden_license/
Removed unnecessary files

* Added new tools path on bitwarden_license to the CODEOWNERS file

* added member access description to the messages.json

* layout changes to member access report

* Created new reports-routing under bitwarden_license
Moved member-access-report files to corresponding subfolder

* Added search logic

* Removed routing from member-access-report BL component on OSS.
Added member-access-report navigation to organizations-routing on BL

* removed unnecessary ng-container

* Added OrganizationPermissionsGuard and canAccessReports validation to member-access-report navigation

* replaced deprecated search code with searchControl

* Address PR feedback

* removed unnecessary canAccessReports method

* Added report-utils class with generic functions to support report operations

* Added member access report mock

* Added member access report specific logic

* Splitted code into different classes that explained their objective.

* fixed member access report service test cases

* Addressed PR feedback

* Creating a service to return the data for the member access report

* added missing ExportHelper on index.ts

* Corrected property names on member access report component view

* removed duplicated service
2024-07-11 17:11:05 +01:00
cyprain-okeke
a08cbf30d9
Resolve the error on license upload (#10057) 2024-07-11 16:18:48 +01:00
Nick Krantz
99d2ff4bbd
open attachments page in new popout window based on browser (#10036) 2024-07-11 09:55:06 -05:00
Nick Krantz
2d4783932b
[PM-9589] Card Details Heading (#10023)
* only show branded card details when the brand isn't "other"

* use TS for the dynamic brand heading rather than template logic
2024-07-11 09:45:15 -05:00
Bernd Schoolmann
9eddbfc6e7
[PM-7084]: 3/6 Introduce shared yubikey two-factor component (#9769)
* Add shared two-factor-options component

* Add new refactored two-factor-auth component and totp auth componnet behind feature flag

* Add yubico yubikey otp shared two-fa component
2024-07-11 10:28:55 -04:00
renovate[bot]
ec1e69ea45
[deps] Tools: Update dotnet monorepo to v8.0.7 (#10069)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-11 16:16:42 +02:00
renovate[bot]
23fdb212e3
[PM-9460][deps] Tools: Update electron to v31.2.0 (#10070)
* [deps] Tools: Update electron to v31.2.0

* Bump version in electron-builder.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-07-11 16:12:33 +02:00
Rui Tomé
5b49412483
[AC-2824] Refactor CLI auth-requests deny command to validate requests and improve exception handling (#9975) 2024-07-11 14:46:15 +01:00
Conner Turnbull
36030c3763
[PM-9113] Trim Whitespace from email in sponsorship form (#9781)
* Removed whitespace from email form when setting up families sponsorship

* Moved sponsorship components to billing folder

* Updated to use existing input stripping directive

* Updated appInputStripSpaces to update both the element and the control value

* Removed the call to Renderer2 as it wasn't needed
2024-07-11 09:04:51 -04:00
Bernd Schoolmann
e977dacdcf
[PM-6797] Prevent account switching race condition on desktop & enable worker decryption (#9312)
* Prevent account switching race condition on desktop

This enables us to allow background thread / multithread bulk decryption on desktop.

* Disable account switcher component during switching
2024-07-11 14:11:51 +02:00
Thomas Rittson
f03dabb6d6
Remove BulkDeviceApproval feature flag (#9931) 2024-07-11 08:47:49 +10:00
Conner Turnbull
dbeab65ea5
When redeeming a F4E sponsorship, now filtering out organizations that the current user is not an owner of (#10013) 2024-07-10 16:16:50 -04:00
KiruthigaManivannan
3f0f5af26a
PM- 2060 Update Two Factor Yubikey dialog (#9010)
* PM-2060 Update Two Factor Yubikey Dialog

* PM-2060 Removed old code

* PM-2060 Added event emitter to capture enabled status

* PM-2060 Addressed review comments

* PM-2060 Change in html file for existing key options

* PM-2060 Addressed the latest comments

* PM-2060 Updated remove method as per comments

* PM-2060 Added throw error to enable and disbale in base component

* tailwind updates to yubikey two factor settings

* fixing imports

* remove disable dialog when keys are null to use the error toast

* PM-2060 Addressed the review comments and fixed conflicts

* Removed super.enable removed extra emitter from component class.

* fixing adding multiple keys in one session of a dialog.

* removed thrown error

---------

Co-authored-by: Ike Kottlowski <ikottlowski@bitwarden.com>
Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com>
2024-07-10 10:56:52 -07:00
Conner Turnbull
e4c7efba12
Resolved circular dependency with UpdateLicenseDialogResult enum (#10056) 2024-07-10 13:34:51 -04:00
Nick Krantz
c7d64cfc25
filter out deleted ciphers in popup service (#10035) 2024-07-10 11:44:53 -05:00
Jason Ng
91294e9c4d
[PM-8527] Identity Add Edit Browser V2 (#10016)
* Add Identity Edit Section for Browser V2 Edit Work
2024-07-10 12:25:20 -04:00
Nick Krantz
aa57260756
add testids for visibility buttons on edit card (#10021) 2024-07-10 10:42:28 -05:00
Daniel James Smith
33de685b40
[PM-5165][PM-8645] Migrate password strength component (#9912)
* Create standalone password-strength-v2 component

* Add deprecation notice to old component

* PM-8645: Use new password-strength component on export

* Remove unneccessary variable

* Remove setPasswordScoreText method

* Rename passwordStrengthResult to passwordStrengthScore and assign proper type

* Add missing types

* Document component Inputs/Outputs

* Add unit tests

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-07-10 16:59:17 +02:00
KiruthigaManivannan
f446c3b454
PM-8545 Defect Upload License Dialog should close after file upload (#9871)
* PM-8545 Defect Upload License Dialog should close after file upload

* Resolve the validation message issue (#10033)

---------

Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com>
2024-07-10 15:40:18 +01:00
Bernd Schoolmann
3d5c0a9b97
Set loading indicator on automatic sso flow (#10028) 2024-07-10 15:57:02 +02:00
Jason Ng
6d6785297b
[PM-7161] browser v2 view container (#9723)
* Build new view-v2 component and reusable view sections. Custom Fields, Item Details, Attachments, Additional Info,  Item History
2024-07-10 00:11:51 -04:00
Oscar Hinton
7dfef8991c
[PM-1935] Migrate vault lock screen to component library (#6237)
* Migrate vault lock screen to component library

* Remove unnecessary divs

* Remove card from trial

* Migrate to standalone component

* refactor to use AnonLayout

* revert login component

* migrate web component to bitSubmit

* remove class

* use inject

* update web pageTitle translation

* validate on submit, not on blur

---------

Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>
2024-07-09 17:19:12 -07:00
Conner Turnbull
a87b5adb80
Added missing i18n key for "sponsored" (#10039) 2024-07-09 16:38:25 -04:00
Will Martin
964438ff1b
[DS] add deprecation comment to ApiActionDirective (#10041) 2024-07-09 16:31:03 -04:00
Merissa Weinstein
64ad336d28
remove erorr console log and add error toast (#10018) 2024-07-09 15:06:36 -05:00
Shane Melton
2fe07f3d8e
[PM-9619] Fix broken vault upon saving empty URI (#10037)
* [PM-9619] Add null check for URI before validating checksum

* [PM-9619] Prevent saving empty string login URIs
2024-07-09 10:48:46 -07:00
aj-rosado
0e2c486a38
[AC-2509] add member access component (#9411)
* Added new report card and FeatureFlag for MemberAccessReport

* Add new "isEnterpriseOrgGuard"

* Add member access icon

* Show upgrade organization dialog for enterprise on member access report click

* verify member access featureflag on enterprise org guard

* add comment with TODO information for follow up task

* Initial member access report component

* Improved readability, removed path to wrong component and refactored buildReports to use the productType

* finished MemberAccessReport layout and added temporary service to provide mock data

* Moved member-access-report files to bitwarden_license/
Removed unnecessary files

* Added new tools path on bitwarden_license to the CODEOWNERS file

* added member access description to the messages.json

* layout changes to member access report

* Created new reports-routing under bitwarden_license
Moved member-access-report files to corresponding subfolder

* Added search logic

* Removed routing from member-access-report BL component on OSS.
Added member-access-report navigation to organizations-routing on BL

* removed unnecessary ng-container

* Added OrganizationPermissionsGuard and canAccessReports validation to member-access-report navigation

* replaced deprecated search code with searchControl

* Address PR feedback

* removed unnecessary canAccessReports method
2024-07-09 18:36:18 +01:00