1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-09-17 02:34:47 +02:00
Commit Graph

7202 Commits

Author SHA1 Message Date
Addison Beck
ff7dd4ad8f
[bug] Don't monitor vault timeout action valueChanges until after init (#1271) 2022-01-26 09:33:37 -05:00
Addison Beck
9271ec37b9
[bug] Ensure remembering email always happens for desktop (#1269)
* [bug] Ensure remembering email always happens for desktop

* update jslib
2022-01-25 19:00:49 +01:00
Addison Beck
d80fdc8a78
Adjust an iterator used to check for locked vaults on reloadProcess (#1268) 2022-01-25 09:49:57 -05:00
Addison Beck
555ee1c230
[bug] Checkout all vaults before reloading process (#1267) 2022-01-25 09:36:30 -05:00
Daniel James Smith
aa8fe04a28
[UX] Change menu items for unauthed and locked vault (#2285)
* Change menu items for unauthed and locked vault

* Use 'Log in' instead of 'Login'
2022-01-25 08:17:01 +01:00
Daniel James Smith
71913a5eb5
Update badge number when saving a new entry (#2284)
* Rename message to changePasswordMessage

* Rename message variable to addLoginMessage

* Add early return and remove unneeded if below

* Update badge and menu after adding an entry

* Adjusted casing of enum properties

* Add explicit check for queueMessageType

* Turn NotificationQueueMessageType into simple enum
2022-01-25 08:16:36 +01:00
Addison Beck
c458b4d8a9
[bug] Move enableBrowserIntegration to global settings (#1265)
* [bug] Move enableBrowserIntegration to global settings

* [style] Ran prettier

* [chore] Update jslib
2022-01-24 11:35:24 -05:00
Oscar Hinton
7d46e5c145
Add explicit init to native messaging service (#1262) 2022-01-24 16:10:32 +01:00
Addison Beck
ca41cdf8b5
[chore] Update jslib (#1264) 2022-01-24 08:45:35 -05:00
Addison Beck
d211b3fcd2
Unset active account when adding additional accounts (#1258) 2022-01-24 07:28:39 -05:00
Addison Beck
ef48ba1ae2
[bug] Correct DI setup for SystemService (#1257)
The DI refactor created a bad initlizer for SystemService that left out the reload callback.
This callback is null in prod, so I just set up a factory initlizer that used null for the callback value.

This fixes a bug causing clipboard clearing to not function, as platformUtilsService was not correctly injected.
2022-01-22 15:24:12 -05:00
Robyn MacCallum
07a3a1ea06
Merge pull request #2282 from bitwarden/beeep/remove-sad-faces
Replace sad face with searching image
2022-01-21 14:37:45 -05:00
Robyn MacCallum
33704b016f
Beeep/remove sad faces (#1255)
* Replace sad face with searching image

* Change css variable name

* Added aria-hidden="true" to images

* Run prettier
2022-01-21 14:37:28 -05:00
Oscar Hinton
a64273f829
Hide account switcher border if no accounts (#1254) 2022-01-21 17:57:09 +01:00
Matt Gibson
21e8db9636
Create testing framework for CLI (#453)
* Create testing framework for CLI

- Need to add tsconfig for specs to convert module format and add spec
dir to output
- Use jasmine-ts to test

expected dev cycle would be to have two watchers, one for jslib
and one for CLI tests. We could add jslib tests to this jasmine config,
but it feels wrong to test a submodule

* Run prettier

* Add tests to build pipeline

* Include required package

* Add placeholder test

* Run prettier

* Add nodemon and fix watch
2022-01-21 10:28:36 -06:00
Robyn MacCallum
4d63769d42 Run prettier 2022-01-21 11:23:01 -05:00
Robyn MacCallum
5c4bcf86a7 Added aria-hidden="true" 2022-01-21 11:21:23 -05:00
Robyn MacCallum
879b983818 Replace sad face with searching image 2022-01-21 10:31:01 -05:00
Daniel James Smith
cb4e6debf3
Fix display of account limit (#1253) 2022-01-21 14:15:24 +01:00
github-actions[bot]
f0dc5aa458
Autosync the updated translations (#2278)
Co-authored-by: github-actions <>
2022-01-21 11:52:06 +01:00
github-actions[bot]
2e7f8a127d
Autosync the updated translations (#1250)
Co-authored-by: github-actions <>
2022-01-21 11:51:41 +01:00
Thomas Rittson
c6eaf3a31e
Move KeyConnector call from client to syncService (#1252) 2022-01-21 19:32:44 +10:00
Daniel James Smith
37b03b09a1
[Account Switching] Design changes to settings menu (#1244)
* Design changes to settings menu

* Remove black border on settings headers

* Pull in jslib

* Only load account related settings when authed

* Hide account related settings when not authed

* Change settings titles

* Changes discussed with Danielle
2022-01-20 22:56:15 +01:00
Thomas Rittson
8b650666c5
Fix migration to Key Connector (#452)
* Move Key Connector check to subclass

* Move authService.logout call to main program

* Move Key Connector migration check to unlock command

* Use get/setConvertAccountRequired flag

* Move Key Connector convert to own command, set usesKeyConnector after conversion

* Remove KC conversion check from syncCommand, fix callback

* Make class service private

* Fix naming convention

* Update jslib and deps
2022-01-21 06:03:37 +10:00
Oscar Hinton
d1c01a2bb0
Remove account switching border (#1249) 2022-01-20 17:15:29 +01:00
Oscar Hinton
0edee78da1
Change account switching dropdown to align with the right side (#1248) 2022-01-20 16:32:05 +01:00
Addison Beck
80c9196e44
[chore] Update jslib (#1247) 2022-01-20 09:26:24 -05:00
Addison Beck
032d2be990
[bug] Remove old mac-bar styling (#1246)
With the account switching work a header was added to the desktop app that new acts as a home for the mac window controls.
Previously we needed a special home for these controls, but since moving them we are not just creating empty space.
Removing this class and the divs that use it corrects the behavior.
2022-01-20 07:44:20 -05:00
Daniel James Smith
a684c102d7
Bump electron from 16.0.2 to 16.0.7 (#1243)
* Pull jslib to bump electron from 16.0.2 to 16.0.7

* Updates to package-lock.json
2022-01-20 12:22:22 +01:00
Daniel James Smith
12bb8b060c
[Account switching] Design changes (#1240)
* Various design changes to the account switcher

* Hide serverUrl on cloud accounts

* Display account limit reached instead of add account
2022-01-19 17:03:34 +01:00
Addison Beck
b796fe094f
[Bug] [Account Switching] Improve State Management Performance (#1237)
* [dep] Implement new StateService factory parameter from jslib

* [bug] Ensure setLastActive uses the correct userId

Sometimes, because of how often it fires, setLastActive can cause accounts to override each other. To make sure the correct userId is always used we now subscribe to activeUser in the appComponent and pass that value into any setLastActive calls.

* [bug] Show loader when logging out

When logging out of a large vault the application can appear to hang. This commit turns on the app component loader while logout is doing work.

* [bug] Stop tracking activity without an active user

* [style] Ran prettier

* [chore] Update jslib
2022-01-19 11:00:28 -05:00
Kyle Spearrin
922cd1dc54
serve command (#451) 2022-01-19 10:45:14 -05:00
Thomas Rittson
84a0bfb07c
Update jslib (#449) 2022-01-19 07:05:48 +10:00
Daniel James Smith
8b521aa35e
[Account switching] Hide active account (#1241)
* Hide active account from dropdown

* No longer need to check if selected account is active before switching

* Applied feedback from PR review
2022-01-18 21:43:14 +01:00
Vince Grassia
ab7fda888f
Update Version Bump action to latest (#2271) 2022-01-18 10:31:10 -05:00
Oscar Hinton
3cacf8a8c4
Rename package to @bitwarden/desktop (#1242) 2022-01-18 14:04:21 +01:00
Oscar Hinton
31e433a49b
Rename package to @bitwarden/browser (#2274) 2022-01-17 17:26:35 +01:00
Andrew Marquez
3f4032011a
Send deletedCipher message to messagingService to refresh badge and menu. Fixes #1708 (#2244) 2022-01-17 16:25:32 +01:00
Vince Grassia
dad1a95fb0
Update Version Bump action to latest (#1238) 2022-01-14 13:32:16 -05:00
Vince Grassia
b6c8307437
Update Version Bump action to latest (#445) 2022-01-14 12:38:38 -05:00
github-actions[bot]
5b6e5fc4fa
Autosync the updated translations (#1236)
Co-authored-by: github-actions <>
2022-01-14 11:21:53 +01:00
github-actions[bot]
c88f9a4140
Autosync the updated translations (#2268)
Co-authored-by: github-actions <>
2022-01-14 11:21:28 +01:00
Oscar Hinton
4644d03b28
Exclude dist-safari from prettier (#1234) 2022-01-13 18:10:59 +01:00
Matt Gibson
3b1ccb409e
Fix/lowdb no cache (#443)
* Add jslib prettier commit to client ignore hashes

* Remove lowdb caching

* Fix state service remove being set to null

* Await in-memory key retrieval

* Fix key loading and unlock requests.

* Linter fixes

* linter fixes

* linter fixes
2022-01-13 11:03:19 -06:00
Daniel James Smith
abede3e5af
Fix logging out of all accounts instead of one (#1231)
When logOut is triggered and the userId is not provided. Retrieve currentUserId
2022-01-13 15:43:00 +01:00
Daniel James Smith
7818ffc2fb
[Account Switching] Fix menus (#1232)
* Fix enabled/disabling menu items with locked state

* Fix the empty about menu (title)

Moved the items to the help menu
2022-01-13 14:29:49 +01:00
Oscar Hinton
b6117d6801
Re-add native dependencies to src/package.json (#1233) 2022-01-13 10:46:33 +01:00
Thomas Rittson
b962af303a
Fix always logging out instead of lock (#444) 2022-01-13 17:35:48 +10:00
Addison Beck
653ff8f45f
[Bug] VaultTimeout incorrectly defaults to "Never" (#1230)
* [Bug] VaultTimeout incorrectly defaults to "Never"

The default desktop vault timeout value is "On Restart", but there is no default set for this in the state service and account model.
This commit extends the StateService and Account model to consider the special vault timeout default requirements needed for desktop.

* [style] Lint fixes

* [chore] Update jslib
2022-01-12 11:37:23 -05:00
Daniel James Smith
71c2fee574
Close opened AccountSwitcher dropdown (#1228)
When a user clicks outside of an opened account switching dropdown, it should close automatically when clicking outside of the dropdown.
2022-01-12 17:20:19 +01:00