1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-28 12:45:45 +01:00
Commit Graph

12846 Commits

Author SHA1 Message Date
Will Martin
54411ea84f
[SM-613] Misc Onboarding UX fixes (#4953)
* make dismiss always visible

* reorder tasks; hide create secret task if no projects

* update stories
2023-03-08 16:01:45 -05:00
cd-bitwarden
6971c3dca2
[SM-401] Adding the ability to edit service account name (#4845)
* Adding the ability to edit service account name

* Update bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/service-accounts-list.component.html

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Suggested Updates

* removing unecessary messages

* Adding back messages.json entry, updating API Call

* fix

* Update bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/service-account.service.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/models/requests/service-account-update.request.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/dialog/service-account-dialog.component.ts

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Fixing endpoints after Server side change

* changes

* updates

* adding loading notification

* adding description to message

* Update bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/service-accounts-list.component.html

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Thomas's suggested changes

* reorder list

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2023-03-08 15:50:23 -05:00
Will Martin
da9210b551
[SM-608] update SM marketing link in product-switcher (#4950) 2023-03-08 14:48:22 -05:00
Andreas Coroiu
c223567cae
[AC-1078] feat: do not block client org creating (#4899)
Single org policy shouldn't not block provider from creating client organizations
2023-03-08 08:28:58 +01:00
Thomas Avery
720b61076a
[SM-611] Fix edit dialog & overview secrets refresh (#4951)
* Fix edit dialog

* Have secrets list refresh during project deletion

* Fix input required for init edit

* Fixing delete prompt for edit dialog
2023-03-07 17:59:52 -06:00
SmithThe4th
85cd419d5c
Added extra check to know if an organization is free (#4905) 2023-03-07 17:25:33 -05:00
cd-bitwarden
1d01bfbb61
[SM-249] Adding detailed description of which secrets are unable to be deleted (#4849)
* Adding detailed description of which secrets are unable to be deleted

* removing accidental change

* removing Can write from Service Account options

* suggested PR changes

* thomas's suggested changes

* fixing merge conflicts after merging in master
2023-03-07 15:33:39 -05:00
Will Martin
9d4d340930
[SM-607] fix BitIcon innerHTML rerender removing click handler (#4949)
* remove innerHTML getter; update tests

* remove template; use hostbinding
2023-03-07 14:31:38 -05:00
Will Martin
0ff3c679c9
[SM-537] add local storage persistence for onboarding tasks (#4880)
* add local storage check for tasks

* associate saved tasks with organization ID

* remove redundant parenthesis

* revert last commit

* add falsy check

* use distinctUntilChanged

* remove extra observable

* apply code review
2023-03-07 14:03:51 -05:00
mimartin12
e153105774
[DEVOPS-1273] - Switch to Unix utility, shasum (#4945) 2023-03-07 11:57:12 -07:00
Josh Richards
d7a94c140f
[PM-1165] Handle personal API login errors [cli] (#4866)
* Handle personal API login errors [cli]

* Revert misguided generic error handling tweak

* Only handle invalid_client errors

Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>

* Typo fix

---------

Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
2023-03-07 13:53:28 -05:00
Matt Gibson
a16d02b39d
Auth/ps 2465 fix knowndevices path (#4710)
* PS-2450 EC-1073 Do not decode and normalize query

Co-authored-by: Jake Fink <jfink@bitwarden.com>

* Use encoded query parameters over path

* Prefer POST for requests with sensitive information

* Send private information in headers over query

* B64 encode email

---------

Co-authored-by: Jake Fink <jfink@bitwarden.com>
2023-03-07 12:49:12 -06:00
Will Martin
6876aad883
[SM-586] add search to Service Accounts list (#4923) 2023-03-07 10:25:59 -05:00
Oscar Hinton
4f64ac87de
[SM-605] Remove access from create service account (#4946) 2023-03-07 14:27:50 +01:00
Oscar Hinton
f2276227aa
[SM-579] Prevent creating secret without project (#4892)
* Change project select to simple dropdown

* Handle null
2023-03-07 10:14:14 +01:00
Thomas Rittson
9fe79afa13
Update button copy in user subscription page (#4819) 2023-03-07 13:30:30 +10:00
Colton Hurst
12fe2b693c
SM-569: Update import/export format to Bitwarden (json) (#4944) 2023-03-06 17:21:17 -05:00
Colton Hurst
75965e6408
SM-585: Add ability to do table sort for service account list (#4943) 2023-03-06 15:40:47 -05:00
Oscar Hinton
fbd0d41b51
[SM-568] Delete service accounts (#4881) 2023-03-06 20:25:06 +01:00
Thomas Avery
c711312fee
[SM-581] User access removal warnings (#4904)
* init refactor

* Fix current user access checks

* Add in warning dialogs that are aware of other APs

* cleanup handlers; refresh sa list on removal

* Code review updates

* [SM-580] Add warning dialog for Service account People tab (#4893)

* Add warning dialog from figma

* move dialog out of access selector component; add after delete event; remove people-sa logic

* remove commented code and unused service

* Updates to work with SM-581

---------

Co-authored-by: William Martin <contact@willmartian.com>

---------

Co-authored-by: William Martin <contact@willmartian.com>
2023-03-06 11:32:02 -06:00
github-actions[bot]
f717c3d619
Autosync the updated translations (#4916)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-03-06 12:47:52 +01:00
github-actions[bot]
6784c883f0
Autosync the updated translations (#4917)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-03-06 11:32:42 +01:00
github-actions[bot]
f674ce62f0
Autosync the updated translations (#4918)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-03-06 11:31:25 +01:00
Andreas Coroiu
ea6666780a
[EC-775] [Technical Dependency] Refactor Vault Filters to be routable (#4733)
* [EC-775] feat: add compatibility layer from #4154

* [EC-775] fix: ciphers not reloading on filter change

* [EC-775] feat: add support for cipher types

* [EC-775] feat: implement organization switching

* [EC-775] feat: remove invalid folder and collection checks

Had to remove these becuase they were causing double navigations on each click.

* [EC-775] fix: fix reverse data flow race condition

vault-filter.component was pushing up old filter models which would sometimes overwrite new filter models that came from the routed filter service.

* [EC-775] fix: No folder use-case not working

* [EC-775] feat: make navigation behave like master

* [EC-775] feat: add support for trash

* [EC-775] chore: simplify findNode

* [EC-775] feat: add support for org vault

* [EC-775] feat: add support for orgId in path

* [EC-775] feat: use proper treenode constructor

* [EC-775] chore: remove unnecessary variable

* [EC-775] docs: add docs to relevant classes

* [EC-775] chore: use existing function for searching tree

* [EC-775] fix: hide "new" button in trash view

* [EC-775] feat: add explicit handling for `AllItems`

* [EC-775] fix: prune folderId when changing organization

* [EC-775] fix: properly use `undefined` instead of `null`

* [EC-775] chore: simplify setters using ternary operator

* [EC-775] feat: add static typing to `type` filter

* [EC-775] feat: use new `All` variable for collections

* [EC-775] feat: return `RouterLink` compatible link from `createRoute`

* [EC-775] feat: add ordId path support to `createRoute`

* [EC-775] fix: interpret params differently in org vault

This is needed due to how defaults used to work when using `state-in-code`. We really want to get rid of this type of logic going forward.

* [EC-775] doc: clarify `createRoute`

* [EC-775] fix: better `type` typing

* [EC-775] feat: remove support for path navigation

It's better that we circle back to this type of navigationt when we're working on the VVR and have more knowledge about how this is supposed to work.

* [EC-775] fix: refactor bridge service to improve readability

Refactor follows feedback from PR review
2023-03-06 08:34:13 +01:00
Will Martin
ae271b5c16
sort access select items (#4922) 2023-03-03 15:44:57 -06:00
Oscar Hinton
7736a981e7
[SM-589][SM-592] Remove router reuse hack (#4913)
* Remove router reuse hack

* Add AuthGuard

* Change to distinctUntilChanged

* Extract show logic
2023-03-03 15:28:59 +01:00
Will Martin
2b95c786d8
[SM-595] add project sort to secrets list (#4914) 2023-03-03 09:00:20 -05:00
Thomas Rittson
04d1fbb716
[AC-1084] Don't copy hidden spaces when selecting password (#4848)
* Don't copy hidden spaces when selecting password

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* [AC-1084] fix: remove whitespaces from inline component

---------

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
2023-03-03 08:15:23 +01:00
Jake Fink
c7a71dc22e
[AC-1108] add correct formControlName (#4891) 2023-03-02 20:02:05 -05:00
Thomas Rittson
f7618e180a
Fix duplicate success toast on license upload (#4820) 2023-03-03 10:14:25 +10:00
Todd Martin
a02f9e3a14
Modified job to only fire when opened or target edited. (#4915) 2023-03-02 18:37:41 -05:00
Colton Hurst
bb9def116a
SM-591: Update dropdown if is secrets list for trash (#4903) 2023-03-02 17:27:48 -05:00
Jared Snider
65bedf8d26
Use page header for 2FA setup comp on org settings page to match other org settings pages but use tabbed header class on user account settings > security > Two-step login tab. (#4890) 2023-03-02 14:42:11 -05:00
Colton Hurst
f80e9cfafd
SM-534: Update delete project toast text (#4902) 2023-03-02 10:12:34 -05:00
Thomas Avery
5f05f73626
[SM-572] Hide Project's People and Service accounts tabs based on permission (#4885)
* Hide tabs based on permission

* Swap to a new endpoint

* Swap to different server implementation

* Swap to server's ProjectPermissionDetails

* remove async

* remove write access observable

* Fix mac decrypt error
2023-03-02 09:02:48 -06:00
Daniel James Smith
5cc73d41d9
PS-2210: Disable Stripe's advanced fraud signals (#4424) 2023-03-02 15:15:45 +01:00
Will Martin
fa1a779b63
[SM-582] update sm logo (#4896)
* update logo

* update layout stories

* remove unused logo; optimize svg
2023-03-02 09:14:29 -05:00
Will Martin
bb36184256
[SM-552] make string sort in TableDataSource case insensitive (#4889)
* make string sort case insensitive

* use localeCompare
2023-03-01 14:41:56 -05:00
Maximilian Power
ce6c975dd9
[SM-489] Added descriptions for all SM related strings (#4692)
* added descriptions for all SM related strings

* rm trailing comma

* Updated descriptions based on feedback

* Update messages.json

* Update messages.json

* Reorder prompts

---------

Co-authored-by: maxkpower <mpower@bitwarden.com>
Co-authored-by: patrick-bitwarden <pbehforrest@bitwarden.com>
Co-authored-by: Patrick <94560851+patrick-bitwarden@users.noreply.github.com>
2023-03-01 11:49:36 -05:00
Will Martin
743f4f8c69
[SM-529] fix directive typo (#4894) 2023-03-01 11:48:39 -05:00
Colton Hurst
667d3fccc2
SM-528: Fix SM Import / Export Error Messaging (#4833)
* SM-528: Remove try catch to use default error handling

* SM-528: Add admin check on import / export

* SM-528: Hide settings nav section unless admin

* SM-528: Refactor observable in navigation component

* SM-528: Hide SM Trash from nav menu if not admin

* SM-528: clean up navigation.component.ts
2023-03-01 09:39:32 -05:00
cd-bitwarden
abbfb0696f
removing Write only (#4884) 2023-02-28 18:15:39 -05:00
Todd Martin
1e7d83c0c8
Fixed syntax on types (#4886) 2023-02-28 10:55:16 -05:00
Oscar Hinton
6348269a1a
[SM-352] Projects tab for service accounts (#4858)
* Init service layer changes

* refactor service to inherit abstract

* refactor access-selector component

* update access selector in projects

* add service accounts access selector

* update i18n

* fix delete action; use useExisting in providers

* update static permissions

* service account people should be readwrite on creation

* use setter instead of observable input

* remove warning callout

* remove abstract service

* truncate name in table

* remove extra comments

* Add projects access policy page

* Add locale

* use map instead of forEach

* refactor view factories

* update SA people copy

* map list responses

* Swap to using granted policies endpoints

* Remove text-xl from icon

---------

Co-authored-by: Thomas Avery <tavery@bitwarden.com>
Co-authored-by: William Martin <contact@willmartian.com>
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2023-02-28 09:31:19 -06:00
Will Martin
4e112573f5
[SM-520] add secret copy actions (#4887) 2023-02-28 09:29:04 -05:00
Brandon Maharaj
6adcb35dd7
fix: missing changes (#4832) 2023-02-28 02:04:41 -05:00
Jake Fink
c160827272
[EC-859] update billing routes for owners of Managed orgs (#4611)
* [EC-859] update billing routes for owners of Managed orgs

* [EC-859] fix observable in billing tab

* [EC-859] update observable name

* [EC-859] update reporting and settings observables

* [EC-859] add startsWith to reporting observable

* [EC-859] async pipe once in settings

* [EC-859] create get$ in org service

* [EC-859] transition remaining components

* [EC-859] add as org to template

* [EC-859] add shareReplay to observable to prevent multicasting
- future proof get$ on org service

* [AC-859] fix missed org
2023-02-27 16:31:55 -05:00
Will Martin
ff89d86d40
[SM-571] reenable route reuse on destroy (#4883) 2023-02-27 14:46:05 -05:00
Robyn MacCallum
3e03c95a10
Add a11y check to PR template (#4882) 2023-02-27 14:21:28 -05:00
Todd Martin
06a3237729
Add workflow to apply needs-qa label (#4727)
* Added new workflow

* Fixed quotes.

* Added step to job.

* Added check for PR destination branch.

* Changed criteria.

* Added fork check for community PRs.

* Removed space

* Changed name.

* Updated with more filters.

* Changed to target approval for adding the label.

* Lint

* Refactored to use pull_request_target instead.

* Fixed comment

* pull_request_target isn't supported, so pull_request instead

* Added comment about target branch.
2023-02-27 13:19:24 -05:00