1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-09-29 04:17:41 +02:00
bitwarden-browser/apps
Patrick H. Lauke 22a138a46f
[PM-2432] Desktop: Modify switch account dropdown/dialog for accessibility (#5529)
* Tweak account switcher button

- if it opens a dialog, it should advertise this with `aria-haspopup="dialog"`, not `aria-haspopup="menu"`
- if it opens a dialog, the `aria-expanded` is pointless (as the user will never get back out into the underlying page to check if it's expanded or collapsed, since it's for a dialog not a disclosure widget or menu)

* Make two variants for button to sort out `aria-label` on logged-in case

* Remove `aria-controls` for button

as it's a dialog that opens, not a disclosure, this is irrelevant

* Fix `overlayPostition` typo

* Simplify approach

just use existing single button, but add visually hidden extra "Switch account" to accName

* Tweak account switch buttons in dialog/dropdown

* Take out the confusing "Logged in as..." a11y text
* Use visible button text (with a few extra `sr-only` parts, for readability) as the button's accName
* Add the "Switch account" context to each of the buttons to make clear what they do
2023-10-31 10:55:43 -07:00
..
browser send to webVault url (#6557) 2023-10-31 08:57:50 -07:00
cli [PM-4360] Move organization-domain and organization-user to admin console (#6630) 2023-10-30 22:32:57 +01:00
desktop [PM-2432] Desktop: Modify switch account dropdown/dialog for accessibility (#5529) 2023-10-31 10:55:43 -07:00
web [PM-105] Premium Badge Send File (#6684) 2023-10-31 13:52:24 -04:00