mirror of
https://github.com/bitwarden/browser.git
synced 2024-09-14 02:08:50 +02:00
The browser extension vault (Chrome, Firefox, Opera, Edge, Safari, & more).
57351d29a2
Currently the StateMigrationService depends on a userId key for running migrations, but if there is not an authenticated user saved to storage that userId is not present. These changes allow for migrating state data even without an active user. For account specific settings like clearClipboard we now temporarily store those values together in disk state until an account is authed that they can be added to. Temp account state is then cleared. Some notes: * In order for this to work we need GlobalState.stateVersion to have a default value of StateVersion.One instead of StateVersion.Latest. Defaulting it to latest was causing migrations to not run on some clients (like desktop) that try to access storage before migrations have been run but save a version as if migrations did run. * I also noticed we aren't clearing old state items from before migrating, and added a case for this to the migrator. * I extracted a few bits of reused code into private methods in the stateMigration service. Things like get/set from storage, default options, etc. |
||
|---|---|---|
| .github | ||
| .husky | ||
| .vscode | ||
| angular | ||
| common | ||
| electron | ||
| node | ||
| shared | ||
| spec | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .prettierignore | ||
| .prettierrc.json | ||
| CONTRIBUTING.md | ||
| LICENSE.txt | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| SECURITY.md | ||
| tsconfig.json | ||
| tslint.json | ||
Bitwarden JavaScript Library
Common code referenced across Bitwarden JavaScript projects.
Requirements
- Node.js v16.13.1 or greater
- NPM v8
- Git
- node-gyp
Windows
- Microsoft Build Tools 2015 in Visual Studio Installer
- Windows 10 SDK 17134 either by downloading it seperately or through the Visual Studio Installer.
Prettier
We recently migrated to using Prettier as code formatter. All previous branches will need to updated to avoid large merge conflicts using the following steps:
- Check out your local Branch
- Run
git merge 8b2dfc6cdcb8ff5b604364c2ea6d343473aee7cd - Resolve any merge conflicts, commit.
- Run
npm run prettier - Commit
- Run
git merge -Xours 193434461dbd9c48fe5dcbad95693470aec422ac - Push
Git blame
We also recommend that you configure git to ignore the prettier revision using:
git config blame.ignoreRevsFile .git-blame-ignore-revs