1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-21 16:18:28 +01:00
bitwarden-browser/apps
Robyn MacCallum 671a9115bb
[PM-1400] Update IconComponent to use OnPush ChangeDetection (#5181)
* Add disableFavicon$ to stateService

* Change IconComponent's ChangeDetectionStrategy and use disableFavicon$ observable

* Only get first result from disableFavicon observable

* Move disabledFavicon$ to SettingsService

* Update usage of disableFavicon to use SettingsService

* Remove getting and setting of disabledFavicon on login

* Settings service observable adjustments

* Fix for popup initially having a null value for the disableFavicon setting in settingsService

* Move disabledFavicon$ subscription to ngOnInit

* feat: experiment with observables

* Remove SettingsService from browser app component

* Fix storybook changes

* Update apps/web/src/app/vault/components/vault-items/vault-items.stories.ts

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* Fix mock function signature

---------

Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
2023-04-28 15:07:26 -04:00
..
browser [PM-1400] Update IconComponent to use OnPush ChangeDetection (#5181) 2023-04-28 15:07:26 -04:00
cli [PM-1267] Updated cli receive command to use api.bitwarden.com as api url (#5239) 2023-04-27 16:36:54 +01:00
desktop [PM-1400] Update IconComponent to use OnPush ChangeDetection (#5181) 2023-04-28 15:07:26 -04:00
web [PM-1400] Update IconComponent to use OnPush ChangeDetection (#5181) 2023-04-28 15:07:26 -04:00