Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-04 23:31:28 +01:00
Code Issues Projects Releases Wiki Activity
The browser extension vault (Chrome, Firefox, Opera, Edge, Safari, & more).
1,501 Commits 800 Branches 481 Tags 858 MiB
TypeScript 81.8%
HTML 12.6%
SCSS 2.3%
JavaScript 1.6%
MDX 0.9%
Other 0.7%
92a65b7b36
Go to file
Addison Beck 92a65b7b36
[bug] Allow for GlobalState to be extended and modified in clients (#646) 
Some clients have unique global setting defaults (and unique global settings)
For example: the web vault defaults to light theme, but most clients with theme support default to system theme.

The current way we handle GlobalState is buried in jslib and not easily extendible in clients.

To fix this, we need to treat GlobalState as a generic in the StateService and StateMigration service and allow for its extension in those methods and anywhere GlobalState is inited.
2022-01-31 14:33:31 -05:00
.github Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
.husky Add Prettier configuration (#574) 2021-12-16 12:45:01 +01:00
.vscode Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
angular [bug] Allow for GlobalState to be extended and modified in clients (#646) 2022-01-31 14:33:31 -05:00
common [bug] Allow for GlobalState to be extended and modified in clients (#646) 2022-01-31 14:33:31 -05:00
electron [bug] Properly define stored window state (#638) 2022-01-27 10:44:09 -05:00
node Fix migration to Key Connector in cli commands (#616) 2022-01-20 19:28:48 +10:00
shared Add a shared tsconfig file (#609) 2022-01-17 13:21:20 +01:00
spec BEEEP: Add importer for Keeper in json format (#608) 2022-01-26 23:04:55 +01:00
.editorconfig Add Prettier configuration (#574) 2021-12-16 12:45:01 +01:00
.git-blame-ignore-revs Add .git-blame-ignore-revs and prettier instructions (#585) 2021-12-16 14:10:11 +01:00
.gitattributes Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
.gitignore setup karma testing 2018-04-17 16:15:19 -04:00
.prettierignore Fix prettier (#598) 2022-01-07 14:23:42 +01:00
.prettierrc.json Add Prettier configuration (#574) 2021-12-16 12:45:01 +01:00
CONTRIBUTING.md Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
LICENSE.txt license and contrib 2018-01-26 16:07:38 -05:00
package-lock.json Use node-ts and jasmine-ts to run tests (#621) 2022-01-20 14:07:13 -06:00
package.json watch ts files and source directly (#623) 2022-01-21 10:11:00 -06:00
README.md Update README.md (#586) 2021-12-16 14:38:11 +01:00
SECURITY.md Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
tsconfig.json Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
tslint.json Apply Prettier (#581) 2021-12-16 13:36:21 +01:00

README.md

Github Workflow build on master

Bitwarden JavaScript Library

Common code referenced across Bitwarden JavaScript projects.

Requirements

  • Node.js v16.13.1 or greater
  • NPM v8
  • Git
  • node-gyp

Windows

  • Microsoft Build Tools 2015 in Visual Studio Installer
  • Windows 10 SDK 17134 either by downloading it seperately or through the Visual Studio Installer.

Prettier

We recently migrated to using Prettier as code formatter. All previous branches will need to updated to avoid large merge conflicts using the following steps:

  1. Check out your local Branch
  2. Run git merge 8b2dfc6cdcb8ff5b604364c2ea6d343473aee7cd
  3. Resolve any merge conflicts, commit.
  4. Run npm run prettier
  5. Commit
  6. Run git merge -Xours 193434461dbd9c48fe5dcbad95693470aec422ac
  7. Push

Git blame

We also recommend that you configure git to ignore the prettier revision using:

git config blame.ignoreRevsFile .git-blame-ignore-revs