Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-23 15:29:29 +01:00
Code Issues Projects Releases Wiki Activity
The browser extension vault (Chrome, Firefox, Opera, Edge, Safari, & more).
1,536 Commits 881 Branches 497 Tags 888 MiB
TypeScript 81.8%
HTML 12.6%
SCSS 2.3%
JavaScript 1.6%
MDX 0.9%
Other 0.7%
a6092916d8
Go to file
Addison Beck a6092916d8
[bug] Persistantly store collapsedGroupings (#686) 
Collapsed groupings have regressed to not maintaining their state through restarting clients.

The state mangement refactor erroniously began saving this field to memory instead of disk, but there were some other issues that changing this brought on that are also fixed in this commit.

Changes:
1. Save collapsedGroupings persistantly in StateService
2. Adjust the type of collapsedGroupings on the Account model from a Set<string> to a string[]
	* This is the way we were storing this value in previous releases, and saving the entire set object breaks.
3. Adjust the StateService getter/setter for collapsedGroupings to expect a string[]
4. Extract a string[] from the GroupingsComponent groupings that is a Set<string> before saving
2022-02-15 12:54:22 -05:00
.github Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
.husky Make husky pre-commit hook executable (#655) 2022-02-08 08:29:50 +10:00
.vscode Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
angular [bug] Persistantly store collapsedGroupings (#686) 2022-02-15 12:54:22 -05:00
common [bug] Persistantly store collapsedGroupings (#686) 2022-02-15 12:54:22 -05:00
electron Add headers for client type and client version (#651) 2022-02-08 11:18:10 +01:00
node [Help] Update links to new pattern (#658) 2022-02-08 17:35:29 -06:00
shared Add a shared tsconfig file (#609) 2022-01-17 13:21:20 +01:00
spec Clear stale everBeenUnlocked value from onDisk storage (#682) 2022-02-14 08:16:07 -05:00
.editorconfig Add Prettier configuration (#574) 2021-12-16 12:45:01 +01:00
.git-blame-ignore-revs Add .git-blame-ignore-revs and prettier instructions (#585) 2021-12-16 14:10:11 +01:00
.gitattributes Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
.gitignore setup karma testing 2018-04-17 16:15:19 -04:00
.prettierignore Fix prettier (#598) 2022-01-07 14:23:42 +01:00
.prettierrc.json Add Prettier configuration (#574) 2021-12-16 12:45:01 +01:00
CONTRIBUTING.md Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
LICENSE.txt license and contrib 2018-01-26 16:07:38 -05:00
package-lock.json Use node-ts and jasmine-ts to run tests (#621) 2022-01-20 14:07:13 -06:00
package.json watch ts files and source directly (#623) 2022-01-21 10:11:00 -06:00
README.md Update README.md (#586) 2021-12-16 14:38:11 +01:00
SECURITY.md Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
tsconfig.json Apply Prettier (#581) 2021-12-16 13:36:21 +01:00
tslint.json Apply Prettier (#581) 2021-12-16 13:36:21 +01:00

README.md

Github Workflow build on master

Bitwarden JavaScript Library

Common code referenced across Bitwarden JavaScript projects.

Requirements

  • Node.js v16.13.1 or greater
  • NPM v8
  • Git
  • node-gyp

Windows

  • Microsoft Build Tools 2015 in Visual Studio Installer
  • Windows 10 SDK 17134 either by downloading it seperately or through the Visual Studio Installer.

Prettier

We recently migrated to using Prettier as code formatter. All previous branches will need to updated to avoid large merge conflicts using the following steps:

  1. Check out your local Branch
  2. Run git merge 8b2dfc6cdcb8ff5b604364c2ea6d343473aee7cd
  3. Resolve any merge conflicts, commit.
  4. Run npm run prettier
  5. Commit
  6. Run git merge -Xours 193434461dbd9c48fe5dcbad95693470aec422ac
  7. Push

Git blame

We also recommend that you configure git to ignore the prettier revision using:

git config blame.ignoreRevsFile .git-blame-ignore-revs