1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-25 12:15:18 +01:00
bitwarden-browser/libs
Daniel James Smith cf2d8b266a
[PM-1071] Display import-details-dialog on successful import (#4817)
* Prefer callback over error-flow to prompt for password

Remove error-flow to request file password
Prefer callback, which has to be provided when retrieving/creating an instance.
Delete ImportError
Call BitwardenPasswordProtector for all Bitwarden json imports, as it extends BitwardenJsonImporter
Throw errors instead of returning
Return ImportResult
Fix and extend tests import.service
Replace "@fluffy-spoon/substitute" with "jest-mock-extended"

* Fix up test cases

Delete bitwarden-json-importer.spec.ts
Add test case to ensure bitwarden-json-importer.ts is called given unencrypted or account-protected files

* Move file-password-prompt into dialog-folder

* Add import success dialog

* Fix typo

* Only list the type when at least one got imported

* update copy based on design feedback

* Remove unnecessary /index import

* Remove promptForPassword_callback from interface

PR feedback from @MGibson1 that giving every importer the ability to request a password is unnecessary. Instead, we can pass the callback into the constructor for every importer that needs this functionality

* Remove unneeded import of BitwardenJsonImporter

* Fix spec constructor

* Fixed organizational import

Added an else statement, or else we'd import into an org and then also import into an individual vault
2023-04-06 22:41:09 +02:00
..
.vscode Multi root workspace tweaks (#2858) 2022-06-13 21:39:36 -05:00
angular [PM-1426] Refactor uri matching (#5003) 2023-04-06 13:30:26 +10:00
common [PM-1426] Refactor uri matching (#5003) 2023-04-06 13:30:26 +10:00
components [PM-1644] Resolve active tab using the wrong background color (#5097) 2023-03-30 21:03:42 +02:00
importer [PM-1071] Display import-details-dialog on successful import (#4817) 2023-04-06 22:41:09 +02:00
node [PS-2251] Implement argon2 kdf (#4468) 2023-01-26 09:20:12 -05:00
shared [PM-328] Move common/importer to libs/importer (tools-migration) (#5060) 2023-03-23 11:43:27 +01:00