From 2e06afcb7dfbd5ec127d835f8a3247f5dca9b682 Mon Sep 17 00:00:00 2001 From: CarleyDiaz-Bitwarden <103955722+CarleyDiaz-Bitwarden@users.noreply.github.com> Date: Mon, 2 May 2022 15:20:00 -0400 Subject: [PATCH] Making suggested changes and accounting for the NORD theme --- src/images/close-button.svg | 1 + src/images/close-white.png | Bin 311 -> 0 bytes src/scss/header.scss | 23 ++++++++++++----------- src/scss/variables.scss | 3 +++ 4 files changed, 16 insertions(+), 11 deletions(-) create mode 100644 src/images/close-button.svg delete mode 100644 src/images/close-white.png diff --git a/src/images/close-button.svg b/src/images/close-button.svg new file mode 100644 index 00000000..8aea3464 --- /dev/null +++ b/src/images/close-button.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/src/images/close-white.png b/src/images/close-white.png deleted file mode 100644 index 07c0f4e38eaf60221168ec8fe46fe60718d259f0..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 311 zcmeAS@N?(olHy`uVBq!ia0vp^{2W$ zo%EWs*+HNs*TuW@d=<-E&4hSQk1d^_XCHP>oc<@kN$gm3dU}bC{^@^liY+pC9G|x~ z=5Mb|e8!`;V3uR4$P2lehAgXdN&Gh%BtxU5c_X|h^lmdKI;Vst008J>9RL6T diff --git a/src/scss/header.scss b/src/scss/header.scss index a5adab1b..879fa60b 100644 --- a/src/scss/header.scss +++ b/src/scss/header.scss @@ -12,19 +12,20 @@ @include themify($themes) { background-color: themed("headerBackgroundColor"); border-bottom-color: themed("headerBorderColor"); - } - app-search { - grid-column-start: 2; - width: 100%; + app-search { + grid-column-start: 2; + width: 100%; - [type="search"]::-webkit-search-cancel-button { - -webkit-appearance: none; - appearance: none; - height: 15px; - width: 15px; - background-repeat: no-repeat; - background-image: url("../images/close-white.png"); + [type="search"]::-webkit-search-cancel-button { + -webkit-appearance: none; + appearance: none; + height: 15px; + width: 15px; + background-repeat: no-repeat; + background-image: url("../images/close-button.svg"); + filter: brightness(themed("svgButtonBrightness")); + } } } diff --git a/src/scss/variables.scss b/src/scss/variables.scss index 8e95667c..8a7a1c6a 100644 --- a/src/scss/variables.scss +++ b/src/scss/variables.scss @@ -93,6 +93,7 @@ $themes: ( accountSwitcherBackgroundColor: $background-color, accountSwitcherTextColor: #ffffff, svgSuffix: "-light.svg", + svgButtonBrightness: 100, ), dark: ( textColor: #ffffff, @@ -146,6 +147,7 @@ $themes: ( accountSwitcherBackgroundColor: #2f2f2f, accountSwitcherTextColor: #ffffff, svgSuffix: "-dark.svg", + svgButtonBrightness: 100, ), nord: ( textColor: $nord5, @@ -199,6 +201,7 @@ $themes: ( accountSwitcherBackgroundColor: $nord0, accountSwitcherTextColor: $nord5, svgSuffix: "-dark.svg", + svgButtonBrightness: 0.5, ), );