From 55a9403ee3142fa2188889b69f69343b7e8ed059 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Thu, 5 May 2022 15:36:46 +0100 Subject: [PATCH] [PS-540] Accessibility: remove `appBlurClick`, add `aria-expanded` to cog options, links to buttons, fix unsufficient focus indication (#1514) --- src/app/accounts/environment.component.html | 2 +- src/app/accounts/hint.component.html | 4 +-- src/app/accounts/lock.component.html | 6 ++-- src/app/accounts/login.component.html | 9 +++--- src/app/accounts/premium.component.html | 4 +-- src/app/accounts/register.component.html | 6 ++-- .../accounts/remove-password.component.html | 2 -- src/app/accounts/set-password.component.html | 2 -- src/app/accounts/two-factor.component.html | 3 +- .../update-temp-password.component.html | 4 +-- .../password-reprompt.component.html | 3 +- src/app/components/set-pin.component.html | 1 - src/app/layout/nav.component.html | 12 +++++-- src/app/send/add-edit.component.html | 7 +--- src/app/send/send.component.html | 10 +----- .../add-edit-custom-fields.component.html | 1 - src/app/vault/add-edit.component.html | 32 +++++-------------- src/app/vault/attachments.component.html | 2 -- src/app/vault/ciphers.component.html | 1 - src/app/vault/collections.component.html | 1 - src/app/vault/export.component.html | 1 - src/app/vault/folder-add-edit.component.html | 2 -- src/app/vault/generator.component.html | 2 -- src/app/vault/groupings.component.html | 18 ++--------- .../password-generator-history.component.html | 1 - src/app/vault/share.component.html | 1 - src/app/vault/view.component.html | 6 ---- src/scss/buttons.scss | 1 - src/scss/vault.scss | 18 ++++++----- 29 files changed, 47 insertions(+), 115 deletions(-) diff --git a/src/app/accounts/environment.component.html b/src/app/accounts/environment.component.html index 390efbb9..eff32641 100644 --- a/src/app/accounts/environment.component.html +++ b/src/app/accounts/environment.component.html @@ -83,7 +83,7 @@
- - {{ "cancel" | i18n }} +
diff --git a/src/app/accounts/lock.component.html b/src/app/accounts/lock.component.html index 71ac7594..f5d8b369 100644 --- a/src/app/accounts/lock.component.html +++ b/src/app/accounts/lock.component.html @@ -34,7 +34,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showPassword" (click)="togglePassword()" @@ -58,17 +57,16 @@ type="button" class="btn block" [ngClass]="{ 'primary font-weight-bold': hideInput }" - appBlurClick (click)="unlockBiometric()" > {{ biometricText | i18n }}
- -
diff --git a/src/app/accounts/login.component.html b/src/app/accounts/login.component.html index bf7830e1..4ec1307f 100644 --- a/src/app/accounts/login.component.html +++ b/src/app/accounts/login.component.html @@ -52,7 +52,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showPassword" (click)="togglePassword()" @@ -76,15 +75,15 @@
- - +
- {{ "getMasterPasswordHint" | i18n }} +
diff --git a/src/app/accounts/premium.component.html b/src/app/accounts/premium.component.html index 20859ec7..01c181da 100644 --- a/src/app/accounts/premium.component.html +++ b/src/app/accounts/premium.component.html @@ -48,14 +48,13 @@
- - {{ "cancel" | i18n }} +
diff --git a/src/app/accounts/remove-password.component.html b/src/app/accounts/remove-password.component.html index 2442d3a4..87f86e77 100644 --- a/src/app/accounts/remove-password.component.html +++ b/src/app/accounts/remove-password.component.html @@ -7,7 +7,6 @@ type="submit" class="btn primary block" [disabled]="actionPromise" - appBlurClick (click)="convert()" > {{ "removeMasterPassword" | i18n }} @@ -17,7 +16,6 @@ type="button" class="btn secondary block" [disabled]="actionPromise" - appBlurClick (click)="leave()" > {{ "leaveOrganization" | i18n }} diff --git a/src/app/accounts/set-password.component.html b/src/app/accounts/set-password.component.html index 61e99105..0e51f5f2 100644 --- a/src/app/accounts/set-password.component.html +++ b/src/app/accounts/set-password.component.html @@ -60,7 +60,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showPassword" (click)="togglePassword(false)" @@ -112,7 +111,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showPassword" (click)="togglePassword(true)" diff --git a/src/app/accounts/two-factor.component.html b/src/app/accounts/two-factor.component.html index e2abd0f8..e18a1dd0 100644 --- a/src/app/accounts/two-factor.component.html +++ b/src/app/accounts/two-factor.component.html @@ -112,7 +112,6 @@ type="submit" class="btn primary block" [disabled]="form.loading" - appBlurClick *ngIf=" selectedProviderType != null && selectedProviderType !== providerType.Duo && @@ -124,7 +123,7 @@ > - {{ "cancel" | i18n }} +
- diff --git a/src/app/components/password-reprompt.component.html b/src/app/components/password-reprompt.component.html index 078e983b..07d9abd8 100644 --- a/src/app/components/password-reprompt.component.html +++ b/src/app/components/password-reprompt.component.html @@ -23,7 +23,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showPassword" (click)="togglePassword()" @@ -43,7 +42,7 @@
diff --git a/src/app/vault/add-edit-custom-fields.component.html b/src/app/vault/add-edit-custom-fields.component.html index 0e5a8f6e..cf4635c3 100644 --- a/src/app/vault/add-edit-custom-fields.component.html +++ b/src/app/vault/add-edit-custom-fields.component.html @@ -81,7 +81,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="f.showValue" (click)="toggleFieldValue(f)" diff --git a/src/app/vault/add-edit.component.html b/src/app/vault/add-edit.component.html index d694e810..6f78e0ce 100644 --- a/src/app/vault/add-edit.component.html +++ b/src/app/vault/add-edit.component.html @@ -39,17 +39,15 @@ />
- - +
@@ -70,7 +68,6 @@ type="button" #checkPasswordBtn class="row-btn btn" - appBlurClick appA11yTitle="{{ 'checkPassword' | i18n }}" (click)="checkPassword()" [appApiAction]="checkPasswordPromise" @@ -91,7 +88,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showPassword" (click)="togglePassword()" @@ -106,7 +102,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'generatePassword' | i18n }}" (click)="generatePassword()" > @@ -155,7 +150,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showCardNumber" (click)="toggleCardNumber()" @@ -209,7 +203,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" [attr.aria-pressed]="showCardCode" (click)="toggleCardCode()" @@ -440,22 +433,18 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleOptions' | i18n }}" (click)="toggleUriOptions(u)" + [attr.aria-expanded]=" + !(u.showOptions === false || (u.showOptions == null && u.match == null)) + " >
- @@ -496,7 +485,6 @@ type="button" class="box-content-row box-content-row-flex text-default" appStopClick - appBlurClick (click)="attachments()" *ngIf="editMode && !cloneMode" > @@ -507,7 +495,6 @@ type="button" class="box-content-row box-content-row-flex text-default" appStopClick - appBlurClick (click)="editCollections()" *ngIf="editMode && !cloneMode && cipher.organizationId" > @@ -578,7 +565,6 @@