[fix] Only use appA11yTitle for semantic buttons

src/app/modules/vault-filter/components/collection-filter.component.html

@@ -43,11 +43,7 @@
               }"
             ></i>
           </button>
-          <button
+          <button class="filter-button" (click)="applyFilter(c.node)">
-            class="filter-button"
-            (click)="applyFilter(c.node)"
-            appA11yTitle="{{ 'applyFilter' | i18n }}"
-          >
             <i
               *ngIf="c.children.length === 0"
               class="bwi bwi-fw bwi-collection"

src/app/modules/vault-filter/components/folder-filter.component.html

@@ -48,11 +48,7 @@
               }"
             ></i>
           </button>
-          <button
+          <button class="filter-button" (click)="applyFilter(f.node)">
-            class="filter-button"
-            (click)="applyFilter(f.node)"
-            appA11yTitle="{{ 'applyFilter' | i18n }}"
-          >
             <i *ngIf="f.children.length === 0" class="bwi bwi-fw bwi-folder" aria-hidden="true"></i>
             &nbsp;{{ f.node.name }}
           </button>

src/app/modules/vault-filter/components/organization-filter.component.html

@@ -18,11 +18,7 @@
             }"
           ></i>
         </button>
-        <button
+        <button class="filter-button" (click)="clearFilter()">
-          class="filter-button"
-          (click)="clearFilter()"
-          appA11yTitle="{{ 'filterAllVaults' | i18n }}"
-        >
           <h2>&nbsp;{{ organizationGrouping.name | i18n }}</h2>
         </button>
       </div>
@@ -33,11 +29,7 @@
           [ngClass]="{ active: organization.id === activeFilter.selectedOrganizationId }"
         >
           <span class="filter-buttons">
-            <button
+            <button class="filter-button" (click)="applyOrganizationFilter(organization)">
-              class="filter-button"
-              (click)="applyOrganizationFilter(organization)"
-              appA11yTitle="{{ 'applyFilter' | i18n }}"
-            >
               <i class="bwi bwi-fw bwi-business" aria-hidden="true"></i>
               &nbsp;{{ organization.name }}
             </button>
@@ -62,22 +54,14 @@
             }"
           ></i>
         </button>
-        <button
+        <button class="filter-button" (click)="clearFilter()">
-          class="filter-button"
-          (click)="clearFilter()"
-          appA11yTitle="{{ 'filterAllVaults' | i18n }}"
-        >
           <h2>&nbsp;{{ organizationGrouping.name | i18n }}</h2>
         </button>
       </div>
       <ul id="organization-filters" *ngIf="!isCollapsed" class="filter-options no-margin">
         <li class="filter-option" [ngClass]="{ active: activeFilter.myVaultOnly }">
           <span class="filter-buttons">
-            <button
+            <button class="filter-button" (click)="applyMyVaultFilter()">
-              class="filter-button"
-              (click)="applyMyVaultFilter()"
-              appA11yTitle="{{ 'applyFilter' | i18n }}"
-            >
               <i class="bwi bwi-fw bwi-user" aria-hidden="true"></i>
               &nbsp;{{ "myVault" | i18n }}
             </button>
@@ -89,11 +73,7 @@
           [ngClass]="{ active: organization.id === activeFilter.selectedOrganizationId }"
         >
           <span class="filter-buttons">
-            <button
+            <button class="filter-button" (click)="applyOrganizationFilter(organization)">
-              class="filter-button"
-              (click)="applyOrganizationFilter(organization)"
-              appA11yTitle="{{ 'applyFilter' | i18n }}"
-            >
               <i class="bwi bwi-fw bwi-business" aria-hidden="true"></i>
               &nbsp;{{ organization.name }}
             </button>

src/app/modules/vault-filter/components/status-filter.component.html

@@ -3,11 +3,7 @@
   <ul class="filter-options">
     <li class="filter-option" [ngClass]="{ active: activeFilter.status === 'all' }">
       <span class="filter-buttons">
-        <button
+        <button class="filter-button" (click)="applyFilter('all')">
-          class="filter-button"
-          (click)="applyFilter('all')"
-          appA11yTitle="{{ 'applyFilter' | i18n }}"
-        >
           <i class="bwi bwi-fw bwi-filter" aria-hidden="true"></i>&nbsp;{{ "allItems" | i18n }}
         </button>
       </span>
@@ -18,11 +14,7 @@
       [ngClass]="{ active: activeFilter.status === 'favorites' }"
     >
       <span class="filter-buttons">
-        <button
+        <button class="filter-button" (click)="applyFilter('favorites')">
-          class="filter-button"
-          (click)="applyFilter('favorites')"
-          appA11yTitle="{{ 'applyFilter' | i18n }}"
-        >
           <i class="bwi bwi-fw bwi-star" aria-hidden="true"></i>&nbsp;{{ "favorites" | i18n }}
         </button>
       </span>
@@ -33,11 +25,7 @@
       [ngClass]="{ active: activeFilter.status === 'trash' }"
     >
       <span class="filter-buttons">
-        <button
+        <button class="filter-button" (click)="applyFilter('trash')">
-          class="filter-button"
-          (click)="applyFilter('trash')"
-          appA11yTitle="{{ 'applyFilter' | i18n }}"
-        >
           <i class="bwi bwi-fw bwi-trash" aria-hidden="true"></i>&nbsp;{{ "trash" | i18n }}
         </button>
       </span>

src/app/modules/vault-filter/components/type-filter.component.html

@@ -23,22 +23,14 @@
     [ngClass]="{ active: activeFilter.cipherType === cipherTypeEnum.Login }"
   >
     <span class="filter-buttons">
-      <button
+      <button class="filter-button" (click)="applyFilter(cipherTypeEnum.Login)">
-        class="filter-button"
-        (click)="applyFilter(cipherTypeEnum.Login)"
-        appA11yTitle="{{ 'applyFilter' | i18n }}"
-      >
         <i class="bwi bwi-fw bwi-globe" aria-hidden="true"></i>&nbsp;{{ "typeLogin" | i18n }}
       </button>
     </span>
   </li>
   <li class="filter-option" [ngClass]="{ active: activeFilter.cipherType === cipherTypeEnum.Card }">
     <span class="filter-buttons">
-      <button
+      <button class="filter-button" (click)="applyFilter(cipherTypeEnum.Card)">
-        class="filter-button"
-        (click)="applyFilter(cipherTypeEnum.Card)"
-        appA11yTitle="{{ 'applyFilter' | i18n }}"
-      >
         <i class="bwi bwi-fw bwi-credit-card" aria-hidden="true"></i>&nbsp;{{ "typeCard" | i18n }}
       </button>
     </span>
@@ -48,11 +40,7 @@
     [ngClass]="{ active: activeFilter.cipherType === cipherTypeEnum.Identity }"
   >
     <span class="filter-buttons">
-      <button
+      <button class="filter-button" (click)="applyFilter(cipherTypeEnum.Identity)">
-        class="filter-button"
-        (click)="applyFilter(cipherTypeEnum.Identity)"
-        appA11yTitle="{{ 'applyFilter' | i18n }}"
-      >
         <i class="bwi bwi-fw bwi-id-card" aria-hidden="true"></i>&nbsp;{{ "typeIdentity" | i18n }}
       </button>
     </span>
@@ -62,11 +50,7 @@
     [ngClass]="{ active: activeFilter.cipherType === cipherTypeEnum.SecureNote }"
   >
     <span class="filter-buttons">
-      <button
+      <button class="filter-button" (click)="applyFilter(cipherTypeEnum.SecureNote)">
-        class="filter-button"
-        (click)="applyFilter(cipherTypeEnum.SecureNote)"
-        appA11yTitle="{{ 'applyFilter' | i18n }}"
-      >
         <i class="bwi bwi-fw bwi-sticky-note" aria-hidden="true"></i>&nbsp;{{
           "typeSecureNote" | i18n
         }}

src/locales/en/messages.json

@@ -1892,13 +1892,5 @@
   },
   "searchMyVault": {
     "message": "Search My Vault"
-  },
-  "applyFilter": {
-    "message": "Apply Filter",
-    "description": "Applying a filter to a list of vault items"
-  },
-  "filterAllVaults": {
-    "message": "Clear any active organization filter",
-    "description": "Applying a filter to a list of vault items"
   }
 }