Remove webpack-node-externals and use asarUnpack (#1221)

This commit is contained in:
Oscar Hinton 2022-01-12 11:32:02 +01:00 committed by GitHub
parent 23a7072341
commit f6f0bd2bfb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 2173 deletions

18
package-lock.json generated
View File

@ -62,8 +62,7 @@
"typescript": "4.3.5",
"webpack": "^5.64.4",
"webpack-cli": "^4.9.1",
"webpack-merge": "^5.8.0",
"webpack-node-externals": "^3.0.0"
"webpack-merge": "^5.8.0"
},
"engines": {
"node": "~16",
@ -9818,15 +9817,6 @@
"node": ">=10.0.0"
}
},
"node_modules/webpack-node-externals": {
"version": "3.0.0",
"resolved": "https://registry.npmjs.org/webpack-node-externals/-/webpack-node-externals-3.0.0.tgz",
"integrity": "sha512-LnL6Z3GGDPht/AigwRh2dvL9PQPFQ8skEpVrWZXLWBYmqcaojHNN0onvHzie6rq7EWKrrBfPYqNEzTJgiwEQDQ==",
"dev": true,
"engines": {
"node": ">=6"
}
},
"node_modules/webpack-sources": {
"version": "3.2.2",
"resolved": "https://registry.npmjs.org/webpack-sources/-/webpack-sources-3.2.2.tgz",
@ -17513,12 +17503,6 @@
"wildcard": "^2.0.0"
}
},
"webpack-node-externals": {
"version": "3.0.0",
"resolved": "https://registry.npmjs.org/webpack-node-externals/-/webpack-node-externals-3.0.0.tgz",
"integrity": "sha512-LnL6Z3GGDPht/AigwRh2dvL9PQPFQ8skEpVrWZXLWBYmqcaojHNN0onvHzie6rq7EWKrrBfPYqNEzTJgiwEQDQ==",
"dev": true
},
"webpack-sources": {
"version": "3.2.2",
"resolved": "https://registry.npmjs.org/webpack-sources/-/webpack-sources-3.2.2.tgz",

View File

@ -72,6 +72,9 @@
"app": "build"
},
"afterSign": "scripts/after-sign.js",
"asarUnpack": [
"*.node"
],
"mac": {
"electronUpdaterCompatibility": ">=0.0.1",
"category": "public.app-category.productivity",
@ -179,10 +182,7 @@
"mas": {
"entitlements": "resources/entitlements.mas.plist",
"entitlementsInherit": "resources/entitlements.mas.inherit.plist",
"hardenedRuntime": false,
"asarUnpack": [
"node_modules/keytar"
]
"hardenedRuntime": false
},
"nsisWeb": {
"oneClick": false,
@ -281,8 +281,7 @@
"typescript": "4.3.5",
"webpack": "^5.64.4",
"webpack-cli": "^4.9.1",
"webpack-merge": "^5.8.0",
"webpack-node-externals": "^3.0.0"
"webpack-merge": "^5.8.0"
},
"dependencies": {
"@angular/animations": "^12.2.13",

2131
src/package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@ -11,17 +11,5 @@
"type": "git",
"url": "https://github.com/bitwarden/desktop"
},
"dependencies": {
"@nodert-win10-rs4/windows.security.credentials.ui": "^0.4.4",
"big-integer": "1.6.48",
"browser-hrtime": "^1.1.8",
"electron-log": "4.4.1",
"electron-store": "8.0.1",
"electron-updater": "4.6.1",
"forcefocus": "^1.1.0",
"keytar": "7.6.0",
"node-ipc": "^9.1.4",
"regedit": "^3.0.3",
"zxcvbn": "4.4.2"
}
"dependencies": {}
}

View File

@ -2,7 +2,6 @@ const path = require("path");
const { merge } = require("webpack-merge");
const CopyWebpackPlugin = require("copy-webpack-plugin");
const { CleanWebpackPlugin } = require("clean-webpack-plugin");
const nodeExternals = require("webpack-node-externals");
const TsconfigPathsPlugin = require("tsconfig-paths-webpack-plugin");
const NODE_ENV = process.env.NODE_ENV == null ? "development" : process.env.NODE_ENV;
@ -76,11 +75,9 @@ const main = {
],
}),
],
externals: [
nodeExternals({
allowlist: ["rxjs"],
}),
],
externals: {
"electron-reload": "commonjs2 electron-reload",
},
};
module.exports = merge(common, NODE_ENV === "development" ? dev : prod, main);