1
0
mirror of https://github.com/bitwarden/desktop.git synced 2024-06-26 10:36:19 +02:00
bitwarden-desktop/src/app/send
Patrick H. Lauke 0396d682b1
Change links to buttons, expose aria-pressed for toggles, add aria-expanded to send view's "Options" (#1437)
* Change links to buttons, expose `aria-pressed` for toggles

- also make existing `<a routerLink...>` type controls keyboard focusable with the addition of `tabindex="0"`

* Correctly set aria-pressed

now that I have a working build environment, could verify correct way to set this with my limited Angular knowledge

* Change more links to buttons, initial style changes

* Fix layout of <button> elements with .box-content-row

* Update jslib submodule

* Add `aria-expanded` to the send view's "Show options" expand/collapse control

* Fix position of "Edit" pencil when hovering over folders

* Update jslib

* Change sends list links to buttons

* Add `aria-pressed` to vault and send list buttons

Programmatically denote which of the buttons is currently active/shown in the right-most panel

* Fix incorrect "Options" expand/collapse button in add-edit view

Currently, that buttons lacks an accName because the "Options" text is outside of it.

* Add `aria-pressed` to the send left-hand column filters

* Simplify base, list, and vault styles

Since links are now buttons, no need to double up selectors for both types of elements. No need to double-up theming in base, as this also causes incorrect "x" in toasts.

* Remove unnecessary `position:relative`

Fixes issue with cut-off focus outlines, has no other adverse effect

* Fix styling for last child of action buttons

Old approach of making right padding smaller results in unsightly, off-center icon (noticeable when focus outline is visible). This visually remains the same, but reduces right-hand margin instead.
2022-04-30 16:09:41 +02:00
..
add-edit.component.html Change links to buttons, expose aria-pressed for toggles, add aria-expanded to send view's "Options" (#1437) 2022-04-30 16:09:41 +02:00
add-edit.component.ts Add eslint (#1369) 2022-02-24 20:50:19 +01:00
efflux-dates.component.html Apply Prettier (#1202) 2021-12-20 15:47:17 +01:00
efflux-dates.component.ts Add eslint (#1369) 2022-02-24 20:50:19 +01:00
send.component.html Change links to buttons, expose aria-pressed for toggles, add aria-expanded to send view's "Options" (#1437) 2022-04-30 16:09:41 +02:00
send.component.ts Add eslint (#1369) 2022-02-24 20:50:19 +01:00