PS-587 - Fix searchbar search textfield and icon colors for dark themes (#1941)

* PS-587 Fix searchbar search textfield and icon colors for dark themes

* PS-587 - PR corrections

src/iOS.Autofill/LoginSearchViewController.cs

@@ -33,10 +33,7 @@ namespace Bit.iOS.Autofill
             CancelBarButton.Title = AppResources.Cancel;
             SearchBar.Placeholder = AppResources.Search;
             SearchBar.BackgroundColor = SearchBar.BarTintColor = ThemeHelpers.ListHeaderBackgroundColor;
-            if (!ThemeHelpers.LightTheme)
+            SearchBar.UpdateThemeIfNeeded();
-            {
-                SearchBar.KeyboardAppearance = UIKeyboardAppearance.Dark;
-            }
 
             TableView.RowHeight = UITableView.AutomaticDimension;
             TableView.EstimatedRowHeight = 44;

src/iOS.Core/Utilities/UISearchBarExtensions.cs

@@ -0,0 +1,20 @@
+using UIKit;
+
+namespace Bit.iOS.Core.Utilities
+{
+    public static class UISearchBarExtensions
+    {
+        public static void UpdateThemeIfNeeded(this UISearchBar searchBar)
+        {
+            if (!ThemeHelpers.LightTheme)
+            {
+                searchBar.KeyboardAppearance = UIKeyboardAppearance.Dark;
+                if (UIDevice.CurrentDevice.CheckSystemVersion(13, 0))
+                {
+                    searchBar.SearchTextField.TextColor = UIColor.White;
+                    searchBar.SearchTextField.LeftView.TintColor = UIColor.White;
+                }
+            }
+        }
+    }
+}

src/iOS.Core/iOS.Core.csproj

@@ -194,6 +194,7 @@
     <Compile Include="Services\ClipboardService.cs" />
     <Compile Include="Utilities\FontElementExtensions.cs" />
     <Compile Include="Effects\ScrollViewContentInsetAdjustmentBehaviorEffect.cs" />
+    <Compile Include="Utilities\UISearchBarExtensions.cs" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\App\App.csproj">