Upstream
/
bitwarden-mobile
mirror of https://github.com/bitwarden/mobile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

TDL-13 Removed workaround of null reference on LabelRenderer given that Xamarin forms has been updated with the fix (#1889)

This commit is contained in:
Federico Maccaroni 2022-04-25 16:09:47 -03:00 committed by GitHub
parent 99828c7ead
commit 2cab62fda5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/iOS.Core/Renderers/CustomLabelRenderer.cs
View File

@ -23,18 +23,7 @@ namespace Bit.iOS.Core.Renderers
protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
{
try
{
base.OnElementPropertyChanged(sender, e);
}
catch (NullReferenceException)
{
// Do nothing...
// There is an issue on Xamarin Forms which throws a null reference
// https://appcenter.ms/users/kspearrin/apps/bitwarden/crashes/errors/534094859u/overview
// TODO: Maybe something like this https://github.com/matteobortolazzo/HtmlLabelPlugin/pull/113 can be implemented to avoid this
// on html labels.
}
base.OnElementPropertyChanged(sender, e);
if (e.PropertyName == Label.FontProperty.PropertyName ||
e.PropertyName == Label.TextProperty.PropertyName ||