From 69ba16ed9e1094eafab46aa10b949111a37014d3 Mon Sep 17 00:00:00 2001
From: Federico Maccaroni <fedemkr@gmail.com>
Date: Wed, 17 Apr 2024 09:58:28 -0300
Subject: [PATCH] PM-7385 Fix unit tests for Fido2 service (#3167)

---
 .../Services/Fido2AuthenticatorGetAssertionTests.cs          | 5 ++++-
 .../Services/Fido2AuthenticatorMakeCredentialTests.cs        | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/test/Core.Test/Services/Fido2AuthenticatorGetAssertionTests.cs b/test/Core.Test/Services/Fido2AuthenticatorGetAssertionTests.cs
index 29953a2cf..a728fd7e2 100644
--- a/test/Core.Test/Services/Fido2AuthenticatorGetAssertionTests.cs
+++ b/test/Core.Test/Services/Fido2AuthenticatorGetAssertionTests.cs
@@ -234,7 +234,8 @@ namespace Bit.Core.Test.Services
             // Arrange
             _params.UserVerificationPreference = Fido2UserVerificationPreference.Required;
             _userInterface.PickCredentialAsync(Arg.Any<Fido2GetAssertionUserInterfaceCredential[]>()).Returns((_selectedCipher.Id, false));
-
+            _sutProvider.GetDependency<IUserVerificationMediatorService>().ShouldEnforceFido2RequiredUserVerificationAsync(Arg.Any<Fido2UserVerificationOptions>()).Returns(Task.FromResult(true));
+            
             // Act and assert
             await Assert.ThrowsAsync<NotAllowedError>(() => _sutProvider.Sut.GetAssertionAsync(_params, _userInterface));
         }
@@ -250,6 +251,7 @@ namespace Bit.Core.Test.Services
             _sutProvider.GetDependency<IUserVerificationMediatorService>()
                 .ShouldPerformMasterPasswordRepromptAsync(Arg.Is<Fido2UserVerificationOptions>(opt => opt.ShouldCheckMasterPasswordReprompt))
                 .Returns(Task.FromResult(true));
+            _sutProvider.GetDependency<IUserVerificationMediatorService>().ShouldEnforceFido2RequiredUserVerificationAsync(Arg.Any<Fido2UserVerificationOptions>()).Returns(Task.FromResult(true));
 
             // Act & Assert
             await Assert.ThrowsAsync<NotAllowedError>(() => _sutProvider.Sut.GetAssertionAsync(_params, _userInterface));
@@ -266,6 +268,7 @@ namespace Bit.Core.Test.Services
             _sutProvider.GetDependency<IUserVerificationMediatorService>()
                 .CanPerformUserVerificationPreferredAsync(Arg.Any<Fido2UserVerificationOptions>())
                 .Returns(Task.FromResult(true));
+            _sutProvider.GetDependency<IUserVerificationMediatorService>().ShouldEnforceFido2RequiredUserVerificationAsync(Arg.Any<Fido2UserVerificationOptions>()).Returns(Task.FromResult(true));
 
             // Act & Assert
             await Assert.ThrowsAsync<NotAllowedError>(() => _sutProvider.Sut.GetAssertionAsync(_params, _userInterface));
diff --git a/test/Core.Test/Services/Fido2AuthenticatorMakeCredentialTests.cs b/test/Core.Test/Services/Fido2AuthenticatorMakeCredentialTests.cs
index 3331da216..ef544b360 100644
--- a/test/Core.Test/Services/Fido2AuthenticatorMakeCredentialTests.cs
+++ b/test/Core.Test/Services/Fido2AuthenticatorMakeCredentialTests.cs
@@ -268,6 +268,7 @@ namespace Bit.Core.Test.Services
             // Arrange
             _params.UserVerificationPreference = Fido2UserVerificationPreference.Required;
             _userInterface.ConfirmNewCredentialAsync(Arg.Any<Fido2ConfirmNewCredentialParams>()).Returns((_encryptedSelectedCipher.Id, false));
+            _sutProvider.GetDependency<IUserVerificationMediatorService>().ShouldEnforceFido2RequiredUserVerificationAsync(Arg.Any<Fido2UserVerificationOptions>()).Returns(Task.FromResult(true));
 
             // Act & Assert
             await Assert.ThrowsAsync<NotAllowedError>(() => _sutProvider.Sut.MakeCredentialAsync(_params, _userInterface));
@@ -283,6 +284,7 @@ namespace Bit.Core.Test.Services
             _sutProvider.GetDependency<IUserVerificationMediatorService>()
                 .ShouldPerformMasterPasswordRepromptAsync(Arg.Is<Fido2UserVerificationOptions>(opt => opt.ShouldCheckMasterPasswordReprompt))
                 .Returns(Task.FromResult(true));
+            _sutProvider.GetDependency<IUserVerificationMediatorService>().ShouldEnforceFido2RequiredUserVerificationAsync(Arg.Any<Fido2UserVerificationOptions>()).Returns(Task.FromResult(true));
 
             // Act & Assert
             await Assert.ThrowsAsync<NotAllowedError>(() => _sutProvider.Sut.MakeCredentialAsync(_params, _userInterface));
@@ -298,6 +300,7 @@ namespace Bit.Core.Test.Services
             _sutProvider.GetDependency<IUserVerificationMediatorService>()
                 .CanPerformUserVerificationPreferredAsync(Arg.Any<Fido2UserVerificationOptions>())
                 .Returns(Task.FromResult(true));
+            _sutProvider.GetDependency<IUserVerificationMediatorService>().ShouldEnforceFido2RequiredUserVerificationAsync(Arg.Any<Fido2UserVerificationOptions>()).Returns(Task.FromResult(true));
 
             // Act & Assert
             await Assert.ThrowsAsync<NotAllowedError>(() => _sutProvider.Sut.MakeCredentialAsync(_params, _userInterface));