mirror of
https://github.com/bitwarden/mobile.git
synced 2024-09-29 04:07:37 +02:00
[PM-6726] Fix for Android 14 devices crashing when using the Tiles (#3069)
* Fix for Android 14 devices crashing when using the TileService. Also added fix for an "hidden" crash in accessibility autofill * Shared StartActivityAndCollapseFromTileService in AndroidHelpers * Update src/App/Platforms/Android/Utilities/AndroidHelpers.cs Co-authored-by: Federico Maccaroni <fedemkr@gmail.com> * Updated name of StartActivityAndCollapseWithIntent method name used by TileService --------- Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
This commit is contained in:
parent
e3441845cd
commit
9bc2901255
@ -347,7 +347,7 @@ namespace Bit.Droid.Autofill
|
|||||||
// InlinePresentation requires nonNull pending intent (even though we only utilize one for the
|
// InlinePresentation requires nonNull pending intent (even though we only utilize one for the
|
||||||
// "my vault" presentation) so we're including an empty one here
|
// "my vault" presentation) so we're including an empty one here
|
||||||
pendingIntent = PendingIntent.GetService(context, 0, new Intent(),
|
pendingIntent = PendingIntent.GetService(context, 0, new Intent(),
|
||||||
AndroidHelpers.AddPendingIntentMutabilityFlag(PendingIntentFlags.OneShot | PendingIntentFlags.UpdateCurrent, true));
|
AndroidHelpers.AddPendingIntentMutabilityFlag(PendingIntentFlags.OneShot | PendingIntentFlags.UpdateCurrent, false));
|
||||||
}
|
}
|
||||||
var slice = CreateInlinePresentationSlice(
|
var slice = CreateInlinePresentationSlice(
|
||||||
inlinePresentationSpec,
|
inlinePresentationSpec,
|
||||||
|
@ -8,6 +8,7 @@ using Bit.Core.Abstractions;
|
|||||||
using Bit.Core.Utilities;
|
using Bit.Core.Utilities;
|
||||||
using Bit.Droid.Accessibility;
|
using Bit.Droid.Accessibility;
|
||||||
using Java.Lang;
|
using Java.Lang;
|
||||||
|
using Bit.App.Droid.Utilities;
|
||||||
|
|
||||||
namespace Bit.Droid.Tile
|
namespace Bit.Droid.Tile
|
||||||
{
|
{
|
||||||
@ -76,7 +77,7 @@ namespace Bit.Droid.Tile
|
|||||||
var intent = new Intent(this, typeof(AccessibilityActivity));
|
var intent = new Intent(this, typeof(AccessibilityActivity));
|
||||||
intent.SetFlags(ActivityFlags.NewTask | ActivityFlags.SingleTop | ActivityFlags.ClearTop);
|
intent.SetFlags(ActivityFlags.NewTask | ActivityFlags.SingleTop | ActivityFlags.ClearTop);
|
||||||
intent.PutExtra("autofillTileClicked", true);
|
intent.PutExtra("autofillTileClicked", true);
|
||||||
StartActivityAndCollapse(intent);
|
this.StartActivityAndCollapseWithIntent(intent, isMutable: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
private void ShowConfigErrorDialog()
|
private void ShowConfigErrorDialog()
|
||||||
|
@ -1,15 +1,8 @@
|
|||||||
using System;
|
using Android.App;
|
||||||
using System.Collections.Generic;
|
|
||||||
using System.Linq;
|
|
||||||
using System.Text;
|
|
||||||
|
|
||||||
using Android.App;
|
|
||||||
using Android.Content;
|
using Android.Content;
|
||||||
using Android.OS;
|
|
||||||
using Android.Runtime;
|
using Android.Runtime;
|
||||||
using Android.Service.QuickSettings;
|
using Android.Service.QuickSettings;
|
||||||
using Android.Views;
|
using Bit.App.Droid.Utilities;
|
||||||
using Android.Widget;
|
|
||||||
using Java.Lang;
|
using Java.Lang;
|
||||||
|
|
||||||
namespace Bit.Droid.Tile
|
namespace Bit.Droid.Tile
|
||||||
@ -62,7 +55,7 @@ namespace Bit.Droid.Tile
|
|||||||
var intent = new Intent(this, typeof(MainActivity));
|
var intent = new Intent(this, typeof(MainActivity));
|
||||||
intent.SetFlags(ActivityFlags.NewTask | ActivityFlags.SingleTop | ActivityFlags.ClearTop);
|
intent.SetFlags(ActivityFlags.NewTask | ActivityFlags.SingleTop | ActivityFlags.ClearTop);
|
||||||
intent.PutExtra("generatorTile", true);
|
intent.PutExtra("generatorTile", true);
|
||||||
StartActivityAndCollapse(intent);
|
this.StartActivityAndCollapseWithIntent(intent, isMutable: false);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -1,15 +1,8 @@
|
|||||||
using System;
|
using Android.App;
|
||||||
using System.Collections.Generic;
|
|
||||||
using System.Linq;
|
|
||||||
using System.Text;
|
|
||||||
|
|
||||||
using Android.App;
|
|
||||||
using Android.Content;
|
using Android.Content;
|
||||||
using Android.OS;
|
|
||||||
using Android.Runtime;
|
using Android.Runtime;
|
||||||
using Android.Service.QuickSettings;
|
using Android.Service.QuickSettings;
|
||||||
using Android.Views;
|
using Bit.App.Droid.Utilities;
|
||||||
using Android.Widget;
|
|
||||||
using Java.Lang;
|
using Java.Lang;
|
||||||
|
|
||||||
namespace Bit.Droid.Tile
|
namespace Bit.Droid.Tile
|
||||||
@ -63,7 +56,7 @@ namespace Bit.Droid.Tile
|
|||||||
var intent = new Intent(this, typeof(MainActivity));
|
var intent = new Intent(this, typeof(MainActivity));
|
||||||
intent.SetFlags(ActivityFlags.NewTask | ActivityFlags.SingleTop | ActivityFlags.ClearTop);
|
intent.SetFlags(ActivityFlags.NewTask | ActivityFlags.SingleTop | ActivityFlags.ClearTop);
|
||||||
intent.PutExtra("myVaultTile", true);
|
intent.PutExtra("myVaultTile", true);
|
||||||
StartActivityAndCollapse(intent);
|
this.StartActivityAndCollapseWithIntent(intent, isMutable: false);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -2,6 +2,7 @@
|
|||||||
using Android.Content;
|
using Android.Content;
|
||||||
using Android.OS;
|
using Android.OS;
|
||||||
using Android.Provider;
|
using Android.Provider;
|
||||||
|
using Android.Service.QuickSettings;
|
||||||
using Bit.App.Utilities;
|
using Bit.App.Utilities;
|
||||||
|
|
||||||
namespace Bit.App.Droid.Utilities
|
namespace Bit.App.Droid.Utilities
|
||||||
@ -64,5 +65,26 @@ namespace Bit.App.Droid.Utilities
|
|||||||
|
|
||||||
return pendingIntentFlags;
|
return pendingIntentFlags;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public static void StartActivityAndCollapseWithIntent(this TileService service, Intent intent, bool isMutable)
|
||||||
|
{
|
||||||
|
//For Android 14+ We need to use PendingIntent instead of Intent directly. Older versions still need to use Intent.
|
||||||
|
if (Build.VERSION.SdkInt < BuildVersionCodes.UpsideDownCake)
|
||||||
|
{
|
||||||
|
service.StartActivityAndCollapse(intent);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
var pendingIntent = PendingIntent.GetActivity(
|
||||||
|
service.ApplicationContext,
|
||||||
|
0,
|
||||||
|
intent,
|
||||||
|
AddPendingIntentMutabilityFlag(PendingIntentFlags.UpdateCurrent, isMutable)
|
||||||
|
);
|
||||||
|
if (pendingIntent == null)
|
||||||
|
{
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
service.StartActivityAndCollapse(pendingIntent);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user