* PM-1575 Added new models for Fido2Key
* PM-1575 Added discoverable passkeys and WIP non-discoverable ones
* PM-1575 Fix format
* PM-1575 Added non-discoverable passkeys to login UI
* PM-1575 Added copy application icon to Fido2Key UI
* PM-1575 Updated bwi font with the updated passkey icon
* PM-1575 For now just display Available for two-step login on non-discoverable passkey inside of a cipher login
* PM-1575 Fix non-discoverable passkey visibility
* PM-1575 remove Passkeys as a filter in the vault list
* PM-1575 Display error toast if there is a duplicate passkey when moving a cipher to an org
* Revert "PM-1575 Display error toast if there is a duplicate passkey when moving a cipher to an org"
This reverts commit 78e6353602.
* [PM-2378] Display error toast on duplicate Passkey when moving cipher to an organization (#2594)
* PM-2378 Display error toast if there is a duplicate passkey when moving a cipher to an org
* PM-3097 Fix issue when moving cipher with passkey to an org where the uniqueness should be taken into consideration on different passkeys types and also the Username (#2632)
* PM-3096 Fix non-discoverable passkey to be taken into account when encrypting a cipher which was causing the passkey to be removed when moving to an org (#2637)
* PM-1402 Refactor pass generation service alongside policyservice
* PM-1402 Refactor PasswordGenerationService and PolicyService to have a simpler code and more specific to each class
* PM-1402 Fix format
* PM-1402 Moved policy consts from PolicyService to Policy
* PM-1402 fix crash due to lack of null checking
* PM-1402 fix format
* PM-1402 removed GetValueOrDefault() given that it was not needed and was changing the behavior
* [AC-1070] Add EnforceOnLogin property to MasterPasswordPolicyOptions
* [AC-1070] Add MasterPasswordPolicy property to Identity responses
* [AC-1070] Add policy service dependency to auth service
* [AC-1070] Introduce logic to evaluate master password after successful login
* [AC-1070] Add optional ForcePasswordResetReason to profile / state service
* [AC-1070] Save ForcePasswordResetReason to state when a weak master password is found during login
- Additionally, save the AdminForcePasswordReset reason if the identity result indicates an admin password reset is in effect.
* [AC-1070] Check for a saved ForcePasswordReset reason on TabsPage load force show the update password page
* [AC-1070] Make InitAsync virtual
Allow the UpdateTempPasswordPage to override the InitAsync method to check for a reset password reason in the state service
* [AC-1070] Modify UpdateTempPassword page appearance
- Load the force password reset reason from the state service
- Make warning text dynamic based on force password reason
- Conditionally show the Current master password field if updating a weak master password
* [AC-1070] Add update password method to Api service
* [AC-1070] Introduce logic to update both temp and regular passwords
- Check the Reason to use the appropriate request/endpoint when submitting.
- Verify the users current password locally using the user verification service.
* [AC-1070] Introduce VerifyMasterPasswordResponse
* [AC-1070] Add logic to evaluate master password on unlock
* [AC-1070] Add support 2FA login flow
Keep track of the reset password reason after a password login requires 2FA. During 2FA submission, check if there is a saved reason, and if so, force the user to update their password.
* [AC-1070] Formatting
* [AC-1070] Remove string key from service resolution
* [AC-1070] Change master password options to method variable to avoid class field
Add null check for password strength result and log an error as this is an unexpected flow
* [AC-1070] Remove usage of i18nService
* [AC-1070] Use AsyncCommand for SubmitCommand
* [AC-1070] Remove type from ShowToast call
* [AC-1070] Simplify UpdatePassword methods to accept string for the new encryption key
* [AC-1070] Use full text for key for the CurrentMasterPassword resource
* [AC-1070] Convert Reason to a private class field
* [AC-1070] Formatting changes
* [AC-1070] Simplify if statements in master password options policy service method
* [AC-1070] Use the saved force password reset reason after 2FA login
* [AC-1070] Use constant for ForceUpdatePassword message command
* [AC-1070] Move shared RequirePasswordChangeOnLogin method into PolicyService
* Revert "[AC-1070] Move shared RequirePasswordChangeOnLogin method into PolicyService"
This reverts commit e4feac130f.
* [AC-1070] Add check for null password strength response
* [AC-1070] Fix broken show password icon
* [AC-1070] Add show password icon for current master password
* [EC-1045] lock action if policy and show message
* [EC-1045] add text for policy message
* [EC-1045] add consts to policy service
* [EC-1045] missed a const
* [AC-1045] fix build
* [AC-1045] fix bug where UI wasn't updating after sync
* [AC-1045] change FirstOrDefault to First to avoid nulls
* [AC-1045] refactor get vault timeout functions
* [AC-1045] don't filter action options unecessarily
* [AC-1045] refactor build alert logic for readability
* [AC-1045] use policy to filter timeout options instead of current timeout
* [AC-1045] update timeout during sync instead of getter
- remove encrypted from state since it's not encrypted
- if policies return a timeout policy, check and update vault timeout
* [AC-1045] default to custom if we can't find vault timeout option
* [AC-1045] revert Encrypted Policies rename
* PM-1576 Moved registration of AccountsManager to avoid race conditions with the app start. To do so, added ConditionedAwaiterManager so that it handles a task to be awaited or completed depending on the callers.
* PM-1576 Fix format
* PM-1576 Fix throw to preserve StackTrace
* [EC-980] Added iOS otpauth handler (#2370)
* EC-980 added Bitwarden as otpauth scheme handler
* EC-980 Fix format
* [EC-981] OTP handling - Set to selected cipher (#2404)
* EC-981 Started adding OTP to existing cipher. Reused AutofillCiphersPage for the cipher selection and refactored it so that we have more code reuse
* EC-981 Fix navigation on otp handling
* EC-981 Fix formatting
* EC-981 Added otp cipher selection callout and add close toolbar item when needed
* PM-1131 implemented cipher creation from otp handling flow with otp key filled (#2407)
* PM-1133 Updated empty states for search and cipher selection on otp flow (#2408)
* Fix ignore diacritics in search
This change updates the search function to ignore diacritical marks in search results. Marks are stripped from both the search input and results.
* Removed logs, added null or whitespace validation and improved formatting
Co-authored-by: aj-rosado <109146700+aj-rosado@users.noreply.github.com>
Co-authored-by: Andre Rosado <arosado@bitwarden.com>
* [SG-816] Get all login requests anfd pick the most recent
* [SG-816] Add check if active user has approve login with device active
* [SG-816] Build fix. Fix response model.
* [SG-816] Move code to sync service
* EC-519 Refactored IDeviceActionService to be split into IFileService and IAutofillManager also some cleanups were made
* EC-519 Fix format
* EC-519 Fix merge to use the new AutofillHandler
* [SG-671] removed unnecessary calc of otpauth period. protected cal of otpauth from crashing the app if url has a wrong format.
* [SG-671] changed logger
* [SG-671] Refactored GetQueryParams code to used HttpUtility.ParseQueryString.
* [SG-671] refactor and null protection.
* [SG-671] code format
* [SG-671] fixed bug where totp circle countdown was fixed to 30.
* [SG-167] added fallback for uri check. Changed all default totp timers to constant.
* [SG-671] missed unsaved file
* [SG-671] simplified code
* SG-223 - Changed page title and password title
* SG-223 - Refactored generated field
* Changed position of generated field
* Replaced buttons generate and copy for icons
* SG-223 - Refactor type to passwordType
* SG-223 - Added password or username selector
* Added string for label type selection
* SG-223 - Added logic for different types of username
* Added strings of new types
* [SG-223] - Added UI components for different username types
* Added static strings for new labels
* Added viewmodel properties to support username generation and their respective options
* [SG-223] Added control over type picker visibility
* [SG-223] Refactored username entry on add edit page and added generate icon
* Added GenerateUsername command
* [SG-223] - Implemented service for username generation
* [SG-223] - Added support for username generation for item creation flow
* Implemented cache for username options
* Added exception handling for api calls
* [SG-223] - Remove unused code
* [SG-223] - Added a new display field for username generated and respective command
* Added description label for each type of username
* Changed defautl value of username from string.Empty to -
* [SG-223] - Removed some StackLayouts and refactored some controls
* [SG-223] - Refactored properties name
* [SG-223] - Added visibility toggle icon for api keys of forwarded email username types
* [SG-223] - Refactored nested StackLayouts into grids.
* [SG-223] - Refactor and pr fixing
* [SG-223] - Removed string keys from Resolve
- Added static string to resources
* [SG-223] - Refactored Copy_Clicked as AsyncCommand
- Improved exception handling
- Refactored TypeSelected as GeneratorTypeSelected
* [SG-223] - Renamed PasswordFormatter
* [SG-223] - Refactored VM properties to use UsernameGenerationOptions
* Removed LoadUsernameOptions
* [SG-223] - Refactored added pickers to use SelectedItem instead SelectedIndex
* Deleted PickerIndexToBoolConverter as it isn't needed anymore
* [SG-223] - Refactored and simplified Grid row and column definitions
* [SG-223] - Refactored Command into async command
* Added exception handling and feedback to the user
* [SG-223] - Refactored GeneratorType picker to use Enum GeneratorType instead of string
* [SG-223] - Changed some resource keys
* [SG-223] - Refactor method name
* [SG-223] - Refactored code and added logs for switch default cases
* [SG-223] - Added flag to control visibility when in edit mode
* [SG-223] - Added suffix Parenthesis to keys to prevent future conflicts
* [SG-223] - Refactored multiple methods into one, GetUsernameFromAsync
* Removed unused Extensions from enums
* [SG-223] - Added exception message
* [SG-223] - Added localizable enum values through LocalizableEnumConverter
* [SG-223] - Fixed space between controls
* [SG-223] - Removed unused code and refactored some variables and methods names
* [SG-223] - Removed unused code and refactored constant name to be more elucidative
* [SG-223] - Removed unused variable
* settings option to allow screen capture on Android
* Improved code on Screen Capture and added prompt to the user to allow screen capture
* EC-325 Removed async on OnCreate of MainActivity given that's not necessary anymore
Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
* feat: update auto totp copy setting
* feat: update show icons settings
* feat: update auto add settings
* feat: update settings and options to sentence case
* feat: update translation keys
With the latest changes the translation keys had diverged from their contents.
This commit fixes that.
* fix: revert AndroidManifest changes
* chore: add todo comments to fix negative functions
* SG-386 Updated active user when coming from background to the iOS app and the extension had switched users
* Added iOSExtensionActiveUserIdKey to preference keys
* Reorder iOS preference keys
* Abstracted App Center Logging into its own component, so that we can have it centralized in one place and we avoid checking for FDroid on all the places we want to use it
* Implemented the new logger where Crashes.TrackError was being used except on some specific cases
* Improved logging, added a debug logger and removed AppCenter to be used on DEBUG
* Account Switching (#1720)
* Account switching
* WIP
* wip
* wip
* updates to send test logic
* fixed Send tests
* fixes for theme handling on account switching and re-adding existing account
* switch fixes
* fixes
* fixes
* cleanup
* vault timeout fixes
* account list status enhancements
* logout fixes and token handling improvements
* merge latest (#1727)
* remove duplicate dependency
* fix for initial login token storage paradox (#1730)
* Fix avatar color update toolbar item issue on iOS for account switching (#1735)
* Updated account switching menu UI (#1733)
* updated account switching menu UI
* additional changes
* add key suffix to constant
* GetFirstLetters method tweaks
* Fix crash on account switching when logging out when having more than user at a time (#1740)
* single account migration to multi-account on app update (#1741)
* Account Switching Tap to dismiss (#1743)
* Added tap to dismiss on the Account switching overlay and improved a bit the code
* Fix account switching overlay background transparent on the proper place
* Fixed transparent background and the shadow on the account switching overlay
* Fix iOS top space on Account switching list overlay after modal (#1746)
* Fix top space added to Account switching list overlay after closing modal
* Fix top space added to Account switching list overlay after closing modal on lock, login and home views just in case we add modals in the future there as well
* Usability: dismiss account list on certain events (#1748)
* dismiss account list on certain events
* use new FireAndForget method for back button logic
* Create and use Account Switching overlay control (#1753)
* Added Account switching overlay control and its own ViewModel and refactored accordingly
* Fix account switching Accounts list binding update
* Implemented dismiss account switching overlay when changing tabs and when selecting the same tab. Also updated the deprecated listener on CustomTabbedRenderer on Android (#1755)
* Overriden Equals on AvatarImageSource so it doesn't get set multiple times when it's the same image thus producing blinking on tab chaged (#1756)
* Usability improvements for logout on vault timeout (#1781)
* accountswitching fixes (#1784)
* Fix for invalid PIN lock state when switching accounts (#1792)
* fix for pin lock flow
* named tuple values and updated async
* clear send service cache on account switch (#1796)
* Global theme and account removal (#1793)
* Global theme and account removal
* remove redundant call to hide account list overlay
* cleanup and additional tweaks
* add try/catch to remove account dialog flow
Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
* WIP Add Share app extension on iOS for Send
* Added Share app extension on iOS for Send and some code fixes as well
* Updated iOS csprojs configs to linkskip the new extension project and also added AdHoc and AppStore configurations to iOS.ShareExtension.csproj
* Code clean up and transformed bundle resources into links to the already used pngs of the main iOS project on ShareExtension
* Updated build.yml to include provisioning profile for iOS Share extension
* Adding in the missing provisioning profile
* Removed .DS_Store from the iOS.ShareExtension csproj Resources
* switching out the share extension profile
* Added Share extension provisioning profile configuration on export options app store for github and also removed custom info.plist config for localhost which is not necessary
* Moved property so that it's grouped with the full ones
* Added AppCenter Crashes package to Core and updated FireAndForget Task Extension
* Updated bundle reference of FontAwesome.ttf to bwi-font.ttf in order for it to compile on ShareExtension
Co-authored-by: Joseph Flinn <joseph.s.flinn@gmail.com>
Co-authored-by: Álison Fernandes <vvolkgang@users.noreply.github.com>
* WIP Add Share app extension on iOS for Send
* Added Share app extension on iOS for Send and some code fixes as well
* Updated iOS csprojs configs to linkskip the new extension project and also added AdHoc and AppStore configurations to iOS.ShareExtension.csproj
* Code clean up and transformed bundle resources into links to the already used pngs of the main iOS project on ShareExtension
* Updated build.yml to include provisioning profile for iOS Share extension
* Adding in the missing provisioning profile
* Removed .DS_Store from the iOS.ShareExtension csproj Resources
* switching out the share extension profile
* Added Share extension provisioning profile configuration on export options app store for github and also removed custom info.plist config for localhost which is not necessary
Co-authored-by: Joseph Flinn <joseph.s.flinn@gmail.com>
* initial commit
- add UsesKeyConnector to UserService
- add models
- begin work on authentication
* finish auth workflow for key connector sso login
- finish api call for get user key
- start api calls for posts to key connector
* Bypass lock page if already unlocked
* Move logic to KeyConnectorService, log out if no pin or biometric is set
* Disable password reprompt when using key connector
* hide password reprompt checkbox when editing or adding cipher
* add PostUserKey and PostSetKeyConnector calls
* add ConvertMasterPasswordPage
* add functionality to RemoveMasterPasswordPage
- rename Convert to Remove
* Hide Change Master Password button if using key connector
* Add OTP verification for export component
* Update src/App/Pages/Vault/AddEditPage.xaml.cs
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
* remove toolbar item "close"
* Update src/Core/Models/Request/KeyConnectorUserKeyRequest.cs
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
* remove new line in resource string
- format warning as two labels
- set label in code behind for loading simultaneously
* implement GetAndSetKey in KeyConnectorService
- ignore EnvironmentService call
* remove unnecesary orgIdentifier
* move RemoveMasterPasswordPage call to LockPage
* add spacing to export vault page
* log out if no PIN or bio on lock page with key connector
* Delete excessive whitespace
* Delete excessive whitespace
* Change capitalisation of OTP
* add default value to models for backwards compatibility
* remove this keyword
* actually handle exceptions
* move RemoveMasterPasswordPage to TabPage using messaging service
* add minor improvements
* remove 'this.'
Co-authored-by: Hinton <oscar@oscarhinton.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
* Make card number hidden
* Add support for password reprompt
* Rename PasswordPrompt to Reprompt
* Protect autofill
* Use Enums.CipherRepromptType
* Fix iOS not building
* Protect iOS autofill
* Update to match jslib
* Fix failing build
* Update Size limits
* Add new Api paths for direct upload of Cipher Attachments
* Add Attachment upload to fileUploadService
* Save with direct upload and fallback to legacy uplaod
CipherID is required for direct upload to request an upload URL
* Inform on when to remove legacy code
* Test Attachment upload
* Add direct upload api endpoints
* Create azure upload service
* Update max file size
* Update send file upload test
* Move internationalization string to correct document
* Allow for one shot blob uploads
* Remove unused helper
* Use FileUploadService
Fallback to legacy method on old server implementations.
* Send feature for mobile
* added fallback for KdfIterations
* additional property exclusions for tests
* support encryptedFileData as byte array comparison in SendServiceTests
* formatting
* requested changes
* additional changes
* change position of send service registration to match declaration order
* Expand Hkdf crypto functions
* Add tests for hkdf crypto functions
Took the testing infrastructure from bitwarden/server
* Move Hkdf to cryptoFunctionService
* Port changes from bitwarden/jslib#192
* Port changes from bitwarden/jslib#205
* Make Send Expiration Optional implement changes from bitwarden/jslib#242
* Bug fixes found by testing
* Test helpers
* Test conversion between model types
* Test SendService
These are mostly happy-path tests to ensure a reasonably correct
implementation
* Add run tests step to GitHub Actions
* Test send decryption
* Test Request generation from Send
* Constructor dependencies on separate lines
* Remove unused testing infrastructure
* Rename to match class name
* Move fat arrows to previous lines
* Handle exceptions in App layer
* PR review cleanups
* Throw when attempting to save an unkown Send Type
I think it's best to only throw on unknown send types here.
I don't think we want to throw whenever we encounter one since that would
do bad things like lock up Sync if clients get out of date relative to
servers. Instead, keep the client from ruining saved data by complaining
last minute that it doesn't know what it's doing.
* clear cipher cache when replacing ios autofill identities
* changed to be service-centric
* support for multiple cache keys
* async suffix
* added cache keys for android
* Password generator policy enforcement
* Formatting
* Changed to simple cast (double unboxing for int64/long)
* Added ui indication of active policy on password generator page and fixed issue with switch enable logic
* First pass at vault export UI
* Password validation via cryptoService
* Export service framework
* support for constructing json export data
* Support for constructing csv export data
* Cleanup and simplification
* Completion of vault export feature
* Formatting and simplification
* Use dialog instead of toast for invalid master password entry
