configurable cache size limit

src/Icons/Controllers/IconsController.cs

@@ -5,7 +5,6 @@ using Bit.Icons.Models;
 using Bit.Icons.Services;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Caching.Memory;
-using Microsoft.Extensions.Options;
 
 namespace Bit.Icons.Controllers
 {
@@ -20,11 +19,11 @@ namespace Bit.Icons.Controllers
         public IconsController(
             IMemoryCache memoryCache,
             IDomainMappingService domainMappingService,
-            IOptions<IconsSettings> iconsSettingsOptions)
+            IconsSettings iconsSettings)
         {
             _memoryCache = memoryCache;
             _domainMappingService = domainMappingService;
-            _iconsSettings = iconsSettingsOptions.Value;
+            _iconsSettings = iconsSettings;
         }
 
         [HttpGet("")]

src/Icons/IconsSettings.cs

@@ -4,5 +4,6 @@
     {
         public virtual string BestIconBaseUrl { get; set; }
         public virtual int CacheHours { get; set; }
+        public virtual long? CacheSizeLimit { get; set; }
     }
 }

src/Icons/Startup.cs

@@ -18,10 +18,24 @@ namespace Bit.Icons
 
         public void ConfigureServices(IServiceCollection services)
         {
+            // Options
             services.AddOptions();
-            services.Configure<IconsSettings>(Configuration.GetSection("IconsSettings"));
-            services.AddMemoryCache();
+
+            // Settings
+            var iconsSettings = new IconsSettings();
+            ConfigurationBinder.Bind(Configuration.GetSection("IconsSettings"), iconsSettings);
+            services.AddSingleton(s => iconsSettings);
+
+            // Cache
+            services.AddMemoryCache(options =>
+            {
+                options.SizeLimit = iconsSettings.CacheSizeLimit;
+            });
+
+            // Services
             services.AddSingleton<IDomainMappingService, DomainMappingService>();
+
+            // Mvc
             services.AddMvc();
         }
 

src/Icons/appsettings.json

@@ -13,7 +13,8 @@
     }
   },
   "iconsSettings": {
-    "BestIconBaseUrl": "https://icons.better-idea.org",
-    "CacheHours": 24
+    "bestIconBaseUrl": "https://icons.better-idea.org",
+    "cacheHours": 24,
+    "cacheSizeLimit": null
   }
 }