Upstream/bitwarden-server
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2024-11-25 12:45:18 +01:00
Code Issues Projects Releases Wiki Activity

[PM-5800] Remove feature flag checks for PasswordlessLogin (#3713)

Browse Source 
* Removed feature flag checks for PasswordlessLogin

* Removed unused reference.
This commit is contained in:
Todd Martin 2024-02-13 11:15:24 -05:00 committed by GitHub
parent 789e266791
commit 1a3146f776
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Api/Auth/Controllers/WebAuthnController.cs
View File

@ -13,7 +13,6 @@ using Bit.Core.Auth.UserFeatures.WebAuthnLogin;
using Bit.Core.Exceptions; using Bit.Core.Exceptions;
using Bit.Core.Services; using Bit.Core.Services;
using Bit.Core.Tokens; using Bit.Core.Tokens;
using Bit.Core.Utilities;
using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
@ -21,7 +20,6 @@ namespace Bit.Api.Auth.Controllers;
[Route("webauthn")] [Route("webauthn")]
[Authorize("Web")] [Authorize("Web")]
[RequireFeature(FeatureFlagKeys.PasswordlessLogin)]
public class WebAuthnController : Controller public class WebAuthnController : Controller
{ {
private readonly IUserService _userService; private readonly IUserService _userService;

2
src/Identity/Controllers/AccountsController.cs
View File

@ -12,7 +12,6 @@ using Bit.Core.Models.Data;
using Bit.Core.Repositories; using Bit.Core.Repositories;
using Bit.Core.Services; using Bit.Core.Services;
using Bit.Core.Tokens; using Bit.Core.Tokens;
using Bit.Core.Utilities;
using Bit.SharedWeb.Utilities; using Bit.SharedWeb.Utilities;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
@ -85,7 +84,6 @@ public class AccountsController : Controller
} }
[HttpGet("webauthn/assertion-options")] [HttpGet("webauthn/assertion-options")]
[RequireFeature(FeatureFlagKeys.PasswordlessLogin)]
public WebAuthnLoginAssertionOptionsResponseModel GetWebAuthnLoginAssertionOptions() public WebAuthnLoginAssertionOptionsResponseModel GetWebAuthnLoginAssertionOptions()
{ {
var options = _getWebAuthnLoginCredentialAssertionOptionsCommand.GetWebAuthnLoginCredentialAssertionOptions(); var options = _getWebAuthnLoginCredentialAssertionOptionsCommand.GetWebAuthnLoginCredentialAssertionOptions();

6
src/Identity/IdentityServer/WebAuthnGrantValidator.cs
View File

@ -65,12 +65,6 @@ public class WebAuthnGrantValidator : BaseRequestValidator<ExtensionGrantValidat
public async Task ValidateAsync(ExtensionGrantValidationContext context) public async Task ValidateAsync(ExtensionGrantValidationContext context)
{ {
if (!FeatureService.IsEnabled(FeatureFlagKeys.PasswordlessLogin))
{
context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant);
return;
}
var rawToken = context.Request.Raw.Get("token"); var rawToken = context.Request.Raw.Get("token");
var rawDeviceResponse = context.Request.Raw.Get("deviceResponse"); var rawDeviceResponse = context.Request.Raw.Get("deviceResponse");
if (string.IsNullOrWhiteSpace(rawToken) || string.IsNullOrWhiteSpace(rawDeviceResponse)) if (string.IsNullOrWhiteSpace(rawToken) || string.IsNullOrWhiteSpace(rawDeviceResponse))