1
0
mirror of https://github.com/bitwarden/server.git synced 2025-02-16 01:51:21 +01:00

Fix typo: CurrentContent -> CurrentContext (#3231)

This commit is contained in:
Thomas Rittson 2023-08-28 10:20:01 +10:00 committed by GitHub
parent 4748b5b3fc
commit 4d59dd4a6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 39 additions and 39 deletions

View File

@ -26,8 +26,8 @@ public class CurrentContext : ICurrentContext
public virtual string DeviceIdentifier { get; set; } public virtual string DeviceIdentifier { get; set; }
public virtual DeviceType? DeviceType { get; set; } public virtual DeviceType? DeviceType { get; set; }
public virtual string IpAddress { get; set; } public virtual string IpAddress { get; set; }
public virtual List<CurrentContentOrganization> Organizations { get; set; } public virtual List<CurrentContextOrganization> Organizations { get; set; }
public virtual List<CurrentContentProvider> Providers { get; set; } public virtual List<CurrentContextProvider> Providers { get; set; }
public virtual Guid? InstallationId { get; set; } public virtual Guid? InstallationId { get; set; }
public virtual Guid? OrganizationId { get; set; } public virtual Guid? OrganizationId { get; set; }
public virtual bool CloudflareWorkerProxied { get; set; } public virtual bool CloudflareWorkerProxied { get; set; }
@ -166,17 +166,17 @@ public class CurrentContext : ICurrentContext
return Task.FromResult(0); return Task.FromResult(0);
} }
private List<CurrentContentOrganization> GetOrganizations(Dictionary<string, IEnumerable<Claim>> claimsDict, bool orgApi) private List<CurrentContextOrganization> GetOrganizations(Dictionary<string, IEnumerable<Claim>> claimsDict, bool orgApi)
{ {
var accessSecretsManager = claimsDict.ContainsKey(Claims.SecretsManagerAccess) var accessSecretsManager = claimsDict.ContainsKey(Claims.SecretsManagerAccess)
? claimsDict[Claims.SecretsManagerAccess].ToDictionary(s => s.Value, _ => true) ? claimsDict[Claims.SecretsManagerAccess].ToDictionary(s => s.Value, _ => true)
: new Dictionary<string, bool>(); : new Dictionary<string, bool>();
var organizations = new List<CurrentContentOrganization>(); var organizations = new List<CurrentContextOrganization>();
if (claimsDict.ContainsKey(Claims.OrganizationOwner)) if (claimsDict.ContainsKey(Claims.OrganizationOwner))
{ {
organizations.AddRange(claimsDict[Claims.OrganizationOwner].Select(c => organizations.AddRange(claimsDict[Claims.OrganizationOwner].Select(c =>
new CurrentContentOrganization new CurrentContextOrganization
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = OrganizationUserType.Owner, Type = OrganizationUserType.Owner,
@ -185,7 +185,7 @@ public class CurrentContext : ICurrentContext
} }
else if (orgApi && OrganizationId.HasValue) else if (orgApi && OrganizationId.HasValue)
{ {
organizations.Add(new CurrentContentOrganization organizations.Add(new CurrentContextOrganization
{ {
Id = OrganizationId.Value, Id = OrganizationId.Value,
Type = OrganizationUserType.Owner, Type = OrganizationUserType.Owner,
@ -195,7 +195,7 @@ public class CurrentContext : ICurrentContext
if (claimsDict.ContainsKey(Claims.OrganizationAdmin)) if (claimsDict.ContainsKey(Claims.OrganizationAdmin))
{ {
organizations.AddRange(claimsDict[Claims.OrganizationAdmin].Select(c => organizations.AddRange(claimsDict[Claims.OrganizationAdmin].Select(c =>
new CurrentContentOrganization new CurrentContextOrganization
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = OrganizationUserType.Admin, Type = OrganizationUserType.Admin,
@ -206,7 +206,7 @@ public class CurrentContext : ICurrentContext
if (claimsDict.ContainsKey(Claims.OrganizationUser)) if (claimsDict.ContainsKey(Claims.OrganizationUser))
{ {
organizations.AddRange(claimsDict[Claims.OrganizationUser].Select(c => organizations.AddRange(claimsDict[Claims.OrganizationUser].Select(c =>
new CurrentContentOrganization new CurrentContextOrganization
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = OrganizationUserType.User, Type = OrganizationUserType.User,
@ -217,7 +217,7 @@ public class CurrentContext : ICurrentContext
if (claimsDict.ContainsKey(Claims.OrganizationManager)) if (claimsDict.ContainsKey(Claims.OrganizationManager))
{ {
organizations.AddRange(claimsDict[Claims.OrganizationManager].Select(c => organizations.AddRange(claimsDict[Claims.OrganizationManager].Select(c =>
new CurrentContentOrganization new CurrentContextOrganization
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = OrganizationUserType.Manager, Type = OrganizationUserType.Manager,
@ -228,7 +228,7 @@ public class CurrentContext : ICurrentContext
if (claimsDict.ContainsKey(Claims.OrganizationCustom)) if (claimsDict.ContainsKey(Claims.OrganizationCustom))
{ {
organizations.AddRange(claimsDict[Claims.OrganizationCustom].Select(c => organizations.AddRange(claimsDict[Claims.OrganizationCustom].Select(c =>
new CurrentContentOrganization new CurrentContextOrganization
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = OrganizationUserType.Custom, Type = OrganizationUserType.Custom,
@ -240,13 +240,13 @@ public class CurrentContext : ICurrentContext
return organizations; return organizations;
} }
private List<CurrentContentProvider> GetProviders(Dictionary<string, IEnumerable<Claim>> claimsDict) private List<CurrentContextProvider> GetProviders(Dictionary<string, IEnumerable<Claim>> claimsDict)
{ {
var providers = new List<CurrentContentProvider>(); var providers = new List<CurrentContextProvider>();
if (claimsDict.ContainsKey(Claims.ProviderAdmin)) if (claimsDict.ContainsKey(Claims.ProviderAdmin))
{ {
providers.AddRange(claimsDict[Claims.ProviderAdmin].Select(c => providers.AddRange(claimsDict[Claims.ProviderAdmin].Select(c =>
new CurrentContentProvider new CurrentContextProvider
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = ProviderUserType.ProviderAdmin Type = ProviderUserType.ProviderAdmin
@ -256,7 +256,7 @@ public class CurrentContext : ICurrentContext
if (claimsDict.ContainsKey(Claims.ProviderServiceUser)) if (claimsDict.ContainsKey(Claims.ProviderServiceUser))
{ {
providers.AddRange(claimsDict[Claims.ProviderServiceUser].Select(c => providers.AddRange(claimsDict[Claims.ProviderServiceUser].Select(c =>
new CurrentContentProvider new CurrentContextProvider
{ {
Id = new Guid(c.Value), Id = new Guid(c.Value),
Type = ProviderUserType.ServiceUser Type = ProviderUserType.ServiceUser
@ -483,26 +483,26 @@ public class CurrentContext : ICurrentContext
return Organizations?.Any(o => o.Id == orgId && o.AccessSecretsManager) ?? false; return Organizations?.Any(o => o.Id == orgId && o.AccessSecretsManager) ?? false;
} }
public async Task<ICollection<CurrentContentOrganization>> OrganizationMembershipAsync( public async Task<ICollection<CurrentContextOrganization>> OrganizationMembershipAsync(
IOrganizationUserRepository organizationUserRepository, Guid userId) IOrganizationUserRepository organizationUserRepository, Guid userId)
{ {
if (Organizations == null) if (Organizations == null)
{ {
var userOrgs = await organizationUserRepository.GetManyDetailsByUserAsync(userId); var userOrgs = await organizationUserRepository.GetManyDetailsByUserAsync(userId);
Organizations = userOrgs.Where(ou => ou.Status == OrganizationUserStatusType.Confirmed) Organizations = userOrgs.Where(ou => ou.Status == OrganizationUserStatusType.Confirmed)
.Select(ou => new CurrentContentOrganization(ou)).ToList(); .Select(ou => new CurrentContextOrganization(ou)).ToList();
} }
return Organizations; return Organizations;
} }
public async Task<ICollection<CurrentContentProvider>> ProviderMembershipAsync( public async Task<ICollection<CurrentContextProvider>> ProviderMembershipAsync(
IProviderUserRepository providerUserRepository, Guid userId) IProviderUserRepository providerUserRepository, Guid userId)
{ {
if (Providers == null) if (Providers == null)
{ {
var userProviders = await providerUserRepository.GetManyByUserAsync(userId); var userProviders = await providerUserRepository.GetManyByUserAsync(userId);
Providers = userProviders.Where(ou => ou.Status == ProviderUserStatusType.Confirmed) Providers = userProviders.Where(ou => ou.Status == ProviderUserStatusType.Confirmed)
.Select(ou => new CurrentContentProvider(ou)).ToList(); .Select(ou => new CurrentContextProvider(ou)).ToList();
} }
return Providers; return Providers;
} }

View File

@ -5,11 +5,11 @@ using Bit.Core.Utilities;
namespace Bit.Core.Context; namespace Bit.Core.Context;
public class CurrentContentOrganization public class CurrentContextOrganization
{ {
public CurrentContentOrganization() { } public CurrentContextOrganization() { }
public CurrentContentOrganization(OrganizationUserOrganizationDetails orgUser) public CurrentContextOrganization(OrganizationUserOrganizationDetails orgUser)
{ {
Id = orgUser.OrganizationId; Id = orgUser.OrganizationId;
Type = orgUser.Type; Type = orgUser.Type;

View File

@ -5,11 +5,11 @@ using Bit.Core.Utilities;
namespace Bit.Core.Context; namespace Bit.Core.Context;
public class CurrentContentProvider public class CurrentContextProvider
{ {
public CurrentContentProvider() { } public CurrentContextProvider() { }
public CurrentContentProvider(ProviderUser providerUser) public CurrentContextProvider(ProviderUser providerUser)
{ {
Id = providerUser.ProviderId; Id = providerUser.ProviderId;
Type = providerUser.Type; Type = providerUser.Type;

View File

@ -16,7 +16,7 @@ public interface ICurrentContext
string DeviceIdentifier { get; set; } string DeviceIdentifier { get; set; }
DeviceType? DeviceType { get; set; } DeviceType? DeviceType { get; set; }
string IpAddress { get; set; } string IpAddress { get; set; }
List<CurrentContentOrganization> Organizations { get; set; } List<CurrentContextOrganization> Organizations { get; set; }
Guid? InstallationId { get; set; } Guid? InstallationId { get; set; }
Guid? OrganizationId { get; set; } Guid? OrganizationId { get; set; }
ClientType ClientType { get; set; } ClientType ClientType { get; set; }
@ -64,10 +64,10 @@ public interface ICurrentContext
bool AccessProviderOrganizations(Guid providerId); bool AccessProviderOrganizations(Guid providerId);
bool ManageProviderOrganizations(Guid providerId); bool ManageProviderOrganizations(Guid providerId);
Task<ICollection<CurrentContentOrganization>> OrganizationMembershipAsync( Task<ICollection<CurrentContextOrganization>> OrganizationMembershipAsync(
IOrganizationUserRepository organizationUserRepository, Guid userId); IOrganizationUserRepository organizationUserRepository, Guid userId);
Task<ICollection<CurrentContentProvider>> ProviderMembershipAsync( Task<ICollection<CurrentContextProvider>> ProviderMembershipAsync(
IProviderUserRepository providerUserRepository, Guid userId); IProviderUserRepository providerUserRepository, Guid userId);
Task<Guid?> ProviderIdForOrg(Guid orgId); Task<Guid?> ProviderIdForOrg(Guid orgId);

View File

@ -624,8 +624,8 @@ public static class CoreHelpers
return configDict; return configDict;
} }
public static List<KeyValuePair<string, string>> BuildIdentityClaims(User user, ICollection<CurrentContentOrganization> orgs, public static List<KeyValuePair<string, string>> BuildIdentityClaims(User user, ICollection<CurrentContextOrganization> orgs,
ICollection<CurrentContentProvider> providers, bool isPremium) ICollection<CurrentContextProvider> providers, bool isPremium)
{ {
var claims = new List<KeyValuePair<string, string>>() var claims = new List<KeyValuePair<string, string>>()
{ {

View File

@ -32,7 +32,7 @@ internal class CurrentContextBuilder : ISpecimenBuilder
} }
var obj = new Fixture().WithAutoNSubstitutions().Create<ICurrentContext>(); var obj = new Fixture().WithAutoNSubstitutions().Create<ICurrentContext>();
obj.Organizations = context.Create<List<CurrentContentOrganization>>(); obj.Organizations = context.Create<List<CurrentContextOrganization>>();
return obj; return obj;
} }
} }

View File

@ -273,8 +273,8 @@ public class CoreHelpersTests
{ "sstamp", user.SecurityStamp }, { "sstamp", user.SecurityStamp },
}.ToList(); }.ToList();
var actual = CoreHelpers.BuildIdentityClaims(user, Array.Empty<CurrentContentOrganization>(), var actual = CoreHelpers.BuildIdentityClaims(user, Array.Empty<CurrentContextOrganization>(),
Array.Empty<CurrentContentProvider>(), isPremium); Array.Empty<CurrentContextProvider>(), isPremium);
foreach (var claim in expected) foreach (var claim in expected)
{ {
@ -289,23 +289,23 @@ public class CoreHelpersTests
var fixture = new Fixture().WithAutoNSubstitutions(); var fixture = new Fixture().WithAutoNSubstitutions();
foreach (var organizationUserType in Enum.GetValues<OrganizationUserType>().Except(new[] { OrganizationUserType.Custom })) foreach (var organizationUserType in Enum.GetValues<OrganizationUserType>().Except(new[] { OrganizationUserType.Custom }))
{ {
var org = fixture.Create<CurrentContentOrganization>(); var org = fixture.Create<CurrentContextOrganization>();
org.Type = organizationUserType; org.Type = organizationUserType;
var expected = new KeyValuePair<string, string>($"org{organizationUserType.ToString().ToLower()}", org.Id.ToString()); var expected = new KeyValuePair<string, string>($"org{organizationUserType.ToString().ToLower()}", org.Id.ToString());
var actual = CoreHelpers.BuildIdentityClaims(user, new[] { org }, Array.Empty<CurrentContentProvider>(), false); var actual = CoreHelpers.BuildIdentityClaims(user, new[] { org }, Array.Empty<CurrentContextProvider>(), false);
Assert.Contains(expected, actual); Assert.Contains(expected, actual);
} }
} }
[Theory, BitAutoData, UserCustomize] [Theory, BitAutoData, UserCustomize]
public void BuildIdentityClaims_CustomOrganizationUserClaims_Success(User user, CurrentContentOrganization org) public void BuildIdentityClaims_CustomOrganizationUserClaims_Success(User user, CurrentContextOrganization org)
{ {
var fixture = new Fixture().WithAutoNSubstitutions(); var fixture = new Fixture().WithAutoNSubstitutions();
org.Type = OrganizationUserType.Custom; org.Type = OrganizationUserType.Custom;
var actual = CoreHelpers.BuildIdentityClaims(user, new[] { org }, Array.Empty<CurrentContentProvider>(), false); var actual = CoreHelpers.BuildIdentityClaims(user, new[] { org }, Array.Empty<CurrentContextProvider>(), false);
foreach (var (permitted, claimName) in org.Permissions.ClaimsMap) foreach (var (permitted, claimName) in org.Permissions.ClaimsMap)
{ {
var claim = new KeyValuePair<string, string>(claimName, org.Id.ToString()); var claim = new KeyValuePair<string, string>(claimName, org.Id.ToString());
@ -325,10 +325,10 @@ public class CoreHelpersTests
public void BuildIdentityClaims_ProviderClaims_Success(User user) public void BuildIdentityClaims_ProviderClaims_Success(User user)
{ {
var fixture = new Fixture().WithAutoNSubstitutions(); var fixture = new Fixture().WithAutoNSubstitutions();
var providers = new List<CurrentContentProvider>(); var providers = new List<CurrentContextProvider>();
foreach (var providerUserType in Enum.GetValues<ProviderUserType>()) foreach (var providerUserType in Enum.GetValues<ProviderUserType>())
{ {
var provider = fixture.Create<CurrentContentProvider>(); var provider = fixture.Create<CurrentContextProvider>();
provider.Type = providerUserType; provider.Type = providerUserType;
providers.Add(provider); providers.Add(provider);
} }
@ -357,7 +357,7 @@ public class CoreHelpersTests
} }
} }
var actual = CoreHelpers.BuildIdentityClaims(user, Array.Empty<CurrentContentOrganization>(), providers, false); var actual = CoreHelpers.BuildIdentityClaims(user, Array.Empty<CurrentContextOrganization>(), providers, false);
foreach (var claim in claims) foreach (var claim in claims)
{ {
Assert.Contains(claim, actual); Assert.Contains(claim, actual);