From 5785905103001457a50524283fc0974183e358bf Mon Sep 17 00:00:00 2001
From: Matt Bishop <mbishop@bitwarden.com>
Date: Wed, 20 Dec 2023 14:47:14 -0500
Subject: [PATCH] Fix some bad test parameter names (#3601)

---
 .../LaunchDarklyFeatureServiceTests.cs         | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs b/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs
index fadea2551..3eb8c2547 100644
--- a/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs
+++ b/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs
@@ -12,8 +12,8 @@ namespace Bit.Core.Test.Services;
 [SutProviderCustomize]
 public class LaunchDarklyFeatureServiceTests
 {
-    private const string _fakeKey = "somekey";
-    private const string _fakeValue = "somevalue";
+    private const string _fakeFeatureKey = "somekey";
+    private const string _fakeSdkKey = "somesdkkey";
 
     private static SutProvider<LaunchDarklyFeatureService> GetSutProvider(IGlobalSettings globalSettings)
     {
@@ -44,46 +44,46 @@ public class LaunchDarklyFeatureServiceTests
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.False(sutProvider.Sut.IsEnabled(_fakeKey, currentContext));
+        Assert.False(sutProvider.Sut.IsEnabled(_fakeFeatureKey, currentContext));
     }
 
     [Fact(Skip = "For local development")]
     public void FeatureValue_Boolean()
     {
-        var settings = new Settings.GlobalSettings { LaunchDarkly = { SdkKey = _fakeValue } };
+        var settings = new Settings.GlobalSettings { LaunchDarkly = { SdkKey = _fakeSdkKey } };
 
         var sutProvider = GetSutProvider(settings);
 
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.False(sutProvider.Sut.IsEnabled(_fakeKey, currentContext));
+        Assert.False(sutProvider.Sut.IsEnabled(_fakeFeatureKey, currentContext));
     }
 
     [Fact(Skip = "For local development")]
     public void FeatureValue_Int()
     {
-        var settings = new Settings.GlobalSettings { LaunchDarkly = { SdkKey = _fakeValue } };
+        var settings = new Settings.GlobalSettings { LaunchDarkly = { SdkKey = _fakeSdkKey } };
 
         var sutProvider = GetSutProvider(settings);
 
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.Equal(0, sutProvider.Sut.GetIntVariation(_fakeKey, currentContext));
+        Assert.Equal(0, sutProvider.Sut.GetIntVariation(_fakeFeatureKey, currentContext));
     }
 
     [Fact(Skip = "For local development")]
     public void FeatureValue_String()
     {
-        var settings = new Settings.GlobalSettings { LaunchDarkly = { SdkKey = _fakeValue } };
+        var settings = new Settings.GlobalSettings { LaunchDarkly = { SdkKey = _fakeSdkKey } };
 
         var sutProvider = GetSutProvider(settings);
 
         var currentContext = Substitute.For<ICurrentContext>();
         currentContext.UserId.Returns(Guid.NewGuid());
 
-        Assert.Null(sutProvider.Sut.GetStringVariation(_fakeKey, currentContext));
+        Assert.Null(sutProvider.Sut.GetStringVariation(_fakeFeatureKey, currentContext));
     }
 
     [Fact(Skip = "For local development")]