Upstream/bitwarden-server
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-02-18 02:11:22 +01:00
Code Issues Projects Releases Wiki Activity

[PM-5437] Handle client_credentials clientId that is not a valid GUID (#3616)

Browse Source 
* Return null if the clientId is not a valid Guid.

* Linting
This commit is contained in:
Todd Martin 2024-03-19 10:21:15 -04:00 committed by GitHub
parent 15eea77d66
commit 611a65e0a9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Identity/IdentityServer/ClientStore.cs
View File

@ -90,7 +90,12 @@ public class ClientStore : IClientStore
private async Task<Client> CreateApiKeyClientAsync(string clientId) private async Task<Client> CreateApiKeyClientAsync(string clientId)
{ {
var apiKey = await _apiKeyRepository.GetDetailsByIdAsync(new Guid(clientId)); if (!Guid.TryParse(clientId, out var guid))
{
return null;
}
var apiKey = await _apiKeyRepository.GetDetailsByIdAsync(guid);
if (apiKey == null || apiKey.ExpireAt <= DateTime.Now) if (apiKey == null || apiKey.ExpireAt <= DateTime.Now)
{ {