From 7d9a2cdd95a9726c2f58a54d3d7c2d80f327febc Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Tue, 4 Apr 2017 17:22:47 -0400
Subject: [PATCH] cipher details with subvaults api

---
 src/Api/Controllers/CiphersController.cs      | 17 +++++++++++++-
 .../Api/Response/CipherResponseModel.cs       | 22 +++++++++++++++++--
 .../Repositories/ISubvaultCipherRepository.cs |  1 +
 .../SqlServer/SubvaultCipherRepository.cs     | 13 +++++++++++
 src/Sql/Sql.sqlproj                           |  1 +
 .../SubvaultCipher_ReadByCipherId.sql         | 20 +++++++++++++++++
 6 files changed, 71 insertions(+), 3 deletions(-)
 create mode 100644 src/Sql/dbo/Stored Procedures/SubvaultCipher_ReadByCipherId.sql

diff --git a/src/Api/Controllers/CiphersController.cs b/src/Api/Controllers/CiphersController.cs
index e7702834c..624b71e12 100644
--- a/src/Api/Controllers/CiphersController.cs
+++ b/src/Api/Controllers/CiphersController.cs
@@ -44,6 +44,21 @@ namespace Bit.Api.Controllers
             return new CipherResponseModel(cipher);
         }
 
+        [HttpGet("{id}/full-details")]
+        public async Task<CipherFullDetailsResponseModel> GetDetails(string id)
+        {
+            var userId = _userService.GetProperUserId(User).Value;
+            var cipherId = new Guid(id);
+            var cipher = await _cipherRepository.GetFullDetailsByIdAsync(cipherId, userId);
+            if(cipher == null)
+            {
+                throw new NotFoundException();
+            }
+
+            var subvaultCiphers = await _subvaultCipherRepository.GetManyByUserIdCipherIdAsync(userId, cipherId);
+            return new CipherFullDetailsResponseModel(cipher, subvaultCiphers);
+        }
+
         [HttpGet("")]
         public async Task<ListResponseModel<CipherResponseModel>> Get()
         {
@@ -53,7 +68,7 @@ namespace Bit.Api.Controllers
             return new ListResponseModel<CipherResponseModel>(responses);
         }
 
-        [HttpGet("subvaults")]
+        [HttpGet("details")]
         public async Task<ListResponseModel<CipherDetailsResponseModel>> GetSubvaults()
         {
             var userId = _userService.GetProperUserId(User).Value;
diff --git a/src/Core/Models/Api/Response/CipherResponseModel.cs b/src/Core/Models/Api/Response/CipherResponseModel.cs
index eb27da1f5..716c31a17 100644
--- a/src/Core/Models/Api/Response/CipherResponseModel.cs
+++ b/src/Core/Models/Api/Response/CipherResponseModel.cs
@@ -45,8 +45,8 @@ namespace Bit.Core.Models.Api
     public class CipherDetailsResponseModel : CipherResponseModel
     {
         public CipherDetailsResponseModel(CipherDetails cipher,
-            IDictionary<Guid, IGrouping<Guid, SubvaultCipher>> subvaultCiphers)
-            : base(cipher, "cipherDetails")
+            IDictionary<Guid, IGrouping<Guid, SubvaultCipher>> subvaultCiphers, string obj = "cipherDetails")
+            : base(cipher, obj)
         {
             if(subvaultCiphers.ContainsKey(cipher.Id))
             {
@@ -58,6 +58,24 @@ namespace Bit.Core.Models.Api
             }
         }
 
+        public CipherDetailsResponseModel(CipherDetails cipher, IEnumerable<SubvaultCipher> subvaultCiphers,
+            string obj = "cipherDetails")
+            : base(cipher, obj)
+        {
+            SubvaultIds = subvaultCiphers.Select(s => s.SubvaultId);
+        }
+
         public IEnumerable<Guid> SubvaultIds { get; set; }
     }
+
+    public class CipherFullDetailsResponseModel : CipherDetailsResponseModel
+    {
+        public CipherFullDetailsResponseModel(CipherFullDetails cipher, IEnumerable<SubvaultCipher> subvaultCiphers)
+            : base(cipher, subvaultCiphers, "cipherFullDetails")
+        {
+            Edit = cipher.Edit;
+        }
+
+        public bool Edit { get; set; }
+    }
 }
diff --git a/src/Core/Repositories/ISubvaultCipherRepository.cs b/src/Core/Repositories/ISubvaultCipherRepository.cs
index ef44859f2..4b6efefb1 100644
--- a/src/Core/Repositories/ISubvaultCipherRepository.cs
+++ b/src/Core/Repositories/ISubvaultCipherRepository.cs
@@ -8,5 +8,6 @@ namespace Bit.Core.Repositories
     public interface ISubvaultCipherRepository
     {
         Task<ICollection<SubvaultCipher>> GetManyByUserIdAsync(Guid userId);
+        Task<ICollection<SubvaultCipher>> GetManyByUserIdCipherIdAsync(Guid userId, Guid cipherId);
     }
 }
diff --git a/src/Core/Repositories/SqlServer/SubvaultCipherRepository.cs b/src/Core/Repositories/SqlServer/SubvaultCipherRepository.cs
index b7ae455d4..542167c9f 100644
--- a/src/Core/Repositories/SqlServer/SubvaultCipherRepository.cs
+++ b/src/Core/Repositories/SqlServer/SubvaultCipherRepository.cs
@@ -31,5 +31,18 @@ namespace Bit.Core.Repositories.SqlServer
                 return results.ToList();
             }
         }
+
+        public async Task<ICollection<SubvaultCipher>> GetManyByUserIdCipherIdAsync(Guid userId, Guid cipherId)
+        {
+            using(var connection = new SqlConnection(ConnectionString))
+            {
+                var results = await connection.QueryAsync<SubvaultCipher>(
+                    $"[dbo].[SubvaultCipher_ReadByUserIdCipherId]",
+                    new { UserId = userId, CipherId = cipherId },
+                    commandType: CommandType.StoredProcedure);
+
+                return results.ToList();
+            }
+        }
     }
 }
diff --git a/src/Sql/Sql.sqlproj b/src/Sql/Sql.sqlproj
index bd0592ea9..fbc5b588d 100644
--- a/src/Sql/Sql.sqlproj
+++ b/src/Sql/Sql.sqlproj
@@ -182,5 +182,6 @@
     <Build Include="dbo\Stored Procedures\OrganizationUserUserDetails_ReadByOrganizationId.sql" />
     <Build Include="dbo\Stored Procedures\Subvault_ReadByOrganizationIdAdminUserId.sql" />
     <Build Include="dbo\User Defined Types\GuidIdArray.sql" />
+    <Build Include="dbo\Stored Procedures\SubvaultCipher_ReadByCipherId.sql" />
   </ItemGroup>
 </Project>
\ No newline at end of file
diff --git a/src/Sql/dbo/Stored Procedures/SubvaultCipher_ReadByCipherId.sql b/src/Sql/dbo/Stored Procedures/SubvaultCipher_ReadByCipherId.sql
new file mode 100644
index 000000000..b0969e46b
--- /dev/null
+++ b/src/Sql/dbo/Stored Procedures/SubvaultCipher_ReadByCipherId.sql	
@@ -0,0 +1,20 @@
+CREATE PROCEDURE [dbo].[SubvaultCipher_ReadByUserIdCipherId]
+    @UserId UNIQUEIDENTIFIER,
+    @CipherId UNIQUEIDENTIFIER
+AS
+BEGIN
+    SET NOCOUNT ON
+
+    SELECT
+        SC.*
+    FROM
+        [dbo].[SubvaultCipher] SC
+    INNER JOIN
+        [dbo].[SubvaultUser] SU ON SU.[SubvaultId] = SC.[SubvaultId]
+    INNER JOIN
+        [dbo].[OrganizationUser] OU ON OU.[Id] = SU.[OrganizationUserId]
+    WHERE
+        SC.[CipherId] = @CipherId
+        AND OU.[UserId] = @UserId
+        AND OU.[Status] = 2 -- Confirmed
+END
\ No newline at end of file