u2f db updates

src/Core/Identity/U2fTokenProvider.cs

@@ -10,6 +10,7 @@ using System.Linq;
 using U2fLib = U2F.Core.Crypto.U2F;
 using U2F.Core.Models;
 using U2F.Core.Exceptions;
+using System;
 
 namespace Bit.Core.Identity
 {
@@ -80,7 +81,8 @@ namespace Bit.Core.Identity
                     Challenge = auth.Challenge,
                     KeyHandle = auth.KeyHandle,
                     Version = auth.Version,
-                    UserId = user.Id
+                    UserId = user.Id,
+                    CreationDate = DateTime.UtcNow
                 });
 
                 challenges.Add(new

src/Core/Services/Implementations/UserService.cs

@@ -281,13 +281,14 @@ namespace Bit.Core.Services
         public async Task<U2fRegistration> StartU2fRegistrationAsync(User user)
         {
             await _u2fRepository.DeleteManyByUserIdAsync(user.Id);
-            var reg = U2fLib.StartRegistration(Utilities.CoreHelpers.U2fAppIdUrl(_globalSettings));
+            var reg = U2fLib.StartRegistration(CoreHelpers.U2fAppIdUrl(_globalSettings));
             await _u2fRepository.CreateAsync(new U2f
             {
                 AppId = reg.AppId,
                 Challenge = reg.Challenge,
                 Version = reg.Version,
-                UserId = user.Id
+                UserId = user.Id,
+                CreationDate = DateTime.UtcNow
             });
 
             return new U2fRegistration

src/Sql/Sql.sqlproj

@@ -229,5 +229,6 @@
     <Build Include="dbo\Stored Procedures\User_ReadByPremiumRenewal.sql" />
     <Build Include="dbo\Stored Procedures\User_UpdateRenewalReminderDate.sql" />
     <Build Include="dbo\Stored Procedures\Grant_DeleteExpired.sql" />
+    <Build Include="dbo\Stored Procedures\U2f_DeleteOld.sql" />
   </ItemGroup>
 </Project>

src/Sql/dbo/Stored Procedures/U2f_DeleteOld.sql

@@ -0,0 +1,19 @@
+CREATE PROCEDURE [dbo].[U2f_DeleteOld]
+AS
+BEGIN
+    SET NOCOUNT ON
+
+    DECLARE @BatchSize INT = 100
+    DECLARE @Threshold DATETIME2(7) = DATEADD (day, -7, GETUTCDATE())
+
+    WHILE @BatchSize > 0
+    BEGIN
+        DELETE TOP(@BatchSize)
+        FROM
+            [dbo].[U2f]
+        WHERE
+            [CreationDate] < @Threshold
+
+        SET @BatchSize = @@ROWCOUNT
+    END
+END

src/Sql/dbo/Tables/U2f.sql

@@ -10,3 +10,13 @@
     CONSTRAINT [FK_U2f_User] FOREIGN KEY ([UserId]) REFERENCES [dbo].[User] ([Id])
 );
 
+
+GO
+CREATE NONCLUSTERED INDEX [IX_U2f_CreationDate]
+    ON [dbo].[U2f]([CreationDate] ASC)
+
+
+GO
+CREATE NONCLUSTERED INDEX [IX_U2f_UserId]
+    ON [dbo].[U2f]([UserId] ASC);
+

util/Setup/DbScripts/2018-06-11_00_WebVaultUpdates.sql

@@ -27,6 +27,26 @@ BEGIN
 END
 GO
 
+IF NOT EXISTS (
+    SELECT * FROM sys.indexes  WHERE [Name]='IX_U2f_CreationDate'
+    AND object_id = OBJECT_ID('[dbo].[U2f]')
+)
+BEGIN
+    CREATE NONCLUSTERED INDEX [IX_U2f_CreationDate]
+        ON [dbo].[U2f]([CreationDate] ASC)
+END
+GO
+
+IF NOT EXISTS (
+    SELECT * FROM sys.indexes  WHERE [Name]='IX_U2f_UserId'
+    AND object_id = OBJECT_ID('[dbo].[U2f]')
+)
+BEGIN
+    CREATE NONCLUSTERED INDEX [IX_U2f_UserId]
+        ON [dbo].[U2f]([UserId] ASC)
+END
+GO
+
 IF EXISTS(SELECT * FROM sys.views WHERE [Name] = 'UserView')
 BEGIN
     DROP VIEW [dbo].[UserView]
@@ -41,6 +61,33 @@ FROM
     [dbo].[User]
 GO
 
+IF OBJECT_ID('[dbo].[U2f_DeleteOld]') IS NOT NULL
+BEGIN
+    DROP PROCEDURE [dbo].[U2f_DeleteOld]
+END
+GO
+
+CREATE PROCEDURE [dbo].[U2f_DeleteOld]
+AS
+BEGIN
+    SET NOCOUNT ON
+
+    DECLARE @BatchSize INT = 100
+    DECLARE @Threshold DATETIME2(7) = DATEADD (day, -7, GETUTCDATE())
+
+    WHILE @BatchSize > 0
+    BEGIN
+        DELETE TOP(@BatchSize)
+        FROM
+            [dbo].[U2f]
+        WHERE
+            [CreationDate] < @Threshold
+
+        SET @BatchSize = @@ROWCOUNT
+    END
+END
+GO
+
 IF OBJECT_ID('[dbo].[Grant_DeleteExpired]') IS NOT NULL
 BEGIN
     DROP PROCEDURE [dbo].[Grant_DeleteExpired]