Upstream/bitwarden-server
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2024-11-29 13:25:17 +01:00
Code Issues Projects Releases Wiki Activity

cleanup ResourceOwnerPasswordValidator

Browse Source
This commit is contained in:
Kyle Spearrin 2017-01-25 00:28:18 -05:00
parent ef38719253
commit 9fe2a4dfb5
1 changed files with 33 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/Api/IdentityServer/ResourceOwnerPasswordValidator.cs
View File

@ -53,8 +53,10 @@ namespace Bit.Api.IdentityServer
var ticket = ValidateOldAuthBearer(oldAuthBearer); var ticket = ValidateOldAuthBearer(oldAuthBearer);
if(ticket != null && ticket.Principal != null) if(ticket != null && ticket.Principal != null)
{ {
var idClaim = ticket.Principal.Claims.FirstOrDefault(c => c.Type == _identityOptions.ClaimsIdentity.UserIdClaimType); var idClaim = ticket.Principal.Claims
var securityTokenClaim = ticket.Principal.Claims.FirstOrDefault(c => c.Type == _identityOptions.ClaimsIdentity.SecurityStampClaimType); .FirstOrDefault(c => c.Type == _identityOptions.ClaimsIdentity.UserIdClaimType);
var securityTokenClaim = ticket.Principal.Claims
.FirstOrDefault(c => c.Type == _identityOptions.ClaimsIdentity.SecurityStampClaimType);
if(idClaim != null && securityTokenClaim != null) if(idClaim != null && securityTokenClaim != null)
{ {
var user = await _userManager.FindByIdAsync(idClaim.Value); var user = await _userManager.FindByIdAsync(idClaim.Value);
@ -76,10 +78,7 @@ namespace Bit.Api.IdentityServer
{ {
if(!twoFactorRequest && await TwoFactorRequiredAsync(user)) if(!twoFactorRequest && await TwoFactorRequiredAsync(user))
{ {
context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, "Two factor required.", BuildTwoFactorResult(user, context);
new Dictionary<string, object> {
{ "TwoFactorRequired", true },
{ "TwoFactorProviders", new string[] { ((int?)user.TwoFactorProvider)?.ToString() } } });
return; return;
} }
@ -93,12 +92,8 @@ namespace Bit.Api.IdentityServer
} }
} }
await Task.Delay(2000); await Task.Delay(2000); // Delay for brute force.
context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, customResponse: BuildErrorResult(twoFactorRequest, context);
new Dictionary<string, object> { {
"ErrorModel", new ErrorResponseModel(twoFactorRequest ?
"Code is not correct. Try again." : "Username or password is incorrect. Try again.")
} });
} }
private void Init() private void Init()
@ -128,6 +123,32 @@ namespace Bit.Api.IdentityServer
claims: claims.Count > 0 ? claims : null); claims: claims.Count > 0 ? claims : null);
} }
private void BuildTwoFactorResult(User user, ResourceOwnerPasswordValidationContext context)
{
var providers = new List<byte>();
if(user.TwoFactorProvider.HasValue)
{
providers.Add((byte)user.TwoFactorProvider.Value);
}
context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, "Two factor required.",
new Dictionary<string, object>
{
{ "TwoFactorRequired", true },
{ "TwoFactorProviders", providers }
});
}
private void BuildErrorResult(bool twoFactorRequest, ResourceOwnerPasswordValidationContext context)
{
context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, customResponse:
new Dictionary<string, object>
{{
"ErrorModel", new ErrorResponseModel(twoFactorRequest ?
"Code is not correct. Try again." : "Username or password is incorrect. Try again.")
}});
}
private AuthenticationTicket ValidateOldAuthBearer(string token) private AuthenticationTicket ValidateOldAuthBearer(string token)
{ {
SecurityToken validatedToken; SecurityToken validatedToken;