mirror of
https://github.com/bitwarden/server.git
synced 2024-11-21 12:05:42 +01:00
Use latest PR template (#4128)
This commit is contained in:
parent
5d47adb0fa
commit
acfe1559d7
47
.github/PULL_REQUEST_TEMPLATE.md
vendored
47
.github/PULL_REQUEST_TEMPLATE.md
vendored
@ -1,30 +1,35 @@
|
|||||||
## Type of change
|
## 🎟️ Tracking
|
||||||
|
|
||||||
<!-- (mark with an `X`) -->
|
<!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. -->
|
||||||
|
|
||||||
```
|
## 📔 Objective
|
||||||
- [ ] Bug fix
|
|
||||||
- [ ] New feature development
|
|
||||||
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
|
|
||||||
- [ ] Build/deploy pipeline (DevOps)
|
|
||||||
- [ ] Other
|
|
||||||
```
|
|
||||||
|
|
||||||
## Objective
|
<!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. -->
|
||||||
<!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding-->
|
|
||||||
|
|
||||||
|
## 📸 Screenshots
|
||||||
|
|
||||||
|
<!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. -->
|
||||||
|
|
||||||
## Code changes
|
## ⏰ Reminders before review
|
||||||
<!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes-->
|
|
||||||
<!--Also refer to any related changes or PRs in other repositories-->
|
|
||||||
|
|
||||||
* **file.ext:** Description of what was changed and why
|
- Contributor guidelines followed
|
||||||
|
- All formatters and local linters executed and passed
|
||||||
|
- Written new unit and / or integration tests where applicable
|
||||||
|
- Protected functional changes with optionality (feature flags)
|
||||||
|
- Used internationalization (i18n) for all UI strings
|
||||||
|
- CI builds passed
|
||||||
|
- Communicated to DevOps any deployment requirements
|
||||||
|
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
|
||||||
|
|
||||||
## Before you submit
|
## 🦮 Reviewer guidelines
|
||||||
|
|
||||||
- Please check for formatting errors (`dotnet format --verify-no-changes`) (required)
|
<!-- Suggested interactions but feel free to use (or not) as you desire! -->
|
||||||
- If making database changes - make sure you also update Entity Framework queries and/or migrations
|
|
||||||
- Please add **unit tests** where it makes sense to do so (encouraged but not required)
|
- 👍 (`:+1:`) or similar for great changes
|
||||||
- If this change requires a **documentation update** - notify the documentation team
|
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
|
||||||
- If this change has particular **deployment requirements** - notify the DevOps team
|
- ❓ (`:question:`) for questions
|
||||||
|
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
|
||||||
|
- 🎨 (`:art:`) for suggestions / improvements
|
||||||
|
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention
|
||||||
|
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt
|
||||||
|
- ⛏ (`:pick:`) for minor or nitpick changes
|
||||||
|
Loading…
Reference in New Issue
Block a user