1
0
mirror of https://github.com/bitwarden/server.git synced 2024-11-25 12:45:18 +01:00

Allow acceptable result ranges for integration tests (#3161)

This commit is contained in:
Matt Gibson 2023-08-08 13:49:51 -04:00 committed by GitHub
parent ab5c6d088b
commit ca368466ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -488,9 +488,9 @@ public class IdentityServerTests : IClassFixture<IdentityApplicationFactory>
} }
[Theory, BitAutoData] [Theory, BitAutoData]
public async Task TokenEndpoint_ToQuickInOneSecond_BlockRequest(string deviceId) public async Task TokenEndpoint_TooQuickInOneSecond_BlockRequest(string deviceId)
{ {
const int AmountInOneSecondAllowed = 5; const int AmountInOneSecondAllowed = 10;
// The rule we are testing is 10 requests in 1 second // The rule we are testing is 10 requests in 1 second
var username = "test+ratelimiting@email.com"; var username = "test+ratelimiting@email.com";
@ -514,9 +514,9 @@ public class IdentityServerTests : IClassFixture<IdentityApplicationFactory>
} }
var responses = (await Task.WhenAll(tasks)).ToList(); var responses = (await Task.WhenAll(tasks)).ToList();
var blockResponses = responses.Where(c => c.Response.StatusCode == StatusCodes.Status429TooManyRequests);
Assert.Equal(5, responses.Count(c => c.Response.StatusCode == StatusCodes.Status200OK)); Assert.True(blockResponses.Count() > 0);
Assert.Equal(1, responses.Count(c => c.Response.StatusCode == StatusCodes.Status429TooManyRequests));
Task<HttpContext> MakeRequest() Task<HttpContext> MakeRequest()
{ {