1
0
mirror of https://github.com/bitwarden/server.git synced 2024-11-22 12:15:36 +01:00

Fix typos in comments (#2876)

This commit is contained in:
Jim Hays 2023-05-09 11:38:47 -04:00 committed by GitHub
parent 0bd0910c39
commit f9038472ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 13 additions and 13 deletions

View File

@ -308,8 +308,8 @@ public class AccountController : Controller
await HttpContext.SignOutAsync(); await HttpContext.SignOutAsync();
} }
// HACK: Temporary workaroud for the time being that doesn't try to sign out of OneLogin schemes, // HACK: Temporary workaround for the time being that doesn't try to sign out of OneLogin schemes,
// which doesnt support SLO // which doesn't support SLO
if (externalAuthenticationScheme != null && !externalAuthenticationScheme.Contains("onelogin")) if (externalAuthenticationScheme != null && !externalAuthenticationScheme.Contains("onelogin"))
{ {
// Build a return URL so the upstream provider will redirect back // Build a return URL so the upstream provider will redirect back

View File

@ -12,7 +12,7 @@ public static class ClaimsExtensions
{ {
var normalizedClaims = claims.Select(c => (Normalize(c.Type), c.Value)).ToList(); var normalizedClaims = claims.Select(c => (Normalize(c.Type), c.Value)).ToList();
// Order of prescendence is by passed in names // Order of precedence is by passed in names
foreach (var name in possibleNames.Select(Normalize)) foreach (var name in possibleNames.Select(Normalize))
{ {
// Second by order of claims (find claim by name) // Second by order of claims (find claim by name)

View File

@ -26,7 +26,7 @@ upstream identity_loadbalancer {
} }
server { server {
listen 33756; # The port clients will connect to for the Identiy, must be exposed via Docker listen 33756; # The port clients will connect to for the Identity, must be exposed via Docker
location / { location / {
proxy_pass http://identity_loadbalancer; proxy_pass http://identity_loadbalancer;
} }

View File

@ -527,7 +527,7 @@ public class ToolsController : Controller
} }
// This requires a redundant API call to Stripe because of the way they handle pagination. // This requires a redundant API call to Stripe because of the way they handle pagination.
// The StartingBefore value has to be infered from the list we get, and isn't supplied by Stripe. // The StartingBefore value has to be inferred from the list we get, and isn't supplied by Stripe.
private async Task<bool> StripeSubscriptionsGetHasPreviousPage(List<Stripe.Subscription> subscriptions, StripeSubscriptionListOptions options) private async Task<bool> StripeSubscriptionsGetHasPreviousPage(List<Stripe.Subscription> subscriptions, StripeSubscriptionListOptions options)
{ {
var hasPreviousPage = false; var hasPreviousPage = false;

View File

@ -140,7 +140,7 @@ public class StripePaymentService : IPaymentService
{ {
Country = taxInfo.BillingAddressCountry, Country = taxInfo.BillingAddressCountry,
PostalCode = taxInfo.BillingAddressPostalCode, PostalCode = taxInfo.BillingAddressPostalCode,
// Line1 is required in Stripe's API, suggestion in Docs is to use Business Name intead. // Line1 is required in Stripe's API, suggestion in Docs is to use Business Name instead.
Line1 = taxInfo.BillingAddressLine1 ?? string.Empty, Line1 = taxInfo.BillingAddressLine1 ?? string.Empty,
Line2 = taxInfo.BillingAddressLine2, Line2 = taxInfo.BillingAddressLine2,
City = taxInfo.BillingAddressCity, City = taxInfo.BillingAddressCity,

View File

@ -390,7 +390,7 @@ public class GlobalSettings : IGlobalSettings
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// The certificate path and <see cref="CertificatePassword"/> are passed into the <see cref="System.Security.Cryptography.X509Certificates.X509Certificate2.X509Certificate2(string, string)" />. /// The certificate path and <see cref="CertificatePassword"/> are passed into the <see cref="System.Security.Cryptography.X509Certificates.X509Certificate2.X509Certificate2(string, string)" />.
/// The file format of the certificate may be binary encded (DER) or base64. If the private key is encrypted, provide the password in <see cref="CertificatePassword"/>, /// The file format of the certificate may be binary encoded (DER) or base64. If the private key is encrypted, provide the password in <see cref="CertificatePassword"/>,
/// </remarks> /// </remarks>
public string CertificatePath { get; set; } public string CertificatePath { get; set; }
/// <summary> /// <summary>

View File

@ -50,7 +50,7 @@ public class CustomRedisProcessingStrategy : RedisProcessingStrategy
return SkipRateLimitResult(); return SkipRateLimitResult();
} }
// Check if any Redis timeouts have occured recently // Check if any Redis timeouts have occurred recently
if (_memoryCache.TryGetValue<TimeoutCounter>(_redisTimeoutCacheKey, out var timeoutCounter)) if (_memoryCache.TryGetValue<TimeoutCounter>(_redisTimeoutCacheKey, out var timeoutCounter))
{ {
// We've exceeded threshold, backoff Redis and skip rate limiting for now // We've exceeded threshold, backoff Redis and skip rate limiting for now

View File

@ -77,7 +77,7 @@ public static class LoggerFactoryExtensions
} }
else if (CoreHelpers.SettingHasValue(globalSettings?.Syslog.Destination)) else if (CoreHelpers.SettingHasValue(globalSettings?.Syslog.Destination))
{ {
// appending sitename to project name to allow eaiser identification in syslog. // appending sitename to project name to allow easier identification in syslog.
var appName = $"{globalSettings.SiteName}-{globalSettings.ProjectName}"; var appName = $"{globalSettings.SiteName}-{globalSettings.ProjectName}";
if (globalSettings.Syslog.Destination.Equals("local", StringComparison.OrdinalIgnoreCase)) if (globalSettings.Syslog.Destination.Equals("local", StringComparison.OrdinalIgnoreCase))
{ {

View File

@ -110,7 +110,7 @@ public class CollectionCipherRepository : BaseEntityFrameworkRepository, ICollec
foreach (var requestedCollectionId in collectionIds) foreach (var requestedCollectionId in collectionIds)
{ {
// I don't totally agree with t.CipherId = cipherId here because that should have been guarenteed by // I don't totally agree with t.CipherId = cipherId here because that should have been guaranteed by
// the WHERE above but the SQL Server CTE has it // the WHERE above but the SQL Server CTE has it
var existingCollectionCipher = collectionCiphers var existingCollectionCipher = collectionCiphers
.FirstOrDefault(t => t.CollectionId == requestedCollectionId && t.CipherId == cipherId); .FirstOrDefault(t => t.CollectionId == requestedCollectionId && t.CipherId == cipherId);

View File

@ -39,7 +39,7 @@ public class HandlebarsMailServiceTests
// This will send all emails to the test email address so that they can be viewed. // This will send all emails to the test email address so that they can be viewed.
var namedParameters = new Dictionary<(string, Type), object> var namedParameters = new Dictionary<(string, Type), object>
{ {
// TODO: Swith to use env variable // TODO: Switch to use env variable
{ ("email", typeof(string)), "test@bitwarden.com" }, { ("email", typeof(string)), "test@bitwarden.com" },
{ ("user", typeof(User)), new User { ("user", typeof(User)), new User
{ {

View File

@ -37,7 +37,7 @@ internal class CipherBuilder : ISpecimenBuilder
.Without(c => c.OrganizationId)); .Without(c => c.OrganizationId));
} }
// Can't test valid Favorites and Folders without creating those values inide each test, // Can't test valid Favorites and Folders without creating those values inside each test,
// since we won't have any UserIds until the test is running & creating data // since we won't have any UserIds until the test is running & creating data
fixture.Customize<Cipher>(c => c fixture.Customize<Cipher>(c => c
.Without(e => e.Favorites) .Without(e => e.Favorites)

View File

@ -55,7 +55,7 @@ WHERE
[ApiKey] IS NULL [ApiKey] IS NULL
GO GO
-- Change dbo.User.ApiKey to not null to enforece all future users to have one on create -- Change dbo.User.ApiKey to not null to enforce all future users to have one on create
ALTER TABLE ALTER TABLE
[dbo].[User] [dbo].[User]
ALTER COLUMN ALTER COLUMN