Upstream/bitwarden-server
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2024-11-23 12:25:16 +01:00
Code Issues Projects Releases Wiki Activity

remove additional queries since they can be abused

Browse Source
This commit is contained in:
Kyle Spearrin 2017-10-09 14:43:15 -04:00
parent 309c7f81ba
commit fe01a51a51
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Icons/Controllers/IconsController.cs
View File

@ -28,10 +28,7 @@ namespace Bit.Icons.Controllers
} }
[HttpGet("")] [HttpGet("")]
public async Task<IActionResult> Get( public async Task<IActionResult> Get([FromQuery]string domain)
[FromQuery]string domain,
[FromQuery]string size = "16..24..200",
[FromQuery]string formats = null)
{ {
if(string.IsNullOrWhiteSpace(domain)) if(string.IsNullOrWhiteSpace(domain))
{ {
@ -49,12 +46,12 @@ namespace Bit.Icons.Controllers
} }
var mappedDomain = _domainMappingService.MapDomain(uri.Host); var mappedDomain = _domainMappingService.MapDomain(uri.Host);
var cacheKey = $"{mappedDomain}_{size}_{formats}"; var cacheKey = $"{mappedDomain}";
var icon = await _memoryCache.GetOrCreateAsync(cacheKey, async entry => var icon = await _memoryCache.GetOrCreateAsync(cacheKey, async entry =>
{ {
entry.AbsoluteExpiration = DateTime.UtcNow.AddHours(_iconsSettings.CacheHours); entry.AbsoluteExpiration = DateTime.UtcNow.AddHours(_iconsSettings.CacheHours);
var iconUrl = $"{_iconsSettings.BestIconBaseUrl}/icon?url={mappedDomain}&size={size}&formats={formats}"; var iconUrl = $"{_iconsSettings.BestIconBaseUrl}/icon?url={mappedDomain}&size=16..24..32";
var response = await _httpClient.GetAsync(iconUrl); var response = await _httpClient.GetAsync(iconUrl);
if(!response.IsSuccessStatusCode) if(!response.IsSuccessStatusCode)
{ {