1
0
mirror of https://github.com/bitwarden/server.git synced 2024-11-29 13:25:17 +01:00
Commit Graph

4029 Commits

Author SHA1 Message Date
SmithThe4th
53b9d52125
[PM-1675] Timeout or transient error when verifying domains (#2835)
* Increased timeout of the dns resolve method and changed the lifetime of the dnsResolverService to scoped

* Reverted to using singleton as this was recommneded on the docs and also registered lookup client as a singleton

* Registerered a singleton service of ILookupClient

* replaced unused serviceProvider with a discard
2023-04-06 15:31:45 -04:00
aj-rosado
49f15d8cc1
[PS-2390] Updating and adding items into folder and collection on import (#2717)
* PS-2390 Adding Id to the Collection/Folder RequestModel
replacing folder/collection when they already exist instead of creating a new one
Adding items to existing collections if the id matches

* PS-2390 Improved Folder/Collection RequestModel code design

* PS-2390 Removed whitespaces from FolderRequestModel

* PS-2390 Verifying if folder/collection belongs to user/organization when updating or creating a new one

* PS-2390 - Removed unnecessary null validation for Id on Folder/CollectionRequestModel

* PS-2390 - Added bulk methods to get and update folders at import

* PS-2390 - Added bulk methods to get and update collections at import org

* PS-2390 - Corrected sqlproj path to Folder_ReadByIdsAndUserId

* PS-2390 - Improved code readibility

* PS-2390 - Added newlines to EOF

* PS-2390 Remove logic to update folders/collections at import

* PS-2390 - removed unnecessary methods and imports

* PS-2390 - Removed unnecessary formatting change

* PS-2390 - Removed unused variable
2023-04-05 19:18:14 +01:00
SmithThe4th
6551d9176b
Modified sso details stored procedure to remove policy checks or an organization (#2831) 2023-04-03 11:03:59 -04:00
Oscar Hinton
60bdf77e8b
[SM-574] Wire up read/write for secret list and secret response (#2767)
* Wire up read/write for secret list and secret response

* Fix trash

* Remove UserHasReadPermission

* Fix list by project

* Implement admin and service accounts for AccessToSecretAsync

* Resolve feedback

* Fix tests

* Rename function

* Change create to return true, true

* Remove duplicated access check
2023-03-30 16:51:46 +02:00
Oscar Hinton
60fcc79f97
[SM-680] Add reference event logging to secrets (#2824)
* Add reference event logging to secrets

* Change to IHostEnvironment

* Fix namespace for ef service collection
2023-03-30 15:37:19 +02:00
Álison Fernandes
7da272dae8
Update Secrets Manager team in CODEOWNERS (#2829) 2023-03-30 14:06:35 +01:00
Stephen Kaiser
3b50ccb9f8
fix: mssql error when running docker compose (#2810)
Fixes the error message, "services.mssql.environment.ACCEPT_EULA must be a string, number or null" when running `docker compose --profile mssql --profile mail up -d` during initial dev setup on MacOS.
2023-03-23 12:14:40 -04:00
Stephen Kaiser
a680dec0d4
[PM-1507] fix: Use camel case for docker default network (#2811)
* fix: Use camel case for docker default network

* Update project name in .env.example
2023-03-23 16:43:18 +01:00
André Bispo
49587dc2a9
[PM-1026] Add constant key to retrieve feature flag from darkly sdk. (#2823)
* [PM-1026] Add constant key to retrieve feature flag from darkly sdk.

* [PM-1026] Rename constant
2023-03-23 13:54:04 +00:00
André Bispo
bf4e039911
[PM-107] Remove fingerprint phase 2 (#2809)
* [PM-131] Remove fingerprint (#2759)

* [PM-107][PM-131] Remove fingerprint property from auth request

* [PM-107][PM-131] Remove fingerprint property from comparer

* [PM-132] Drop fingerprint phrase (#2803)

* [PM-132] Added migrations to remove fingerprint phrase from db

* [PM-132] Remove fp from stored procedures
2023-03-23 13:08:49 +00:00
Matt Bishop
39f884ddcc
Provide anonymous user context for unauthenticated requests using LaunchDarkly (#2819) 2023-03-22 11:05:09 -04:00
Colton Hurst
d7b091d7d6
SM-662: Make sm controller test class names plural (#2816) 2023-03-22 11:04:50 -04:00
Thomas Avery
56d3c3a5d1
Add in integration tests (#2806) 2023-03-21 17:12:13 -05:00
github-actions[bot]
5616cd5403
Bumped version to 2023.3.0 (#2817)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-03-21 15:09:32 -06:00
André Bispo
2e3e96a25c
[PM-1095][PM-1104] Update email template (#2746)
* [SG-994] Add import Open Sans font to full template

* [SG-994] Update organization user invite email template to new UI

* [SG-994] update alt text for mobile app download buttons

* [SG-994] Update copy. Add hyperlinks to stores.

* [SG-944] Improve layout responsiveness

* [PM-1095][PM-1104] Add new template for title and contact us. Add new template for user organization invite

* [PM-1095][PM-1104] Remove wrong text from free invite

* [PM-1104][PM-1095] Add bold class. Add margin.

* [PM-1104][PM-1095] Change font type to previously used

* [PM-1104][PM-1095] Remove Open Sans font

* [PM-1104][PM-1095] Improve browsers rendering compatibility

* [PM-1104][PM-1095] Fixed margins

* [PM-1095][PM-1104] Remove unnecessary string sanitise.
2023-03-21 14:44:58 +00:00
Matt Bishop
3d0ca908ff
Use all organization memberships for LaunchDarkly user context, better separate context kinds (#2807)
* Use all organization memberships for LaunchDarkly context

* Use simpler null check

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Remove unnecessary interpolation

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Remove unnecessary interpolation

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Fully spell out organizations

* Use client type for context separation decisions

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2023-03-20 11:48:45 -04:00
Michał Chęciński
e667908a06
Fix self contained mssqlmigratorutility (#2804)
* Fix self-contained mssqlmigratorutility

* Fix build

* Fix

* Fix
2023-03-15 16:57:36 +01:00
Colton Hurst
1dc9aad1f1
SM-655: Add Authorizations and Tests for the SM Porting Controller (#2802)
* SM-655: Add Authorize attribute for secrets on the SM Porting Controller

* SM-655: Add access secrets manager check to SM Import and Export

* SM-655: Add tests for export and import endpoints
2023-03-15 11:51:01 -04:00
Justin Baur
388caa28f8
Remove Visual Studio Code Generation Package (#2749) 2023-03-14 15:44:53 -04:00
mimartin12
f33c4e120d
Fix build.yml - Update tag generator to not use beta (#2800) 2023-03-14 11:30:17 -06:00
André Bispo
3008759e8a
[PM-1317] Make fingerprint phrase property optional. (#2796) 2023-03-13 15:43:44 +00:00
Jake Fink
2f6e463012
[AC-1105] allow users with manage groups permission to access collections (#2780) 2023-03-13 11:09:44 -04:00
cyprain-okeke
24d227d075
[PM 237] Test Clock Error in Production when attempting to view Stripe Subscription page (#2745)
* Check for environment before hitting TestClock

* Getting the environment from WebHotsEnvironment

* Dotnet format changes
2023-03-12 17:10:07 +01:00
Jake Fink
dafcdde715
[AC-1110] add deleteAnyCollection permission to bulk delete (#2766)
* [AC-1110] add deleteAnyCollection permission to bulk delete

* [AC-1110] call collection service instead of repo for user collections

* [AC-1110] fix tests

* [AC-1110] fix more tests
2023-03-10 12:53:22 -05:00
Jake Fink
e5aafe1c8b
[AC-1046] add browser autofill policy (#2751)
* [EC-1046] add browser autofill policy

* [AC-1046] check plan when activating policy

* [AC-1046] add useActivateAutofillPolicy to Organization response

* [AC-1046] add UseActivateAutofillPolicy to provider org response
2023-03-10 12:52:50 -05:00
Colton Hurst
397f3d6865
SM-561: Update Secret Revision Dates (#2770)
* SM-561: Update secret revision date on restore

* SM-561: Update secret revision dates when a project is deleted

* SM-561: Fix bug when updating revision dates for secrets when their parent project is deleted

* SM-561: Handle case when there are no secrets in the projects that are being deleted

* SM-561: Rename func to GetManyWithSecretsByIds and move UpdateRevisionDates call from ProjectsController to projects delete command

* SM-561: update secret ids before project deletion

* SM-561: Refactor out command in command call to follow CQRS pattern

* SM-561: Remove null check
2023-03-10 11:54:19 -05:00
Thomas Avery
250509c7ac
Add fix for MSP's enabling secrets manager (#2794) 2023-03-10 09:52:07 -06:00
Matt Bishop
bd666841a5
All feature state access through config API (#2785) 2023-03-10 08:11:11 -05:00
SmithThe4th
efe7ae8d07
[SG-648] BEEEP-Refactor DuoApi class to use Httpclient (#2793)
* Started work on refactoring class

* Added duo api respons model

* Made httpclient version of APICall

* Added more properties to response model

* Refactored duo api class to use httpclient

* Removed unuseful comments

* Fixed lint formatting
2023-03-09 16:33:01 -05:00
Oscar Hinton
6a6b15fada
[SM-567] Change how project permission is resolved (#2791)
* Change how project permission is resolved

* Fix tests

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2023-03-09 11:23:50 -06:00
SmithThe4th
15954fb679
Revert "[SG-648] BEEEP-Refactor DuoApi class to use Httpclient (#2691)" (#2792)
This reverts commit f11c58e396.
2023-03-09 12:07:12 -05:00
Opeyemi
03bbc7195b
update entry.sh file for bw apps (#2771) 2023-03-09 14:20:46 +00:00
Colton Hurst
a18ab213e4
SM-609: Block imports where any secret is associated with more than one project (#2789) 2023-03-09 08:15:22 -05:00
github-actions[bot]
b3a2141ed3
Bumped version to 2023.2.2 (#2787)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-03-08 22:51:11 +00:00
Kyle Spearrin
a4cb6e0900
freshdesk now requires "Basic" to be appended to api key (#2786) 2023-03-08 14:12:44 -05:00
cd-bitwarden
a4d637a9b3
[SM-401] - add ability to edit service accounts - Update ServiceAccountsController.cs to get one service account by Id (#2755)
* Update ServiceAccountsController.cs

* Update ServiceAccountsController.cs

updates to access checks

* Update src/Api/SecretsManager/Controllers/ServiceAccountsController.cs

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* fixing error

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2023-03-08 09:37:02 -05:00
Matt Gibson
465681c712
Use encoded query parameters over path (#2682)
* Use encoded query parameters over path

* Prefer POST for requests with sensitive information

* Send private information in headers over query

* B64 encode email
2023-03-07 12:49:29 -06:00
Matt Bishop
11c59addf4
[PM-1012] Feature access using context (#2764)
* Document online method

* Feature accessors with context

* Direct null assertion

* Establish a constants class for flag keys
2023-03-07 13:46:52 -05:00
cd-bitwarden
7334de636b
[SM-577] - ACCESS POLICY fixing issue with user being able to update a secret if they are assi… (#2763)
* fixing issue with user being able to update a secret if they are assigning it to a project that has read/write permissions. Even though the customer is only allowed to read.

* Add additional check for newly assigned project access and original project access.

* fixing Lint issue

* Fixing tests

* uneeded param removed

* Updating to extract logic into function

* renaming function

* lint fixes

* renaming function
2023-03-07 13:22:03 -05:00
Matt Bishop
48ae4a2e92
Include migrator utility in solution (#2776) 2023-03-07 10:29:05 -05:00
Thomas Avery
c27b323ef2
[SM-604] Filter for only confirmed Org users in potential grantees (#2773)
* Filter for only confirmed users

* Take out assert.recent for long running test
2023-03-07 09:03:09 -06:00
Andreas Coroiu
2c9df6d1ff
[PM-1191] collections cannot be managed in family organization (#2765)
* [PM-1191] fix: use join instead of select-subquery

EF6 is currently not able to translate LINQ that include selects after groupby statements. Using join let's us bypass this issue.

* [PM-1191] chore: simplify queries

* Revert "[PM-1191] chore: simplify queries"

This reverts commit f57443d8c4.
2023-03-07 08:35:39 -05:00
Michał Chęciński
5e3f4c9bbe
Revert "Revert "[DEVOPS-1215] Build migrator CLI project (#2747)" (#2769)" (#2774)
This reverts commit f8cbd4ef7d.
2023-03-07 14:10:34 +01:00
Oscar Hinton
2c8f23ec9b
[SM-579] Prevent creating secrets not attached to projects (#2754)
* Prevent creating secrets not attached to projects, and prevent updating secrets to remove project relation

* Fix test
2023-03-07 10:13:49 +01:00
Thomas Rittson
14c8edfcb7
Remove obsolete selfhosted license endpoints (#2727) 2023-03-07 03:28:29 +00:00
Oscar Hinton
a0df350ea3
[SM-568] Delete service accounts (#2748) 2023-03-06 20:25:27 +01:00
Thomas Avery
de559e80f4
[SM-581] Adding support for warning dialogs (#2762)
* Adding support for warning dialogs

* Swap to repository layer implementation
2023-03-06 11:31:56 -06:00
Michał Chęciński
f8cbd4ef7d
Revert "[DEVOPS-1215] Build migrator CLI project (#2747)" (#2769)
This reverts commit 9cbf254fef.
2023-03-06 18:02:19 +01:00
Michał Chęciński
9cbf254fef
[DEVOPS-1215] Build migrator CLI project (#2747)
* Add migrator cli

* Ran format

* Acc build workflow

* Change paths in push and pr triggers

* Add build migrator cli to build workflow

* Remove build migrator cli workflow

* Add different levels of logs for verbose

* Rename migratorCLI to MsSqlMigratorUtility

* Add MsSqlMigratorUtility to solution file

* Remove the clean command

* Fix name and path in build workflow

* Add retry logic to DbMigrator instead of invocation

* Add migrator with retry mechanism as a new method

* Log the migration start log to migrate database method

* Fix name in build

* Fix cli leftovers

* Fix exception var name

* String interpolation

* Remove redundant check for number

* Remove CommandDotNet

* dotnet format

* Remove CommandDotNet from packages lock

* Remove all cli

* Trying to remove usings to see if this fixes linter

* Add usings back again - uild is failing

* Remove implicit usings

* Trying to fix linter issues

* Trying to fix linter
2023-03-06 15:39:30 +01:00
Matt Bishop
27adaf59b4
[PM-1011] LaunchDarkly service (#2726)
* LaunchDarkly service

* Load file-based flag values, properly support offline only when self-host

* Simplify tests

* Use interface for LD settings

* Remove tests that will provide inconsistent results depending on machine setup and file fallback

* Fall back to offline mode more actively

* Drive fallback file path with setting
2023-03-02 14:04:23 -05:00