1
0
mirror of https://github.com/bitwarden/server.git synced 2024-11-28 13:15:12 +01:00
Commit Graph

5209 Commits

Author SHA1 Message Date
Shane Melton
afec63ffa4
[PM-14418] Add security-tasks feature flag (#5023) 2024-11-12 11:53:22 +01:00
renovate[bot]
7bd1c015f4
[deps] Tools: Update aws-sdk-net monorepo (#5017)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2024-11-12 11:53:12 +01:00
Matt Bishop
5533c12556
Check run earlier during setup (#5022) 2024-11-12 11:53:12 +01:00
Vijay Oommen
e29e85e798
PM-13237 password health report application add get (#5000)
* PM-13236 PasswordHealthReportApplications db

* PM-13236 incorporated pr comments

* PM-13236 fixed error in SQL script

* PM-13236 resolve quality scan errors SQL71006, SQL7101, SQL70001

* PM-13236 fixed warnings on procedures

* PM-13236 added efMigrations

* PM-13236 renamed files to PasswordHealthReportApplication (singular)

* PM-13236 changed file name to more appropriate naming

* PM-13236 changed the file name singular

* PM-13236 PasswordHealthReportApplication Entities and Repos

* PM-13236 moved files under tools from core

* PM-13236 Entity PasswordHealthReportApplication namespace changed to tools/entities

* PM-13236 moved Repos and Interfaces to tools

* PM-13236 migrated model to tools namespace

* PM-13236 minor fixes to the unit tests

* PM-13236 fixed script errors during build

* PM-13236 Script to drop PasswordHealthReportApplications if it exists

* PM-13236 fixes to database snapshot

* PM-13236 updated databasesnapshots

* PM-13236 Update database model changes for Mysql

* PM-13236 update model changes for Sqlite

* PM-13236 updated the models to remove commented code

* PM-13236 added correct db snapshot for MySql

* PM-13236 updated database snapshot for Postgres

* PM-13236 updated database snapshot for Sqlite

* PM-13236 removed unwanted directive to fix linting error

* PM-13236 removed redundant script files

* PM-13237 Add entity command and unit tests

* PM-13237 Get query added with unit tests

* PM-13237 Controller to add/get PasswordHealthReportApplication

* PM-13237 Setup dependencies in the EF Service collection extensions

* PM-13237 Added unit tests for ReportsController
2024-11-12 11:53:11 +01:00
Tom
54f9bd29d0
[PM-13298] Modify members access logic (#4876)
* Initial refactor of members acess

* Refactor of the members access report to include a list of ciphers

* Saving ciphers to parent object

* Missed saving the response model

* bit.core change and updating references. Removing unused refs

* Removing commented code

* Adding Bit to the namespaces

* The mapping to the response model missed setting the UserId
2024-11-12 11:53:11 +01:00
Jared McCannon
74371732c9
[PM-13014] - Add CanToggleStatus property to PolicyRepsonseModel based on Policy Validators (#4940)
* Adding CanToggleState to PoliciesControllers (api/public) endpoints. Added mappings wrapped in feature flag.

* Updated logic for determining CanToggle. Removed setting of toggle from List endpoint. Added new details model for single policy response. Validator now returns after first error.
2024-11-12 11:53:11 +01:00
Alex Morask
befce9122f
Create ProviderInvoiceItems for empty invoices (#5021) 2024-11-12 11:53:11 +01:00
Alex Urbina
d9c334f5b9
Fix Hackerone Report ID 2830741 (#5010) 2024-11-12 11:53:11 +01:00
Jimmy Vo
87d2cb109b
PM-13763 Move ResetPasswordEnrolled to response model (#4983)
to adhere to Liskov Substitution Principle. Ensures request models inherit only relevant properties.
2024-11-12 11:53:10 +01:00
MtnBurrit0
e06d0f63b7
Update logic to handle pull_request_target (#5008)
- Removing the grep and create a conditional based on GITHUB_EVENT_NAME
2024-11-12 11:53:10 +01:00
Vijay Oommen
a0b91d4546
PM-13236 - Password Health Report Application - entities repos (#4974)
* PM-13236 PasswordHealthReportApplications db

* PM-13236 incorporated pr comments

* PM-13236 fixed error in SQL script

* PM-13236 resolve quality scan errors SQL71006, SQL7101, SQL70001

* PM-13236 fixed warnings on procedures

* PM-13236 added efMigrations

* PM-13236 renamed files to PasswordHealthReportApplication (singular)

* PM-13236 changed file name to more appropriate naming

* PM-13236 changed the file name singular

* PM-13236 PasswordHealthReportApplication Entities and Repos

* PM-13236 moved files under tools from core

* PM-13236 Entity PasswordHealthReportApplication namespace changed to tools/entities

* PM-13236 moved Repos and Interfaces to tools

* PM-13236 migrated model to tools namespace

* PM-13236 minor fixes to the unit tests

* PM-13236 fixed script errors during build

* PM-13236 Script to drop PasswordHealthReportApplications if it exists

* PM-13236 fixes to database snapshot

* PM-13236 updated databasesnapshots

* PM-13236 Update database model changes for Mysql

* PM-13236 update model changes for Sqlite

* PM-13236 updated the models to remove commented code

* PM-13236 added correct db snapshot for MySql

* PM-13236 updated database snapshot for Postgres

* PM-13236 updated database snapshot for Sqlite

* PM-13236 removed unwanted directive to fix linting error

* PM-13236 removed redundant script files
2024-11-12 11:53:10 +01:00
Matt Bishop
360f1fdce1
Only build Unified on main branch pushes (#5006) 2024-11-12 11:53:10 +01:00
Matt Bishop
154894a06f
Catch PR targets for certain build operations (#5003)
* Catch PR targets for certain build operations

* Support EE
2024-11-12 11:53:10 +01:00
Matt Bishop
e2e54535c5
Support client version prerelease flag in context and LD targeting (#4994)
* Support client version prerelease flag in context and LD targeting

* Use integer instead of Boolean
2024-11-12 11:53:09 +01:00
renovate[bot]
e710bcb9aa
[deps] Tools: Update aws-sdk-net monorepo (#4993)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-12 11:53:09 +01:00
Jason Ng
5b6bd58ecf
[PM-8682] added flags for new device verification notice (#4999) 2024-11-12 11:53:05 +01:00
Brandon Treston
28bbaccdf9
[PM-11408] Remove cs delete permission (#4998)
* remove user delete permission from CS role
2024-11-12 11:52:44 +01:00
Brandon Treston
f30f247c64
[PM-11409] prevent managed user from leaving managing organization (#4995)
* prevent managed user from leaving managing organization

* fix org check to be specific to single org

* simplify logic
2024-11-12 11:52:44 +01:00
renovate[bot]
88323f4fde
[deps]: Update Microsoft.NET.Test.Sdk to 17.11.1 (#4830)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-12 11:52:44 +01:00
Cy Okeke
b163129bec
resolve conflict
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2024-11-12 11:51:51 +01:00
Nick Krantz
5ac559665b
[PM-13839][PM-13840] Admin Console Collections (#4922)
* add collectionIds to the response of `{id}/admin`

- They're now needed in the admin console when add/editing a cipher.
- Prior to this there was no way to edit collection when editing a cipher. Assigning collections was a separate workflow

* return cipher from collections endpoint
2024-11-12 11:50:56 +01:00
Matt Bishop
be2b75574a
Check run permissions for secrets usage (#4992) 2024-11-12 11:50:56 +01:00
Todd Martin
e7a9568900
Add back provider keys on TwoFactorProviders response (#4991) 2024-11-12 11:50:56 +01:00
Justin Baur
c954a9fed5
Add MariaDB test (#4989)
* Add MariaDB Test

* Use Correct Syntax

* Use Container Name

* Add Port

* Remove MySQL Thing

* Remove Another Thing

* Different Port Syntax

* Add Back Skipped Checks

* Use Correct Connection String in Test Setup

* Update .github/workflows/test-database.yml

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>

* Update .github/workflows/test-database.yml

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>

* Use MariaDB 10

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-12 11:50:55 +01:00
holow29
dba182d6a8
Update 2024-09-05_00_SyncDuoVersionFourMetadataToVersionTwo.sql (#4982)
Fix MariaDB compatibility with JSON_EXTRACT

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2024-11-12 11:50:55 +01:00
Justin Baur
2c57dbbd87
Move Packages to Platform Ownership (#4988) 2024-11-12 11:50:55 +01:00
Matt Bishop
6a74feaf1a
Check for secrets on Docker builds (#4985) 2024-11-12 11:50:55 +01:00
Matt Bishop
41e41e0b1e
Check for secrets on database test report upload (#4984) 2024-11-12 11:50:55 +01:00
Jonas Hendrickx
ba23f885a7
[PM-14456] Return provider type when getting provider's subscription (#4972) 2024-11-12 11:50:54 +01:00
Jonas Hendrickx
14a397c1e1
[PM-13450] Change Client Plan when Provider's Plan changes. (#4980) 2024-11-12 11:50:54 +01:00
Jonas Hendrickx
c5ae849b97
[PM-13470] Allow creating clients for Multi-organization enterprise (#4977) 2024-11-12 11:50:54 +01:00
Bernd Schoolmann
319b13d87e
[PM-10394] Add new item type ssh key (#4575)
* Add ssh key item type

* Add fingerprint

* Limit ssh key ciphers to new clients

* Fix enc string length for 4096 bit rsa keys

* Remove keyAlgorithm from ssh cipher

* Add featureflag and exclude mobile from sync

* Add ssh-agent flag
2024-11-12 11:50:54 +01:00
Todd Martin
4fa1f0d725
Removed eu-environment feature flag (#4966) 2024-11-12 11:50:54 +01:00
Cy Okeke
be832de470
resolve conflict
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2024-11-12 11:50:11 +01:00
Vince Grassia
d5f2eeee1c
Add version bump task (#4976) 2024-11-12 11:49:06 +01:00
Alex Morask
3b6b5eccd9
[PM-11345] Add SCIM to Teams Plan (#4924)
* Add SCIM to Teams

* Robert's feedback

* Feedback
2024-11-12 11:49:06 +01:00
Vijay Oommen
043b591e66
PM-13236 PasswordHealthReportApplication DB Tables (#4958)
* PM-13236 PasswordHealthReportApplications db

* PM-13236 incorporated pr comments

* PM-13236 fixed error in SQL script

* PM-13236 resolve quality scan errors SQL71006, SQL7101, SQL70001

* PM-13236 fixed warnings on procedures

* PM-13236 added efMigrations

* PM-13236 renamed files to PasswordHealthReportApplication (singular)

* PM-13236 changed file name to more appropriate naming

* PM-13236 changed the file name singular

* PM-13236 removed the entity file

* PM-13236 Moved PasswordHealthReportApplication entity to src/core/tools/entities
2024-11-12 11:49:05 +01:00
Rui Tomé
0a1238f887
[PM-11406] Account Management: Prevent a verified user from deleting their account (#4878)
* Add check for managed user before purging account

* Rename IOrganizationRepository.GetByClaimedUserDomainAsync to GetByVerifiedUserEmailDomainAsync and refactor to return a list. Remove ManagedByOrganizationId from ProfileResponseMode. Add ManagesActiveUser to ProfileOrganizationResponseModel

* Rename the property ManagesActiveUser to UserIsManagedByOrganization

* Remove whole class #nullable enable and add it to specific places

* [PM-11405] Account Deprovisioning: Prevent a verified user from changing their email address

* Remove unnecessary .ToList()

* Refactor IUserService methods GetOrganizationsManagingUserAsync and IsManagedByAnyOrganizationAsync to not return nullable objects. Update ProfileOrganizationResponseModel.UserIsManagedByOrganization to not be nullable

* Prevent deletion of accounts managed by an organization when Account Deprovisioning is enabled

* Add CannotDeleteManagedAccountViewModel and email templates

- Added CannotDeleteManagedAccountViewModel class to handle emails related to preventing deletion of accounts managed by an organization.
- Added HTML and text email templates for sending notifications about the inability to delete an account owned by an organization.
- Updated IMailService interface with a new method to send the cannot delete managed account email.
- Implemented the SendCannotDeleteManagedAccountEmailAsync method in HandlebarsMailService.
- Added a check in UserService to send the cannot delete managed account email if the user is managed by any organization.
- Added a no-op implementation for SendCannotDeleteManagedAccountEmailAsync in NoopMailService.

* Update error message when unable to purge vault for managed account

* Update error message when unable to change email for managed account

* Update error message when unable to delete account when managed by organization

* Update error message in test for deleting organization-owned accounts
2024-11-12 11:49:05 +01:00
Vince Grassia
e0e24db445
Bump project version (#4971) 2024-11-12 11:49:05 +01:00
Jonas Hendrickx
b8caa36c0e
[PM-14443] Cannot view pending MOE provider page (#4970) 2024-11-12 11:49:04 +01:00
Cy Okeke
00d041837f
Changes for email notification 2024-11-12 11:23:28 +01:00
Cy Okeke
ef4bedb616
Changes for email notification 2024-11-12 11:23:00 +01:00
Rui Tomé
60672bbe48
[PM-10323] Remove user verification from organization user deletion methods (#4965) 2024-11-04 14:48:13 +00:00
cyprain-okeke
96862b974f
[PM-14365][Defect] Member of trialing org cannot log in app (#4968)
* decreased authorization level

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Add some level of authorization

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

---------

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2024-11-04 15:15:27 +01:00
cyprain-okeke
df4f8df485
Remove the time threshold feature flag (#4860)
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2024-11-04 12:38:58 +01:00
Jonas Hendrickx
35b0f61986
[PM-13450] Admin: Display Multi-organization Enterprise attributes on provider details (#4955) 2024-11-04 06:45:25 +01:00
cyprain-okeke
fc719efee9
[PM-14365][Defect] Member of trialing org cannot log in app (#4967)
* changes to include subscription status metadata

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Fix the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

---------

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2024-11-01 17:55:59 +01:00
Alex Morask
f149f247d5
Don't try to credit customer \$0 (#4964) 2024-11-01 12:55:07 -04:00
renovate[bot]
edd31bcf4e
[deps] Auth: Update Duende.IdentityServer to 7.0.8 [SECURITY] (#4953)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-31 14:40:46 -07:00
Matt Bishop
a04df4beba
Device deactivation (#4963)
* Device deactivation

* Check active status in service

* Format and work around potential deadlocks
2024-10-31 17:05:13 -04:00