using System.Net; using System.Net.Http.Headers; using Bit.Api.IntegrationTest.Factories; using Bit.Api.IntegrationTest.SecretsManager.Enums; using Bit.Api.Models.Response; using Bit.Api.SecretsManager.Models.Request; using Bit.Api.SecretsManager.Models.Response; using Bit.Core.AdminConsole.Entities; using Bit.Core.AdminConsole.Repositories; using Bit.Core.Entities; using Bit.Core.Enums; using Bit.Core.SecretsManager.Entities; using Bit.Core.SecretsManager.Repositories; using Bit.Test.Common.Helpers; using Xunit; namespace Bit.Api.IntegrationTest.SecretsManager.Controllers; public class AccessPoliciesControllerTests : IClassFixture, IAsyncLifetime { private const string _mockEncryptedString = "2.3Uk+WNBIoU5xzmVFNcoWzz==|1MsPIYuRfdOHfu/0uY6H2Q==|/98sp4wb6pHP1VTZ9JcNCYgQjEUMFPlqJgCwRk1YXKg="; private readonly IAccessPolicyRepository _accessPolicyRepository; private readonly HttpClient _client; private readonly ApiApplicationFactory _factory; private readonly IProjectRepository _projectRepository; private readonly IServiceAccountRepository _serviceAccountRepository; private readonly IGroupRepository _groupRepository; private string _email = null!; private SecretsManagerOrganizationHelper _organizationHelper = null!; public AccessPoliciesControllerTests(ApiApplicationFactory factory) { _factory = factory; _client = _factory.CreateClient(); _accessPolicyRepository = _factory.GetService(); _serviceAccountRepository = _factory.GetService(); _projectRepository = _factory.GetService(); _groupRepository = _factory.GetService(); } public async Task InitializeAsync() { _email = $"integration-test{Guid.NewGuid()}@bitwarden.com"; await _factory.LoginWithNewAccount(_email); _organizationHelper = new SecretsManagerOrganizationHelper(_factory, _email); } public Task DisposeAsync() { _client.Dispose(); return Task.CompletedTask; } private async Task LoginAsync(string email) { var tokens = await _factory.LoginAsync(email); _client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", tokens.Token); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task CreateProjectAccessPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var (projectId, serviceAccountId) = await CreateProjectAndServiceAccountAsync(org.Id); var request = new AccessPoliciesCreateRequest { ServiceAccountAccessPolicyRequests = new List { new() { GranteeId = serviceAccountId, Read = true, Write = true }, }, }; var response = await _client.PostAsJsonAsync($"/projects/{projectId}/access-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task CreateProjectAccessPolicies_NoPermission() { // Create a new account as a user var (org, _) = await _organizationHelper.Initialize(true, true, true); var (email, _) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var (projectId, serviceAccountId) = await CreateProjectAndServiceAccountAsync(org.Id); var request = new AccessPoliciesCreateRequest { ServiceAccountAccessPolicyRequests = new List { new() { GranteeId = serviceAccountId, Read = true, Write = true }, }, }; var response = await _client.PostAsJsonAsync($"/projects/{projectId}/access-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task CreateProjectAccessPolicies_MismatchedOrgIds_NotFound(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (projectId, serviceAccountId) = await CreateProjectAndServiceAccountAsync(org.Id, true); await SetupProjectAndServiceAccountPermissionAsync(permissionType, projectId, serviceAccountId); var request = new AccessPoliciesCreateRequest { ServiceAccountAccessPolicyRequests = new List { new() { GranteeId = serviceAccountId, Read = true, Write = true }, }, }; var response = await _client.PostAsJsonAsync($"/projects/{projectId}/access-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task CreateProjectAccessPolicies_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (projectId, serviceAccountId) = await CreateProjectAndServiceAccountAsync(org.Id); await SetupProjectAndServiceAccountPermissionAsync(permissionType, projectId, serviceAccountId); var request = new AccessPoliciesCreateRequest { ServiceAccountAccessPolicyRequests = new List { new() { GranteeId = serviceAccountId, Read = true, Write = true }, }, }; var response = await _client.PostAsJsonAsync($"/projects/{projectId}/access-policies", request); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Equal(serviceAccountId, result!.ServiceAccountAccessPolicies.First().ServiceAccountId); Assert.True(result.ServiceAccountAccessPolicies.First().Read); Assert.True(result.ServiceAccountAccessPolicies.First().Write); AssertHelper.AssertRecent(result.ServiceAccountAccessPolicies.First().RevisionDate); AssertHelper.AssertRecent(result.ServiceAccountAccessPolicies.First().CreationDate); var createdAccessPolicy = await _accessPolicyRepository.GetByIdAsync(result.ServiceAccountAccessPolicies.First().Id); Assert.NotNull(createdAccessPolicy); Assert.Equal(result.ServiceAccountAccessPolicies.First().Read, createdAccessPolicy!.Read); Assert.Equal(result.ServiceAccountAccessPolicies.First().Write, createdAccessPolicy.Write); Assert.Equal(result.ServiceAccountAccessPolicies.First().Id, createdAccessPolicy.Id); AssertHelper.AssertRecent(createdAccessPolicy.CreationDate); AssertHelper.AssertRecent(createdAccessPolicy.RevisionDate); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task UpdateAccessPolicy_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); const bool expectedRead = true; const bool expectedWrite = false; var request = new AccessPolicyUpdateRequest { Read = expectedRead, Write = expectedWrite }; var response = await _client.PutAsJsonAsync($"/access-policies/{initData.AccessPolicyId}", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task UpdateAccessPolicy_NoPermission() { // Create a new account as a user await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var initData = await SetupAccessPolicyRequest(orgUser.OrganizationId); const bool expectedRead = true; const bool expectedWrite = false; var request = new AccessPolicyUpdateRequest { Read = expectedRead, Write = expectedWrite }; var response = await _client.PutAsJsonAsync($"/access-policies/{initData.AccessPolicyId}", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task UpdateAccessPolicy_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserProjectAccessPolicy { GrantedProjectId = initData.ProjectId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } const bool expectedRead = true; const bool expectedWrite = false; var request = new AccessPolicyUpdateRequest { Read = expectedRead, Write = expectedWrite }; var response = await _client.PutAsJsonAsync($"/access-policies/{initData.AccessPolicyId}", request); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Equal(expectedRead, result!.Read); Assert.Equal(expectedWrite, result.Write); AssertHelper.AssertRecent(result.RevisionDate); var updatedAccessPolicy = await _accessPolicyRepository.GetByIdAsync(result.Id); Assert.NotNull(updatedAccessPolicy); Assert.Equal(expectedRead, updatedAccessPolicy!.Read); Assert.Equal(expectedWrite, updatedAccessPolicy.Write); AssertHelper.AssertRecent(updatedAccessPolicy.RevisionDate); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task DeleteAccessPolicy_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); var response = await _client.DeleteAsync($"/access-policies/{initData.AccessPolicyId}"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task DeleteAccessPolicy_NoPermission() { // Create a new account as a user await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var initData = await SetupAccessPolicyRequest(orgUser.OrganizationId); var response = await _client.DeleteAsync($"/access-policies/{initData.AccessPolicyId}"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task DeleteAccessPolicy_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserProjectAccessPolicy { GrantedProjectId = initData.ProjectId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } var response = await _client.DeleteAsync($"/access-policies/{initData.AccessPolicyId}"); response.EnsureSuccessStatusCode(); var test = await _accessPolicyRepository.GetByIdAsync(initData.AccessPolicyId); Assert.Null(test); } [Fact] public async Task GetProjectAccessPolicies_ReturnsEmpty() { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var project = await _projectRepository.CreateAsync(new Project { OrganizationId = org.Id, Name = _mockEncryptedString, }); var response = await _client.GetAsync($"/projects/{project.Id}/access-policies"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Empty(result!.UserAccessPolicies); Assert.Empty(result.GroupAccessPolicies); Assert.Empty(result.ServiceAccountAccessPolicies); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetProjectAccessPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); var response = await _client.GetAsync($"/projects/{initData.ProjectId}/access-policies"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task GetProjectAccessPolicies_NoPermission() { // Create a new account as a user await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var initData = await SetupAccessPolicyRequest(orgUser.OrganizationId); var response = await _client.GetAsync($"/projects/{initData.ProjectId}/access-policies"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetProjectAccessPolicies(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserProjectAccessPolicy { GrantedProjectId = initData.ProjectId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } var response = await _client.GetAsync($"/projects/{initData.ProjectId}/access-policies"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result?.ServiceAccountAccessPolicies); Assert.Single(result!.ServiceAccountAccessPolicies); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetPeoplePotentialGrantees_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/people/potential-grantees"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetPeoplePotentialGrantees_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, _) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); } var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/people/potential-grantees"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync>(); Assert.NotNull(result?.Data); Assert.NotEmpty(result!.Data); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetServiceAccountPotentialGrantees_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/service-accounts/potential-grantees"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task GetServiceAccountPotentialGrantees_OnlyReturnsServiceAccountsWithWriteAccess() { // Create a new account as a user var (org, _) = await _organizationHelper.Initialize(true, true, true); var (email, _) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/service-accounts/potential-grantees"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync>(); Assert.NotNull(result?.Data); Assert.Empty(result!.Data); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetServiceAccountsPotentialGrantees_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); await _accessPolicyRepository.CreateManyAsync( new List { new UserServiceAccountAccessPolicy { GrantedServiceAccountId = serviceAccount.Id, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }); } var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/service-accounts/potential-grantees"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync>(); Assert.NotNull(result?.Data); Assert.NotEmpty(result!.Data); Assert.Equal(serviceAccount.Id, result.Data.First(x => x.Id == serviceAccount.Id).Id); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetProjectPotentialGrantees_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/projects/potential-grantees"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task GetProjectPotentialGrantees_OnlyReturnsProjectsWithWriteAccess() { // Create a new account as a user var (org, _) = await _organizationHelper.Initialize(true, true, true); var (email, _) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); await _projectRepository.CreateAsync(new Project { OrganizationId = org.Id, Name = _mockEncryptedString }); var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/projects/potential-grantees"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync>(); Assert.NotNull(result?.Data); Assert.Empty(result!.Data); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetProjectPotentialGrantees_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var project = await _projectRepository.CreateAsync(new Project { OrganizationId = org.Id, Name = _mockEncryptedString, }); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); await _accessPolicyRepository.CreateManyAsync( new List { new UserProjectAccessPolicy { GrantedProjectId = project.Id, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }); } var response = await _client.GetAsync( $"/organizations/{org.Id}/access-policies/projects/potential-grantees"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync>(); Assert.NotNull(result?.Data); Assert.NotEmpty(result!.Data); Assert.Equal(project.Id, result.Data.First(x => x.Id == project.Id).Id); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task CreateServiceAccountAccessPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, orgUser) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var request = new AccessPoliciesCreateRequest { UserAccessPolicyRequests = new List { new() { GranteeId = orgUser.Id, Read = true, Write = true }, }, }; var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccount.Id}/access-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task CreateServiceAccountAccessPolicies_MismatchOrgId_NotFound(PermissionType permissionType) { var (_, orgUser) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var anotherOrg = await _organizationHelper.CreateSmOrganizationAsync(); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = anotherOrg.Id, Name = _mockEncryptedString, }); var request = await SetupUserServiceAccountAccessPolicyRequestAsync(permissionType, orgUser.Id, serviceAccount.Id); var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccount.Id}/access-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task CreateServiceAccountAccessPolicies_Success(PermissionType permissionType) { var (org, orgUser) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var ownerOrgUserId = orgUser.Id; var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var request = await SetupUserServiceAccountAccessPolicyRequestAsync(permissionType, orgUser.Id, serviceAccount.Id); var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccount.Id}/access-policies", request); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Equal(ownerOrgUserId, result!.UserAccessPolicies.First(ap => ap.OrganizationUserId == ownerOrgUserId).OrganizationUserId); Assert.True(result.UserAccessPolicies.First().Read); Assert.True(result.UserAccessPolicies.First().Write); var createdAccessPolicy = await _accessPolicyRepository.GetByIdAsync(result.UserAccessPolicies.First().Id); Assert.NotNull(createdAccessPolicy); Assert.Equal(result.UserAccessPolicies.First().Read, createdAccessPolicy!.Read); Assert.Equal(result.UserAccessPolicies.First().Write, createdAccessPolicy.Write); Assert.Equal(result.UserAccessPolicies.First().Id, createdAccessPolicy.Id); } [Fact] public async Task CreateServiceAccountAccessPolicies_NoPermission() { // Create a new account as a user var (org, _) = await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var request = new AccessPoliciesCreateRequest { UserAccessPolicyRequests = new List { new() { GranteeId = orgUser.Id, Read = true, Write = true }, }, }; var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccount.Id}/access-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetServiceAccountAccessPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); var response = await _client.GetAsync($"/service-accounts/{initData.ServiceAccountId}/access-policies"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task GetServiceAccountAccessPolicies_ReturnsEmpty() { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var response = await _client.GetAsync($"/service-accounts/{serviceAccount.Id}/access-policies"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Empty(result!.UserAccessPolicies); Assert.Empty(result.GroupAccessPolicies); } [Fact] public async Task GetServiceAccountAccessPolicies_NoPermission() { // Create a new account as a user await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var initData = await SetupAccessPolicyRequest(orgUser.OrganizationId); var response = await _client.GetAsync($"/service-accounts/{initData.ServiceAccountId}/access-policies"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetServiceAccountAccessPolicies(PermissionType permissionType) { var (org, ownerOrgUser) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserServiceAccountAccessPolicy { GrantedServiceAccountId = initData.ServiceAccountId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } var policies = new List { new UserServiceAccountAccessPolicy { GrantedServiceAccountId = initData.ServiceAccountId, OrganizationUserId = ownerOrgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(policies); var response = await _client.GetAsync($"/service-accounts/{initData.ServiceAccountId}/access-policies"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result?.UserAccessPolicies); Assert.NotEmpty(result!.UserAccessPolicies); Assert.Equal(ownerOrgUser.Id, result.UserAccessPolicies.First(x => x.OrganizationUserId == ownerOrgUser.Id).OrganizationUserId); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task CreateServiceAccountGrantedPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var request = new List { new() { GrantedId = new Guid() } }; var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccount.Id}/granted-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task CreateServiceAccountGrantedPolicies_NoPermission() { // Create a new account as a user var (org, _) = await _organizationHelper.Initialize(true, true, true); var (email, _) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var project = await _projectRepository.CreateAsync(new Project { OrganizationId = org.Id, Name = _mockEncryptedString, }); var request = new List { new() { GrantedId = project.Id, Read = true, Write = true } }; var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccount.Id}/granted-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task CreateServiceAccountGrantedPolicies_MismatchedOrgId_NotFound(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (projectId, serviceAccountId) = await CreateProjectAndServiceAccountAsync(org.Id, true); await SetupProjectAndServiceAccountPermissionAsync(permissionType, projectId, serviceAccountId); var request = new List { new() { GrantedId = projectId, Read = true, Write = true } }; var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccountId}/granted-policies", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task CreateServiceAccountGrantedPolicies_Success(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (projectId, serviceAccountId) = await CreateProjectAndServiceAccountAsync(org.Id); await SetupProjectAndServiceAccountPermissionAsync(permissionType, projectId, serviceAccountId); var request = new List { new() { GrantedId = projectId, Read = true, Write = true } }; var response = await _client.PostAsJsonAsync($"/service-accounts/{serviceAccountId}/granted-policies", request); response.EnsureSuccessStatusCode(); var result = await response.Content .ReadFromJsonAsync>(); Assert.NotNull(result); Assert.NotEmpty(result!.Data); Assert.Equal(projectId, result.Data.First().GrantedProjectId); var createdAccessPolicy = await _accessPolicyRepository.GetByIdAsync(result.Data.First().Id); Assert.NotNull(createdAccessPolicy); Assert.Equal(result.Data.First().Read, createdAccessPolicy!.Read); Assert.Equal(result.Data.First().Write, createdAccessPolicy.Write); Assert.Equal(result.Data.First().Id, createdAccessPolicy.Id); AssertHelper.AssertRecent(createdAccessPolicy.CreationDate); AssertHelper.AssertRecent(createdAccessPolicy.RevisionDate); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetServiceAccountGrantedPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); var response = await _client.GetAsync($"/service-accounts/{initData.ServiceAccountId}/granted-policies"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task GetServiceAccountGrantedPolicies_ReturnsEmpty() { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = org.Id, Name = _mockEncryptedString, }); var response = await _client.GetAsync($"/service-accounts/{serviceAccount.Id}/granted-policies"); response.EnsureSuccessStatusCode(); var result = await response.Content .ReadFromJsonAsync>(); Assert.NotNull(result); Assert.Empty(result!.Data); } [Fact] public async Task GetServiceAccountGrantedPolicies_NoPermission_ReturnsEmpty() { // Create a new account as a user await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var initData = await SetupAccessPolicyRequest(orgUser.OrganizationId); var response = await _client.GetAsync($"/service-accounts/{initData.ServiceAccountId}/granted-policies"); var result = await response.Content .ReadFromJsonAsync>(); Assert.NotNull(result); Assert.Empty(result!.Data); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetServiceAccountGrantedPolicies(PermissionType permissionType) { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserProjectAccessPolicy { GrantedProjectId = initData.ProjectId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } var response = await _client.GetAsync($"/service-accounts/{initData.ServiceAccountId}/granted-policies"); response.EnsureSuccessStatusCode(); var result = await response.Content .ReadFromJsonAsync>(); Assert.NotNull(result?.Data); Assert.NotEmpty(result!.Data); Assert.Equal(initData.ServiceAccountId, result.Data.First().ServiceAccountId); Assert.NotNull(result.Data.First().ServiceAccountName); Assert.NotNull(result.Data.First().GrantedProjectName); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task GetProjectPeopleAccessPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (org, _) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var initData = await SetupAccessPolicyRequest(org.Id); var response = await _client.GetAsync($"/projects/{initData.ProjectId}/access-policies/people"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task GetProjectPeopleAccessPolicies_ReturnsEmpty() { var (org, _) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var project = await _projectRepository.CreateAsync(new Project { OrganizationId = org.Id, Name = _mockEncryptedString }); var response = await _client.GetAsync($"/projects/{project.Id}/access-policies/people"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Empty(result!.UserAccessPolicies); Assert.Empty(result.GroupAccessPolicies); } [Fact] public async Task GetProjectPeopleAccessPolicies_NoPermission_NotFound() { await _organizationHelper.Initialize(true, true, true); var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var project = await _projectRepository.CreateAsync(new Project { OrganizationId = orgUser.OrganizationId, Name = _mockEncryptedString }); var response = await _client.GetAsync($"/projects/{project.Id}/access-policies/people"); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task GetProjectPeopleAccessPolicies_Success(PermissionType permissionType) { var (_, organizationUser) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (project, _) = await SetupProjectPeoplePermissionAsync(permissionType, organizationUser); var response = await _client.GetAsync($"/projects/{project.Id}/access-policies/people"); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result?.UserAccessPolicies); Assert.Single(result!.UserAccessPolicies); } [Theory] [InlineData(false, false, false)] [InlineData(false, false, true)] [InlineData(false, true, false)] [InlineData(false, true, true)] [InlineData(true, false, false)] [InlineData(true, false, true)] [InlineData(true, true, false)] public async Task PutProjectPeopleAccessPolicies_SmAccessDenied_NotFound(bool useSecrets, bool accessSecrets, bool organizationEnabled) { var (_, organizationUser) = await _organizationHelper.Initialize(useSecrets, accessSecrets, organizationEnabled); await LoginAsync(_email); var (project, request) = await SetupProjectPeopleRequestAsync(PermissionType.RunAsAdmin, organizationUser); var response = await _client.PutAsJsonAsync($"/projects/{project.Id}/access-policies/people", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Fact] public async Task PutProjectPeopleAccessPolicies_NoPermission() { var (org, _) = await _organizationHelper.Initialize(true, true, true); var (email, organizationUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var project = await _projectRepository.CreateAsync(new Project { OrganizationId = org.Id, Name = _mockEncryptedString }); var request = new PeopleAccessPoliciesRequestModel { UserAccessPolicyRequests = new List { new() { GranteeId = organizationUser.Id, Read = true, Write = true } } }; var response = await _client.PutAsJsonAsync($"/projects/{project.Id}/access-policies/people", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task PutProjectPeopleAccessPolicies_MismatchedOrgIds_NotFound(PermissionType permissionType) { var (_, organizationUser) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (project, request) = await SetupProjectPeopleRequestAsync(permissionType, organizationUser); var newOrg = await _organizationHelper.CreateSmOrganizationAsync(); var group = await _groupRepository.CreateAsync(new Group { OrganizationId = newOrg.Id, Name = _mockEncryptedString }); request.GroupAccessPolicyRequests = new List { new() { GranteeId = group.Id, Read = true, Write = true } }; var response = await _client.PutAsJsonAsync($"/projects/{project.Id}/access-policies/people", request); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); } [Theory] [InlineData(PermissionType.RunAsAdmin)] [InlineData(PermissionType.RunAsUserWithPermission)] public async Task PutProjectPeopleAccessPolicies_Success(PermissionType permissionType) { var (_, organizationUser) = await _organizationHelper.Initialize(true, true, true); await LoginAsync(_email); var (project, request) = await SetupProjectPeopleRequestAsync(permissionType, organizationUser); var response = await _client.PutAsJsonAsync($"/projects/{project.Id}/access-policies/people", request); response.EnsureSuccessStatusCode(); var result = await response.Content.ReadFromJsonAsync(); Assert.NotNull(result); Assert.Equal(request.UserAccessPolicyRequests.First().GranteeId, result!.UserAccessPolicies.First().OrganizationUserId); Assert.True(result.UserAccessPolicies.First().Read); Assert.True(result.UserAccessPolicies.First().Write); var createdAccessPolicy = await _accessPolicyRepository.GetByIdAsync(result.UserAccessPolicies.First().Id); Assert.NotNull(createdAccessPolicy); Assert.Equal(result.UserAccessPolicies.First().Read, createdAccessPolicy!.Read); Assert.Equal(result.UserAccessPolicies.First().Write, createdAccessPolicy.Write); Assert.Equal(result.UserAccessPolicies.First().Id, createdAccessPolicy.Id); } private async Task SetupAccessPolicyRequest(Guid organizationId) { var project = await _projectRepository.CreateAsync(new Project { OrganizationId = organizationId, Name = _mockEncryptedString, }); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = organizationId, Name = _mockEncryptedString, }); var accessPolicy = await _accessPolicyRepository.CreateManyAsync( new List { new ServiceAccountProjectAccessPolicy { Read = true, Write = true, ServiceAccountId = serviceAccount.Id, GrantedProjectId = project.Id, }, }); return new RequestSetupData { ProjectId = project.Id, ServiceAccountId = serviceAccount.Id, AccessPolicyId = accessPolicy.First().Id, }; } private async Task<(Project project, OrganizationUser currentUser)> SetupProjectPeoplePermissionAsync( PermissionType permissionType, OrganizationUser organizationUser) { var project = await _projectRepository.CreateAsync(new Project { OrganizationId = organizationUser.OrganizationId, Name = _mockEncryptedString }); if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); organizationUser = orgUser; } var accessPolicies = new List { new UserProjectAccessPolicy { GrantedProjectId = project.Id, OrganizationUserId = organizationUser.Id, Read = true, Write = true } }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); return (project, organizationUser); } private async Task<(Project project, PeopleAccessPoliciesRequestModel request)> SetupProjectPeopleRequestAsync( PermissionType permissionType, OrganizationUser organizationUser) { var (project, currentUser) = await SetupProjectPeoplePermissionAsync(permissionType, organizationUser); var request = new PeopleAccessPoliciesRequestModel { UserAccessPolicyRequests = new List { new() { GranteeId = currentUser.Id, Read = true, Write = true } } }; return (project, request); } private async Task<(Guid ProjectId, Guid ServiceAccountId)> CreateProjectAndServiceAccountAsync(Guid organizationId, bool misMatchOrganization = false) { var newOrg = new Organization(); if (misMatchOrganization) { newOrg = await _organizationHelper.CreateSmOrganizationAsync(); } var project = await _projectRepository.CreateAsync(new Project { OrganizationId = misMatchOrganization ? newOrg.Id : organizationId, Name = _mockEncryptedString, }); var serviceAccount = await _serviceAccountRepository.CreateAsync(new ServiceAccount { OrganizationId = organizationId, Name = _mockEncryptedString, }); return (project.Id, serviceAccount.Id); } private async Task SetupProjectAndServiceAccountPermissionAsync(PermissionType permissionType, Guid projectId, Guid serviceAccountId) { if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, orgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserProjectAccessPolicy { GrantedProjectId = projectId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, new UserServiceAccountAccessPolicy { GrantedServiceAccountId = serviceAccountId, OrganizationUserId = orgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } } private async Task SetupUserServiceAccountAccessPolicyRequestAsync( PermissionType permissionType, Guid userId, Guid serviceAccountId) { if (permissionType == PermissionType.RunAsUserWithPermission) { var (email, newOrgUser) = await _organizationHelper.CreateNewUser(OrganizationUserType.User, true); await LoginAsync(email); var accessPolicies = new List { new UserServiceAccountAccessPolicy { GrantedServiceAccountId = serviceAccountId, OrganizationUserId = newOrgUser.Id, Read = true, Write = true, }, }; await _accessPolicyRepository.CreateManyAsync(accessPolicies); } return new AccessPoliciesCreateRequest { UserAccessPolicyRequests = new List { new() { GranteeId = userId, Read = true, Write = true }, }, }; } private class RequestSetupData { public Guid ProjectId { get; set; } public Guid AccessPolicyId { get; set; } public Guid ServiceAccountId { get; set; } } }