using System.Security.Claims; using Bit.Api.AdminConsole.Controllers; using Bit.Api.AdminConsole.Models.Request.Organizations; using Bit.Api.Models.Request; using Bit.Api.Vault.AuthorizationHandlers.Collections; using Bit.Core; using Bit.Core.AdminConsole.Entities; using Bit.Core.AdminConsole.Enums; using Bit.Core.AdminConsole.Models.Data.Organizations.Policies; using Bit.Core.AdminConsole.OrganizationFeatures.OrganizationUsers.Interfaces; using Bit.Core.AdminConsole.Repositories; using Bit.Core.Context; using Bit.Core.Entities; using Bit.Core.Enums; using Bit.Core.Exceptions; using Bit.Core.Models.Business; using Bit.Core.Models.Data; using Bit.Core.Models.Data.Organizations; using Bit.Core.Models.Data.Organizations.OrganizationUsers; using Bit.Core.OrganizationFeatures.OrganizationUsers.Interfaces; using Bit.Core.Repositories; using Bit.Core.Services; using Bit.Core.Utilities; using Bit.Test.Common.AutoFixture; using Bit.Test.Common.AutoFixture.Attributes; using Microsoft.AspNetCore.Authorization; using NSubstitute; using Xunit; namespace Bit.Api.Test.AdminConsole.Controllers; [ControllerCustomize(typeof(OrganizationUsersController))] [SutProviderCustomize] public class OrganizationUsersControllerTests { [Theory] [BitAutoData] public async Task PutResetPasswordEnrollment_InivitedUser_AcceptsInvite(Guid orgId, Guid userId, OrganizationUserResetPasswordEnrollmentRequestModel model, User user, OrganizationUser orgUser, SutProvider sutProvider) { orgUser.Status = Core.Enums.OrganizationUserStatusType.Invited; sutProvider.GetDependency().GetUserByPrincipalAsync(default).ReturnsForAnyArgs(user); sutProvider.GetDependency().GetByOrganizationAsync(default, default).ReturnsForAnyArgs(orgUser); await sutProvider.Sut.PutResetPasswordEnrollment(orgId, userId, model); await sutProvider.GetDependency().Received(1).AcceptOrgUserByOrgIdAsync(orgId, user, sutProvider.GetDependency()); } [Theory] [BitAutoData] public async Task PutResetPasswordEnrollment_ConfirmedUser_AcceptsInvite(Guid orgId, Guid userId, OrganizationUserResetPasswordEnrollmentRequestModel model, User user, OrganizationUser orgUser, SutProvider sutProvider) { orgUser.Status = Core.Enums.OrganizationUserStatusType.Confirmed; sutProvider.GetDependency().GetUserByPrincipalAsync(default).ReturnsForAnyArgs(user); sutProvider.GetDependency().GetByOrganizationAsync(default, default).ReturnsForAnyArgs(orgUser); await sutProvider.Sut.PutResetPasswordEnrollment(orgId, userId, model); await sutProvider.GetDependency().Received(0).AcceptOrgUserByOrgIdAsync(orgId, user, sutProvider.GetDependency()); } [Theory] [BitAutoData] public async Task Accept_RequiresKnownUser(Guid orgId, Guid orgUserId, OrganizationUserAcceptRequestModel model, SutProvider sutProvider) { sutProvider.GetDependency().GetUserByPrincipalAsync(default).ReturnsForAnyArgs((User)null); await Assert.ThrowsAsync(() => sutProvider.Sut.Accept(orgId, orgUserId, model)); } [Theory] [BitAutoData] public async Task Accept_NoMasterPasswordReset(Guid orgId, Guid orgUserId, OrganizationUserAcceptRequestModel model, User user, SutProvider sutProvider) { sutProvider.GetDependency().GetUserByPrincipalAsync(default).ReturnsForAnyArgs(user); await sutProvider.Sut.Accept(orgId, orgUserId, model); await sutProvider.GetDependency().Received(1) .AcceptOrgUserByEmailTokenAsync(orgUserId, user, model.Token, sutProvider.GetDependency()); await sutProvider.GetDependency().DidNotReceiveWithAnyArgs() .UpdateUserResetPasswordEnrollmentAsync(default, default, default, default); } [Theory] [BitAutoData] public async Task Accept_RequireMasterPasswordReset(Guid orgId, Guid orgUserId, OrganizationUserAcceptRequestModel model, User user, SutProvider sutProvider) { var policy = new Policy { Enabled = true, Data = CoreHelpers.ClassToJsonData(new ResetPasswordDataModel { AutoEnrollEnabled = true, }), }; sutProvider.GetDependency().GetUserByPrincipalAsync(default).ReturnsForAnyArgs(user); sutProvider.GetDependency().GetByOrganizationIdTypeAsync(orgId, PolicyType.ResetPassword).Returns(policy); await sutProvider.Sut.Accept(orgId, orgUserId, model); await sutProvider.GetDependency().Received(1) .AcceptOrgUserByEmailTokenAsync(orgUserId, user, model.Token, sutProvider.GetDependency()); await sutProvider.GetDependency().Received(1) .UpdateUserResetPasswordEnrollmentAsync(orgId, user.Id, model.ResetPasswordKey, user.Id); } [Theory] [BitAutoData] public async Task Invite_Success(OrganizationAbility organizationAbility, OrganizationUserInviteRequestModel model, Guid userId, SutProvider sutProvider) { sutProvider.GetDependency().ManageUsers(organizationAbility.Id).Returns(true); sutProvider.GetDependency().GetOrganizationAbilityAsync(organizationAbility.Id) .Returns(organizationAbility); sutProvider.GetDependency() .AuthorizeAsync(Arg.Any(), Arg.Any>(), Arg.Is>(reqs => reqs.Contains(BulkCollectionOperations.ModifyUserAccess))) .Returns(AuthorizationResult.Success()); sutProvider.GetDependency().GetProperUserId(Arg.Any()).Returns(userId); await sutProvider.Sut.Invite(organizationAbility.Id, model); await sutProvider.GetDependency().Received(1).InviteUsersAsync(organizationAbility.Id, userId, systemUser: null, Arg.Is>(invites => invites.Count() == 1 && invites.First().Item1.Emails.SequenceEqual(model.Emails) && invites.First().Item1.Type == model.Type && invites.First().Item1.AccessSecretsManager == model.AccessSecretsManager)); } [Theory] [BitAutoData] public async Task Invite_NotAuthorizedToGiveAccessToCollections_Throws(OrganizationAbility organizationAbility, OrganizationUserInviteRequestModel model, Guid userId, SutProvider sutProvider) { sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(true); sutProvider.GetDependency().ManageUsers(organizationAbility.Id).Returns(true); sutProvider.GetDependency().GetOrganizationAbilityAsync(organizationAbility.Id) .Returns(organizationAbility); sutProvider.GetDependency() .AuthorizeAsync(Arg.Any(), Arg.Any>(), Arg.Is>(reqs => reqs.Contains(BulkCollectionOperations.ModifyUserAccess))) .Returns(AuthorizationResult.Failed()); sutProvider.GetDependency().GetProperUserId(Arg.Any()).Returns(userId); var exception = await Assert.ThrowsAsync(() => sutProvider.Sut.Invite(organizationAbility.Id, model)); Assert.Contains("You are not authorized", exception.Message); } [Theory] [BitAutoData] public async Task Put_Success(OrganizationUserUpdateRequestModel model, OrganizationUser organizationUser, OrganizationAbility organizationAbility, SutProvider sutProvider, Guid savingUserId) { sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(false); Put_Setup(sutProvider, organizationAbility, organizationUser, savingUserId, model, true); // Save these for later - organizationUser object will be mutated var orgUserId = organizationUser.Id; var orgUserEmail = organizationUser.Email; await sutProvider.Sut.Put(organizationAbility.Id, organizationUser.Id, model); await sutProvider.GetDependency().Received(1).UpdateUserAsync(Arg.Is(ou => ou.Type == model.Type && ou.Permissions == CoreHelpers.ClassToJsonData(model.Permissions) && ou.AccessSecretsManager == model.AccessSecretsManager && ou.Id == orgUserId && ou.Email == orgUserEmail), savingUserId, Arg.Is>(cas => cas.All(c => model.Collections.Any(m => m.Id == c.Id))), model.Groups); } [Theory] [BitAutoData] public async Task Put_UpdateSelf_WithoutAllowAdminAccessToAllCollectionItems_CannotAddSelfToCollections(OrganizationUserUpdateRequestModel model, OrganizationUser organizationUser, OrganizationAbility organizationAbility, SutProvider sutProvider, Guid savingUserId) { // Updating self organizationUser.UserId = savingUserId; organizationAbility.AllowAdminAccessToAllCollectionItems = false; sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(true); Put_Setup(sutProvider, organizationAbility, organizationUser, savingUserId, model, false); // User is not currently assigned to any collections, which means they're adding themselves sutProvider.GetDependency() .GetByIdWithCollectionsAsync(organizationUser.Id) .Returns(new Tuple>(organizationUser, new List())); sutProvider.GetDependency() .GetManyByManyIdsAsync(Arg.Any>()) .Returns(new List()); var orgUserId = organizationUser.Id; var orgUserEmail = organizationUser.Email; var exception = await Assert.ThrowsAsync(async () => await sutProvider.Sut.Put(organizationAbility.Id, organizationUser.Id, model)); Assert.Contains("You cannot add yourself to a collection.", exception.Message); } [Theory] [BitAutoData] public async Task Put_UpdateSelf_WithoutAllowAdminAccessToAllCollectionItems_DoesNotUpdateGroups(OrganizationUserUpdateRequestModel model, OrganizationUser organizationUser, OrganizationAbility organizationAbility, SutProvider sutProvider, Guid savingUserId) { // Updating self organizationUser.UserId = savingUserId; organizationAbility.AllowAdminAccessToAllCollectionItems = false; sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(true); Put_Setup(sutProvider, organizationAbility, organizationUser, savingUserId, model, true); var orgUserId = organizationUser.Id; var orgUserEmail = organizationUser.Email; await sutProvider.Sut.Put(organizationAbility.Id, organizationUser.Id, model); await sutProvider.GetDependency().Received(1).UpdateUserAsync(Arg.Is(ou => ou.Type == model.Type && ou.Permissions == CoreHelpers.ClassToJsonData(model.Permissions) && ou.AccessSecretsManager == model.AccessSecretsManager && ou.Id == orgUserId && ou.Email == orgUserEmail), savingUserId, Arg.Is>(cas => cas.All(c => model.Collections.Any(m => m.Id == c.Id))), null); } [Theory] [BitAutoData] public async Task Put_UpdateSelf_WithAllowAdminAccessToAllCollectionItems_DoesUpdateGroups(OrganizationUserUpdateRequestModel model, OrganizationUser organizationUser, OrganizationAbility organizationAbility, SutProvider sutProvider, Guid savingUserId) { // Updating self organizationUser.UserId = savingUserId; organizationAbility.AllowAdminAccessToAllCollectionItems = true; sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(true); Put_Setup(sutProvider, organizationAbility, organizationUser, savingUserId, model, true); var orgUserId = organizationUser.Id; var orgUserEmail = organizationUser.Email; await sutProvider.Sut.Put(organizationAbility.Id, organizationUser.Id, model); await sutProvider.GetDependency().Received(1).UpdateUserAsync(Arg.Is(ou => ou.Type == model.Type && ou.Permissions == CoreHelpers.ClassToJsonData(model.Permissions) && ou.AccessSecretsManager == model.AccessSecretsManager && ou.Id == orgUserId && ou.Email == orgUserEmail), savingUserId, Arg.Is>(cas => cas.All(c => model.Collections.Any(m => m.Id == c.Id))), model.Groups); } [Theory] [BitAutoData] public async Task Put_UpdateCollections_OnlyUpdatesCollectionsTheSavingUserCanUpdate(OrganizationUserUpdateRequestModel model, OrganizationUser organizationUser, OrganizationAbility organizationAbility, SutProvider sutProvider, Guid savingUserId) { sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(true); Put_Setup(sutProvider, organizationAbility, organizationUser, savingUserId, model, false); var editedCollectionId = CoreHelpers.GenerateComb(); var readonlyCollectionId1 = CoreHelpers.GenerateComb(); var readonlyCollectionId2 = CoreHelpers.GenerateComb(); var currentCollectionAccess = new List { new() { Id = editedCollectionId, HidePasswords = true, Manage = false, ReadOnly = true }, new() { Id = readonlyCollectionId1, HidePasswords = false, Manage = true, ReadOnly = false }, new() { Id = readonlyCollectionId2, HidePasswords = false, Manage = false, ReadOnly = false }, }; // User is upgrading editedCollectionId to manage model.Collections = new List { new() { Id = editedCollectionId, HidePasswords = false, Manage = true, ReadOnly = false } }; // Save these for later - organizationUser object will be mutated var orgUserId = organizationUser.Id; var orgUserEmail = organizationUser.Email; sutProvider.GetDependency() .GetByIdWithCollectionsAsync(organizationUser.Id) .Returns(new Tuple>(organizationUser, currentCollectionAccess)); var currentCollections = currentCollectionAccess .Select(cas => new Collection { Id = cas.Id }).ToList(); sutProvider.GetDependency() .GetManyByManyIdsAsync(Arg.Any>()) .Returns(currentCollections); // Authorize the editedCollection sutProvider.GetDependency() .AuthorizeAsync(Arg.Any(), Arg.Is(c => c.Id == editedCollectionId), Arg.Is>(reqs => reqs.Contains(BulkCollectionOperations.ModifyUserAccess))) .Returns(AuthorizationResult.Success()); // Do not authorize the readonly collections sutProvider.GetDependency() .AuthorizeAsync(Arg.Any(), Arg.Is(c => c.Id == readonlyCollectionId1 || c.Id == readonlyCollectionId2), Arg.Is>(reqs => reqs.Contains(BulkCollectionOperations.ModifyUserAccess))) .Returns(AuthorizationResult.Failed()); await sutProvider.Sut.Put(organizationAbility.Id, organizationUser.Id, model); // Expect all collection access (modified and unmodified) to be saved await sutProvider.GetDependency().Received(1).UpdateUserAsync(Arg.Is(ou => ou.Type == model.Type && ou.Permissions == CoreHelpers.ClassToJsonData(model.Permissions) && ou.AccessSecretsManager == model.AccessSecretsManager && ou.Id == orgUserId && ou.Email == orgUserEmail), savingUserId, Arg.Is>(cas => cas.Select(c => c.Id).SequenceEqual(currentCollectionAccess.Select(c => c.Id)) && cas.First(c => c.Id == editedCollectionId).Manage == true && cas.First(c => c.Id == editedCollectionId).ReadOnly == false && cas.First(c => c.Id == editedCollectionId).HidePasswords == false), model.Groups); } [Theory] [BitAutoData] public async Task Put_UpdateCollections_ThrowsIfSavingUserCannotUpdateCollections(OrganizationUserUpdateRequestModel model, OrganizationUser organizationUser, OrganizationAbility organizationAbility, SutProvider sutProvider, Guid savingUserId) { sutProvider.GetDependency().IsEnabled(FeatureFlagKeys.FlexibleCollectionsV1).Returns(true); Put_Setup(sutProvider, organizationAbility, organizationUser, savingUserId, model, false); sutProvider.GetDependency() .GetByIdWithCollectionsAsync(organizationUser.Id) .Returns(new Tuple>(organizationUser, model.Collections.Select(cas => cas.ToSelectionReadOnly()).ToList())); var collections = model.Collections.Select(cas => new Collection { Id = cas.Id }).ToList(); sutProvider.GetDependency() .GetManyByManyIdsAsync(Arg.Is>(guids => guids.SequenceEqual(collections.Select(c => c.Id)))) .Returns(collections); sutProvider.GetDependency() .AuthorizeAsync(Arg.Any(), Arg.Is(c => collections.Contains(c)), Arg.Is>(reqs => reqs.Contains(BulkCollectionOperations.ModifyUserAccess))) .Returns(AuthorizationResult.Failed()); var exception = await Assert.ThrowsAsync(() => sutProvider.Sut.Put(organizationAbility.Id, organizationUser.Id, model)); Assert.Contains("You must have Can Manage permission", exception.Message); } [Theory] [BitAutoData] public async Task Get_ReturnsUsers( ICollection organizationUsers, OrganizationAbility organizationAbility, SutProvider sutProvider) { Get_Setup(organizationAbility, organizationUsers, sutProvider); var response = await sutProvider.Sut.Get(organizationAbility.Id); Assert.True(response.Data.All(r => organizationUsers.Any(ou => ou.Id == r.Id))); } [Theory] [BitAutoData] public async Task Get_HandlesNullPermissionsObject( ICollection organizationUsers, OrganizationAbility organizationAbility, SutProvider sutProvider) { Get_Setup(organizationAbility, organizationUsers, sutProvider); organizationUsers.First().Permissions = "null"; var response = await sutProvider.Sut.Get(organizationAbility.Id); Assert.True(response.Data.All(r => organizationUsers.Any(ou => ou.Id == r.Id))); } [Theory] [BitAutoData] public async Task Get_SetsDeprecatedCustomPermissionstoFalse( ICollection organizationUsers, OrganizationAbility organizationAbility, SutProvider sutProvider) { Get_Setup(organizationAbility, organizationUsers, sutProvider); var customUser = organizationUsers.First(); customUser.Type = OrganizationUserType.Custom; customUser.Permissions = CoreHelpers.ClassToJsonData(new Permissions { AccessReports = true, EditAssignedCollections = true, DeleteAssignedCollections = true, AccessEventLogs = true }); var response = await sutProvider.Sut.Get(organizationAbility.Id); var customUserResponse = response.Data.First(r => r.Id == organizationUsers.First().Id); Assert.Equal(OrganizationUserType.Custom, customUserResponse.Type); Assert.True(customUserResponse.Permissions.AccessReports); Assert.True(customUserResponse.Permissions.AccessEventLogs); Assert.False(customUserResponse.Permissions.EditAssignedCollections); Assert.False(customUserResponse.Permissions.DeleteAssignedCollections); } [Theory] [BitAutoData] public async Task Get_DowngradesCustomUsersWithDeprecatedPermissions( ICollection organizationUsers, OrganizationAbility organizationAbility, SutProvider sutProvider) { Get_Setup(organizationAbility, organizationUsers, sutProvider); var customUser = organizationUsers.First(); customUser.Type = OrganizationUserType.Custom; customUser.Permissions = CoreHelpers.ClassToJsonData(new Permissions { EditAssignedCollections = true, DeleteAssignedCollections = true, }); var response = await sutProvider.Sut.Get(organizationAbility.Id); var customUserResponse = response.Data.First(r => r.Id == organizationUsers.First().Id); Assert.Equal(OrganizationUserType.User, customUserResponse.Type); Assert.False(customUserResponse.Permissions.EditAssignedCollections); Assert.False(customUserResponse.Permissions.DeleteAssignedCollections); } [Theory] [BitAutoData] public async Task GetAccountRecoveryDetails_ReturnsDetails( Guid organizationId, OrganizationUserBulkRequestModel bulkRequestModel, ICollection resetPasswordDetails, SutProvider sutProvider) { sutProvider.GetDependency().ManageResetPassword(organizationId).Returns(true); sutProvider.GetDependency() .GetManyAccountRecoveryDetailsByOrganizationUserAsync(organizationId, bulkRequestModel.Ids) .Returns(resetPasswordDetails); var response = await sutProvider.Sut.GetAccountRecoveryDetails(organizationId, bulkRequestModel); Assert.Equal(resetPasswordDetails.Count, response.Data.Count()); Assert.True(response.Data.All(r => resetPasswordDetails.Any(ou => ou.OrganizationUserId == r.OrganizationUserId && ou.Kdf == r.Kdf && ou.KdfIterations == r.KdfIterations && ou.KdfMemory == r.KdfMemory && ou.KdfParallelism == r.KdfParallelism && ou.ResetPasswordKey == r.ResetPasswordKey && ou.EncryptedPrivateKey == r.EncryptedPrivateKey))); } [Theory] [BitAutoData] public async Task GetAccountRecoveryDetails_WithoutManageResetPasswordPermission_Throws( Guid organizationId, OrganizationUserBulkRequestModel bulkRequestModel, SutProvider sutProvider) { sutProvider.GetDependency().ManageResetPassword(organizationId).Returns(false); await Assert.ThrowsAsync(async () => await sutProvider.Sut.GetAccountRecoveryDetails(organizationId, bulkRequestModel)); } private void Put_Setup(SutProvider sutProvider, OrganizationAbility organizationAbility, OrganizationUser organizationUser, Guid savingUserId, OrganizationUserUpdateRequestModel model, bool authorizeAll) { var orgId = organizationAbility.Id = organizationUser.OrganizationId; sutProvider.GetDependency().ManageUsers(orgId).Returns(true); sutProvider.GetDependency().GetByIdAsync(organizationUser.Id).Returns(organizationUser); sutProvider.GetDependency().GetOrganizationAbilityAsync(orgId) .Returns(organizationAbility); sutProvider.GetDependency().GetProperUserId(Arg.Any()).Returns(savingUserId); if (authorizeAll) { // Simple case: saving user can edit all collections, all collection access is replaced sutProvider.GetDependency() .GetByIdWithCollectionsAsync(organizationUser.Id) .Returns(new Tuple>(organizationUser, model.Collections.Select(cas => cas.ToSelectionReadOnly()).ToList())); var collections = model.Collections.Select(cas => new Collection { Id = cas.Id }).ToList(); sutProvider.GetDependency() .GetManyByManyIdsAsync(Arg.Is>(guids => guids.SequenceEqual(collections.Select(c => c.Id)))) .Returns(collections); sutProvider.GetDependency() .AuthorizeAsync(Arg.Any(), Arg.Is(c => collections.Contains(c)), Arg.Is>(r => r.Contains(BulkCollectionOperations.ModifyUserAccess))) .Returns(AuthorizationResult.Success()); } } private void Get_Setup(OrganizationAbility organizationAbility, ICollection organizationUsers, SutProvider sutProvider) { foreach (var orgUser in organizationUsers) { orgUser.Permissions = null; } sutProvider.GetDependency().GetOrganizationAbilityAsync(organizationAbility.Id) .Returns(organizationAbility); sutProvider.GetDependency().AuthorizeAsync( user: Arg.Any(), resource: Arg.Any(), requirements: Arg.Any>()) .Returns(AuthorizationResult.Success()); sutProvider.GetDependency() .GetManyDetailsByOrganizationAsync(organizationAbility.Id, Arg.Any(), Arg.Any()) .Returns(organizationUsers); } }