mirror of
https://github.com/bitwarden/server.git
synced 2024-11-25 12:45:18 +01:00
f44a59f7a9
* Allow for binning of comb IDs by date and value
* Introduce notification hub pool
* Replace device type sharding with comb + range sharding
* Fix proxy interface
* Use enumerable services for multiServiceNotificationHub
* Fix push interface usage
* Fix push notification service dependencies
* Fix push notification keys
* Fixup documentation
* Remove deprecated settings
* Fix tests
* PascalCase method names
* Remove unused request model properties
* Remove unused setting
* Improve DateFromComb precision
* Prefer readonly service enumerable
* Pascal case template holes
* Name TryParse methods TryParse
* Apply suggestions from code review
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
* AllClients is a set of clients and must be deduplicated
* Fix registration start time
* Add logging to initialization of a notification hub
* more logging
* Add lower level logging for hub settings
* Log when connection is resolved
* Improve log message
* Log pushes to notification hub
* temporarily elevate log messages for visibility
* Log in multi-service when relaying to another push service
* Revert to more reasonable logging free of user information
* Fixup merge
Deleting user was extracted to a command in #4803, this updates that work to use just the device ids as I did elsewhere in abd67e8ec
* Do not use bouncy castle exception types
* Add required services for logging
---------
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Co-authored-by: bnagawiecki <107435978+bnagawiecki@users.noreply.github.com>
206 lines
5.9 KiB
C#
206 lines
5.9 KiB
C#
using Bit.Core.Settings;
|
|
using Bit.Core.Utilities;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.NotificationHub;
|
|
|
|
public class NotificationHubConnectionTests
|
|
{
|
|
[Fact]
|
|
public void IsValid_ConnectionStringIsNull_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = null,
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
|
|
// Act
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Assert
|
|
Assert.False(connection.IsValid);
|
|
}
|
|
|
|
[Fact]
|
|
public void IsValid_HubNameIsNull_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "Endpoint=sb://example.servicebus.windows.net/;",
|
|
HubName = null,
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
|
|
// Act
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Assert
|
|
Assert.False(connection.IsValid);
|
|
}
|
|
|
|
[Fact]
|
|
public void IsValid_ConnectionStringAndHubNameAreNotNull_ReturnsTrue()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
|
|
// Act
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Assert
|
|
Assert.True(connection.IsValid);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_QueryTimeIsBeforeStartDate_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow.AddDays(1),
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(2)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(DateTime.UtcNow);
|
|
|
|
// Assert
|
|
Assert.False(result);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_QueryTimeIsAfterEndDate_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(DateTime.UtcNow.AddDays(2));
|
|
|
|
// Assert
|
|
Assert.False(result);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_NullStartDate_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = null,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(DateTime.UtcNow);
|
|
|
|
// Assert
|
|
Assert.False(result);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_QueryTimeIsBetweenStartDateAndEndDate_ReturnsTrue()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(DateTime.UtcNow.AddHours(1));
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_CombTimeIsBeforeStartDate_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow.AddDays(1),
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(2)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(CoreHelpers.GenerateComb(Guid.NewGuid(), DateTime.UtcNow));
|
|
|
|
// Assert
|
|
Assert.False(result);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_CombTimeIsAfterEndDate_ReturnsFalse()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(CoreHelpers.GenerateComb(Guid.NewGuid(), DateTime.UtcNow.AddDays(2)));
|
|
|
|
// Assert
|
|
Assert.False(result);
|
|
}
|
|
|
|
[Fact]
|
|
public void RegistrationEnabled_CombTimeIsBetweenStartDateAndEndDate_ReturnsTrue()
|
|
{
|
|
// Arrange
|
|
var hub = new GlobalSettings.NotificationHubSettings()
|
|
{
|
|
ConnectionString = "connection",
|
|
HubName = "hub",
|
|
RegistrationStartDate = DateTime.UtcNow,
|
|
RegistrationEndDate = DateTime.UtcNow.AddDays(1)
|
|
};
|
|
var connection = NotificationHubConnection.From(hub);
|
|
|
|
// Act
|
|
var result = connection.RegistrationEnabled(CoreHelpers.GenerateComb(Guid.NewGuid(), DateTime.UtcNow.AddHours(1)));
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
}
|
|
}
|