mirror of
https://github.com/bitwarden/server.git
synced 2024-11-22 12:15:36 +01:00
0f3fcc122d
Following the paradigms illustrated in "Working Effectively with Legacy Code", this commit introduces at least one test for each service class implementation. This test is a simple construction test -- we just create each service and assert that it exists. Each test suite includes a comment instructing the developer who comes next to remove the constructor test. We don't want to keep these tests as the codebase matures, as they aren't useful in the longterm. They only prove that we have that class under test. Where test suites failed to construct their associated classes, we skip the test but leave behind the implementation. This is by design, so that as the constructors for those classes change, we are forced to keep the test suite current by leaning on the compiler.
40 lines
1.3 KiB
C#
40 lines
1.3 KiB
C#
using System;
|
|
using Bit.Core.Services;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.Extensions.Logging;
|
|
using NSubstitute;
|
|
using Xunit;
|
|
|
|
namespace Bit.Core.Test.Services
|
|
{
|
|
public class NotificationsApiPushNotificationServiceTests
|
|
{
|
|
private readonly NotificationsApiPushNotificationService _sut;
|
|
|
|
private readonly GlobalSettings _globalSettings;
|
|
private readonly IHttpContextAccessor _httpContextAccessor;
|
|
private readonly ILogger<NotificationsApiPushNotificationService> _logger;
|
|
|
|
public NotificationsApiPushNotificationServiceTests()
|
|
{
|
|
_globalSettings = new GlobalSettings();
|
|
_httpContextAccessor = Substitute.For<IHttpContextAccessor>();
|
|
_logger = Substitute.For<ILogger<NotificationsApiPushNotificationService>>();
|
|
|
|
_sut = new NotificationsApiPushNotificationService(
|
|
_globalSettings,
|
|
_httpContextAccessor,
|
|
_logger
|
|
);
|
|
}
|
|
|
|
// Remove this test when we add actual tests. It only proves that
|
|
// we've properly constructed the system under test.
|
|
[Fact(Skip = "Needs additional work")]
|
|
public void ServiceExists()
|
|
{
|
|
Assert.NotNull(_sut);
|
|
}
|
|
}
|
|
}
|